Caanot get username from a class

[ibrahim yener]

Hello to all

I had homework from school that teacher wants me create a program so i decided create a Black Jack game
But I am facing a weird problem. I cannot get username for my main form application but somehow same code works on another application.
the worst from it that i have no idea why my code works on TestScreen but now actual Form.

I really appreciate for any help.

Regards



This is where i store usernames:

ProgramSettings.java

class ProgramSettings
{
private static String cashier = "Register";
private static String userName = "N/A";
public void setUserName(String param1)
{
userName = param1;
}
public String getUserName()
{
return userName;
}
}

And this is Where user can enter his/her name. After hit Enter button textField value write into userName
UserSetting.java

import java.awt.EventQueue;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.border.EmptyBorder;
import javax.swing.JLabel;
import java.awt.Color;
import javax.swing.JTextField;
import javax.swing.JSeparator;
import javax.swing.JButton;
import java.awt.event.ActionListener;
import java.awt.event.ActionEvent;
import javax.swing.UIManager;
public class UserSetting extends JFrame
{
private static final long serialVersionUID = -4728666188644326775L;
private JPanel contentPane;
private JTextField textField_1;
private JTextField textField_2;
private JTextField textField_3;
private JTextField textField_4;
static UserSetting frame = new UserSetting( );
private int counter = 1;
StartUp mainScreen = new StartUp();
private JLabel label;
public static void main(String[ ] args) throws Exception
{
EventQueue.invokeLater(new Runnable( )
{
public void run( )
{
frame.setVisible(true);
}
});
}
public UserSetting( )
{
setResizable(false);
setTitle("User Name Setting");
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setBounds(100, 100, 251, 207);
contentPane = new JPanel( );
contentPane.setBackground(UIManager.getColor("Button.background"));
contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
setContentPane(contentPane);
contentPane.setLayout(null);
// Titles
label = new JLabel("User Name");
label.setBounds(143, 11, 86, 14);
contentPane.add(label);
// TextField One
textField_1 = new JTextField( );
textField_1.setBounds(141, 33, 86, 20);
contentPane.add(textField_1);
textField_1.setColumns(10);
// Start Button
JButton btnNewButton = new JButton("Let's Start !!!");
btnNewButton.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
ProgramSettings pr = new ProgramSettings();
// Set username
pr.setUserName(textField_1.getText( ));
frame.setVisible(false);
// mainScreen doesn't work
mainScreen.setVisible(true);
// but somehow TestScreen works
// TestScreen ts = new TestScreen();
// ts.setVisible(true);
}
});
btnNewButton.setBounds(10, 148, 219, 23);
contentPane.add(btnNewButton);
}
}

And this is the main Screen for my application. Where i am facing problem
StartUp.java

import java.awt.EventQueue;
import java.awt.FlowLayout;
import javax.swing.ImageIcon;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.border.EmptyBorder;
import javax.swing.JLabel;
public class StartUp extends JFrame
{
private static final long serialVersionUID = -8690017906317241523L;
private JPanel contentPane;
public static void main(String[ ] args) throws Exception
{
EventQueue.invokeLater(new Runnable( )
{
public void run( )
{
StartUp frame = new StartUp( );
frame.setVisible(true);
}
});
}
public StartUp( )
{
//setTitle("Black Jack");
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setBounds(100, 100, 609, 500);
contentPane = new JPanel( );
contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
setContentPane(contentPane);
contentPane.setLayout(null);
JLabel backGround = new JLabel(new ImageIcon("./img/main.jpg"));
backGround.setBounds(0, 0, 600, 357);
getContentPane().add(backGround);
backGround.setLayout(new FlowLayout());
ProgramSettings pr = new ProgramSettings();
// Cannot get User name
JLabel label_1 = new JLabel(pr.getUserNameFirst());
label_1.setBounds(10, 378, 77, 14);
contentPane.add(label_1);
}
}

And this is Test screen which works perfect
TestScreen.java

import java.awt.EventQueue;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.border.EmptyBorder;
import javax.swing.JLabel;
public class TestScreen extends JFrame
{
/**
*
*/
private static final long serialVersionUID = 2074279618266037844L;
private JPanel contentPane;
/**
* Launch the application.
*/
public static void main(String[ ] args)
{
EventQueue.invokeLater(new Runnable( )
{
public void run( )
{
try
{
deneme frame = new deneme( );
frame.setVisible(true);
}
catch (Exception e)
{
e.printStackTrace( );
}
}
});
}
/**
* Create the frame.
*/
public TestScreen( )
{
setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
setBounds(100, 100, 450, 300);
contentPane = new JPanel( );
contentPane.setBorder(new EmptyBorder(5, 5, 5, 5));
setContentPane(contentPane);
contentPane.setLayout(null);
ProgramSettings pr = new ProgramSettings();
// Somehow this part of code works.
JLabel lblNewLabel = new JLabel(pr.getUserNameFirst());
lblNewLabel.setBounds(203, 140, 46, 14);
contentPane.add(lblNewLabel);
}
}

[ibrahim yener]

P.S.: I've already built command prompt version of above program and it works excellent. But i want to build graphic version.

[Jesper de Jong]

Why are the member variables cashier and userName static in your ProgramSettings class?

You're trying to call a method getUserNameFirst in your ProgramSettings class, but that class doesn't have that method. Did you forget to add it?

[ibrahim yener]

 

Jesper de Jong wrote:Why are the member variables cashier and userName static in your ProgramSettings class?

You're trying to call a method getUserNameFirst in your ProgramSettings class, but that class doesn't have that method. Did you forget to add it?

Dear Jesper thanks for reply.
getUserNameFirst should be getUserName. Sorry for my fault.

So, when i change to static variable/method to non-static then i have problem like non-static method cannot call from static method...
also i've removed static keyword while replying and seems no luck.

[Jesper de Jong]

 

ibrahim yener wrote:So, when i change to static variable/method to non-static then i have problem like non-static method cannot call from static method...

Is the code you posted for the ProgramSettings class really the code that you're using in your project? Because there's no way you can get that error message with the code you posted.

The member variables cashier and userName in class ProgramSettings should not be static. Do you know what static means? It means there's only one copy of the member variables that is shared between the instances of class ProgramSettings. See Understanding Instance and Class Members for a more detailed explanation. Don't just add the static keyword to make an error go away, if you don't know what it means.

The problem you originally asked about:

In line 69 of class UserSetting you're creating a ProgramSettings object. Then you set the username in that object on line 72. But note that the ProgramSettings object is just a local variable inside the actionPerformed method (lines 67-82). When the method ends, the ProgramSettings object is also gone. So, what you set in that object isn't saved anywhere.

In line 42 of class StartUp you again create a new ProgramSettings object. Note that its member variables (cashier and userName) are set to null. In line 45 you're getting the username from the ProgramSettings object, but it's null.

You have to store the ProgramSettings object somewhere. When you create a new ProgramSettings object, it doesn't automatically remember what you put into a previous ProgramSettings object.

[ibrahim yener]

 

Jesper de Jong wrote:
You have to store the ProgramSettings object somewhere. When you create a new ProgramSettings object, it doesn't automatically remember what you put into a previous ProgramSettings object.

Yes that is the code what i am using in my actual program but made simplifier to understand because most part of it is/was Japanese.

I guess you are right what you said up there. When program display another Form then Start object all over again and that is the reason i have got null username for all the time.

I think storing object somewhere is problem for me since i am a java student.
I appreciate if you show me the path how to store that object somewhere else and re use it.

Regards

[ibrahim yener]

Dear Jesper
i created new test purpose program but still i cannot get the return value.

Here is main class

public class StartGame extends Object
{
public static void main(String[ ] args)
{
welcomeForm welcomeScreen = new welcomeForm();
welcomeScreen.setVisible(true);
if(welcomeScreen.getOkButton() == 1)
{
welcomeScreen.setVisible(false);
}
}
}

and this welcomeForm.java

import java.awt.*;
public class welcomeForm extends JDialog
{
private static final long serialVersionUID = -1759363284965211924L;
private final JPanel contentPanel = new JPanel( );
public static welcomeForm dialog = new welcomeForm( );
public static void main(String[ ] args)
{
try
{
dialog.setDefaultCloseOperation(JDialog.DISPOSE_ON_CLOSE);
dialog.setVisible(true);
}
catch (Exception e)
{
}
}
public welcomeForm( )
{
setBounds(100, 100, 350, 139);
setTitle("Welcome !!!");
setResizable(false);
getContentPane().setLayout(null);
contentPanel.setBounds(0, 0, 0, 0);
contentPanel.setLayout(new FlowLayout( ));
contentPanel.setBorder(new EmptyBorder(5, 5, 5, 5));
getContentPane( ).add(contentPanel);
addButton();
addBackground();
addLabel();
}
public int getOkButton()
{
int x = 0;
return x;
}
public void addButton()
{
JPanel buttonPane = new JPanel( );
buttonPane.setBounds(0, 81, 344, 33);
buttonPane.setLayout(new FlowLayout(FlowLayout.RIGHT));
getContentPane( ).add(buttonPane);
JButton okButton = new JButton("はい");
okButton.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent e) {
// dialog.setOkButton();
dialog.setVisible(false);
}
});
okButton.setActionCommand("OK");
buttonPane.add(okButton);
getRootPane( ).setDefaultButton(okButton);
JButton cancelButton = new JButton("いいえ");
cancelButton.addActionListener(new ActionListener() {
public void actionPerformed(ActionEvent arg0) {
System.exit(1);
}
});
cancelButton.setActionCommand("Cancel");
buttonPane.add(cancelButton);
}
public void addBackground()
{
JLabel background = new JLabel(new ImageIcon("./img/welcome.gif"));
background.setBounds(0, 0, 344, 51);
getContentPane( ).add(background);
background.setLayout(new FlowLayout( ));
}
public void addLabel()
{
JLabel label = new JLabel("You should be at least 18 years or older to play this game. Are you?");
label.setFont(new Font("MS PGothic", Font.PLAIN, 15));
label.setHorizontalAlignment(SwingConstants.CENTER);
label.setBounds(0, 62, 344, 21);
getContentPane().add(label);
}
}

if i run welcomeForm alone than OK button works fine. But if i call welcomeForm through another form is not closing/hiding.
Also Form close instantly when i change return value 0 to 1 in getOkButton() method.

Really needs some advice.

Regards