JTable with JLabel in cell renderer problems

[Paul Hayabusa]

Good evening!
I have a JTable with a JLabel where i show a given picture if a person is approved(or failed) in a test.
I use that renderer:

public class TestCellRenderer extends JLabel implements TableCellRenderer {
List<Student> list=null;
public TestCellRenderer(List<Student> l){
super();
this.list=l;
}
@Override
public Component getTableCellRendererComponent(JTable table, Object object,boolean isSelected, boolean hasFocus, int row, int column) {
/
for(int j=0;j<list.size();j++){
Student s=list.get(j);
if(j==row){
if(s.getPoints()>=90)
setIcon(new ImageIcon(getClass().getResource(okay_path)));
if(s.getPoints()<90)
setIcon(new ImageIcon(getClass().getResource(error_path)));
}
}
setHorizontalAlignment(JLabel.CENTER);
return this;
}
}

It works flawless, until i have to edit a Student in a JTable row.I open a screen with the contents of that row for edition.Of course, my Table model dont show a value, but a JLabel where i show the picture.But in my Edit frame, i have a box with values.I tried to update after i choose a value but dont works(off course, if i close the main frame and open the imagem is showed modified, but i need to show the rows updated after i close the edit frame(NOTE: all other fields i change in Edit frame updates, less the JLabel).I tried that:

public JLabel setJLabel(int value){
JLabel l=new JLabel();
if(value>=90)
l.setIcon(new ImageIcon(getClass().getResource("...successpath")));
else if(value<90)
l.setIcon(new ImageIcon(getClass().getResource("...failedpath")));
return l;
}
and my setData method i did:
s.setRate(setJLabel(c.getRate())); 

but dont update the picture.Any thoughts?


Best Regards,

[Rob Spoor]

Just an unrelated hint:

Paul Hayabusa wrote:

 for(int j=0;j<list.size();j++){
Student s=list.get(j);
if(j==row){
}
} 

Can't you just replace that with one line?

Student s = list.get(row);

[Paul Hayabusa]

 

Can't you just replace that with one line?

Yeah, you are totally right, a big overwork on my part.

I still can t change the JLabel after edit(only when i close the frame and reaopen again), if you have any thought about it how to do it i will apreciate.


Best Wishes,

[Darryl Burke]

Another improvement you might like to make is to extend DefaultTableCellRenderer instead of JLabel. The class has a couple of optimizations that you can read about in the API.

You may need to play with the notifications from the table model (fire.... method calls) ... are you using a DefaultTableModel or do you have a custom table model?

[Paul Hayabusa]

Darry, i use my own TableModel(extending AbstractTableModel).

And i return a JLabel there:

case GRADE_POINT:
return JLabel.class;

I was trying:

if (arg0.getSource() == exitDialog) {
model.setData(myList);
model.fireTableDataChanged();
dispose();//clear EditFrame
}

But update everything but the JLabel with my Icon...

[Nam Ha Minh]

Hi Paul Hayabusa,

You need to use a table cell editor in addition to the renderer.

[Paul Hayabusa]

Nam Ha Minh,
how i implement that Editor?


Best Regards,

[Maneesh Godbole]

 

Paul Hayabusa wrote:
how i implement that Editor?

Similar to the renderer. Recommended reading http://docs.oracle.com/javase/tutorial/uiswing/components/table.html#editrender

[Paul Hayabusa]

 

Similar to the renderer.

I read that tutorial to make my renderer.And works flawless if i dont edit my row.I dont get it with the Editor.I will put the same way i made in my TestCellRenderer checking the values for getPoints()?Can you give a snippet of code?


Best Regards,