Forum:

Other Java Products

Errors in running Jess expert system .clp file

Greenhorn

Posts: 3

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi,

I am new to Jess the rule based system in Java and need some assistance if possible. I am trying to run an program in Jess the expert system which analyses risk of developing a particular disease. There are no compilation issues with my .clp file, but when the program runs it does not fully complete. Users are asked questions and answers are stored in Jess, but no calculations are performed and results are not displayed to users yet.

I am currently trying to get Jess to store the bmi value derived from the entered height and weight by a user, but I get an error displayed in the console. I will display some code below if anyone can help;

some of the clp file code:

I have coded (watch all) into the .clp file to list all activations etc on the console for disgnostics.

The error code on the console screen:

FIRE 14 interview::assert-user-facts f-16, f-26
 ==> f-27 (MAIN::user (age nil) (male no) (weight nil) (height nil) (bmi 29) (ex
ercise nil) (alcohol nil) (hepatitis no) (sick no) (jaundice no) (swelling no) (
disease no) (blood no) (pain no) (unwell no))
Jess reported an error in routine >=
        while executing (>= ?e(0,5,-1) 3.5)
        while executing rule LHS (TEQ)
        while executing rule LHS (TECT)
        while executing (assert (MAIN::user (age nil) (male no) (weight nil) (he
ight nil) (bmi ?bmi) (exercise nil) (alcohol nil) (hepatitis no) (sick no) (jaun
dice no) (swelling no) (disease no) (blood no) (pain no) (unwell no)))
        while executing defrule interview::assert-user-facts
        while executing (run)
        while executing deffunction run-system
        while executing (run-system)
        while executing (batch "C:/symptoms1j.clp").
  Message: compareTo threw an exception.
  Program text: ( run-system )  at line 462 in file C:/symptoms1j.clp.

Nested exception is:
java.lang.Double cannot be cast to java.lang.String
Jess>

In the error code above the slot 'user bmi' is at first asserted correctly to value of 29 but just after Jess reports an error in executing bmi to the value of the binded variable ?bmi.
Why is binding a value then assigning it to a slot not working?
I need the bmi stored in the user bmi slot so that corresponding rules can be fired which match the bmi value. An example of one of my current defrules is;

This current program I am working on is heavily adapted from a .clp file from the book 'Jess in Action' named Taxes.clp

Any help in getting my program to display the results to users will be appreciated.

Lalith Phigera

Greenhorn

Posts: 3

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I have since solved the issue I posted above and worked out a method to store the calculated bmi in a slot. I omitted the bind and directly asserted the bmi calculation into the relavant slot. See code below;

I am still though unable to run the program completely. I get no errors but a lot of rules I want to fire do not do so. I have seperated my file into different defmodules namely startup, interview, calculate and report. All the desired rules fire in defmodules startup and interview but not in calculate and report? I need the appropriate rules to fire in calculate and report defmodules for users to get outputted results. The rules are meant to fire according to the facts asserted via user answers.
I have copied the entire .clp file I am working with below if anyone can help to get the program to run fully, thanks you.

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Income tax forms advisor from part 3 of "Jess in Action" FULL EDIT
;; Medical symptoms analysis test 
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;; Module MAIN

(deftemplate user
  (slot age (default 0)) 
  (slot male (default yes)) 
  (slot weight (default 0))
  (slot height (default 0))
  (slot bmi (default 0))
  (slot exercise (default 0))
  (slot alcohol (default 0))
  (slot hepatitis (default no)) 
  (slot sick (default no)) 
  (slot jaundice (default no))
  (slot swelling (default no))
  (slot disease (default no))
  (slot blood (default no))
  (slot pain (default 0))
  (slot unwell (default no)))

(deftemplate question
  (slot text)
  (slot type)
  (slot ident))

(deftemplate answer
  (slot ident)
  (slot text))

;;Change to analysis deftemplate from recommendations

(deftemplate analysis
  (slot total (default 0))
  (multislot reasons))

(deffacts question-data
  "The questions the system can ask."
  (question (ident age) (type number)
            (text "what is your age?"))
  (question (ident male) (type yes-no)
            (text "Are you a male?"))
  (question (ident weight) (type number)
            (text "what is your current weight in kilograms?"))
  (question (ident height) (type number)
            (text "What is your height in meters?"))
  (question (ident drink) (type number)
            (text "How many units of alcohol do you drink a week?"))
  (question (ident exercise) (type number)
            (text "How many hours of exercise do you do on average a week?"))
  (question (ident hepatitis) (type yes-no)
            (text "Do you have Hepatitis B or C?"))
  (question (ident sick) (type yes-no)
            (text "Are you regularly felling sick?"))
  (question (ident jaundice) (type yes-no)
            (text "Do you have a yellowing of the eyes and skin?"))
  (question (ident swelling) (type yes-no)
            (text "Do you have a swelling in your ankles?"))
  (question (ident disease) (type yes-no)
            (text "Do you have a moderate form of liver disease such as non-alcoholic liver disease?"))
  (question (ident blood) (type yes-no)
            (text "Are you vomiting blood or passing blood in your stools?"))
  (question (ident pain) (type yes-no)
            (text "Do you have upper right abdominal pain?"))
  (question (ident unwell) (type yes-no)
            (text "Do you have a general feeling of being unwell?")))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module ask

(defmodule ask)

(deffunction ask-user (?question ?type)
  "Ask a question, and return the answer"
  (bind ?answer "")
  (while (not (is-of-type ?answer ?type)) do
         (printout t ?question " ")
         (if (eq ?type yes-no) then
           (printout t "(yes or no) "))
         (bind ?answer (read)))
  (return ?answer))

(deffunction is-of-type (?answer ?type)
	"Check that the answer has the right form"
	(if (eq ?type yes-no) then
		(return (or (eq ?answer yes) (eq ?answer no)))
	elif (eq ?type number) then
		(return (numberp ?answer))
	else (return (> (str-length ?answer) 0))))
   
(defrule ask::ask-question-by-id
  "Given the identifier of a question, ask it and assert the answer"
  (declare (auto-focus TRUE))
  (MAIN::question (ident ?id) (text ?text) (type ?type))
  (not (MAIN::answer (ident ?id)))
  ?ask <- (MAIN::ask ?id)
  =>
  (bind ?answer (ask-user ?text ?type))
  (assert (answer (ident ?id) (text ?answer)))
  (retract ?ask)
  (return))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module startup

(defmodule startup)

(defrule print-banner
  =>
  (printout t "Type your name and press Enter> ")
  (bind ?name (read))
  (printout t crlf "**********************************" crlf)
  (printout t " Hello, " ?name "." crlf)
  (printout t " Welcome to the medical symptoms analyst" crlf)
  (printout t " Please answer the questions and" crlf)
  (printout t " I will tell you your likelihood" crlf)
  (printout t " of developing cirrhosis." crlf)
  (printout t "**********************************" crlf crlf))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module interview
(defmodule interview)

(defrule request-age
  =>
  (assert (ask age)))
  
(defrule request-sex
  =>
  (assert (ask male)))

(defrule request-weight
  =>
  (assert (ask weight)))

(defrule request-height
  =>
  (assert (ask height)))
  
(defrule request-drink-intake
  =>
  (assert (ask drink)))

(defrule request-exercise-per-week
  =>
  (assert (ask exercise)))
  
(defrule request-hepatitis-status
  =>
  (assert (ask hepatitis)))

(defrule request-feeling-sick
  =>
  (assert (ask sick)))

(defrule ask-have-jaundice
  =>
  (assert (ask jaundice)))
  
(defrule request-have-swelling
  =>
  (assert (ask swelling)))

(defrule request-have-disease
  =>
  (assert (ask disease)))
  
(defrule ask-have-blood
  =>
  (assert (ask blood)))
  
(defrule request-have-pain
  =>
  (assert (ask pain)))

(defrule request-feeling-unwell
  =>
  (assert (ask unwell)))
  
(defrule assert-user-facts
  (answer (ident height) (text ?height))
  (answer (ident weight) (text ?weight))
  =>
  (assert (user (bmi (round(/ (/ ?weight ?height) ?height))))))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module recommend
;; Change to Module analysis 
(defmodule calculate)

(defrule bmi-overweight
    "Test if bmi equates to overweight, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (and (user (bmi ?b&:(>= ?b 25))
	(bmi ?b&:(<= ?b 29.9))))
	?f1 <- (analysis (reasons $?c))
    =>
	(bind ?over "You are overweight.")
	(modify ?f1 (reasons (create$ ?c ?over)))
	(retract ?f1)
	(analysis (total ?t&:(+ ?t 1))))
	
(defrule bmi-underweight
    "Test if bmi equates to underweight, if so add status to reasons multislot for later output"
	(user (bmi ?b&:(<= ?b 19.9)))
	?f2 <- (analysis (reasons $?c))
    =>
	(bind ?under "You are underweight.")
	(modify ?f2 (reasons (create$ ?c ?under)))
	(retract ?f2))
	
(defrule bmi-normal
    "Test if bmi equates to normal, if so add status to reasons multislot for later output"
	(and (user (bmi ?b&:(>= ?b 20.0))
	(bmi ?b&:(<= ?b 24.9))))
	?f3 <- (analysis (reasons $?c))
    =>
	(bind ?normal "Your weight is normal according to the body mass index.")
	(modify ?f3 (reasons (create$ ?c ?bo)))
	(retract ?f3))
	
(defrule bmi-obese
    "Test if bmi equates to obese, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(and (user (bmi ?b&:(>= ?b 30.0))
	(bmi ?b&:(<= ?b 39.9))))
	?f4 <- (analysis (reasons $?c))
    =>
	(bind ?obese "Your are obese according to the body mass index.")
	(modify ?f4 (reasons (create$ ?c ?obese)))
	(analysis (total ?t&:(+ ?t 2)))
	(retract ?f4))
	
(defrule bmi-gross-obese
    "Test if bmi equates to obese, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(user (bmi ?b&:(>= ?b 40.0)))
	?f5 <- (analysis (reasons $?c))
    =>
	(bind ?g-obese "Your are heavily obese according to the body mass index.")
	(modify ?f5 (reasons (create$ ?c ?g-obese)))
	(analysis (total ?t&:(+ ?t 3)))
	(retract ?f5))

(defrule exercise-good
    "Test if user does good amount of exercise, if so add status to reasons multislot for later output"
	(and (answer (ident exercise) (text ?e&:(>= ?e 3.5)))
		 (answer (ident exercise) (text ?e&:(<= ?e 8.0))))
	?f6 <- (analysis (reasons $?c))
    =>
	(bind ?good-ex "You are exercising a good amount.")
	(modify ?f6 (reasons (create$ ?c ?good-ex)))
	(retract ?f6))
	
(defrule exercise-under
    "Test if user does not exercise enough, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident exercise) (text ?e&:(<= ?e 3.5)))
	?f7 <- (analysis (reasons $?c))
    =>
	(bind ?bad-ex "You are not exercising enough.")
	(modify ?f7 (reasons (create$ ?c ?bad-ex)))
	(analysis {total + 2})
	(retract ?f7))
	
(defrule exercise-over
    "Test if user does not exercise more than required, if so add status to reasons multislot for later output"
	(answer (ident exercise) (text ?e&:(>= ?e 8.0)))
	?f8 <- (analysis (reasons $?c))
    =>
	(bind ?over-ex "You are exercising a great amount.")
	(modify ?f8 (reasons (create$ ?c ?over-ex)))
	(retract ?f8))
	
(defrule alcohol-ok-male
    "Test if user drinks acceptable amount of alcohol, if so add status to reasons multislot for later output"
    (user {alcohol <= 21.0 && male == yes})
	?f9 <- (analysis (reasons $?c))
    =>
	(bind ?alc-ok-m "You are drinking within safe limits.")
	(modify ?f9 (reasons (create$ ?c ?alc-ok-m)))
	(retract ?f9))
	
(defrule alcohol-ok-female
    "Test if user drinks acceptable amount of alcohol, if so add status to reasons multislot for later output"
    (user {alcohol <= 14.0 && male == no})
	?f10 <- (analysis (reasons $?c))
    =>
	(bind ?alc-ok-f "You are drinking within safe limits.")
	(modify ?f10 (reasons (create$ ?c ?alc-ok-f)))
	(retract ?f10))
	
(defrule alcohol-bad-male
    "Test if user is over-drinking, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {alcohol > 21.0 && male == yes})
	?f11 <- (analysis (reasons $?c))
    =>
	(bind ?alc-bad-m "You are drinking to much alcohol which is unsafe.")
	(modify ?f11 (reasons (create$ ?c ?alc-bad-m)))
	(analysis {total + 2})
	(retract ?f11))
	
(defrule alcohol-bad-female
    "Test if user is over-drinking, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {alcohol > 14.0 && male == no})
	?f12 <- (analysis (reasons $?c))
    =>
	(bind ?alc-bad-f "You are drinking to much alcohol which is unsafe.")
	(modify ?f12 (reasons (create$ ?c ?alc-bad-f)))
	(analysis {total + 2})
	(retract ?f12))
	
(defrule have-hepatitis
    "Test if user has hepatitis, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {hepatitis == yes})
	?f13 <- (analysis (reasons $?c))
    =>
	(bind ?hep-yes "You have the risk factor of hepatitis.")
	(modify ?f13 (reasons (create$ ?c ?hep-yes)))
	(analysis {total + 3})
	(retract ?f13))
	
(defrule regularly-sick
    "Test if user is regularly feeling sick, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {sick == yes})
	?f14 <- (analysis (reasons $?c))
    =>
	(bind ?sick-yes "You have the liver disease symptom of regularly feeling sick.")
	(modify ?f14 (reasons (create$ ?c ?sick-yes)))
	(analysis {total + 1})
	(retract ?f14))
	
(defrule have-jaundice
    "Test if user has jaundice, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {sick == yes})
	?f15 <- (analysis (reasons $?c))
    =>
	(bind ?jaun-yes "You have the liver disease symptom of jaundice.")
	(modify ?f15 (reasons (create$ ?c ?jaun-yes)))
	(analysis {total + 2})
	(retract ?f15))
	
(defrule have-swelling
    "Test if user has swelling of the ankles, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {swelling == yes})
	?f16 <- (analysis (reasons $?c))
    =>
	(bind ?swell-yes "You have the liver disease symptom of swelling in the ankles.")
	(modify ?f16 (reasons (create$ ?c ?swell-yes)))
	(analysis {total + 1})
	(retract ?f16))
	
(defrule have-disease
    "Test if user already has a form of liver disease, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {disease == yes})
	?f17 <- (analysis (reasons $?c))
    =>
	(bind ?dis-yes "You have the risk factor of already having a form of liver disease.")
	(modify ?f17 (reasons (create$ ?c ?dis-yes)))
	(analysis {total + 4})
	(retract ?f17))
	
(defrule have-blood
    "Test if user has blood in stools of vomit, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {disease == yes})
	?f18 <- (analysis (reasons $?c))
    =>
	(bind ?blood-yes "You have the liver disease symptom of blood in vomit and/or stools.")
	(modify ?f18 (reasons (create$ ?c ?blood-yes)))
	(analysis {total + 1})
	(retract ?f18))
	
(defrule have-pain
    "Test if user has abdominal pain, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {pain == yes})
	?f19 <- (analysis (reasons $?c))
    =>
	(bind ?pain-yes "You have the liver disease symptom of pain in the upper right of the abdomen.")
	(modify ?f19 (reasons (create$ ?c ?blood-yes)))
	(analysis {total + 1})
	(retract ?f19))
	
(defrule is-unwell
    "Test if user has malaise, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (user {unwell == yes})
	?f20 <- (analysis (reasons $?c))
    =>
	(bind ?unwell-yes "You have the liver disease symptom of malaise.")
	(modify ?f20 (reasons (create$ ?c ?unwell-yes)))
	(analysis {total + 1})
	(retract ?f20))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module report

(defmodule report)

(defrule sort-and-print-low
  (and (analysis (total ?t&:(> ?t 0)))
	(analysis (total ?t&:(<= ?t 7))))
  ?r1 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: low" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r1 hasNext) 
    (bind ?reason (call ?r1 next)) 
    (printout t ?reason crlf))
	(retract ?r1))
	
(defrule sort-and-print-moderate
	(and (analysis (total ?t&:(> ?t 7)))
	(analysis (total ?t&:(<= ?t 13))))
  ?r2 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: moderate" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r2 hasNext) 
    (bind ?reason (call ?r2 next)) 
    (printout t ?reason crlf))
	(retract ?r2))
	
(defrule sort-and-print-high
	(analysis (total ?t&:(> ?t 13)))
  ?r3 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: high" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r3 hasNext) 
    (bind ?reason (call ?r3 next)) 
    (printout t ?reason crlf))
	(retract ?r3))
	
(defrule sort-and-print-high
  (analysis (total ?t&:(== ?t 0)))
  ?r4 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: error" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r4 hasNext) 
    (bind ?reason (call ?r4 next)) 
    (printout t ?reason crlf))
	(retract ?r4))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Test data

(deffunction run-system ()
  (watch all)
  (reset)
  (focus startup interview calculate report)
  (run))

(run-system)

If anyone needs the console code from running the file above with (watch all) activated, I can post this code.

I'm aware that many of the user facts have not been asserted in the above .clp code, such as user alcohol, disease, etc. I ommitted their assertion as I am planning to use the answer slot 'text' direct fact data.

User facts could otherwise be asserted as so;

The following is a list of all the facts in Jess MAIN module when the .clp file is run:

Jess> (facts MAIN)
f-0   (MAIN::initial-fact)
f-1   (MAIN::question (text "what is your age?") (type number) (ident age))
f-2   (MAIN::question (text "Are you a male?") (type yes-no) (ident male))
f-3   (MAIN::question (text "what is your current weight in kilograms?") (type n
umber) (ident weight))
f-4   (MAIN::question (text "What is your height in meters?") (type number) (ide
nt height))
f-5   (MAIN::question (text "How many units of alcohol do you drink a week?") (t
ype number) (ident drink))
f-6   (MAIN::question (text "How many hours of exercise do you do on average a w
eek?") (type number) (ident exercise))
f-7   (MAIN::question (text "Do you have Hepatitis B or C?") (type yes-no) (iden
t hepatitis))
f-8   (MAIN::question (text "Are you regularly felling sick?") (type yes-no) (id
ent sick))
f-9   (MAIN::question (text "Do you have a yellowing of the eyes and skin?") (ty
pe yes-no) (ident jaundice))
f-10   (MAIN::question (text "Do you have a swelling in your ankles?") (type yes
-no) (ident swelling))
f-11   (MAIN::question (text "Do you have a moderate form of liver disease such
as non-alcoholic liver disease?") (type yes-no) (ident disease))
f-12   (MAIN::question (text "Are you vomiting blood or passing blood in your st
ools?") (type yes-no) (ident blood))
f-13   (MAIN::question (text "Do you have upper right abdominal pain?") (type ye
s-no) (ident pain))
f-14   (MAIN::question (text "Do you have a general feeling of being unwell?") (
type yes-no) (ident unwell))
f-16   (MAIN::answer (ident height) (text 1.79))
f-18   (MAIN::answer (ident unwell) (text no))
f-20   (MAIN::answer (ident age) (text 35))
f-22   (MAIN::answer (ident exercise) (text 7))
f-24   (MAIN::answer (ident disease) (text yes))
f-26   (MAIN::answer (ident weight) (text 95))
f-27   (MAIN::user (age 0) (male yes) (weight 0) (height 0) (bmi 30) (exercise 0
) (alcohol 0) (hepatitis no) (sick no) (jaundice no) (swelling no) (disease no)
(blood no) (pain 0) (unwell no))
f-29   (MAIN::answer (ident pain) (text no))
f-31   (MAIN::answer (ident sick) (text no))
f-33   (MAIN::answer (ident jaundice) (text yes))
f-35   (MAIN::answer (ident swelling) (text no))
f-37   (MAIN::answer (ident drink) (text 8))
f-39   (MAIN::answer (ident blood) (text no))
f-41   (MAIN::answer (ident hepatitis) (text no))
f-43   (MAIN::answer (ident male) (text yes))
For a total of 30 facts in module MAIN.

Once again I now need the relavant rules to fire in the calculate and report defmodules so results can be outputted to a user, what to I need to improve or change in the code?
The code in the above file is still work in progress and I am aware that maybe many changes to the code is necessary.

Many thanks for any help.

Ernest Friedman-Hill

author and iconoclast

Posts: 24207

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

The immediate reason why none of the "calculate" or "report" rules fire is that every one of them matches an "analysis" pattern on the left-hand-side, but no code anywhere asserts any "analysis" facts; therefore none of those rules are ever activated.

I do see where a lot of rules in those modules attempt to call an (undefined) function named "analysis", like this:

Maybe that last line should be

That wouldn't quite fix the logic though, because as I said, it looks every rule that creates an analysis fact requires one to previously exist, and none do. Also, you'd have to have bound "?t" on the rule left-hand-side first; the syntax you were using is a pattern-matching syntax valid only on rule left-hand-sides. Also note that in a few places you use a syntax like (analysis {total + 1}); that's also not allowed on right-hand-sides.

[Jess in Action][AskingGoodQuestions]

Lalith Phigera

Greenhorn

Posts: 3

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Dear Ernest,

Many thanks for your reply, I have since been able to get rules to activate in the interview, calculate and report defmodules. This is progress but the output I want for users is still not being displayed. Rules do activate but only some fire. I do not understand why serveral of the rules list 'activation' but do not fire? such as in the 'watch all' code below.

FIRE 31 calculate::bmi-overweight f-27, f-28, f-28
<== Activation: calculate::exercise-good :  f-22, f-22, f-28
<== Activation: calculate::have-disease :  f-24, f-28, f-28
<== Activation: calculate::is-unwell :  f-18, f-28, f-28
<== Activation: report::sort-and-print-error :  f-28, f-28
 <=> f-28 (MAIN::analysis (total 0) (reasons "" "You are overweight."))
==> Activation: calculate::exercise-good :  f-22, f-22, f-28
==> Activation: calculate::bmi-overweight :  f-27, f-28, f-28
==> Activation: calculate::have-disease :  f-24, f-28, f-28
==> Activation: calculate::is-unwell :  f-18, f-28, f-28
==> Activation: report::sort-and-print-error :  f-28, f-28
<== Activation: calculate::bmi-overweight :  f-27, f-28, f-28
<== Activation: calculate::exercise-good :  f-22, f-22, f-28
<== Activation: calculate::have-disease :  f-24, f-28, f-28
<== Activation: calculate::is-unwell :  f-18, f-28, f-28
<== Activation: report::sort-and-print-error :  f-28, f-28
 <=> f-28 (MAIN::analysis (total 1) (reasons "" "You are overweight."))
==> Activation: calculate::exercise-good :  f-22, f-22, f-28
==> Activation: calculate::bmi-overweight :  f-27, f-28, f-28
==> Activation: calculate::have-disease :  f-24, f-28, f-28
==> Activation: calculate::is-unwell :  f-18, f-28, f-28
==> Activation: report::sort-and-print-low :  f-28, f-28, f-28
 <== f-28 (MAIN::analysis (total 1) (reasons "" "You are overweight."))
<== Activation: calculate::bmi-overweight :  f-27, f-28, f-28
<== Activation: calculate::exercise-good :  f-22, f-22, f-28
<== Activation: calculate::have-disease :  f-24, f-28, f-28
<== Activation: calculate::is-unwell :  f-18, f-28, f-28
<== Activation: report::sort-and-print-low :  f-28, f-28, f-28
 <== Focus calculate
 ==> Focus report
 <== Focus report
 ==> Focus MAIN
 <== Focus MAIN

I have tried to take on our comments in your reply and have edited by code.

If I briefly tell you what I want the program to do this might lead to a better understanding. I want answers read from a user to be utalised in rules to output a basic analysis. I want to analysis symptoms of a user such as 'jaundice' to give a likelihood of developing cirrhosis. The idea of the program is basic enough, for each rule that fires a number is added to a total signifying the importance of having a paticular symptom. Additionally for each symptom or risk factor the user has, a short text is added to a list (for example "You have the liver disease symptom of jaundice.") as in my code to the multislot 'reasons' in the analysis deftemplate. For each symptom the user has a number such as 1 or 2 is added to the 'total' numeric slot in the analysis deftemplate. You said in your reply here that a lot of my rules attempt to call a function 'analysis' but this is simply a deftemplate name within my code and 'total' is the numeric slot I wish to add to as rules fire.

Once the 'total' and 'reasons' slots have been accordingly modified, the total is used to output a risk status to the user such as low, moderate or high and the multislot 'reasons' is printed out for the user to see a list of reasons as to why they have been assigned their level of risk. The rules in the defmodule 'report' are meant to print out risk status and list of reasons but they do not work as of yet. The rules in the report module are activated but do not fire. I think maybe I have wrote the code for rules in the report module somewhat incorrectly, I wonder if you can tell me where they would need to be changed.

One other problem is if I answer yes to all the symptoms then I seem to get a continues loop where rules are endlessly activated and facts seems to continuesly multiply such as f-25 up to f-200 on-going. The other error is that the slot 'total' is only added to once from what I see and not continuesly to get to a number such as 7 or 12.

Sorry for including all my code below, but I think it will help you understand what I have changed so far and the code is not that long. My current code is pasted below:

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Income tax forms advisor from part 3 of "Jess in Action" FULL EDIT
;; Medical symptoms analysis beta testing (Basis of application). 
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

;; Module MAIN

(defglobal ?*t* = 0)

(deftemplate question
  (slot text)
  (slot type)
  (slot ident))

(deftemplate answer
  (slot ident)
  (slot text))

;;Change to analysis deftemplate from recommendations

(deftemplate analysis
  (slot total (default 0))
  (multislot reasons))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module ask

(defmodule ask)

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module startup

(defmodule startup)

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module interview
(defmodule interview)

(defrule request-age
  =>
  (assert (ask age)))
  
(defrule request-sex
  =>
  (assert (ask male)))

(defrule request-weight
  =>
  (assert (ask weight)))

(defrule request-height
  =>
  (assert (ask height)))
  
(defrule request-drink-intake
  =>
  (assert (ask drink)))

(defrule request-exercise-per-week
  =>
  (assert (ask exercise)))
  
(defrule request-hepatitis-status
  =>
  (assert (ask hepatitis)))

(defrule request-feeling-sick
  =>
  (assert (ask sick)))

(defrule ask-have-jaundice
  =>
  (assert (ask jaundice)))
  
(defrule request-have-swelling
  =>
  (assert (ask swelling)))

(defrule request-have-disease
  =>
  (assert (ask disease)))
  
(defrule ask-have-blood
  =>
  (assert (ask blood)))
  
(defrule request-have-pain
  =>
  (assert (ask pain)))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module recommend
;; Change to Module analysis 
(defmodule calculate)
	
(defrule bmi-overweight
    "Test if bmi equates to overweight, if so add status to reasons multislot for later output and add to counter for later risk analysis."
    (and (user (bmi ?b&:(>= ?b 25))
	(bmi ?b&:(<= ?b 29.9))))
	?f1 <- (analysis (reasons $?c))
	?g1 <- (analysis (total ?t))
    =>
	(bind ?over "You are overweight.")
	(modify ?f1 (reasons (create$ ?c ?over)))
	(modify ?g1 (total (+ ?t 1)))
	(retract ?f1)
	(retract ?g1)) 
	
(defrule bmi-underweight
    "Test if bmi equates to underweight, if so add status to reasons multislot for later output"
	(user (bmi ?b&:(<= ?b 19.9)))
	?f2 <- (analysis (reasons $?c))
    =>
	(bind ?under "You are underweight.")
	(modify ?f2 (reasons (create$ ?c ?under)))
	(retract ?f2))
	
(defrule bmi-normal
    "Test if bmi equates to normal, if so add status to reasons multislot for later output"
	(and (user (bmi ?b&:(>= ?b 20.0))
	(bmi ?b&:(<= ?b 24.9))))
	?f3 <- (analysis (reasons $?c))
    =>
	(bind ?normal "Your weight is normal according to the body mass index.")
	(modify ?f3 (reasons (create$ ?c ?bo)))
	(retract ?f3))
	
(defrule bmi-obese
    "Test if bmi equates to obese, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(and (user (bmi ?b&:(>= ?b 30.0))
	(bmi ?b&:(<= ?b 39.9))))
	?f4 <- (analysis (reasons $?c))
	?g4 <- (analysis (total ?t))
    =>
	(bind ?obese "Your are obese according to the body mass index.")
	(modify ?f4 (reasons (create$ ?c ?obese)))
	(modify ?g4 (total (+ ?t 2)))
	(retract ?f4)
	(retract ?g4))
	
(defrule bmi-gross-obese
    "Test if bmi equates to obese, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(user (bmi ?b&:(>= ?b 40.0)))
	?f5 <- (analysis (reasons $?c))
	?g5 <- (analysis (total ?t))
    =>
	(bind ?g-obese "Your are heavily obese according to the body mass index.")
	(modify ?f5 (reasons (create$ ?c ?g-obese)))
	(modify ?g5 (total (+ ?t 3)))
	(retract ?f5)
	(retract ?g5))

(defrule exercise-good
    "Test if user does good amount of exercise, if so add status to reasons multislot for later output"
	(and (answer (ident exercise) (text ?e&:(>= ?e 3.5)))
		 (answer (ident exercise) (text ?e&:(<= ?e 8.0))))
	?f6 <- (analysis (reasons $?c))
    =>
	(bind ?good-ex "You are exercising a good amount.")
	(modify ?f6 (reasons (create$ ?c ?good-ex)))
	(retract ?f6))
	
(defrule exercise-under
    "Test if user does not exercise enough, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident exercise) (text ?e&:(<= ?e 3.5)))
	?f7 <- (analysis (reasons $?c))
	?g7 <- (analysis (total ?t))
    =>
	(bind ?bad-ex "You are not exercising enough.")
	(modify ?f7 (reasons (create$ ?c ?bad-ex)))
	(modify ?g7 (total (+ ?t 2)))
	(retract ?f7)
	(retract ?g7))
	
(defrule exercise-over
    "Test if user does not exercise more than required, if so add status to reasons multislot for later output"
	(answer (ident exercise) (text ?e&:(>= ?e 8.0)))
	?f8 <- (analysis (reasons $?c))
    =>
	(bind ?over-ex "You are exercising a great amount.")
	(modify ?f8 (reasons (create$ ?c ?over-ex)))
	(retract ?f8))
	
(defrule alcohol-ok-male
    "Test if user drinks acceptable amount of alcohol, if so add status to reasons multislot for later output"
	(and (answer (ident alcohol) (text ?al&:(<= ?al 21.0)))
		(answer (ident male) (text ?male&:(eq ?male yes))))
	?f9 <- (analysis (reasons $?c))
    =>
	(bind ?alc-ok-m "You are drinking within safe limits.")
	(modify ?f9 (reasons (create$ ?c ?alc-ok-m)))
	(retract ?f9))
	
(defrule alcohol-ok-female
    "Test if user drinks acceptable amount of alcohol, if so add status to reasons multislot for later output"
	(and (answer (ident alcohol) (text ?al&:(<= ?al 14.0)))
		(answer (ident male) (text ?male&:(eq ?male no))))
	?f10 <- (analysis (reasons $?c))
    =>
	(bind ?alc-ok-f "You are drinking within safe limits.")
	(modify ?f10 (reasons (create$ ?c ?alc-ok-f)))
	(retract ?f10))
	
(defrule alcohol-bad-male
    "Test if user is over-drinking, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(and (answer (ident alcohol) (text ?al&:(> ?al 21.0)))
		(answer (ident male) (text ?male&:(eq ?male yes))))
	?f11 <- (analysis (reasons $?c))
	?g11 <- (analysis (total ?t))
    =>
	(bind ?alc-bad-m "You are drinking to much alcohol which is unsafe.")
	(modify ?f11 (reasons (create$ ?c ?alc-bad-m)))
	(modify ?g11 (total (+ ?t 2)))
	(retract ?f11)
	(retract ?g11))
	
(defrule alcohol-bad-female
    "Test if user is over-drinking, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(and (answer (ident alcohol) (text ?al&:(> ?al 14.0)))
		(answer (ident male) (text ?male&:(eq ?male no))))
	?f12 <- (analysis (reasons $?c))
	?g12 <- (analysis (total ?t))
    =>
	(bind ?alc-bad-f "You are drinking to much alcohol which is unsafe.")
	(modify ?f12 (reasons (create$ ?c ?alc-bad-f)))
	(modify ?g12 (total (+ ?t 2)))
	(retract ?f12)
	(retract ?g12))
	
(defrule have-hepatitis
    "Test if user has hepatitis, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident hepatitis) (text ?hep&:(eq ?hep yes)))
	?f13 <- (analysis (reasons $?c))
	?g13 <- (analysis (total ?t))
    =>
	(bind ?hep-yes "You have the risk factor of hepatitis.")
	(modify ?f13 (reasons (create$ ?c ?hep-yes)))
	(assert (analysis (total (+ ?t 3))))
	(modify ?g13 (total (+ ?t 3)))
	(retract ?f13)
	(retract ?g13))
	
(defrule regularly-sick
    "Test if user is regularly feeling sick, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident sick) (text ?sick&:(eq ?sick yes)))
	?f14 <- (analysis (reasons $?c))
	?g14 <- (analysis (total ?t))
    =>
	(bind ?sick-yes "You have the liver disease symptom of regularly feeling sick.")
	(modify ?f14 (reasons (create$ ?c ?sick-yes)))
	(modify ?g14 (total (+ ?t 1)))
	(retract ?f14)
	(retract ?g14))
	
(defrule have-jaundice
    "Test if user has jaundice, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident jaundice) (text ?jaun&:(eq ?jaun yes)))
	?f15 <- (analysis (reasons $?c))
	?g15 <- (analysis (total ?t))
    =>
	(bind ?jaun-yes "You have the liver disease symptom of jaundice.")
	(modify ?f15 (reasons (create$ ?c ?jaun-yes)))
	(modify ?g15 (total (+ ?t 2)))
	(retract ?f15)
	(retract ?g15))
	
(defrule have-swelling
    "Test if user has swelling of the ankles, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident swelling) (text ?swell&:(eq ?swell yes)))
	?f16 <- (analysis (reasons $?c))
	?g16 <- (analysis (total ?t))
    =>
	(bind ?swell-yes "You have the liver disease symptom of swelling in the ankles.")
	(modify ?f16 (reasons (create$ ?c ?swell-yes)))
	(modify ?g16 (total (+ ?t 2)))
	(retract ?f16)
	(retract ?g16))
	
(defrule have-disease
    "Test if user already has a form of liver disease, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident disease) (text ?dis&:(eq ?dis yes)))
	?f17 <- (analysis (reasons $?c))
	?g17 <- (analysis (total ?t))
    =>
	(bind ?dis-yes "You have the risk factor of already having a form of liver disease.")
	(modify ?f17 (reasons (create$ ?c ?dis-yes)))
	(modify ?g17 (total (+ ?t 4)))
	(retract ?f17)
	(retract ?g17))
	
(defrule have-blood
    "Test if user has blood in stools of vomit, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident blood) (text ?blood&:(eq ?blood yes)))
	?f18 <- (analysis (reasons $?c))
	?g18 <- (analysis (total ?t))
    =>
	(bind ?blood-yes "You have the liver disease symptom of blood in vomit and/or stools.")
	(modify ?f18 (reasons (create$ ?c ?blood-yes)))
	(modify ?g18 (total (+ ?t 1)))
	(retract ?f18)
	(retract ?g18))
	
(defrule have-pain
    "Test if user has abdominal pain, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident pain) (text ?pain&:(eq ?pain yes)))
	?f19 <- (analysis (reasons $?c))
	?g19 <- (analysis (total ?t))
    =>
	(bind ?pain-yes "You have the liver disease symptom of pain in the upper right of the abdomen.")
	(modify ?f19 (reasons (create$ ?c ?blood-yes)))
	(modify ?g19 (total (+ ?t 1)))
	(retract ?f19)
	(retract ?g19))
	
(defrule is-unwell
    "Test if user has malaise, if so add status to reasons multislot for later output and add to counter for later risk analysis."
	(answer (ident unwell) (text ?unwell&:(eq ?unwell yes)))
	?f20 <- (analysis (reasons $?c))
	?g20 <- (analysis (total ?t))
    =>
	(bind ?unwell-yes "You have the liver disease symptom of malaise.")
	(modify ?f20 (reasons (create$ ?c ?unwell-yes)))
	(modify ?g20 (total (+ ?t 1)))
	(retract ?f20)
	(retract ?g20))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Module report

(defmodule report)

(defrule sort-and-print-low
  (and (analysis (total ?t&:(> ?t 0)))
	(analysis (total ?t&:(<= ?t 7))))
  ?r1 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: low" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r1 hasNext) 
    (bind ?reason (call ?r1 next)) 
    (printout t ?reason crlf))
	(retract ?r1))
	
(defrule sort-and-print-moderate
	(and (analysis (total ?t&:(> ?t 7)))
	(analysis (total ?t&:(<= ?t 13))))
  ?r2 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: moderate" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r2 hasNext) 
    (bind ?reason (call ?r2 next)) 
    (printout t ?reason crlf))
	(retract ?r2))
	
(defrule sort-and-print-high
	(analysis (total ?t&:(> ?t 13)))
  ?r3 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: high" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r3 hasNext) 
    (bind ?reason (call ?r3 next)) 
    (printout t ?reason crlf))
	(retract ?r3))
	
(defrule sort-and-print-error
  (analysis (total ?t&:(eq ?t 0)))
  ?r4 <- (analysis (reasons $?c))
  =>
  (printout t "Your risk for developing cirrhosis is: error" crlf)
  (printout t "Reasons as to why you have been assigned this level" crlf)
  (printout t "of risk are detailed below:" crlf)
	(while (?r4 hasNext) 
    (bind ?reason (call ?r4 next)) 
    (printout t ?reason crlf))
	(retract ?r4))

;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
;; Test data

(deffunction run-system ()
  (watch all)
  (reset)
  (focus startup interview calculate report)
  (run))

(run-system)

Many thanks if you can answer my questions and I appreciate your help kind Sir.

Don't get me started about those stupid light bulbs.