Help with hashmaps - selecting keys/values

[Kirstin Jackson]

I'm learning Java using BlueJ, I have made a class that has a HashMap of (String, String) that contains an the make of a car and the model.

I want a method to return a collection of all the keys that satisfy a condition, like if someone wants to find what make a certain model is. I know it requires a loop, just not too sure how to write the loop to satisfy the condition if anyone could point me in the right direction?

Thank you so much.

[K. Tsang]

Welcome to the ranch.

There are 3 important methods from the Map interface you will use often: 1) keySet(), 2) values() and 3) entrySet()

The keySet() method returns a Set of the map's keys
The values() method returns a Collection of the map's values
The entrySet() method returns a Set of Map.Entry (great for looping)

To loop a map

for(Map.Entry<String,String> entry : myMap.entrySet()) {
System.out.println("key="+entry.getKey() + " value="entry.getValue());
}

[Kirstin Jackson]

thank you for the welcome.

I have tried using the map.Entry before but blueJ says package modelMap does not exist when I go to compile the program.

[Stephan van Hulst]

Hi Kirstin,

ItDoesntWorkIsUseless, please show us some code and tell us where the error occurs.

[Campbell Ritchie]

Welcome again

I have changed your post to black text; many people find the green difficult to read.
I have suffered from BlueJ myself and am pleased to have recovered from it. I don't like it. If you are new enough to need it, you are better off with the command line, and if you are experienced enough to be able to use an IDE, you can use NetBeans Eclipse or IntelliJ etc. BlueJ seems to have difficulties with package names. Can you compile the whole thing from the command line?
Are you familiar with the different sorts of Collections and Maps? Do you know all about what the Java Tutorials will tell you? If you get the Set of Strings which are keys, would you know how to iterate the set, and put all values satisfying a particular condition into another set? Of course in Java8 you can get a Stream which can be filtered very concisely.

[Kirstin Jackson]

Hi Stephan,
I can post what I have and see if that aids a bit.

Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels);
that's all I have at the moment cause I just came back on to edit the code a bit more.


Hi Campbell,
I am ready to see the back of bluej myself.

I am not certain I am very familiar with collections yet, but I earlier managed to get the program to list all the keys separate from values, just not able to get certain keys displayed. I am quite fine with the iterating and placing the keys into another string, it might be I need to change from a Map to a List or Set, etc. I am just not too sure how to change the Hashmap or Hashset into an ArrayList or ArraySet.
Not too sure what part is the command line, I know it will compile if I leave the code like it is above.

[Henry Wong]

Kirstin Jackson wrote:
I have tried using the map.Entry before but blueJ says package modelMap does not exist when I go to compile the program.

Kirstin Jackson wrote:
I can post what I have and see if that aids a bit.

that's all I have at the moment cause I just came back on to edit the code a bit more.

Since you mentioned that the error involved the package -- perhaps it would be good to show us the complete code? Including the part that includes the package statements?

Henry

[Kirstin Jackson]

Hi Henry,

import java.util.*; import ou.*; /** * Write a description of class CarDealership here. * * @author (your name) * @version (a version number or a date) */ public class CarDealership { // instance variables - replace the example below with your own private Map<String, String> carModel; /** * Constructor for objects of class CarDealership */ public CarDealership() { // initialise instance variables carModel = new HashMap<>(); } /** * An example of a method - replace this comment with your own * * @param y a sample parameter for a method * @return the sum of x and y */ public Set<String> addModels(String car) { // put your code here Set<String> carModel = new HashSet<>(); String dialogString = "Please input the model for " + car + ". Press Cancel to end."; String input = OUDialog.request(dialogString); while (input != null) { carModel.add(input); input = OUDialog.request(dialogString); } return carModel; } /** * * */ public void dealerData() { Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels); for (String eachCar : modelMap.keySet()) { addModels = modelMap.get(eachCar); System.out.println("The models of " + eachCar + " currently available are " + addModels); } } /** * */ public void printMap() { Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels); for (String eachCar : modelMap.keySet()) { addModels = modelMap.get(eachCar); System.out.println(eachCar + addModels); } } /** * */ public void addMapEntry() { Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels); String dialogString = "Please input the make of car"; String car = OUDialog.request(dialogString); if (modelMap.containsKey(car)) { OUDialog.alert(car + " is already in database"); OUDialog.confirm("Do you wish to add " + car + " to the database?"); } else { OUDialog.alert(car + " is not in database"); } } /** * */ public void deleteEntry() { Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels); String dialogString = "Please input the make of car"; String car = OUDialog.request(dialogString); if (modelMap.containsKey(car)) { modelMap.remove(car); System.out.println(modelMap); } else { OUDialog.alert(car + " is not in database"); } } /** * */ public void addValue() { Map<String, Set<String>> modelMap = new HashMap<>(); Set<String> addModels = new HashSet<>(); addModels.add("Clio"); addModels.add("Scenic"); addModels.add("Captur"); addModels.add("Zoe"); addModels.add("Megane"); modelMap.put("Renault", addModels); addModels = new HashSet<>(); addModels.add("Escort"); addModels.add("Kuga"); addModels.add("Mondeo"); addModels.add("Fiesta"); addModels.add("Focus"); addModels.add("Ka"); modelMap.put("Ford", addModels); addModels = new HashSet<>(); addModels.add("Yaris"); addModels.add("Prius"); addModels.add("Auris"); addModels.add("Celica"); addModels.add("Aygo"); modelMap.put("Toyota", addModels); addModels = new HashSet<>(); addModels.add("Accord"); addModels.add("Civic"); addModels.add("Insight"); addModels.add("Jazz"); modelMap.put("Honda", addModels); addModels = new HashSet<>(); addModels.add("Soul"); addModels.add("Rio"); addModels.add("Picanto"); addModels.add("Optima"); addModels.add("Carens"); modelMap.put("Kia", addModels); Collection<String> result = new ArrayList<String>(); for(String key : modelMap.keySet()) { if((modelMap.containsValue("Clio"))) // if the key is odd... result.add(key); // ... then add it to the result } System.out.println(result); } }

I added in a bit more code at the part giving me trouble but when I execute it, all it gives me is [] and not the key which should be Renault..

[Henry Wong]

Kirstin Jackson wrote:
I added in a bit more code at the part giving me trouble but when I execute it, all it gives me is [] and not the key which should be Renault..

So, basically, you solved your compile error -- and is now having a completely different issue. Perhaps you can better describe your new issue?

Henry

[Kirstin Jackson]

From what I can see, when the code is executed, it's not returning the key from the value I am entering. I am only getting [], going to try to see if I can sort the issue out or not.

Kirstin

[Mike. J. Thompson]

Kirstin Jackson wrote:From what I can see, when the code is executed, it's not returning the key from the value I am entering. I am only getting [], going to try to see if I can sort the issue out or not.

Kirstin

Where is your main method, the entry point to your application? Without that I don't know which part of your code you're attempting to run. Which method is it that isn't doing what you expect?

[Kirstin Jackson]

I am trying to run the addValues() method, Mike. The rest of the methods work as expected.

[Mike. J. Thompson]

The problem is that you are checking for the String "Clio" in your HashMap (modelMap), but the map does not contain a matching key. When you call contains() on a map it only checks the keys. The String you are looking for is in the Set that you have mapped to "Renault".

[Kirstin Jackson]

Ah, I see.

That why's it's returning []. Not sure how to call the set up with Renault, since I thought that was the key.

[Mike. J. Thompson]

Well I don't know exactly what it is you were trying to achieve here. Maps are designed so that when you give it a key it will give you back the value mapped to that key.

So modelMap.contains("Renault") will return true if you have a key that matches "Renault" in the map. modelMap.get("Renault") will return you the Set that you mapped to Renault.

If instead you want to search for the word "Clio" or one of the other models then you cannot do that directly using the map interface. The map does not know that you have put sets in it, and will not search inside them for you.

To search in the sets you need to get a reference to the set and call the contains(...) method on it. You can get all the sets using modelMap.values() or by getting the collection of Entry objects and iterating through them. Alternatively you can get a specific set by calling modelMap.get(...)

So what specifically do you want to do?