how do i make this "more groovy"

[Jeanne Boyarsky]

I wrote a Groovy script. I'm finally in the habit of using each() instead of a for loop and grep() instead of an if statement (for filtering.)

I'm not sure what to do with this if statement through. This code is supposed to loop through all the p's and print out objects that don't have any q's of the right type with a value set. I had to use a helper variable because I couldn't figure out how to do this the Groovy way. Ideas?

// for each 
list.each({ 
  // for each 
  p->
     def a= p.attribute.grep({
       // keep track of any that are not empty
      q -> q instanceof Foo && q.str.trim().equals("")
     })
     // print if found any
     if (a.isEmpty())
         println p.name
})
// so doesn't print results of loop
null

[Gregg Bolinger]

Not sure if this is really groovier, but I might do something like this:

list.each { p ->
    println p.attribute.findAll { q ->
        q instanceof Foo && q.str.trim().equals("")
    }.isEmpty() ? p : null
}

This also assumes that p has a toString() that would return its name.

[Jeanne Boyarsky]

Thanks Gregg. That was what I was looking for.

[Jeanne Boyarsky]

I made one slight adaptation. Greg's example printed out a bunch of lines with null on them. I changed it to:

    list.each { p ->
        print p.attribute.findAll { q ->
            q instanceof Foo && q.str.trim().equals("")  
         }.isEmpty() ? project.name + "\n" : ""
    }