Forum:

OnClick Function not getting called on click of button on JSP page

Greenhorn

Posts: 7

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hello,
My JSP page looks like

<%@ page language="java" %>
<%@ page import="listFilesFromDir.getFilesInterface" %>
<%@ page import="java.util.ArrayList" %>
<%@ page import="java.util.Collection" %>
<%@ page import="java.util.Iterator" %>
<%@ page import="java.util.List" %>
<%@ page import="org.apache.cxf.jaxws.JaxWsProxyFactoryBean" %>

<html>
<head>
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>Files Display page</title>
</head>
<body link="#FFFFFF" vlink="#FFFFFF" alink="#FFFFFF" bgcolor="#000055" text="#FFFFFF">
<script language="javascript" type="text/javascript">
MyFunction(){
             alert("entered function");
             var clicked = "true";
             var select = document.getElementById('selectFile').value;
             var cType = document.getElementById('conversionType').value;
             submit();
}
</script>

<center><h3>File Listing from Directory</h3></center>
<hr/>

<form method="POST" name="submitRequest" action="">
<%  
   JaxWsProxyFactoryBean pf = new JaxWsProxyFactoryBean();
        pf.setServiceClass(getFilesInterface.class);
        pf.setAddress(getFilesInterface.URL);
        getFilesInterface getFilesTest = (getFilesInterface)pf.create();
        String path="C:\\yak\\MulePollFolder\\Working\\";
        String buttonClicked=request.getParameter("clicked");
	     if(buttonClicked=="true"){
         String field = request.getParameter("select");
         String fileName = field != null ? field : "";
         field = request.getParameter("cType");
         String conversionType= field != null ? field : "";
         String TranslatedFilePath= getFilesTest.TranslateFile(fileName,conversionType,path);
         if(TranslatedFilePath!=null)
		{ %> 
        <p><%=TranslatedFilePath%></p>
        
       <% }
        }
        
        else{
           List <String> results = getFilesTest.getFiles(path);
           if (results == null)
        {
            results = new ArrayList();
        }
           else{
           %>
           Your search returned the following files(s):<br/>
          <br/>
          <label> Select File</label>
          <select id="selectFile" name="selectFile">
          <% 
          String result;
          for (Iterator<String> i = results.iterator(); i.hasNext();)
         {
           result = i.next();
         %>
        
         <option value=""><%=result%></option>
         
         <%
        }
        
           }
            }
        %>
        </select>
        <label> Select Conversion Type </label>
        <select id="conversionType" name="conversionType">
						  <option value="ani1">Giraffe</option>
						  <option value="ani2">Lion</option>
		</select>
		<input type="button" name="button" value="TranslateFile" onclick="MyFunction()" />
		
<hr/>
</form>
</body>
</html>

The problem is that after loading the dropdown, I am selecting values from them and clicking the button to submit the form. But it does not seem to work. I tried putting an alert inside the function call too alert("entered function"); but no good. Could anyone suggest what might be the issue?

Regards,
Rachael

Bear Bibeault

Sheriff

Posts: 67756

173

I like...

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Sigh.Still using scriptlets?

In any case, responding to clicks is a function of client-side JavaScript, so showing us all this server-side markup just makes things difficult. Rather, show us the generated HTML which is easily viewable using browser tools.

Be sure to tidy it up before posting (plenty of HTML tidy tools), and UseCodeTags when posting code.

[Asking smart questions] [About Bear] [Books by Bear]

HTML 5 (verified skill)
Skill verified by Jeanne Boyarsky

CSS 3 (verified skill)
Skill verified by Jeanne Boyarsky

JavaScript (verified skill)
Skill verified by Jeanne Boyarsky

Rachael Rose

Greenhorn

Posts: 7

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hello Bear,
Thanks for a quick reply. I do understand your point that using java scrip-lets inside JSP page is a bad idea but I have some work related integration to be done on MULE esb. In their documentation they have mentioned this as a way to call Java classes from JSP pages.

<center><h3>File Listing from Directory</h3></center>
<hr/>

Your search returned the following files(s):<br/>
          <br/>
          <label> Select File</label>
          <select id="selectFile" name="selectFile">
          
        
         <option value="">SampleISO1.xml</option>
         
         
        
         <option value="">SampleISO2.xml</option>
         
         
        
         <option value="">SampleISO3.xml</option>
         
         
        </select>
        <label> Select Conversion Type </label>
        <select id="conversionType" name="conversionType">
						  <option value="GFFISO">GFF to ISO</option>
						  <option value="ISOGFF">ISO to GFF</option>
		</select>
		<input type="button" name="button" value="TranslateFile" onclick="MyFunction()" />
		
<hr/>
</form>
</body>
</html>

Hope this is what you have requested...

Regards,
Rachael

Paul Ngom

Ranch Hand

Posts: 355

posted 11 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Rachael,
You did not declare your function. It should read function MyFunction()

I am always surprised at the added knowledge i can get from others when i give my opinion on a topic.

World domination requires a hollowed out volcano with good submarine access. Tiny ads are optional.

Clean our rivers and oceans from home

https://www.kickstarter.com/projects/paulwheaton/willow-feeders