How to check equality of map in assertequals()

[vivek dhiman]

Hi

I am trying to test below method, which is throwing NPE. Please advice whats the cause of it.

public  Map getConfigProps(Configuration config)
    {
        Map props=new HashMap();
        String  customerSecret,refreshToken;
        props.put("instanceUrl",(String)config.get("instanceurl", ""));
        props.put("accesstoken",(String)config.get("accesstoken", ""));
        props.put("customerkey",(String)config.get("customerkey", ""));
        String customerSecretTemp = (String)config.get("customersecret", "");
        String refreshTokenTemp = (String)config.get("refreshtoken", "");
        customerSecret = customerSecretTemp;
        refreshToken = refreshTokenTemp;
        try {
            if (this.cryptoSupport.isProtected(customerSecretTemp)) {
                customerSecret = this.cryptoSupport.unprotect(customerSecretTemp);
            }
            if (this.cryptoSupport.isProtected(refreshTokenTemp)) {
                refreshToken = this.cryptoSupport.unprotect(refreshTokenTemp);
            }
        } catch (Exception e) {
            e.printStackTrace();  //To change body of catch statement use File | Settings | File Templates.
        }
        props.put("customerSecret",customerSecret);
        props.put("refreshToken",refreshToken);
        return props;
    }

Test case :

 @Test
    public void testGetConfigProps() throws Exception {
            SalesforceLeadSearch1 clt=new SalesforceLeadSearch1();

            Configuration config=mock(Configuration.class);
            Map props=new HashMap();
            CryptoSupport cryptoSupport=mock(CryptoSupport.class);
            when(config.get("instanceurl","")).thenReturn("instanceurlVal");
            props.put("instanceurl", "instanceurlVal");
            when(config.get("accesstoken","")).thenReturn("accesstokenVal");
            props.put("accesstoken", "accesstokenVal");
            when(config.get("customerkey","")).thenReturn("clientIdVal");
            props.put("customerkey", "clientIdVal");


            when(cryptoSupport.isProtected("customersecretVal")).thenReturn(true);
            when(cryptoSupport.unprotect("customersecretVal")).thenReturn("customersecretValNew");
            when(config.get("customersecret", "")).thenReturn("customersecretValNew");
            props.put("customersecret", "customersecretValNew");
            when(cryptoSupport.isProtected("refreshTokenVal")).thenReturn(true);
            when(cryptoSupport.unprotect("refreshTokenVal")).thenReturn("refreshTokenValNew");
            when(config.get("refreshtoken", "")).thenReturn("refreshTokenValNew");
            props.put("refreshtoken", "refreshTokenValNew");
            assertEquals(props,clt.getConfigProps(config));
    }

Exception is :

java.lang.NullPointerException
	at com.ig.igwebcms.services.impl.SalesforceLeadSearch1.getConfigProps(SalesforceLeadSearch1.java:131)
	at com.ig.igwebcms.services.impl.SalesforceLeadSearch1TestN.testGetConfigProps(SalesforceLeadSearch1TestN.java:73)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
junit.framework.AssertionFailedError: 
Expected :{accesstoken=accesstokenVal, instanceurl=instanceurlVal, refreshtoken=refreshTokenValNew, customerkey=clientIdVal, customersecret=customersecretValNew}
Actual   :{accesstoken=accesstokenVal, customerkey=clientIdVal, refreshToken=refreshTokenValNew, customerSecret=customersecretValNew, instanceUrl=instanceurlVal}

Thanks

[Matthew Brown]

Well, the error is happing on line 131. So it makes it much easier for people to help you if you tell us which line in getConfigProps corresponds to that line. Something on that line is null that shouldn't be. There won't be many candidates.

Without knowing the line, my first guess would be line 13 of the listing. What is the value of cryptoSupport on that line? When do you set it to anything other than null? You create a CryptoSupport mock in the test method, but it doesn't seem to get passed into the SalesforceLeadSearch1 object.

[Tim Cooke]

Hi, can you indicate what line is 131 in your SalesforceLeadSearch1 class? You can do it with the code tags in the editor, just add the "firstline" param as I've shown below.

[code=java:firstline[24]]
  System.out.println("Hello World!");
[/code]

Or you can just tell us which line it is.

[vivek dhiman]

Line 131 is Line 13 of listing

 if (this.cryptoSupport.isProtected(customerSecretTemp)) { 

Here cryptoSupport is null.

[Maneesh Godbole]

vivek dhiman wrote:Line 131 is Line 13 of listing

 if (this.cryptoSupport.isProtected(customerSecretTemp)) { 

It would seem cryptoSupport is null

[vivek dhiman]

There is function in SalesforceLeadSearch1.

protected void bindCryptoSupport(CryptoSupport paramCryptoSupport)
    {
        this.cryptoSupport = paramCryptoSupport;
    }

I am trying to bind this with SalesforceLeadSearch1 object with below code.

            clt.bindCryptoSupport(cryptoSupport);

Now NPE has been gone but still test gets fails.

junit.framework.AssertionFailedError: 
Expected :{accesstoken=accesstokenVal, instanceurl=instanceurlVal, refreshtoken=refreshTokenValNew, customerkey=clientIdVal, customersecret=customersecretValNew}
Actual   :{accesstoken=accesstokenVal, customerkey=clientIdVal, refreshToken=refreshTokenValNew, customerSecret=customersecretValNew, instanceUrl=instanceurlVal}
 <Click to see difference>

[Maneesh Godbole]

1) Confirm it is cryptoSupport which is null
2) Put in a null check OR
3) Ensure the object is not null

[vivek dhiman]

Yes cryptoSupport was null, but i bind is with class object as mentioned above, now i can see this inside method Mock for CryptoSupport, hashCode: 777355268. Now there is no NPE. but collection are fail to compare as follows :

junit.framework.AssertionFailedError: 
Expected :{accesstoken=accesstokenVal, instanceurl=instanceurlVal, refreshtoken=refreshTokenValNew, customerkey=clientIdVal, customersecret=customersecretValNew}
Actual   :{accesstoken=accesstokenVal, customerkey=clientIdVal, refreshToken=refreshTokenValNew, customerSecret=customersecretValNew, instanceUrl=instanceurlVal}
 <Click to see difference>

[Tim Cooke]

Check the capitalisation on the map keys.