Missed a } and/or ) on if/else

[sasa anali]

I missed a } and/or ) at the end of the code, I tried so many times but I didn't get it, can someone know?

     doclink.setOnClickListener(new OnClickListener() {

            @Override
            public void onClick(View arg0) {
            if(!uri.contains("https://www.facebook.com/")) {  
              String natgeo = "natgeo";  
              String uri = "fb://Page/" + natgeo;      
              Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(uri));  
              startActivity(intent);     
              }  
            else{  
              String natgeo = "natgeo";  
              String uri = "https://www.facebook.com/" + natgeo;    
              Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(uri));      
              startActivity(i);   
    }
};

[Ulf Dittmer]

How many "{" and "}" does this code have, respectively? Count the same for "(" and ")". If both numbers are not the same for both kinds of brackets, make sure to balance them evenly.

[sasa anali]

I fixed only the "}" because there is 4 "{" and 3 "}" .. now they're equal, but with the ")" got me an error .. now there is 11 "(" and 10 ")" at the end it look like this

doclink.setOnClickListener(new OnClickListener() {  
  
            @Override  
            public void onClick(View arg0) {  
          if(!uri.contains("https://www.facebook.com/")) {    
              String natgeo = "natgeo";    
              String uri = "fb://Page/" + natgeo;        
              Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(uri));    
              startActivity(intent);       
              }    
          else{    
              String natgeo = "natgeo";    
              String uri = "https://www.facebook.com/" + natgeo;      
              Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(uri));        
              startActivity(i);     
              }  
}}; 

The problem is, I kept putting the ")" here and there and I still have an error!

[sasa anali]

It worked but, there is a problem I get a msg on the mobile saying "Unfortunately, A has stopped"

package com.example.a;

import android.app.Activity;
import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.widget.Button;
import android.view.View;
import android.view.View.OnClickListener;

public class MainActivity extends Activity {

    Button dadclink;

    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_main);
        addListenerOnButton();
    }

    public void addListenerOnButton() {
        dadclink = (Button) findViewById(R.id.dadclink);

        dadclink.setOnClickListener(new OnClickListener() {
            @SuppressWarnings("null")
            @Override
            public void onClick(View arg0) {
                String uri = null;
                String uri2 = uri;
                if (!uri2.contains("https://www.facebook.com/")) {
                    String natgeo = "natgeo";
                    String uri1 = "fb://Page/" + natgeo;
                    Intent intent = new Intent(Intent.ACTION_VIEW, Uri
                            .parse(uri1));
                    startActivity(intent);
                } else {
                    String natgeo = "natgeo";
                    String uri1 = "https://www.facebook.com/" + natgeo;
                    Intent i = new Intent(Intent.ACTION_VIEW, Uri.parse(uri1));
                    startActivity(i);
                } 
            }
        });
    }
}

[Ulf Dittmer]

Whenever you get that message, check the logcat which contains the full stack trace of the exception. ("adb logcat" from the console of your desktop computer while the device is connected via USB.)

I bet it's an NPE, because in line 30 you're setting "uri2" to null (or rather, you're setting it to "uri", which you're setting to null in line 29), and in line 31 you're invoking a method on it.

Could also be an NPE in line 25 if "dadclink" is null. But there's no point in guessing, as the stack trace in the logcat will tell you.

[sasa anali]

It worked!