Forum:

Servlets

Dojo Progressbar not working properly with Commons FileUpload

Ravi Sree

Ranch Hand

Posts: 64

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I have been trying different examples on showing progress bar for file upload progress for couple of days.

Some of the different example were using libraries like Dojo,jQuery and just using plain AJAX with iframe method.

But unfortunately, however i try i'm not able to show the progressbar thingy at all although
the upload part is working good.

Following is the example with Dojo[dojo-release-1.0.3]

I'm using Servlet 2.5,commons fileupload libs, TomEE-plus-1.7. 0 & ant for building tool
in ubuntu 12.04 as the platform with firefox 32.

Here is the code (as it was in the site)

build.xml

<?xml version="1.0" encoding="UTF-8"?>

<path id="build.path">
 <fileset dir="${server.dir}/lib">
 <include name="*.jar"/>
 </fileset>
 <fileset dir="${web.dir}/WEB-INF/lib">
 <include name="*.jar"/>
 </fileset> 
 </path>

<echo>
 Application : ${ant.project.name}
 Build File : ${ant.file}
 Run Date : ${build.time}
 Run by : ${user.name}
 Build directory: ${build.dir}
 Base directory : ${basedir}
 Java Home : ${java.home} 
 </echo>
 
 
 <target name="clean" description="Cleans the project directory">
 <echo>Cleaning the distribution directory...</echo>
 <delete dir="${dist.dir}"/>
 <echo>Cleaning the build directory...</echo>
 <delete dir="${build.dir}"/>
 <echo>Cleaning completed...</echo>
 </target>
 
 
  
 <target name="prepare" description="Prepares the project directory">
 <echo>Preparing the build directory...</echo>
 <mkdir dir="${build.dir}"/>
 <echo>Preparing the distribution directory...</echo>
 <mkdir dir="${dist.dir}"/>
 <echo>Project directory preparation completed...</echo>
 </target>
 
 
 
 <target name="compile" description="Compiles files into build directory" depends="clean, prepare">
 <echo>Copying required files...</echo>
 <copy todir="${build.dir}">
 <fileset dir="${web.dir}"/>
 </copy>
 <mkdir dir="${build.dir}/WEB-INF/classes"/>
 <echo>Compiling of source files started...</echo>
 <javac srcdir="${src.dir}" destdir="${build.dir}/WEB-INF/classes"
 debug="false" verbose="false" includeantruntime="true">
 <classpath refid="build.path"/>
 </javac>
 <echo>Compilation of source files completed...</echo>
 </target>

<target name="dist" description="Packages all the required files into a war (Web Archive) file" depends="compile">
 <war destfile="${dist.dir}/${war-file}" webxml="${build.dir}/WEB-INF/web.xml">
 <fileset dir="${build.dir}"/>
 </war>
 </target>
 
 
</project>

web.xml

<?xml version="1.0" encoding="UTF-8"?>
<web-app id="jqjsonEx1"
 xmlns="http://java.sun.com/xml/ns/javaee"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd"
 version="2.5">
 <display-name>File Upload with Servlet 6</display-name>
 <description>File Upload with Servlet 6</description>
 <servlet>
 <servlet-name>TestServlet</servlet-name>
 <servlet-class>test.TestServlet</servlet-class>
 </servlet>
 <servlet>
 <servlet-name>ProgressServlet</servlet-name>
 <servlet-class>test.ProgressServlet</servlet-class>
 </servlet>
 <servlet-mapping>
 <servlet-name>ProgressServlet</servlet-name>
 <url-pattern>/progress</url-pattern>
 </servlet-mapping>
 <servlet-mapping>
 <servlet-name>TestServlet</servlet-name>
 <url-pattern>/test</url-pattern>
 </servlet-mapping>
 <welcome-file-list>
 <welcome-file>upload.jsp</welcome-file>
 </welcome-file-list>
</web-app>

ProgressServlet.java

package test;

import java.io.IOException;
import java.io.PrintWriter;

import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

public class ProgressServlet extends HttpServlet {

private static final long serialVersionUID = 1L;

public void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
		doPost(request, response);
	}

public void doPost(HttpServletRequest request, HttpServletResponse response) throws IOException {
		response.setContentType("text/html");
		response.setHeader("Cache-Control", "no-cache");
		
		PrintWriter out = response.getWriter();

HttpSession session = request.getSession(true);
		if (session == null) {
			out.println("Sorry, session is null"); // just to be safe
			return;
		}

TestProgressListener testProgressListener = (TestProgressListener) session.getAttribute("testProgressListener");
		if (testProgressListener == null) {
			out.println("Progress listener is null");
			return;
		}

//		out.println(testProgressListener.getMessage());
		out.println(testProgressListener.getPercentDone());

}
}

ProgressListener.java

package test;

import org.apache.commons.fileupload.ProgressListener;

public class TestProgressListener implements ProgressListener {

private long num100Ks = 0;

private long theBytesRead = 0;
	private long theContentLength = -1;
	private int whichItem = 0;
	private int percentDone = 0;
	private boolean contentLengthKnown = false;

public void update(long bytesRead, long contentLength, int items) {

if (contentLength > -1) {
			contentLengthKnown = true;
		}
		theBytesRead = bytesRead;
		theContentLength = contentLength;
		whichItem = items;

long nowNum100Ks = bytesRead / 100000;
		// Only run this code once every 100K
		if (nowNum100Ks > num100Ks) {
			num100Ks = nowNum100Ks;
			if (contentLengthKnown) {
				percentDone = (int) Math.round(100.00 * bytesRead / contentLength);
			}
			System.out.println(getMessage());
		}
	}

public String getMessage() {
		if (theContentLength == -1) {
			return "" + theBytesRead + " of Unknown-Total bytes have been read.";
		} else {
			return "" + theBytesRead + " of " + theContentLength + " bytes have been read (" + percentDone + "% done).";
		}

}

public long getNum100Ks() {
		return num100Ks;
	}

public void setNum100Ks(long num100Ks) {
		this.num100Ks = num100Ks;
	}

public long getTheBytesRead() {
		return theBytesRead;
	}

public void setTheBytesRead(long theBytesRead) {
		this.theBytesRead = theBytesRead;
	}

public long getTheContentLength() {
		return theContentLength;
	}

public void setTheContentLength(long theContentLength) {
		this.theContentLength = theContentLength;
	}

public int getWhichItem() {
		return whichItem;
	}

public void setWhichItem(int whichItem) {
		this.whichItem = whichItem;
	}

public int getPercentDone() {
		return percentDone;
	}

public void setPercentDone(int percentDone) {
		this.percentDone = percentDone;
	}

public boolean isContentLengthKnown() {
		return contentLengthKnown;
	}

public void setContentLengthKnown(boolean contentLengthKnown) {
		this.contentLengthKnown = contentLengthKnown;
	}

}

TestServlet.java

package test;

import java.io.IOException;
import java.io.PrintWriter;
import java.util.Enumeration;
import java.util.Iterator;
import java.util.List;

import javax.servlet.http.HttpServlet;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.servlet.http.HttpSession;

import org.apache.commons.fileupload.FileItem;
import org.apache.commons.fileupload.FileItemFactory;
import org.apache.commons.fileupload.FileUploadException;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.servlet.ServletFileUpload;

public class TestServlet extends HttpServlet {

private static final long serialVersionUID = 1L;
//	public static final long MAX_UPLOAD_IN_MEGS = 50;

public void doGet(HttpServletRequest request, HttpServletResponse response) throws IOException {
		doPost(request, response);
	}

public void doPost(HttpServletRequest request, HttpServletResponse response) throws IOException {
		response.setContentType("text/html");
		PrintWriter out = response.getWriter();
		
		out.println("Hello ");

boolean isMultipartContent = ServletFileUpload.isMultipartContent(request);
		if (!isMultipartContent) {
			out.println("You are not trying to upload ");
			return;
		}
		out.println("You are trying to upload ");

FileItemFactory factory = new DiskFileItemFactory();
		ServletFileUpload upload = new ServletFileUpload(factory);
//		upload.setSizeMax(MAX_UPLOAD_IN_MEGS * 1024 * 1024);
		
		TestProgressListener testProgressListener = new TestProgressListener();
		upload.setProgressListener(testProgressListener);

HttpSession session = request.getSession();
		session.setAttribute("testProgressListener", testProgressListener);
		
		try {
			List<FileItem> fields = upload.parseRequest(request);
			out.println("Number of fields: " + fields.size() + " ");
			Iterator<FileItem> it = fields.iterator();
			if (!it.hasNext()) {
				out.println("No fields found");
				return;
			}
			out.println("<table border=\"1\">");
 			while (it.hasNext()) {
 			out.println("<tr>");
 			FileItem fileItem = it.next();
 			boolean isFormField = fileItem.isFormField();
 			if (isFormField) {
 			 out.println("<td>regular form field</td><td>FIELD NAME: " + fileItem.getFieldName() + " STRING: " + fileItem.getString());
 			 out.println("</td>");
 			} else {
 			 out.println("<td>file form field</td><td>FIELD NAME: " + fileItem.getFieldName() +STRING: " + fileItem.getString()
 +" NAME: " + fileItem.getName() +" CONTENT TYPE: " + fileItem.getContentType()
 +" SIZE (BYTES): " + fileItem.getSize() +" TO STRING: " + fileItem.toString());
 out.println("</td>");
 		 }
 		 out.println("</tr>");
 		}
 		out.println("</table>");
	} catch (FileUploadException e) {
	 out.println("Error: " + e.getMessage());
	 e.printStackTrace();
	}
}
}

If i choose a file of size 68MB, on page load the progressbar is seen
but stays at 0% all the time even after submttting the form.

On debugging, cant find error/bug here.

P.S This code can be seen CodeGuru: FileUpload Example

I cant find where I'm going wrong or is it some bug

Thanks in advance.

Sree

Ravi Sree

Ranch Hand

Posts: 64

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Dear All,

I dont know what happened but this and other Dojo examples which I tried seem to work now.

Regards,
Sree

With a little knowledge, a cast iron skillet is non-stick and lasts a lifetime.