Spring Controller @ResponseBody is Empty

[Alex Giovi]

In my spring webapp, I'm trying to test my controller:

@Controller
@RequestMapping(value="/Position")
public class PositionController {
 @Autowired
PositionRepository positionRepository;

@RequestMapping(method=RequestMethod.GET, value="/search/infoforPosition)
public @ResponseBody List<Map<String, Object>> read(@RequestParam(value="id", required=true)    Integer id){                

    List<Map<String, Object>> res = positionRepository.infoPerPosition(id);
    return res;
  } 
 }

My test Code looks like this:

@RunWith(SpringJUnit4ClassRunner.class)
@WebAppConfiguration
@ContextConfiguration(locations={"classpath*:/META-INF/spring/applicationContext.xml"})
 private MockMvc mockMvc;  
 @Mock
 PositionController PositionMock;
 @Before 
 public void setUp() {
      MockitoAnnotations.initMocks(this);
    this.mockMvc = MockMvcBuilders.standaloneSetup(PositionMock).build();
}

@Test
public void test() throws Exception {
    mockMvc.perform(MockMvcRequestBuilders.get("/Position/search/infoforPosition")
             .param("id", "435651")
             .accept("application/json"))
             .andDo(print())
             .andExpect(MockMvcResultMatchers.status().isOk());
        }  

When i execute the test i got this:

 MockHttpServletRequest:
     HTTP Method = GET
     Request URI = /Position/search/infoforPosition
     Parameters = {id=[435651]}
     Headers = {Accept=[application/json]}

     Handler:
      Type = org.controllers.PositionController
     Method = public java.util.List<java.util.Map<java.lang.String, java.lang.Object>>   org.controllers.PositionController.read(java.lang.Integer)

           Async:
    Was async started = false
    Async result = null

   Resolved Exception:
            Type = null

     ModelAndView:
       View name = null
            View = null
           Model = null

        FlashMap:

  MockHttpServletResponse:
          Status = 200
   Error message = null
         Headers = {Content-Type=[application/json;charset=UTF-8]}
    Content type = application/json;charset=UTF-8
            Body = []
   Forwarded URL = null
   Redirected URL = null
         Cookies = []

when i test the url in Chrome Browser i got this:

[{"id":435651,"Position_id":33,"section":64509}]

In my pom.xml file i added jackson-mapper-asl.jar and jackson-core-asl.jar I don't know why the response status is 200 but i did'nt got any data,so how the unit test pass?

Any help will be much appreciated

[Dave Tolls]

Something doesn't look right there.
You are mocking the controller you want to test.
I'm going to guess that the result of that is Sping's call to the read method will result in a default response by the mocked controller.
I would have expected you to @InjectMocks into the controller, and @Mock the PositionRepository attribute?

[Alex Giovi]

Hi Dave,
thanks for the post , i'm a newbie in spring and unit testing, i thought @Mock will create a Reference instance to the original class,so i don't understand what's @InjeckMoks is used for?
so if you can explain a little bit what's the difference between them.
And it works:)

Now ,i updated my controller code, with a new line (to make it easy for me)

 @Autowired
HttpSession sessionHttp;
@Controller  
@RequestMapping(value="/Position")  
public class PositionController {  
 @Autowired  
PositionRepository positionRepository;  
  
@RequestMapping(method=RequestMethod.GET, value="/search/infoforPosition)  
public @ResponseBody List<Map<String, Object>> read(@RequestParam(value="id", required=true)    Integer id){                  
    Integer user_Id = Util.getInformationSession(sessionHttp).getIdProfile();	 //LINE "M"
    List<Map<String, Object>> res = positionRepository.infoPerPosition(id,user_Id );  
    return res;  
  }   
 }  

And

public class Util {
		public static InfoSession getInformationSession(HttpSession session) {
		try {
			return (InfoSession) session.getAttribute("INFO_SESSIONE");
		}
		catch (Exception e) {
			
		}
	}

public class InfoSession{
	public Integer getIdProfile() {
		return idProfile;
	}
	}

I know it's not a clear code , but i would like to have your opinion , if possible.
to execute LINE M in Mockito test method(Got a NPE in this line), do i have to Mock the others classes,Like what I do for the Repository interface
or is there any other method to include the execution of this line on code in Test ambiant
Also, i put a breakpoint in Read() method , and i started the appliaction in debug mode but it doesn't stop,is it
normal when using Mocking url?
Many thanks

[Dave Tolls]

@Mock tells mockito you want to create a mock version of that class. That is, a version you can then handle all interaction with.
You don't mock out the class you are testing, you mock out the dependencies of that class.

Now, for Util it is going to be harder as it is a class of static methods, and mocking works best with interfaces.
It can be done, but in this case it's not necessary as all the class does is get something from the HttpSession...which you can mock out. So just mock that call and return a suitable InfoSession object (possibly itself another mocked object).

Have you read the Mockito docs?

[Alex Giovi]

Thanks for these informations.
I'll have a look at the documentation