Forum:

Struts

Struts2 XML validation is not working

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Guys,

I am using Struts2 version (2.3.20) and also tried to downgrade to 2.3.15. But my declarative validations in XML are not working. Attached are the files. Could anyone please help.

struts.xml
------------

index.jsp

EmployeeAction.java
-------------------------

package techmyguru.actions;

import com.opensymphony.xwork2.ActionSupport;
import java.util.Date;

public class EmployeeAction extends ActionSupport {
  private String id;
  private String name;
  private String password1;
  private String password2;
  private Date dob;
  private Integer salary;
  private String city;
  private String email;

public String getId() {
        return id;
    }

public void setId(String id) {
        this.id = id;
    }
  
    public void setName(String name) {
        this.name = name;
    }
     public String getName() {
        return name;
    }

public String getPassword1() {
        return password1;
    }

public void setPassword1(String password1) {
        this.password1 = password1;
    }

public String getPassword2() {
        return password2;
    }

public void setPassword2(String password2) {
        this.password2 = password2;
    }

public Date getDob() {
        return dob;
    }

public void setDob(Date dob) {
        this.dob = dob;
    }

public Integer getSalary() {
        return salary;
    }

public void setSalary(Integer salary) {
        this.salary = salary;
    }

public String getCity() {
        return city;
    }

public void setCity(String city) {
        this.city = city;
    }

public String getEmail() {
        return email;
    }

public void setEmail(String email) {
        this.email = email;
    }
  
  
  @Override
  public String execute() throws Exception {
    return SUCCESS;
  }
}

EmpSuccess.jsp
------------------------

EmployeeAction-valildation.xml
--------------------------------------

<!DOCTYPE validators PUBLIC 
               "-//OpenSymphony Group//XWork Validator 1.0.2//EN"
               "http://www.opensymphony.com/xwork/xwork-validator-1.0.2.dtd">

<validators>
  <field name="id">
    <field-validator type="requiredstring">
      <message>Employee Id can not be blank</message>
    </field-validator>
    <field-validator type="regex">
      <param name="expression">
      <![CDATA[([A-Z][A-Z][0][0][0-9][0-9][0-9])]]>
      </param>
      <message>Valid Employee ID required e.g. SS00123</message>
    </field-validator>
  </field>

<field name="name">
    <field-validator type="requiredstring">
    <message>Employee Name can not be blank</message>
    </field-validator>
  </field>

<field name="password1">
    <field-validator type="requiredstring">
    <message>Password can not be blank</message>
    </field-validator>
    <field-validator type="stringlength">
    <param name="maxLength">10</param>
    <param name="minLength">5</param>
    <param name="trim">true</param>
    <message>Enter password 5-10 characters long.</message>
    </field-validator>
  </field>

<field name="password2">
    <field-validator type="fieldexpression">
    <param name="expression">(password1 == password2)</param>
    <message>Both Password must be same.</message>
    </field-validator>
  </field>

<field name="dob">
    <field-validator type="date">
    <param name="min">01/01/2001</param>
    <param name="max">01/01/2013</param>
    <message>Enter date between ${min}and ${max}</message>
    </field-validator>
  </field>

<field name="salary">
    <field-validator type="int">
    <param name="min">1</param>
    <param name="max">50000</param>
    <message>Enter salary between ${min}and ${max}</message>
    </field-validator>
  </field>

<field name="city">
    <field-validator type="requiredstring">
    <message>City can not be blank.</message>
    </field-validator>
  </field>

<field name="email">
    <field-validator type="requiredstring">
      <message>Blank email is not allowed</message>
    </field-validator>
    
    <field-validator type="email">
      <message>Enter a valid eMail Id.</message>
    </field-validator>
  </field>
  
</validators>

web.xml
------------

Issue: While I am not filling up the form, no validation is working and it is going to EmpSuccess.jsp

What wrong I am doing here

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Joe Ess

Bartender

Posts: 9626

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Where is EmployeeAction-valildation.xml located?

[How To Ask Questions On JavaRanch]

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

It is in the same package along with the EmployeeAction.java

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I am using Netbeans. Please find the project structure attached.

Struts2.jpg

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Joe Ess

Bartender

Posts: 9626

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

It looks like the doctype you are using in your validation.xml file is not accessible. According to the Struts documentation, the doctype for validation files is:

[How To Ask Questions On JavaRanch]

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I tried it. But still the issue persists.

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

bablu singh

Ranch Hand

Posts: 32

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

You can try with the following

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

This does not work either. It throws Freemarker template error at runtime.

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Joe Ess

Bartender

Posts: 9626

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

bablu singh wrote:You can try with the following
<s:form action="EmployeeAction" validate="true">

That attribute turns on client side validation.

Since you are using Struts 2.3.x, you should update the doctype of your Struts.xml as well:

The typical problem I have with validation is matching the action name, action class and method in the validation file name.
I would take the following steps:
1. rename the action name in struts.xml to something other than the action class name (i.e. register).
2. change the validation file name to match the action class name and the action name (i.e. EmployeeAction-register-validation.xml)
3. place a debug statement in the action.execute method (if this is printed out, we know that validation didn't work. It rules out having a bad mapping for the input result in struts.xml)
4. reduce the validation to a single field and a single, simple validator (like "required"). This should rule out any other errors in the validation file.
Do that and check your server log files to see if there's any errors processing the files.

[How To Ask Questions On JavaRanch]

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I did 1 to 4. But found that log statement is not being printed.

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Joe Ess

Bartender

Posts: 9626

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

That would indicate to me that validation IS working and the problem is elsewhere. Is the log message printed out if you put something in the required field?

[How To Ask Questions On JavaRanch]

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

No it is not. It is showing the entered value in the EmpSuccess.jsp. But sysout inside execute( ) is not being printed.

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Souvik Dasgupta

Ranch Hand

Posts: 113

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Joe,

I have been able to resolve the issue.It was a problem regarding the location of the validation.xml file. It should go under src/main/resources/<my package>. Here goes the correct structure. However, Thanks a ton for spending your time.

struts2.jpg

Thanks and Regards
Souvik
SCJP, SCWCD, OCEJWSD

Joe Ess

Bartender

Posts: 9626

I like...

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Oh, are you using Maven to build? The "best practice" for Maven is to put non-source files to be in the "resources" directory. I always use Ant and the "best practice" for it is to have the source and validation files in the same directory, since that is where they will be in the WAR.

[How To Ask Questions On JavaRanch]

Please do not shoot the fish in this barrel. But you can shoot at this tiny ad:

Smokeless wood heat with a rocket mass heater

https://woodheat.net