process builder problem

[Emrah Ozkan]

Greetings,

I am working on a jsp application and at some point I need to execute a terminal command within java code.
Although the exact command works in terminal(osx), it returns a application specific error when I try it in java. (I interpreted this as I can reach the .jar file and execute it yet there's somehow a problem while passing the parameters).
I tried both runtime.exec() and processbuilder.start() options.
Any help will be highly appreciated
Below is the command and the code I have been working on:

command:
java -jar /AbsoluteFilePath/rdfslice_1.42.jar -source /AbsoluteFilePath/test.nt -patterns "{?s ?p ?o}" -out /AbsoluteFilePath/output.out -order "S"
java code (both with processbuilder and runtime.exec())

/* Process p = Runtime.getRuntime().exec(
 *         "java -jar /AbsoluteFilePath/rdfslice_1.42.jar -source /" +
 *         "AbsoluteFilePath/test.nt -patterns \"{?s ?p ?o}\" -out" +
 *         "  /AbsoluteFilePath/output.out -order \"S\"");
 */
		List<String> list = Arrays.asList(
				"java",
				"-jar",
				"/AbsoluteFilePath/rdfslice_1.42.jar",
				"-source",
				"/AbsoluteFilePath/test.nt",
				"-pattern", "\"{?s ?p ?o}\"", "-out",
				"/AbsoluteFilePath/output.out",
				"-order", "\"S\"" );

		// create the process builder
		ProcessBuilder pb = new ProcessBuilder(list);
		Process p = pb.start();
		
		int error;
		try {
			error = p.waitFor();
			System.out.println(error);
		} catch (InterruptedException e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		
		
		BufferedReader reader = new BufferedReader(new InputStreamReader(
				p.getInputStream()));
		StringBuilder builder = new StringBuilder();
		String line = null;
		while ((line = reader.readLine()) != null) {
			builder.append(line);
			builder.append(System.getProperty("line.separator"));
		}
		String result = builder.toString();
		System.out.println(result);

[Maxim Karvonen]

Hi, Emrah

Do you input your first command in a shell? If yes, then you do not need any additional quotes in parameters passed to a ProcessBuilder. Quotes are treated in a special way by the shell. They are used to properly pass some arguments. For example, shell treats ""{?s ?p ?o}" as single argument. Without quotes it would be three arguments. However, in ProcessBuilder you already have natural separation between arguments. Each string is treated as exactly one parameter. So in your code you should have "{?s ?p ?o}" instead of "\"{?s ?p ?o}\"". Same for "S".

[Campbell Ritchie]

Welcome to the Ranch

Thank you for using code tags, but the long lines make the post difficult to read. I have broken them; the first code block was originally one line. I have changed the // comments to /* comments */. I do not know whether line 6 of the second block is supposed to be inside the comment or not. I suspect not.