Not getting the output expected

[Tim Davis]

When I run my program and choose option 2 to get contact details I am expecting it to display as follows (First Name, Last Name):

Contacts how have been entered:
0) John Doe
1) George Smith
2) Nancy Davis
Please enter the number corresponding to the contact you would like to view:

Instead for a personal contact it is displaying as follows:
Contacts who have been entered:
0) Doe 1 F St. (last name, address)
Please enter the number corresponding to the contact you would like to view:

Instead for a business contact it is displaying as follows:
Contacts who have been entered:
0) 1 F St. [e-mail] (address, email)
Please enter the number corresponding to the contact you would like to view:

Then when I enter the number to display the contact for personal it is returning me only first name and business is only returning me first and last name. It should be returning the full contact info that was put in during the add contact step. I thought I programmed everything properly but it isn't displaying what I want to see. Any help would be greatly appreciated. My code is listed below.

ContactList

/*
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
*/
package contactlist;
import java.util.ArrayList;
import java.util.Scanner;
/**
*
* @author Tim
*/
public class ContactList {
public static void main(String[] args) {
// Local variable
int swValue;
Scanner keyIn = new Scanner(System.in);
ArrayList<Contact> ContactRecords = new ArrayList<Contact>();
while (true) {
// Display menu graphics
System.out.println("========================================");
System.out.println("| Address List |");
System.out.println("========================================");
System.out.println("| Options: |");
System.out.println("| 1. Add Contact |");
System.out.println("| 2. Get Contact Details |");
System.out.println("| 3. Exit |");
System.out.println("========================================");
System.out.println(" Select option: ");
swValue = keyIn.nextInt();
// Switch construct
switch (swValue) {
case 1:
addContact(ContactRecords);
break;
case 2:
getRecords(ContactRecords);
break;
case 3:
System.exit(0);
break;
default:
System.out.println("Invalid selection");
break;
}
}
}
public static void addContact(ArrayList<Contact> ContactRecords) {
Scanner textIn = new Scanner(System.in);
Scanner keyIn = new Scanner(System.in);
System.out.println("First Name: ");
String firstName = textIn.nextLine();
System.out.println("Last Name: ");
String lastName = textIn.nextLine();
System.out.println("Address: ");
String address = textIn.nextLine();
System.out.println("Email Address: ");
String email = textIn.nextLine();
System.out.println("Phone: ");
String phone = textIn.nextLine();
System.out.println("Is this a 1) Personal or 2) Business?");
int choice = keyIn.nextInt();
if (choice == 1) {
System.out.println("Date of Birth: ");
String dateOfBirth = textIn.nextLine();
Personal aPersonal = new Personal(firstName, lastName, address, email, phone, dateOfBirth);
ContactRecords.add(aPersonal);
}
if (choice == 2) {
System.out.println("Job Title: ");
String jobTitle = textIn.nextLine();
System.out.println("Organization: ");
String organization = textIn.nextLine();
Business aBusiness = new Business(firstName, lastName, address, email, phone, jobTitle, organization);
ContactRecords.add(aBusiness);
}
}
public static void getRecords(ArrayList<Contact> ContactRecords)
{
Scanner keyIn = new Scanner(System.in);
System.out.println("Contacts who have been entered:");
for (int i = 0; i < ContactRecords.size(); i++) {
System.out.println(i + ") "+ ContactRecords.get(i).getFirstName() + " " + ContactRecords.get(i).getLastName()) ;
}
System.out.println("Please enter the number corresponding to the contact you would like to view: ");
int choice = keyIn.nextInt();
System.out.println(ContactRecords.get(choice).toString());
}
}

Contact

/*
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
*/
package contactlist;
/**
*
* @author Tim
*/
public abstract class Contact {
private String firstName;
private String lastName;
private String address;
private String email;
private String phone;
public Contact(String firstName, String lastName, String address, String email, String phone) {
this.firstName = firstName;
this.lastName = lastName;
this.address = address;
this.email = email;
this.phone = phone;
}
public Contact() {
}
public String getFirstName() {
return firstName;
}
public void setFirstName(String firstName) {
this.firstName = firstName;
}
public String getLastName() {
return lastName;
}
public void setLastName(String lastName) {
this.lastName = lastName;
}
public String getAddress() {
return address;
}
public void setAddress(String address) {
this.address = address;
}
public String getEmail() {
return email;
}
public void setEmail(String email) {
this.email = email;
}
public String getPhone() {
return phone;
}
public void setPhone(String phone) {
this.phone = phone;
}
@Override
public String toString() {
return firstName + " " +lastName ;
}
}

Personal

/*
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
*/
package contactlist;
/**
*
* @author Tim
*/
public class Personal extends Contact {
private String dateOfBirth;
public Personal(String dateOfBirth, String firstName, String lastName, String address, String email, String phone) {
super(firstName, lastName, address, email, phone);
this.dateOfBirth = dateOfBirth;
}
public Personal() {
super();
}
public String getDateOfBirth() {
return dateOfBirth;
}
public void setDateOfBirth(String dateOfBirth) {
this.dateOfBirth = dateOfBirth;
}
@Override
public String toString() {
return dateOfBirth;
}
}

Business

/*
* To change this license header, choose License Headers in Project Properties.
* To change this template file, choose Tools | Templates
* and open the template in the editor.
*/
package contactlist;
/**
*
* @author Tim
*/
public class Business extends Contact {
private String jobTitle;
private String organization;
public Business(String jobTitle, String organization, String firstName, String lastName, String address, String email, String phone) {
super(firstName, lastName, address, email, phone);
this.jobTitle = jobTitle;
this.organization = organization;
}
public Business() {
super();
}
public String getJobTitle() {
return jobTitle;
}
public void setJobTitle(String jobTitle) {
this.jobTitle = jobTitle;
}
public String getOrganization() {
return organization;
}
public void setOrganization(String organization) {
this.organization = organization;
}
@Override
public String toString() {
return jobTitle + " " + organization;
}
}

[Junilu Lacar]

Unlike constructors, methods do not have an implicit call to the superclass method that was overriden. You have to explicitly call them with super.whatever(). In this case, you have to call super.toString() and use the returned value along with whatever else you want to tack on to it. If you don't call super.toString, then only what you wrote is what you're going to get.

BTW, I'm not implying that constructors are overridden, because they're not. The point is that you have to explicitly call the overridden super method if you want to execute the code there, otherwise, only the overriding code gets executed.

[Tim Davis]

Maybe I am missing something but you are saying in my Personal and Business subclasses I need to add to my return statement super.toStirng() along with any additional info I would like to see?

[S Majumder]

Tim ,
I am curious to know few things on your code :
1) Why your have defined the class Contact as abstract

public abstract class Contact {

, (still there is no abstract method !!!)
2)Why you override the toString() of Business and Personal like this :

@Override
public String toString() {
return dateOfBirth;
}

@Override
public String toString() {
return jobTitle + " " + organization;
}

why didnt you take other inherited properties here ? like firstName , lastName etc ..

and finally the last question :
3)why you have defined all properties (in Contact ,Personal and Business) as String ? Probably this is the most important question .Why am I asking this because you can find the solution of your problem in here.
You have done silly mistakes of calling constructor in Personal and Business class .It is showing you are passing different values from ContactList class to the respective constructor. Change constructor of Personal and Business accordingly , you can get the desire result .

Hope you get the point ..
Satya

[Junilu Lacar]

 

S Majumder wrote:
You have done silly mistakes of calling constructor in Personal and Business class .It is showing you are passing different values from ContactList class to the respective constructor. Change constructor of Personal and Business accordingly , you can get the desire result

To clarify this, check the parameters you are passing to your constructors; Java doesn't care about the names, it only cares about the positions and types. That is, the first value passed will be assigned to the first parameter declared and so on. The names are for your benefit, so you know what the value you are passing means or what it's for.