submit button not working?

[Aneeqa Rustam]

The class does get compiled but the submit button doesn't work?

/**
 * Orchestration class for Account
 */
import java.awt.*; //Importing the java.awt.* class
import java.awt.event.*;//Importing the java.awt.event.* class
import javax.swing.*;//Importing the  javax.swing. class

public class AccountDemo extends JFrame 
{
/// initializes the variables in the container
    String text1;
    String text2;
    String text3;
    String text4;
    String text5;
    String text6;
    JTextField nameText ;
    JTextField addressText ;
    JTextField currentBalanceText ;
    JTextField creditLimitText ;
    JTextField genderText ;
    JLabel nameLabel;
    JLabel addressLabel;
    JLabel currentBalanceLabel;
    JLabel creditLimitLabel;
    JLabel genderLabel;
    JRadioButton getRadioButton1;
    JRadioButton getRadioButton2;
    JButton getJButton;

    /**
     * Constructor
     */
    public AccountDemo()
    {
    super("This is a JFrame");
   final Container con = getContentPane(); 
   //Create window, get content pane
        
       
        //Creates buttons, text fields and labels
      
        nameLabel = new JLabel("Please enter your name");
        nameText = new JTextField(15);
        
        addressLabel = new JLabel("Please enter your address");
        addressText = new JTextField(15);
        
        currentBalanceLabel = new JLabel("Please enter your current balance");
        currentBalanceText = new JTextField(15);
        
        creditLimitLabel= new JLabel("Please enter your credit limit");
        creditLimitText = new JTextField(15); 
        
        genderLabel = new JLabel("Gender");
        
        getRadioButton1 = new JRadioButton("Male");
        
        getRadioButton2 = new JRadioButton("Female");
        
        getJButton = new JButton("SUBMIT");
        
      
        //Sets the layout
        FlowLayout myLayout = new FlowLayout();
        con.setLayout(myLayout);
         
        //Adds all the created GUI elements to the content pane
        con.add(nameLabel);
        con.add(nameText);
    
        con.add(addressLabel);
        con.add(addressText);
        
        con.add(currentBalanceLabel);
        con.add(currentBalanceText);
        
        con.add(creditLimitLabel);
        con.add(creditLimitText);
        
        con.add(genderLabel);
        
        con.add(getRadioButton1);
        con.add(getRadioButton2);
        
        con.add(getJButton);
       
    
        getJButton.addActionListener(new ActionListener()
//Gets the text for each button and creates account object using constructor. 
        {
            public void actionPerformed(ActionEvent e)
            {
                text1 = nameText.getText();         
                text2 = addressText.getText();          
                text3 = currentBalanceText.getText();           
                text4 = creditLimitText.getText();
                text5 = genderText.getText() ; 
                                
                System.out.println("Account holders name is "
                   + text1 +"  Account holders address is " + text2
                   +  " balance = "  + text3 + " credit = "
                   + text4 + " I am " + text5 + "SUBMIT" + text6);
            }
        });
        pack();//Sorts out the layout and tells Java to exit when pressing Close button
        setLocation(210,150);
        setSize(400, 300);
        setVisible(true);
        setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
   }

    public static void main(String [] args)  {
         AccountDemo demoObject = new AccountDemo();
    }
}

[Raghavan Muthu]

Hi,

When I ran the code I saw the below error in the console.

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
        at AccountDemo$1.actionPerformed(AccountDemo.java:97)
        at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2018)
        at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2341)
        at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
        at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
        at javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:252)
        at java.awt.Component.processMouseEvent(Component.java:6505)
        at javax.swing.JComponent.processMouseEvent(JComponent.java:3320)
        at java.awt.Component.processEvent(Component.java:6270)
        at java.awt.Container.processEvent(Container.java:2229)
        at java.awt.Component.dispatchEventImpl(Component.java:4861)
        at java.awt.Container.dispatchEventImpl(Container.java:2287)
        at java.awt.Component.dispatchEvent(Component.java:4687)
        at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4832)
        at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4492)
        at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4422)
        at java.awt.Container.dispatchEventImpl(Container.java:2273)
        at java.awt.Window.dispatchEventImpl(Window.java:2719)
        at java.awt.Component.dispatchEvent(Component.java:4687)
        at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:735)
        at java.awt.EventQueue.access$200(EventQueue.java:103)
        at java.awt.EventQueue$3.run(EventQueue.java:694)
        at java.awt.EventQueue$3.run(EventQueue.java:692)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
        at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:87)
        at java.awt.EventQueue$4.run(EventQueue.java:708)
        at java.awt.EventQueue$4.run(EventQueue.java:706)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
        at java.awt.EventQueue.dispatchEvent(EventQueue.java:705)
        at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
        at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
        at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
        at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
        at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

On line 97, you have

text5 = genderText.getText() ;

But the 'genderText' has just been declared on line 21 but not initialized further. However, it is a Radio button and NOT a text box like any others.

Can you modify your code suitably on this ? I am sure you would make it work.

[Aneeqa Rustam]

I can't make sense of what your trying to say?

[Raghavan Muthu]

I meant to say, you are actually capturing the input via a Radiobutton. But inside the code, you are trying to read it as a text box (genderText.getText()). The method getText() works with Text Box but you used it for a Radio Button,.

You need to add an action listener to each radio button because it is also a button. Please see this link http://docs.oracle.com/javase/tutorial/uiswing/components/button.html#radiobutton to modify your code suitably so that whenver you click on a radio button an event gets triggered and you capture the exact response from the User.

[Aneeqa Rustam]

Thank you, could you tell me how I could write out the action listener for the code and what I need to takeaway from this code?

[Darryl Burke]

Raghavan Muthu wrote:I meant to say, you are actually capturing the input via a Radiobutton. But inside the code, you are trying to read it as a text box (genderText.getText()). The method getText() works with Text Box but you used it for a Radio Button,.

What's a Text Box? And did you check whether JRadioButton has a method getText()?

Raghavan Muthu wrote:You need to add an action listener to each radio button because it is also a button.

Only if you want to respond to the action of selecting the radio button. That doesn't appear to be the case here.

edit Fixed the Quote tags

[Aneeqa Rustam]

how do i add an action listener?? also what change do i need to make to the JRadioButton? Are both needed?

[Campbell Ritchie]

Moving to our GUIs forum. Please don't write such long lines; they make the post illegible.
You add a listener the same way you added it in your previous thread.

You need to think of the design of what you are doing. Radio buttons are not intended to be pressed repeatedly but to maintain their state. You probably want an ordinary button.

[Darryl Burke]

Aneeqa Rustam wrote:I can't make sense of what your trying to say?

In your previous thread, K. Tsang gave you a link to a tutorial. The code you have posted in this thread suggests that you haven't gone through that tutorial. Please do, and you find if anything there confusing, feel free to ask about it here.

[Patrick Hayden]

The answer is in the first line of the stack trace:

at AccountDemo$1.actionPerformed(AccountDemo.java:99)

genderText is declared but is never initialized. It is referenced in the ActionListener (text5 = genderText.getText()).

At runtime genderText has the value null so this is evaluated as null.getText().

Hence the null pointer exception.

As a separate issue it is recommended that you explicitly start a Swing application in the Event Dispatch Thread:

    public static void main(String[] args) {
        SwingUtilities.invokeLater(new Runnable() {
            @Override
            public void run() {
                new AccountDemo();
            }
        });
    }

[Rob Spoor]

Or in Java 8:

    public static void main(String[] args) {
        SwingUtilities.invokeLater(() -> new AccountDemo());
    }