random card generator

[Vincent Tyson]

I've been trying to get a card generator working, but hells bells nothing is easy in java (unless you already the correct answer) trying to figure out the correct way to apply a method you don't understand is like being asked for the German word for banana in Spanish class.

If someone can finish off this segment of code, I can adapt it to fit my project and be done with this nightmare.

If you solve this problem for me, I will give you a years supply of rep points !!! (unless trading rep points is against the forum rules, or I forget)

Seriously, thanks.

import java.util.Random;
import java.util.Scanner;

class jacktest
{
    public static void main ( String[] args )
    {
            Random r = new Random();

            Scanner input = new Scanner(System.in);
            String name;
            boolean playing = true;
            boolean notplaying = true;
            int ncard = 1 + r.nextInt(11);

            for (i=0; i>11; ++i);

            System.out.println("two cards from the same int: "+ncard +ncard);
    }
}

As it stands, I can't make i and ncard interact, to form two different numbers,

I tried:
int ncard = i; -- symbol ncard already used
int i = ncard; -- symbol already used

for int (i=0; i>11; ++i) -- illegal statement
for (int i=0; i>11; ++i) -- illegal statement

my next step might be using object (hammer >=computer)=watch telly instead.

Thanks for the help.

[fred rosenberger]

first, your for-loop is wrong. it contains no body, so it basically does nothing.

next. your print statement prints the same variable twice, so it will always print the same number. If you want two different values, you need to generate two different values and save each of them.

[Guillermo Ishi]

I did this once. I used an arraylist containing all 52 cards and when I dealt one and removed it from the arraylist the arraylist length automatically changes, which gives you the new current upper bound for your random number. This is one case where Java makes it very easy. It was an arraylist of card objects, and the card objects contained suit, numeric value, and a bitmap of the card face.

[Henry Wong]

Also...

Vincent Tyson wrote:
I tried:
int ncard = i; -- symbol ncard already used
int i = ncard; -- symbol already used

for int (i=0; i>11; ++i) -- illegal statement
for (int i=0; i>11; ++i) -- illegal statement

my next step might be using object (hammer >=computer)=watch telly instead.

Programming isn't about throwing different statements together and see what works or what is correct. You get to the correct solution, by understanding the language, and by understanding the issue/program. Without the later, you don't know what to fix, and without the first, you can't get to the solution.

Henry

[Vincent Tyson]

Can you solve the above code for me as is?

I have the rest of my project almost complete, but it won't work without the card generator. I just need a simple 1-11 random number to generate.

I can save the int in a placeholder like

int ptotal = ncard +ncard
int pcurrent =ptotal +ncard

and the dealer
int dtotal =ncard +ncard
int dcurrent =dtotal +ncard

and use if statements to decided if either player is bust or has blackjack.

it's just the damn generator won't do what i want it too, If I need x2 sys.out lines I can live with that.

[Vincent Tyson]

I know what your saying Henry, I almost agree with you, but until I see the method working I can't decipher the logic, once I understand the logic, I can do anything with it, until then, I'm lost.

I can't find a page that explains what it is I'm trying to do, there is no text on the subject nor any published work I can draw from, so all I'm left with is guess work, and yes, I don't understand it.. yet, but I will if someone shows me the correct method, instead of telling me the 1000's of things I've done wrong..... if that makes sense.

anyways, without your help I can go no further, so help or not. your choice.

Vincent

[Ash Jon]

Vincent, Henry is giving sound advice. You don't understand what is wrong at the moment, why would a method that works allow you to understand why it works? You need to understand all of the code, including why your for-loop is wrong:

 // Your for-loop
         for (i = 0; i>11; ++i);
         // i is not given a type, should be: int i
         // there is no body (i.e. no curly brackets  { }) so absolutely nothing happens
                  
         // correct for loop
                  
         for (int i = 0; i > 11; ++i) {
        	 // this is the body

        	 // this will NEVER loop because it will only loop (but it IS correct syntax)
        	 // if i is more than 11 (i > 11)
        	 // ++i increments by 1 BEFORE the body of the loop
        	 // is processed
         }
         
         // a looping for-loop that actually loops
         for (int i = 0; i < 12; ++i) {
        	 // this body of code will process 11 times
        	 // because i will be less than 12 for 11 loops.
        	 // first loop: i = 1
        	 // second loop i = 2 etc
                // Needs to be less than 12 if you want use the i as a integer between and including 1 and 11

                // OR you could just use (int i = 1; i < 12; i++)



         }

At the moment, you are printing out the same value twice (ncard). If you need two different values based on the first variable (ncard), you need to create a new variable to store the new value after you have calculated whatever it is you need to calculate (I have no idea how to even play BlackJack so can't help here)


Hope it helps...

[Junilu Lacar]

One thing you'll have to understand, Vincent, is that we're NotACodeMill (←click that link) and we expect you to DoYourOwnHomework (←click). That means if you make 1000 mistakes, we won't give 1000 solutions but instead 1000 hints on how to correct your mistakes.

Why don't you describe, in plain English, what exactly you want the card generator to do. If you can't explain it simply to other people in plain English, then you won't have much luck trying to explain it to a computer in Java.

[Vincent Tyson]

Thanks Ash,

That helps, I wasn't having a go at Henry, I know better than that.
I just responded to his post, if I offended I apologize.

I came to the forum looking for help, but all I got so far was figure it out for yourself and stop bothering me.

I've asked for the code to be finished for me, because I don't // can't get to grips with it, and once I see what it should look like, I can analyze and compare to my own failed attempts
and perhaps say to myself "AH FFS Vincent!!! there is your problem right there" -- or -- "Oh so that's how it works, NICE!" and learn how not to make that mistake again.

I have been trying very hard on my own, I can show you 4-5 saved fails from my computer, but that will not help understand what is wrong, until I know what right looks like.

I hope I have been clear, I'm not trying to be argumentative in the least, I am spun out, dizzy from fails, and need to see where I'm going wrong so I can fix it.

Vincent.

[Carey Brown]

Vincent Tyson wrote:
int dtotal =ncard +ncard

This would be the same as

int dtotal = ncard * 2;

I don't see the purpose of this at all. Why *2 ?

[Vincent Tyson]

@Junilu

I would like my generator to produce a random number between 1-11, and save that number somewhere.
then another number, show it to me, and add it to the first number.
x=4
y=11
total = 15

without having to make 20+ int place holders (variables) or an array.

I would like ncard to = 1+ r.nextInt(11); every time I call it. So when a player hits,
system.out.println("your next card is"+ncard);

look... this is my project so far, and it will work perfectly if I can figure the card generator part, which I probably won't because no one will show me what it's supposed to look like <- not judging "notacodemill!"

import java.util.Random;
import java.util.Scanner;

class blackjack
{
    public static void main ( String[] args )
 {
		Random r = new Random();
		Scanner input = new Scanner(System.in);
		String name;
		boolean playing = true;
		boolean notplaying = true;
		
		int card1 = 1 + r.nextInt(11);
		int card2 = 1 + r.nextInt(11);
		int card3 = 1 + r.nextInt(11);
		int card4 = 1 + r.nextInt(11);
		int card5 = 1 + r.nextInt(11);
		int card6 = 1 + r.nextInt(11);
		int card7 = 1 + r.nextInt(11);
		int card8 = 1 + r.nextInt(11);
		int dcard1 = 1 + r.nextInt(11);
		int dcard2 = 1 + r.nextInt(11);
		int dcard3 = 1 + r.nextInt(11);
		int dcard4 = 1 + r.nextInt(11);
		int dcard5 = 1 + r.nextInt(11);
		int dcard6 = 1 + r.nextInt(11);
		int dcard7 = 1 + r.nextInt(11);
		int dcard8 = 1 + r.nextInt(11);
		
		int ptotal = card1 + card2;
		int ptotal = pcurrent + card2;
		int ptotal = pcurrent + card3;
		int ptotal = pcurrent + card4;
		int ptotal = pcurrent + card5;
		int dtotal = pcurrent + card6;
		int dtotal = pcurrent + card7;
		int dtotal = pcurrent + card8;
		
		int dtotal = dcard1 + dcard2;
		int dtotal = dcurrent + dcard3;
		int dtotal = dcurrent + dcard4;
		int dtotal = dcurrent + dcard5;
		int dtotal = dcurrent + dcard6;
		int dtotal = dcurrent + dcard7;
		int dtotal = dcurrent + dcard8;
				
				
        System.out.println("Welcome to Blackjack ! " );
		System.out.println("Score as close to 21 without going over to win ");
		System.out.println("What is your name?");
			name = input.nextLine();
		System.out.println("Hello " + name);
		
		System.out.println("Let's play some BlackJack!");
			System.out.println("The dealer shows: \n\t\t" +dcard1 );
			System.out.println("Your first card is: \n\t\t " +card1 );
			System.out.println("Your second card is: \n\t\t" +card2);
			System.out.println("giving you a total of " +ptotal );
		//Start of game
		//round1
			while (playing)
		{
			System.out.println("Would you like to (H)it or (S)tick?");
			Scanner hit1 = new Scanner(System.in);
				String a = hit1.nextLine();
				if(a.equals("h"))
		{
			card2 = getRandomInt();
			System.out.println("Your next card is " +card2 );
			System.out.println("Giving you a new total of " +pcurrent);
				if ((pcurrent >=22))
			System.out.println("You Busted! \nSorry! you lose");
		}
			else if(a.equals("s"))
		{
			System.out.println("You stick at "+ptotal );
			System.out.println("Now it's the dealers turn\n Dealer must draw until 17");
			playing = false;
		}
			else
		{
			System.out.println("Please press H or S");
		}
			
		}
				
 }
}		

the while loop will not work correctly until I can eliminate the 100's of int variables, and have only two, or three.
I still need to write the dealers part, but that will be simple enough.

So if the generator could simply make a random number for me to save and +ncard to, I could start gluing back in all the hair I've pulled out over the last week.

Thanks for replies.
Vincent.

[Carey Brown]

Vincent Tyson wrote:I have been trying very hard on my own, I can show you 4-5 saved fails from my computer, but that will not help understand what is wrong, until I know what right looks like.
I hope I have been clear, I'm not trying to be argumentative in the least, I am spun out, dizzy from fails, and need to see where I'm going wrong so I can fix it.
Vincent.

This is known as "thrashing". Forget Java for a moment, can you write down the steps in English?

[Vincent Tyson]

@Carey

the int = ncard +ncard;

would look like:

int = random3+ random6

but I've not gotten to that part yet, should be easy to create a temp int variable to store the first card drawn, and then add the second to it, for a player total per hit,
it's really just there to remind me to fix it once the card generator is done.

eg 3+6+8=17
17+5=bust!

[Vincent Tyson]

@Carey

Sure.

Welcome to BlackJack!
What is your name?
Hello Vincent
Lets play some Blackjack

Dealer draws a 8

Vincent draws a 8
and a 8
Your total is: 16
Would you like to Hit or Stick?
h
Vincent draws a: 4
Your total is:20

Dealers turn
Dealer must draw until 17

Dealer draws a:9
Dealer total: 17
Dealer draws a:10
Dealer: BUST

Congratulations.
You Win.

Would you like to play again? Yes or No.

That is the entirety of what I am trying to accomplish.

[Liutauras Vilda]

Hi Vincent,

Quite good start, but it is an actual game flow (you'll have it at the end, once you have working program), try to start from the very abstract steps then move on to more specific.

For instance:
1. Show greeting message
2. Ask player name
3. Greet player
Now your turn

After you finish 1st round, write down more specific steps of each abstract step (1 abstract step can/probably will extend to more specific steps), for instance:
1. Print message "BlackJack!"
2.1 Ask player name by printing message "What is your name?"
2.2 Store player name
3. Print greeting message and previously stored player name
...

Then 3rd round (you can add some technical details).. and so on.

[Stefan Evans]

Actually I think you would be better off generating a "deck" of 52 cards into an array and then "shuffling" them.
You can then "deal" from the deck starting at index 0, and going through all the cards.

Getting a random number from 0 to 11 isn't actually modelling the game properly. There are 13 cards in a suit, and four suits.
Because the picture cards all have a value of "10" in Blackjack, 10 is meant to be more likely to obtain than any other value - something not currently being modelled in your solution

[Junilu Lacar]

I agree with Stefan. You may have bitten off more than you can chew right now, Vincent. Trying to do this all in main() is not the best way to learn Java programming, especially for this problem. The ideal solution would involve different classes like Deck and Hand to represent a deck of cards and the hand each player is dealt. It would also involve using the List interface and one of its implementations, usually ArrayList. And then there are object-oriented concepts you need to know like encapsulation.

If you want to keep going the way you're going though, perhaps you can get some hints from searching for Java Blackjack implementation

[Stefan Evans]

At the risk of being a code mill:
Here is a method to help you get rid of all of those ints.

// declare your Random number generator outside of main, so that your method can use it
Random r = new Random();

public int getValueOfNextCard(){
  int card = r.nextInt(13) + 1;
  // 10, 11, 12, 13 --> 10 (10, Jack, Queen, King) 
  if (card >= 10){
    return 10;
  }
  return card;
}

Right now it uses a (slightly modified) version of your random number generator.
But it should help you get rid of all of those variables you have.

[Vincent Tyson]

Thanks Stefan,

I was attempting that for 9 hours, before I ran out of hair to pull out ;)

Since then I found a way to skirt the generator completely, and generate the new random card inside a loop, which is working very well at the moment, but it looks like I've got a broken while loop now, and all I need to do is fix it, and add a start again loop.

I'll copy that section into my method library for future reference, it will be very useful in up coming projects, I see how you made the J,Q,K come out as 10's and I didn't realize I could make conditions for the int value, which would of made life a lot easier in the first place

import java.util.Random;
import java.util.Scanner;

class Blackjack
{
    public static void main(String[] args)
    {
        Random r = new Random();
        String name;
        Scanner scannerIn = new Scanner(System.in);

			boolean yourTurn = true;
			boolean dealersTurn =true;
			int card1 = 1 + r.nextInt(11);
			int card2 = 1 + r.nextInt(11);
			int dcard1 = 1 + r.nextInt(11);
			int dcard2 = 1 + r.nextInt(11);

			int pscore = card1 +card2;
			int dscore = dcard1 +dcard2;

			System.out.println("Welcome to Blackjack ! " );
			System.out.println("\nScore as close to 21 without going over to win ");
			System.out.println("\nWhat is your name?");
				name = scannerIn.nextLine();
			System.out.println("\nHello " + name);
			System.out.println("\nLet's play some BlackJack!");
				System.out.println("\nThe dealer shows:\t" +dcard1 );
			System.out.println("\n\nYour first card is:\t " +card1 );
			System.out.println("\nYour second card is:\t" +card2  );
				System.out.println("\nGiving you a grand total of: " +pscore );


        while (yourTurn)
        {
					if ((pscore <= +card1 +card2))
					System.out.println("\nWould you like to (H)it or (S)tick?");
						String a = scannerIn.nextLine();
					if(a.toLowerCase().equals("h"))
			{
					int newCard = 1 + r.nextInt(11);
					System.out.println("\nYour next card is " +newCard );
						pscore = pscore +newCard;
					System.out.println("\nGiving you a new total of "+pscore);
						
					if ((pscore >=22))
                {
                    System.out.println("\nYou Busted! \nSorry! you lose");
					yourTurn = false;break;
                }
            }
			
			else if(a.toLowerCase().equals("s"))
			{	
				yourTurn = false;
                System.out.println("\nYou stick at " +pscore );
                System.out.println("\nNow it's the dealers turn\n Dealer must draw until 17");
            }
            else
            {
                System.out.println("\nPlease press H or S");
            }
			
			
		}	
		while (dealersTurn)
		{
			dealersTurn = true;
			{	if ((dscore <= dcard1+dcard2))
				System.out.println("\nThe dealers cards were:\n " +dcard1);
				System.out.println("\nand\n" +dcard2);
				System.out.println("\nGiving the Dealer a grand total of: " +dscore );
			}
			
			{
				int newCard1 = 1 + r.nextInt(11);
				if ((dscore<pscore))
					System.out.println("\nThe dealer draws a: " +newCard1 );
				dscore = dscore +newCard1;
					System.out.println("\nGiving the dealer a grand total of: "+dscore);
			}
			
			{
				if ((dscore==(pscore)))
					System.out.println("Dealer matches your score and sticks at: " +dscore);
					System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! ");
			}
			
				
			{
				if ((dscore >=22))
				System.out.println("\nDealer Bust!");
				System.out.println("\nThe House loses");
				System.out.println("\nYou Win");
				dealersTurn = false;
			}
			
			{	if((dscore >=pscore))
			
				System.out.println("\nDealer has " +dscore);
				System.out.println("\nThe dealer beat you!");
				System.out.println("\nThe House Wins!");
				dealersTurn = false;break;
			}
		}
	
        scannerIn.close();
	}    
}

you'll see, I added a new int value inside the loop, so each time it runs, a new random occurs.

But now, my problem is the dealers loop, I can't single out just one instance of the end game, either two or more run at the same time, or I need to adjust the if((dscore==(pscore))) line so the loop calls it correctly.

I realize this is yet another question, but I'm not sure if I should use one thread, or start a new one.

Thanks again.

[Junilu Lacar]

Vincent,

I'm not sure how you got to doing it the way you are but your use and placement of braces, while syntactically correct, is very unconventional and potentially very confusing and misleading. Your code indentation is also all over the place. For example:
{ if ((dscore==(pscore))) System.out.println("Dealer matches your score and sticks at: " +dscore); System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! "); }
There is nothing syntactically wrong with this, which may surprise a few who read this. It is valid code and will compile, as you obviously know. However, per normal conventions, the indentation of the code implies that the intent was for lines 85 and 86 to be executed on the condition that dscore == pscore. Also, you have used more parentheses than are really necessary on line 84. If written using standard conventions, your code would be written as:
if (dscore == pscore) { System.out.println("Dealer matches your score and sticks at: " +dscore); System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! "); }
However, your code is actually executed as if it were written in this more standard way:
if (dscore == pscore) { System.out.println("Dealer matches your score and sticks at: " +dscore); } System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! ");
Braces are used to group together statements to be executed as one "block" - in fact, that's what zero or more statements surrounded by balanced, matching braces is called: a statement block. Statement blocks are needed when you want to execute them as part of any control flow statement such as an if-else, while-loop, for-loop, etc. Braces around a block of statements are optional if they are not associated with a control-flow structure, that's why your code still compiles. If you want to visually see some separation between logical groups of statements, use a blank line or two. Better yet, put related statements in a method that represents a chunk of work to be done.

[Junilu Lacar]

Since you have put in a lot of effort already, let me try to give you something that might help your organize your program better. The idea here is trying to tell the "story" at a high-level first, then progressively drill down to more detailed levels. Note that the main method consists only of two statements: create an instance of the Blackjack game and then invoke its play() method, which is about as high-level as you can get. Then the play() method outlines the general flow and calls other methods to get smaller tasks done.

public static void main(String[] args) {
    Blackjack game = new Blackjack();
    game.play();
}

public void play() {
    boolean keepPlaying = true;

    while (keepPlaying) {
        Deck deck = new Deck();
        Hand dealersHand = dealHand(deck);
        Hand playersHand = dealHand(deck);

        giveTurn("Dealer", deck, dealersHand);

        if (dealersHand.isGood()) {
            giveTurn("Player", deck, playersHand);                  
        } 

        if (playersHand.beats(dealersHand)) {
            declareWinner("Player");
        } else {
            declareWinner("Dealer");
        }

        keepPlaying = playAgain();
    }
}

// all the other methods used above ...

private void declareWinner(String winnersName) {
    System.out.println(winnersName + " wins this round!");
}

private boolean playAgain() {
    System.out.println("Do you want to play again (Y/N)? ");
    String choice = ... // get user input, etc.
    return "Y".equalsIgnoreCase(choice);
}

private void giveTurn(String player, Deck deck, Hand hand) {
    greet(player);
    boolean keepGoing = true;
    while (hand.isGood() && keepGoing) {
         String action = promptHitOrStay();
         if ("H".equalsIgnoreCase(action)) {
             hand.add(deck.dealCard());
         } else {
             keepGoing = false;
         }
    }
}

private Hand dealHand(Deck deck) {
    Hand newHand = new Hand();
    for (... // however many cards are in a hand ) {
         newHand.add(deck.dealCard());
    }
    return newHand;
}

// more methods that go into more detail...

Methods like declareWinner() and playAgain() are at the lowest level of abstraction and detail - that's where the nitty-gritty works gets done. Methods like giveTurn() and dealHand() are at a level where the code is still abstract and you're trying to break down a chunk of the story into smaller chunks. So you continue to outline and refine.

By breaking the problem down into progressively smaller chunks, you can manage the complexity and get a better handle on how things are supposed to flow in your program. By starting at a high level of abstraction, you get the lay of the land first and an overall picture of what's going to happen. As you drill down into the details, you just follow the same strategy of slowly dividing and conquering the work to be done. As I mentioned previously, you'll also want to create separate classes to represent a Hand and a Deck of cards, respectively.

[Vincent Tyson]

Yeah, I've been told off about my braces before, but the college instructor wants it done his way to avoid confusion on his part. eg

public stacic void main(String[] args) { //body

}

he prefers
Public stactic void main(String[] args)
{//body
}

and I guess, it's confusing even me now at this point, It feels like I'm trying to follow two sets of rules, and now I'm paying for it in spades (pardon the pun)

Thanks for the revision, I won't be copy pasting, but I will try to indent and use braces correctly as you've laid out here, it's really useful to see how it should look.
We haven't touched on the public void play () { yet, and although I do sort of understand what it's doing, I fear that is well outside of my wheelhouse. I should be able to modify my loops as you suggested and make each loop end correctly, instead of seeing all three when the game ends.

I honestly can't express how helpful you all have been, and I wish there was a way I could repay your kindness, I will probably go find a private tutor for java and see if I can learn the more popular, conventional way of structuring code, because everyone has told me it looks like a dogs dinner or something similar.

I've got an exam in networking (MUCH easier than java ;) ) tomorrow, but I should still brush up. I'll be back in a couple of days with a progress report if you'd like one.

Vincent.

[Stefan Evans]

Style on placement of braces is a religious war that will never end.
Whichever way you do them however, they do at least need to match your intentions

rather than

{
    if ((dscore==(pscore)))
        System.out.println("Dealer matches your score and sticks at: " +dscore);
        System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! ");
}

You need

if ((dscore==(pscore)))
{  
        System.out.println("Dealer matches your score and sticks at: " +dscore);
        System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! ");
}

The braces group together the set of statements to execute for the 'if' statement. If you don't have braces after the if statement, only the very next line is tied to the if statement, and the rest are not.

[Vincent Tyson]

I've made the final revisions, to my code and now after almost 6 days of serious confusion, I have a finished product. - almost.

I have a slight problem in one of the loops, where the program freezes if certain conditions are met,and the players can still draw 11 for both cards in the beginning, forcing a bust before the game starts. I've moved if statements outside the {} braces for flow control.
Overall I have a 99% working blackjack game, with Strings, Scanners, int variables, while loops, if-else statements and correctly indented and structured code. I reckon it's worth at least a B+. the grade belongs to the forum members without them I would have nothing at all. I'll keep on with bugs and see if I can do something with them, I just wanted to say thanks for all the help, and I hope someday I'll be able to offer advise and information like the people in this community do.

I know some people will be curious as to how it looks and reads now, I haven't copy pasted any code offered here as a guideline, I learned the method after I was shown what the working model looks like, and thanks again for being so patient with me, I knew this wouldn't be easy, but I never thought it would be this hard.

Thanks again for everything, -- marked as resolved --

import java.util.Random;
import java.util.Scanner;
//imports random number generator and a scanner for keyboard inputs
class Blackjack // declare the class name: Must match the filename
{
    public static void main(String[] args) // main method
    {
        Random r = new Random(); // declares "r" as the caller id for a random number
        String name; // declares "name" as the caller id for the String variable: Must be letters only
        Scanner scannerIn = new Scanner(System.in); // declares scannerIn as the caller id for keyboard inputs
 
            boolean yourTurn = true; // true or false statement for the while "loop"
            boolean dealersTurn =true;// true or false statement for the while "loop"
            int card1 = 1 + r.nextInt(11);
            int card2 = 1 + r.nextInt(11);
            int dcard1 = 1 + r.nextInt(11);
            int dcard2 = 1 + r.nextInt(11); // first four cards dealt to the players
 
            int pscore = card1 +card2; // first total score for the player
            int dscore = dcard1 +dcard2; // first total score for the dealer
 
            System.out.println("Welcome to Blackjack ! " );
            System.out.println("\nScore as close to 21 without going over to win ");
            System.out.println("\nWhat is your name?"); // greeting message
                name = scannerIn.nextLine(); // the String "name" will be saved as the players name
            System.out.println("\nHello " + name); // players name is output
            System.out.println("\nLet's play some BlackJack!");
                System.out.println("\nThe dealer shows a hidden card an a: " +dcard1 ); // dealers first card is generated and displayed
            System.out.println("\n\nYour first card is:\t " +card1 ); // players first card is generated and displayed
            System.out.println("\nYour second card is:\t" +card2  ); // players second card is generated and displayed
                System.out.println("\nGiving you a grand total of: " +pscore ); // players score is generated
 
 
        while (yourTurn) // the while loop runs to next if statements as long as the "yourTurn" boolean remains true
        { // while method, contains rules for handling scores and gameplay
		
					if (card1 + card2 ==21) //if statement runs if players first two cards add to 21 :otherwise ignored
				{
					System.out.println("Player has BLACKJACK\nWe Have A Winner!!");
					yourTurn = false;break; // boolean yourTurn declared false ending the game. .. break stops the loop checking for other if statements that might be also true
				}
                    if ((pscore <= +card1 +card2))// player score must be equal or less than the first two cards dealt for this if statement to run : always true, but necessary for flow
                    System.out.println("\nWould you like to (H)it or (S)tick?");
                        String a = scannerIn.nextLine();// String variable for the scanner declared inside the if statement : otherwise many String variables would be required
                    if(a.toLowerCase().equals("h"))// string "a" does not need to be in upper or lower case : caps lock 
            {
                    int newCard = 1 + r.nextInt(11); // int newCard variable declared inside the loop, calling a new variable each time. (struggled with this for awhile)
                    System.out.println("\nYour next card is " +newCard ); // declares the new card as a real number
                        pscore = pscore +newCard; // adds the total of the original score to the bew card : creating a new total
                    System.out.println("\nGiving you a new total of "+pscore); // tells the player what the new total is (struggled with this also)
                         
                    if ((pscore >=22))// if players score goes over 21 the player is bust and the game ends
                {
                    System.out.println("\nYou Busted! \nSorry! you lose");
                    yourTurn = false;break; // declares the boolean false and breaks the loop
                }
            }
             
            else if(a.toLowerCase().equals("s")) // second half of the if statement, if the player sticks
            {   
                yourTurn = false; // ends the loop
                System.out.println("\nYou stick at " +pscore ); // shows the players final score, which the dealer must beat
                System.out.println("\nNow it's the dealers turn\n Dealer must draw until 17"); // tells the user the computer will play now
            }
            else // if the player chooses anything other than (H)it or (S)tick this loop will ask the player to make the choice
            {
                System.out.println("\nPlease press H or S");
            }
             
             
        }   
        while (dealersTurn) // second while loop
        {// dealers turn boolean is true : declared before the main method
            dealersTurn = true; // this second declaration is to ensure the loop does not accidentally break while dealing with the rules in the if statement
			
				if (dscore <= dcard1+dcard2) // this checks if this is the dealers first turn or not
            {   
                System.out.println("\nThe dealers cards were:\n " +dcard1);
				System.out.println("\nand\n" +dcard2); // this line sometimes comes out when the dealer hits more than once, unsure why or how
                System.out.println("\nGiving the Dealer a grand total of: " +dscore );
            }
				else if (dcard1 + dcard2 ==21 && dscore == 21) // if not the first turn, checks conditions for blackjack rule e.g 10+11
			{
				System.out.println("Dealer has BLACKJACK\nHouse wins!!");
				dealersTurn= false;break; // ends loop, breaks checking other if statements for true statements.
			}
			
				else if (dcard1 + dcard2 >=17 && dscore<=22 && dscore>=pscore) // if not the first turn or blackjack, this checks if the dealer needs to draw another card or if he wins
				{
					System.out.println("Dealer has:" +dscore);
					System.out.println("Which beats the players score of: " +pscore);
					System.out.println("Dealer WINS!!!");
					dealersTurn = false;break; // ends the loop, breaks checking for other if statements
				}
			 
				
			    if (dscore < pscore) // checks if the dealers score is lower than the players score, weather or not he must play again
            {
                int newCard1 = 1 + r.nextInt(11);
                    System.out.println("\nThe dealer draws a: " +newCard1 );
                dscore = dscore +newCard1;
                    System.out.println("\nGiving the dealer a grand total of: "+dscore);
					
            }
				if (dscore<17) // forces the dealer to draw until 17 is reached
            {
				int newCard2 = 1 + r.nextInt(11);
                    System.out.println("\nThe dealer draws a: " +newCard2 );
                dscore = dscore +newCard2;
                    System.out.println("\nGiving the dealer a grand total of: "+dscore);
            }
             
			 if (dscore==pscore && pscore>=22 && dscore>=22) // fixes if statement that allows the dealer to win if he busts at the same score as the player e.g. both score 24
            {
                System.out.println("Both players BUSTED!\nTied Game");
				dealersTurn = false;break;
			}
			
			if (dscore==pscore && pscore <22 & dscore <22) // dealer wins if both scores are the same and less than 21
            {
                System.out.println("Dealer matches your score and sticks at: " +dscore);
                System.out.println("The House Wins\nYou failed to beat the dealer\nYou Lose! ");
				dealersTurn = false;break;
            }
			
			if (pscore >=22 && dscore >=17 && dscore <22) //stops the dealer from drawing cards past the players score and the dealer wins
			{
				System.out.println("Dealer Sticks at " +dscore);
				System.out.println("Dealer Wins! ");
				dealersTurn = false;break;
			}
			
			if (dscore >=22 && pscore>=22) // both scores are over 21 force a tied game
			{
				System.out.println("Both players BUSTED!\nTied Game");
				dealersTurn = false;break;
			}
             
            if (dscore >=22) // dealer draws cards over the value of 21
            {
                System.out.println("\nDealer Bust!");
                System.out.println("\nThe House loses");
                System.out.println("\nYou Win");
                dealersTurn = false;break;
            }
             
			 if(dscore >=pscore && dscore <21 ) // checks if the dealers score is higher than the players score but lower than 21, allowing the dealer to win
            {
                System.out.println("\nDealer has " +dscore);
                System.out.println("\nThe dealer beat you!");
                System.out.println("\nThe House Wins!");
                dealersTurn = false;break;
            }
        }scannerIn.close();

// bugs: both player and dealer may accidentally get 11 for both initial cards, making one or both bust before the game starts,game freezes at a point in the code if one certain condition is met
// credits: Helpful members of Java-moose-ranch, Instructor (deleted), Classmates of PCM1 Greenhills college 2014-2015
// notes:  Members of Java-moose-ranch helping with brace placement and syntax errors    
}
//to do: 
// add a sleep timer so the dealers hand is more realistic. 
// attempt to fix the double 11 draw on the initial cards.
// fix game freeze in specific section of while loop; problem unknown.
// get some sleep :)

[Henry Wong]

Vincent Tyson wrote:and the players can still draw 11 for both cards in the beginning, forcing a bust before the game starts.

An Ace is either a one or an eleven. So two aces is either a two or a twelve. You will need to adjust for this case.

On the same note, if a player draws a card, that busts the hand, you will also need to check to readjusts any aces that were previously treated as an eleven, as it should be now treated as a one.

Henry

[Junilu Lacar]

Hi Vincent,

This is what happens when I hard-coded the initial cards dealt to the player and dealer to be all 11, i.e. they both bust at the start.
Welcome to Blackjack ! Score as close to 21 without going over to win What is your name? J Hello J Let's play some BlackJack! The dealer shows a hidden card an a: 11 Your first card is: 11 Your second card is: 11 Giving you a grand total of: 22 Would you like to (H)it or (S)tick? H Your next card is 11 Giving you a new total of 33 You Busted! Sorry! you lose The dealers cards were: 11 and 11 Giving the Dealer a grand total of: 22 The dealer draws a: 11 Giving the dealer a grand total of: 33 Both players BUSTED! Tied Game
I had to input my name (Line 6) and on line 21, I was prompted if I wanted to Hit or Stick and I entered "H" (Line 22). So there's still some logic that's off. You made a valiant run in getting to this point though and I have to commend you for your perseverance.

[Vincent Tyson]

Thanks Henry,
After some discussion about this double 11 situation with my instructor, he said it was ok if the rules weren't identical to the original blackjack game because we haven't studied Case() as you have mentioned, and we probably won't get to it by terms end in may.

So as an alternative, I call 10+11=21 blackjack, which is still possible in the game, and I can make two more if statements to declare if (card1+card2==22) declare a bad deal, end the program.

My real problem is I haven't learned the methods needed yet, and although there is plenty of text out there on the subject, I have to make the game work within the confines of what we have covered in class, but I guess I've already come this far. Maybe my local store has a good book on Java that covers all the good stuff like cases and arrays. If they have examples and exercises I can learn just about anything, so fingers crossed.

@junilu,

Yep that's exactly what I get too, and I just found another bug which causes an infinite loop when some unknown exact criteria are met, but on a positive side, my instructor said the work so far was, far beyond what he had expected of me, I suppose technically it wasn't my code entirely, but he said as long as I understand it, it doesn't matter where it comes from. I'll go see if I can find that book, maybe there is a way to salvage this and submit a bug free program.

Vincent.

[Stijn Rensen]

kudos for the contributers of this topic. Once again showing the strength of this forum.

Having the guru's getting the student to really go through a learning proces. And having the "newbie" overcome his frustation and open up to really learn to code.

Thumbs up.

PS. and making it a nice read for other newbies in the mean time

[Tushar Goel]

We can't generate perfect random number for deck of cards using shuffling. For perfect randomness possible combinations are 52! which is
not possible to do on 64 bit machine. It requires 226 bit instead. Here is the Wikipedia link, http://en.wikipedia.org/wiki/Fisher%E2%80%93Yates_shuffle

I am sorry if its is irrelevant to the post.

[Vincent Tyson]

You raised an interesting point there, the idea of pure randomness is not exactly possible, and the algorithm ( a little above my pay grade ) seems to state that.
So I suppose the correct thing would be to say an unpredictable card, rather than a random one.

That said, for the purpose of this school exercise, I don't think it would make a tremendous difference to the outcome of any of the games played within.

Thanks for the interesting aside.
Vincent

[Campbell Ritchie]

Nothing mechanical can produce true randomness. You can get true randomness from some systems, e.g. radioactive decay, thermal noise, Brownian motion, etc. Now you aren't going to have a lump of radium or a Brownian motion producer (not even a really hot cup of tea) in your computer, so the nearest you will get is pseudo‑randomness. The number of possible deals of cards, allowing for there being 52! orders for the cards, is so many that the java.util.Random class can never produce them all. But, as you say, you are not going to notice that in your exercise. It is worth mentioning in the accompanying report, however.

[Campbell Ritchie]

A few minutes ago, I wrote: . . . you aren't going to have a . . . ( . . . really hot cup of tea) in your computer . . .

Not unless you are very careless, that is