Forum:

Some RowSet Info not Being Displayed

Greenhorn

Posts: 16

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Guys,

I am reading from a database(SQL Server 2012) and storing that information in a ResultSet. I am then trying to display that information using a DataTable. The problem is, only some of the information is being displayed and I can't figure out why.

Here is my managed bean

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package clientspage;

import java.io.Serializable;
import java.sql.DriverManager;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.sql.SQLException;
import javax.faces.bean.ManagedBean;
import javax.faces.bean.RequestScoped;
import java.sql.Connection;
import javax.sql.rowset.CachedRowSet;

@ManagedBean(name="clientsPageManagedBean")
@RequestScoped
public class ClientsPageManagedBean implements Serializable{
    
    private int clientID;
    private String client;
    private Connection connection;

public int getClientID() {
        return clientID;
    }

public void setClientID(int clientID) {
        this.clientID = clientID;
    }

public String getClient() {
        return client;
    }

public void setClientName(String client) {
        this.client = client;
    }
    
      public ResultSet getClients() throws SQLException, ClassNotFoundException {
        try{Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver");

connection = DriverManager.getConnection(
                "jdbc:sqlserver://localhost:1433;databaseName=dbName;"
                + "user=sa;password=dbPassword");

String SQL = "SELECT ClientID, Client FROM Clients";

PreparedStatement getClients = connection.prepareStatement(SQL);
        getClients.execute();

CachedRowSet rowSet = new com.sun.rowset.CachedRowSetImpl();
        rowSet.populate(getClients.executeQuery());
        
         return rowSet;
        }finally{
            connection.close();
        }
            
    }
}

And this is my JSF code

<?xml version='1.0' encoding='UTF-8' ?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:h="http://xmlns.jcp.org/jsf/html"
      xmlns:f="http://xmlns.jcp.org/jsf/core">
    <h:head>
        <title>Client</title>
    </h:head>
    <h:body>
        <h:form>

<h:outputText value="Search:"/>
            <h:inputText/>
            <h:commandButton value="Go"/>
            <h:commandButton value="New Client"/>

<h:dataTable value="#{clientsPageManagedBean.clients}" var="c"
                         cellpadding="5" cellspacing="0">
                <h:column>
                    <f:facet name="header">

</f:facet>
                    <h:commandLink value=">>>"/>
                </h:column>
                
                <h:column>
                    <f:facet name="header">
                        ID
                    </f:facet>
                    #{c.clientID}
                </h:column>
                
                <h:column>
                    <f:facet name="header">
                        Client
                    </f:facet>
                    #{c.clientName}
                </h:column>
                
            </h:dataTable>
        </h:form>
    </h:body>
</html>

Any ideas? The ID and the commandLinks are being displayed but the Client is not.
Edit: I don't have a lot of experience with JSF so any tips are welcome

Tim Holloway

Saloon Keeper

Posts: 28713

211

I like...

posted 10 years ago

1
Number of slices to send:

Optional 'thank-you' note:

Send

You are doing a database fetch operation in a property-fetch method. The "get" and "set" methods can be invoked as many as 5 or 6 times in a SINGLE page request. That's a lot of overhead. Furthermore, if your get/set methods change the data state, then they won't operate reliably.

You should fetch the data once, cache it in a list or array, and return the cached data on subsequent "get" requests.

Experience keeps a dear School, but Fools will learn in no other.
---
Benjamin Franklin - Postal official and Weather observer

Oli Brown

Greenhorn

Posts: 16

posted 10 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Thank you Tim. That's fixed the problem.

Don't get me started about those stupid light bulbs.