My program doesn't function properly

[Clark James]

My program is suppose to accept up to 5 names and grades and it does that but when I try to sort them by Name or Grade and then try print them out I am only getting the last name and grade entry made. I'm pretty sure the problem is with my counter but I can't seem to figure it out. Any help would be appreciated it.

public class Roster 

{

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) 
 
//begin main
        String[] Name = new String[5];  
        int[] Grade = new int[5];         
        int Count = 0;                     //declare an integer Count and initialize to zero
        int Selection;                      // declare an integer Selection
        char in = 'Y';                     //declare a char in and initialize to the letter Y
        Scanner keyboard = new Scanner(System.in);  // instantiate a new Scanner object for keyboard capture
        for(int i = 0; i < 5; i++)
        

        //Prompt User To Enter Grades
        while(( Count < 5 && in != 'N'))
        {      //begin while        
            
             System.out.print("Enter the last name of student: ");           //add code to prompt user to enter last nmae
             Name[i] = keyboard.next();                                               //add code to capture last name and store in the appropriate array element
             System.out.print("Enter a grade (1-100) for student: ");      //add code to prompt to enter grade, grade should be from 1 to 100
             Grade[i] = keyboard.nextInt();                                          //add code to store in the appropriate array element
             Count++; //add code to increment your counter 
             System.out.print("Continue? Enter Y for YES or N for NO?");
             in = keyboard.next().toUpperCase().charAt(0);
in = keyboard.next().toUpperCase().charAt(0);
             
        }   //end while
  
        //Prompt User To Make A Selection  
        
       do
         {     //begin do while      //***Keeps printing this section after Selecting 1 or 2
            System.out.println("");
            System.out.println("Please Choose An Option:");
            System.out.println("1. Arrange By Student Name");
            System.out.println("2. Arrange By Student Grade");
            System.out.println("3. Exit Program");
            System.out.println("");
            Selection = keyboard.nextInt();
            System.out.println("");

            //Sort Entered Information By Selected Criteria
            switch(Selection)  
            {
               case 1:
                   System.out.print("The information will be sorted by student name.");
                 System.out.println("");  //break;
               case 2:
                   System.out.print("The information will be sorted by student grade.");
                   System.out.println(""); //  break;
//               default:
//                   System.out.println("Not a valid option, please choose 1, 2 or 3.");
                  
                  Bubble(Name,Grade,Selection,Count); //add code to call bubble and pass the four required arguments(Last, Grade, Selection, Count)
                  Print(Name,Grade,Count); //add code to call print and pass the required arguments (Last, Grade, Count)
              
            }  //end switch
         } 
        while(Selection != 3);  //end do while
//            System.out.println("Exiting program, Goodbye!");
    }           //end main
    
       public static void Bubble(String[] Name, int[] Grade, int check, int Count)
        
      {   //start bubble sort
        
        String nme;
        int grd;
     
        //Sort By Student Name:
        if(check == 1)
        {  //start if arrange by student name
            for(int j = 1; j < Count; j++)
            {      //start outer sort loop for bubble
                for(int i = 1; i <= Count-1; i++)
                {    //start inner sort loop bubble
                    if(0 <= Name[i-1].compareTo(Name[i]))
                    {      //start compare
                        
                        nme = Name[i-1];
                        grd = Grade[i-1];
                        Name[i-1] = Name[i];// swapping
                        Grade[i-1] = Grade[i];// swapping
                        Name[i] = nme;
                        Grade[i] = grd;
                        
                    }       //end compare
                }       //end inner sort loop
           }       //end outer sort loop
        }      // end if arrange by student name


         //Sort By Student Grade:
        else
         {
            for(int j = 1; j < Count; j++)
            {      //start outer sort loop
                for(int i = 1; i <= Count-1; i++)
                {   //start inner sort loop
                    if(Grade[i-1] < Grade[i])
                    {     //start compare
                        nme = Name[i-1];
                        grd = Grade[i-1];
                        Name[i-1] = Name[i];
                        Grade[i-1] = Grade[i];
                        Name[i] = nme;
                        Grade[i] = grd;
                    }            //end compare
                }           //end inner sort loop
            }           //end outer sort loop
          }
      }   //end bubble

  
        public static void Print(String[] Name, int[] Grade, int Count)
        
        {  //start print
            System.out.println("Name\tNumerical Grade");
            for(int i = 0; i < Count; i++)                                                //set up a for loop that will iterate from 0 to count -1
            { 
             System.out.print(Name[i]+ "\t" +Grade[i]);                         //Write code to print array Name and array Grade within the loop (All elements of the array)
             System.out.println();   
            }
        }  // end print
}          //end class Roster

[Tushar Goel]

Your code doesn't compile. Please paste code which can be compiled and also use codetagsfor the same.

[Stefan Evans]

Hi! Welcome to the ranch.

Yeah, as Tushar has pointed out, it helps if you UseCodeTags. <--- click to find out how.
I've put them in for you this time - see how much better it looks?


There are a couple of minor compile errors in there
- missing import for scanner class
- missing an opening { for your class.

Once those are sorted your program should compile and run .

You do have a problem in the code that inputs the names.
Your print method looks ok though. I would suggest calling it after you have finished entering names just to show you what the user entered before sorting.
Or maybe even printing them names after you have entered EACH name .
That should help you get a handle on what is going on in your program.

[Clark James]

See if it compiles now. I'm using NetBeans and it does compile there but I left out the top couple lines previously.

package roster;
import java.util.Scanner;
/**
 *
 * @author Jimmy
 */
public class Roster 

{

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) 

    {   //begin main
        String[] Name = new String[5];  
        int[] Grade = new int[5];         
        int Count = 0;       //declare an integer Count and initialize to zero
        int Selection;                     // declare an integer Selection
        char in = 'Y';       //declare a char in and initialize to the letter Y
        Scanner keyboard = new Scanner(System.in);  // instantiate a new Scanner object for keyboard capture
        for(int i = 0; i < 5; i++)
        

        //Prompt User To Enter Grades
        while(( Count < 5 && in != 'N'))
        {      //begin while        
            
             System.out.print("Enter the last name of student: ");   //add code to prompt user to enter last nmae
             Name[i] = keyboard.next();       //add code to capture last name and store in the appropriate array element
             System.out.print("Enter a grade (1-100) for student: "); //add code to prompt to enter grade, grade should be from 1 to 100
             Grade[i] = keyboard.nextInt();  //add code to store in the appropriate array element
             Count++; //add code to increment your counter 
             System.out.print("Continue? Enter Y for YES or N for NO?");
             in = keyboard.next().toUpperCase().charAt(0);
             
        }   //end while
  
        //Prompt User To Make A Selection  
        
       do
         {     //begin do while      
            System.out.println("");
            System.out.println("Please Choose An Option:");
            System.out.println("1. Arrange By Student Name");
            System.out.println("2. Arrange By Student Grade");
            System.out.println("3. Exit Program");
            System.out.println("");
            Selection = keyboard.nextInt();
            System.out.println("");

            //Sort Entered Information By Selected Criteria
            switch(Selection)  
            {
               case 1:
                   System.out.print("The information will be sorted by student name.");
                 System.out.println("");  //break;
               case 2:
                   System.out.print("The information will be sorted by student grade.");
                   System.out.println(""); //  break;
               
                  Bubble(Name,Grade,Selection,Count); //add code to call bubble and pass the four required arguments(Last, Grade, Selection, Count)
                  Print(Name,Grade,Count); //add code to call print and pass the required arguments (Last, Grade, Count)
              
            }  //end switch
         } 
        while(Selection != 3);  //end do while

    }           //end main
    
       public static void Bubble(String[] Name, int[] Grade, int check, int Count)
        
      {   //start bubble sort
        
        String nme;
        int grd;
     
        //Sort By Student Name:
        if(check == 1)
        {  //start if arrange by student name
            for(int j = 1; j < Count; j++)
            {      //start outer sort loop for bubble
                for(int i = 1; i <= Count-1; i++)
                {    //start inner sort loop bubble
                    if(Name[i-1].compareTo(Name[i]) > 0)
                    {      //start compare
                        
                        nme = Name[i-1];
                        grd = Grade[i-1];
                        Name[i-1] = Name[i];// swapping
                        Grade[i-1] = Grade[i];// swapping
                        Name[i] = nme;
                        Grade[i] = grd;
                        
                    }       //end compare
                }       //end inner sort loop
           }       //end outer sort loop
        }      // end if arrange by student name


         //Sort By Student Grade:
        else
         {
            for(int j = 1; j < Count; j++)
            {      //start outer sort loop
                for(int i = 1; i <= Count-1; i++)
                {   //start inner sort loop
                    if(Grade[i-1] < Grade[i])
                    {     //start compare
                        nme = Name[i-1];
                        grd = Grade[i-1];
                        Name[i-1] = Name[i];
                        Grade[i-1] = Grade[i];
                        Name[i] = nme;
                        Grade[i] = grd;
                    }            //end compare
                }           //end inner sort loop
            }           //end outer sort loop
          }
      }   //end bubble

  
        public static void Print(String[] Name, int[] Grade, int Count)
        
        {  //start print
            System.out.println("Name\tNumerical Grade");
            for(int i = 0; i < Count; i++)  //set up a for loop that will iterate from 0 to count -1
            { 
             System.out.print(Name[i]+ "\t" +Grade[i]);//Write code to print array Name and array Grade within the loop (All elements of the array)
             System.out.println();   
            }
        }  // end print
}          //end class Roster

[Clark James]

Stefan Evans wrote:Hi! Welcome to the ranch.

Yeah, as Tushar has pointed out, it helps if you UseCodeTags. <--- click to find out how.
I've put them in for you this time - see how much better it looks?


There are a couple of minor compile errors in there
- missing import for scanner class
- missing an opening { for your class.

Once those are sorted your program should compile and run .

You do have a problem in the code that inputs the names.
Your print method looks ok though. I would suggest calling it after you have finished entering names just to show you what the user entered before sorting.
Or maybe even printing them names after you have entered EACH name .
That should help you get a handle on what is going on in your program.

Stefan,

After reading your comments I started looking at my Name and Grade input and finally got it working. I simply added i++; after the Grade input line and it finally accepted and printed all five names and grades out of the parallel arrays.
Thanks for your help. I'm only a couple months into Java and this had me stumped for a few days.

[Campbell Ritchie]

Welcome to the Ranch again

I can see lots of ways you can improve that code. One problem is that method is much too large. You should divide that up; you can probably make ten methods from it. Don't start variable names with CapitalLetters; start them with smallLetters. Don't write comments which make the lines so long and don't tell us anything we can't guess from the code anyway.

Where did you add i++; (line number)? Can you explain why that made the program work? If you can do that, you will demonstrate you learnt something useful.

[Carey Brown]

You have a for() loop on line 23 without any braces. The result is the for() loop immediately incloses the following while() loop.

[Liutauras Vilda]

I'm not sure what is more bad: to put such a lot code in one method, or create such an amount of comments - which just makes code less readable.

But even that, if you decide to write so many comments, make sure they are very accurate.
For example:

Clark James wrote:

for(int i = 0; i < Count; i++)  //set up a for loop that will iterate from 0 to count -1

This comment is overloaded of useless information, wouldn't be clearer like:

// for loop will iterate "Count" times

[edit]I just realized now, probably you were thinking about array indexes, in this context, maybe that comment is not so bad[edit]