Five Card Draw Poker Game Registering 6+ cards

[joseph Anderson]

So this wednesday I decided to make a poker game since I thought I knew everything I needed to make to make it. then I ran into the attached error. The first place where it says "your new hand is" should say your cards from 2 to ace. but if you look at the numbers there are two tens. The following code is whats responsible for changing these numbers. Sorry for the messy code. also sorry it is so long, but it is divided into 5 almost identical parts. I just dont understand why this is occuring. it should subtract whatever it adds.

 if (heldCard[0] == 1) //if card is not held
{
do
{
markerHand = firstHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 -= 1; System.out.println("case subtract 2 has been removed"); break; //scorekeeper variables
case 3: card3 -= 1; System.out.println("case subtract 3 has been removed"); break;
case 4: card4 -= 1; System.out.println("case subtract 4 has been removed"); break;
case 5: card5 -= 1; System.out.println("case subtract 5 has been removed"); break;
case 6: card6 -= 1; System.out.println("case subtract 6 has been removed"); break;
case 7: card7 -= 1; System.out.println("case subtract 7 has been removed"); break;
case 8: card8 -= 1; System.out.println("case subtract 8 has been removed"); break;
case 9: card9 -= 1; System.out.println("case subtract 9 has been removed"); break;
case 10: card10 -= 1; System.out.println("case subtract 10 has been removed"); break;
case 11: cardJ -= 1; System.out.println("case subtract J has been removed"); break;
case 12: cardQ -= 1; System.out.println("case subtract Q has been removed"); break;
case 13: cardK -= 1; System.out.println("case subtract K has been removed"); break;
case 14: cardA -= 1; System.out.println("case subtract A has been removed"); break;
}
if(firstHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(firstHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(firstHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}
random = (int)(Math.random() * 52);
firstHand = (int)random;
markerHand = firstHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 += 1; break; //scorekeeper variables
case 3: card3 += 1; break;
case 4: card4 += 1; break;
case 5: card5 += 1; break;
case 6: card6 += 1; break;
case 7: card7 += 1; break;
case 8: card8 += 1; break;
case 9: card9 += 1; break;
case 10: card10 += 1; break;
case 11: cardJ += 1; break;
case 12: cardQ += 1; break;
case 13: cardK += 1; break;
case 14: cardA += 1; break;
}
if(firstHand < 13) //if hearts
{
hearts += 1;
}
else
{
if(firstHand < 26) //if diamonds
{
diamonds += 1;
}
else
{
if(firstHand < 39) //if clubs
{
clubs += 1;
}
else
{
spades += 1;
}
}
}
} while (cardDrawn[firstHand] == 0);
cardDrawn[firstHand] = 0;
}
if (heldCard[1] == 1)
{
do
{
markerHand = secondHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 -= 1; System.out.println("case subtract 2 has been removed"); break; //scorekeeper variables
case 3: card3 -= 1; System.out.println("case subtract 3 has been removed"); break;
case 4: card4 -= 1; System.out.println("case subtract 4 has been removed"); break;
case 5: card5 -= 1; System.out.println("case subtract 5 has been removed"); break;
case 6: card6 -= 1; System.out.println("case subtract 6 has been removed"); break;
case 7: card7 -= 1; System.out.println("case subtract 7 has been removed"); break;
case 8: card8 -= 1; System.out.println("case subtract 8 has been removed"); break;
case 9: card9 -= 1; System.out.println("case subtract 9 has been removed"); break;
case 10: card10 -= 1; System.out.println("case subtract 10 has been removed"); break;
case 11: cardJ -= 1; System.out.println("case subtract J has been removed"); break;
case 12: cardQ -= 1; System.out.println("case subtract Q has been removed"); break;
case 13: cardK -= 1; System.out.println("case subtract K has been removed"); break;
case 14: cardA -= 1; System.out.println("case subtract A has been removed"); break;
}
if(secondHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(secondHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(secondHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}
random = (int)(Math.random() * 52);
secondHand = (int)random;
markerHand = secondHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 += 1; break; //scorekeeper variables
case 3: card3 += 1; break;
case 4: card4 += 1; break;
case 5: card5 += 1; break;
case 6: card6 += 1; break;
case 7: card7 += 1; break;
case 8: card8 += 1; break;
case 9: card9 += 1; break;
case 10: card10 += 1; break;
case 11: cardJ += 1; break;
case 12: cardQ += 1; break;
case 13: cardK += 1; break;
case 14: cardA += 1; break;
}
if(secondHand < 13) //if hearts
{
hearts += 1;
}
else
{
if(secondHand < 26) //if diamonds
{
diamonds += 1;
}
else
{
if(secondHand < 39) //if clubs
{
clubs += 1;
}
else
{
spades += 1;
}
}
}
} while (cardDrawn[secondHand] == 0);
cardDrawn[secondHand] = 0;
}
if (heldCard[2] == 1)
{
do
{
markerHand = thirdHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 -= 1; System.out.println("case subtract 2 has been removed"); break; //scorekeeper variables
case 3: card3 -= 1; System.out.println("case subtract 3 has been removed"); break;
case 4: card4 -= 1; System.out.println("case subtract 4 has been removed"); break;
case 5: card5 -= 1; System.out.println("case subtract 5 has been removed"); break;
case 6: card6 -= 1; System.out.println("case subtract 6 has been removed"); break;
case 7: card7 -= 1; System.out.println("case subtract 7 has been removed"); break;
case 8: card8 -= 1; System.out.println("case subtract 8 has been removed"); break;
case 9: card9 -= 1; System.out.println("case subtract 9 has been removed"); break;
case 10: card10 -= 1; System.out.println("case subtract 10 has been removed"); break;
case 11: cardJ -= 1; System.out.println("case subtract J has been removed"); break;
case 12: cardQ -= 1; System.out.println("case subtract Q has been removed"); break;
case 13: cardK -= 1; System.out.println("case subtract K has been removed"); break;
case 14: cardA -= 1; System.out.println("case subtract A has been removed"); break;
}
if(thirdHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(thirdHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(thirdHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}
random = (int)(Math.random() * 52);
thirdHand = (int)random;
markerHand = thirdHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 += 1; break; //scorekeeper variables
case 3: card3 += 1; break;
case 4: card4 += 1; break;
case 5: card5 += 1; break;
case 6: card6 += 1; break;
case 7: card7 += 1; break;
case 8: card8 += 1; break;
case 9: card9 += 1; break;
case 10: card10 += 1; break;
case 11: cardJ += 1; break;
case 12: cardQ += 1; break;
case 13: cardK += 1; break;
case 14: cardA += 1; break;
}
if(thirdHand < 13) //if hearts
{
hearts += 1;
}
else
{
if(thirdHand < 26) //if diamonds
{
diamonds += 1;
}
else
{
if(thirdHand < 39) //if clubs
{
clubs += 1;
}
else
{
spades += 1;
}
}
}
} while (cardDrawn[thirdHand] == 0);
cardDrawn[thirdHand] = 0;
}
if (heldCard[3] == 1)
{
do
{
markerHand = fourthHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 -= 1; System.out.println("case subtract 2 has been removed"); break; //scorekeeper variables
case 3: card3 -= 1; System.out.println("case subtract 3 has been removed"); break;
case 4: card4 -= 1; System.out.println("case subtract 4 has been removed"); break;
case 5: card5 -= 1; System.out.println("case subtract 5 has been removed"); break;
case 6: card6 -= 1; System.out.println("case subtract 6 has been removed"); break;
case 7: card7 -= 1; System.out.println("case subtract 7 has been removed"); break;
case 8: card8 -= 1; System.out.println("case subtract 8 has been removed"); break;
case 9: card9 -= 1; System.out.println("case subtract 9 has been removed"); break;
case 10: card10 -= 1; System.out.println("case subtract 10 has been removed"); break;
case 11: cardJ -= 1; System.out.println("case subtract J has been removed"); break;
case 12: cardQ -= 1; System.out.println("case subtract Q has been removed"); break;
case 13: cardK -= 1; System.out.println("case subtract K has been removed"); break;
case 14: cardA -= 1; System.out.println("case subtract A has been removed"); break;
}
if(fourthHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(fourthHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(fourthHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}
random = (int)(Math.random() * 52);
fourthHand = (int)random;
markerHand = fourthHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 += 1; break; //scorekeeper variables
case 3: card3 += 1; break;
case 4: card4 += 1; break;
case 5: card5 += 1; break;
case 6: card6 += 1; break;
case 7: card7 += 1; break;
case 8: card8 += 1; break;
case 9: card9 += 1; break;
case 10: card10 += 1; break;
case 11: cardJ += 1; break;
case 12: cardQ += 1; break;
case 13: cardK += 1; break;
case 14: cardA += 1; break;
}
if(fourthHand < 13) //if hearts
{
hearts += 1;
}
else
{
if(fourthHand < 26) //if diamonds
{
diamonds += 1;
}
else
{
if(fourthHand < 39) //if clubs
{
clubs += 1;
}
else
{
spades += 1;
}
}
}
} while (cardDrawn[fourthHand] == 0);
cardDrawn[fourthHand] = 0;
}
if (heldCard[4] == 1)
{
do
{
markerHand = fifthHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 -= 1; System.out.println("case subtract 2 has been removed"); break; //scorekeeper variables
case 3: card3 -= 1; System.out.println("case subtract 3 has been removed"); break;
case 4: card4 -= 1; System.out.println("case subtract 4 has been removed"); break;
case 5: card5 -= 1; System.out.println("case subtract 5 has been removed"); break;
case 6: card6 -= 1; System.out.println("case subtract 6 has been removed"); break;
case 7: card7 -= 1; System.out.println("case subtract 7 has been removed"); break;
case 8: card8 -= 1; System.out.println("case subtract 8 has been removed"); break;
case 9: card9 -= 1; System.out.println("case subtract 9 has been removed"); break;
case 10: card10 -= 1; System.out.println("case subtract 10 has been removed"); break;
case 11: cardJ -= 1; System.out.println("case subtract J has been removed"); break;
case 12: cardQ -= 1; System.out.println("case subtract Q has been removed"); break;
case 13: cardK -= 1; System.out.println("case subtract K has been removed"); break;
case 14: cardA -= 1; System.out.println("case subtract A has been removed"); break;
}
if(fifthHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(fifthHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(fifthHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}
random = (int)(Math.random() * 52);
fifthHand = (int)random;
markerHand = fifthHand;
while (markerHand >= 13)
{
markerHand -= 13;
}
markerHand += 2;
switch(markerHand)
{
case 2: card2 += 1; break; //scorekeeper variables
case 3: card3 += 1; break;
case 4: card4 += 1; break;
case 5: card5 += 1; break;
case 6: card6 += 1; break;
case 7: card7 += 1; break;
case 8: card8 += 1; break;
case 9: card9 += 1; break;
case 10: card10 += 1; break;
case 11: cardJ += 1; break;
case 12: cardQ += 1; break;
case 13: cardK += 1; break;
case 14: cardA += 1; break;
}
if(fifthHand < 13) //if hearts
{
hearts += 1;
}
else
{
if(fifthHand < 26) //if diamonds
{
diamonds += 1;
}
else
{
if(fifthHand < 39) //if clubs
{
clubs += 1;
}
else
{
spades += 1;
}
}
}
} while (cardDrawn[fifthHand] == 0);
cardDrawn[fifthHand] = 0;
}

[Knute Snortum]

It's very hard to read your code, especially when the first thing is an uninitialized variable. Is this all in one method? Break it out into smaller methods. Also, repeated code should be put in a method and called. Just doing this is going to make your code easier to debug.

[Campbell Ritchie]

And get rid of those switch blocks. They can probably be replaced by the appropriate data structure.

[joseph Anderson]

yeah really sorry about how hard it is to read. I was just trying to get it done and didn't separate it into different methods, this is approximately lines 500 to 1000 out of 1200 in my program, its technically not repeated each repeat is checking a different variable. but this is the only block where the card counters are decreased and before the program run that I went through with the picture I've never had any added just had problems with keeping cards from previous hand so I figured the problem was probably here. all variables have been initialized. and I realize that the error would be next to impossible to find. but I'm thinking it is almost definitely a logical error. If you want I can upload the whole problem, but I figured even 500 lines of code is stretching what is reasonable.

edit: oh and the reason I am using switch statements is they are easy to use. also why not use them. If they serve the purpose they were meant for and are easy to read it does its job.

[Campbell Ritchie]

 

joseph Anderson wrote: . . . its technically not repeated each repeat is checking a different variable. . . .

No, that is repeated code which you are pretending is different on each occasion

. . . switch statements . . . are easy to use. . . . they serve the purpose they were meant for and are easy to read it does its job.

Are you trying to tell us those blocks are easy to read? Each consists of 14 13 repeated lines, and squeezing the code together into single lines makes it more difficult to read.

[fred rosenberger]

This is repeated code, even if you do use a different variable:

if(fourthHand < 13) //if hearts
{
hearts -= 1;
}
else
{
if(fourthHand < 26) //if diamonds
{
diamonds -= 1;
}
else
{
if(fourthHand < 39) //if clubs
{
clubs -= 1;
}
else
{
spades -= 1;
}
}
}

it should be put into a method where you pass in your four variables one after another (hmmm...maybe that suggests a loop)

[joseph Anderson]

Yeah, I just went over it with my brother, and when I told him that I only used one method/class he said "how did you even do that", he was kinda surprised at the lack of methods and thought it could be condensed to about a third the total volume. He did however give me an idea for how to solve the issue, though it will take several hundred lines of code which I don't feel like putting in right now. instead of reducing as I am putting the cards into the deck do the card scoring right before the hand scoring.

I appreciate your help. And will put this as solved.