Having issues with calling a Sorting Method & creating a method to total the inventory value

[Amie Mac]

Good Afternoon,

I am now working on the Inventory Part 2 program for my Java Programming class.
I am having issues and I am hoping to get help/guidance here.

The instructions are:
/**
* Modify the Inventory Program so the application can handle multiple items. Use an array to store the items.
* The output should display the information one product at a time, including the item number, the name of the product,
* the number of units in stock, the price of each unit, and the value of the inventory of that product.
* In addition, the output should display the value of the entire inventory.
*
* Create a method to calculate the value of the entire inventory.
* Create another method to sort the array items by the name of the product.
*/

I have the sorting method in the Inventory class (which was given by the instructor) but I can't figure out how to call it from the InventoryLauncher. I also need to create a method in the Inventory class that is called from the InventoryLauncher that adds together the inventoryValues for each inventory item. I am not sure how to do this since the array is in the InventoryLauncher and the value that needs to be added is one of the elements(?) in the array.

I hope this makes sense... I've been working on this all day and getting frustrated that I don't understand this...

Here is my code... Thanks in advance for any assistance.

Inventory.java

public class Inventory
{
	// variables
	private String itemName;
	private double itemPrice,
				          itemNumber,
				          itemStock,
				          inventoryValue;

  public Inventory ()
  {}; //empty constructor
  
	public Inventory( double itemNumber, String itemName, double itemStock, double itemPrice )
	{
		this.itemNumber = itemNumber;
		this.itemName = itemName;
		this.itemStock = itemStock;
		this.itemPrice = itemPrice;
	} // end constructor

  //---------------SET and GET METHODS --------------------
	public void setItemName(String itemName)
	{
		this.itemName = itemName;
	} //end setItemName

	public String getItemName()
	{
		return this.itemName;
	} // end getItemName

  
	public void setItemNumber(double itemNumber)
	{
		this.itemNumber = itemNumber;
	}//end setItemNmber

	public double getItemNumber()
	{
		return this.itemNumber;
	} // end getItemNumber


	public void setItemStock(double itemStock)
	{
		this.itemStock = itemStock;
	}//end setItemStock

	public double getItemStock()
	{
		return this.itemStock;
	} // end getItemStock


	public void setItemPrice(double itemPrice)
	{
		this.itemPrice = itemPrice;
	} // end setItemPrice

	public double getItemPrice()
	{
		return this.itemPrice;
	} // end getItemPrice

  
  //----------Calculate Inventory Value for each Item----------------
	public double inventoryValue()
	{
		inventoryValue = itemStock * itemPrice;
		return inventoryValue;
	} // end inventoryValue
  
  
  //----------Sort Inventory Method------------------------
	public Inventory[] Sortinventory(Inventory[] theinventory)
	{
		Inventory tmp;
			for(int index = 0; index < theinventory.length; index++)
			{
				for(int anotherindex = index + 1; anotherindex < theinventory.length; anotherindex++)
				{
					String s1 = theinventory[index].getItemName();
					String s2 = theinventory[anotherindex].getItemName();
					if(s1.compareTo(s2) > 0)
					{
						tmp = theinventory[index];
						theinventory[index] = theinventory[anotherindex];
						theinventory[anotherindex] = tmp;
					}
				}
			}
			return theinventory;
	}
  
  //------------Calculate Total Inventory Value---------------------
    //>>>>>>>need to add together the inventoryValue of each item in the Books array


  
} // end class Inventory

InventoryLauncher.java

public class InventoryLauncher
{
	//main method launches Java application
	public static void main(String[] args)
	{	
    //create instance of Inventory class
    Inventory inventory = new Inventory();
    
		// construct an array of books
		Inventory[] Books = new Inventory[3];

		//populate the array of books
		Books[0] = new Inventory(1, "\"Java: A Beginner's Guide\"", 10, 22.32);
		Books[1] = new Inventory(2, "\"Head First Java, 2nd Edition\"", 7, 26.97);
		Books[2] = new Inventory(3, "\"Java: The Complete Reference\"", 5, 39.20);

    
		// display program title
		System.out.printf("Welcome to the Inventory Program%n%n");

       
    // display Book Inventory
    System.out.printf("Book Inventory%n");
    for(int counter = 0; counter < Books.length; counter++)
      {
      System.out.printf("%nItem Number:     %03.0f%nItem Name:       %s%nNumber in Stock: %.0f%nPrice:           $%.2f%nTotal Cost:      $%.2f%n",
			Books[counter].getItemNumber(), Books[counter].getItemName(), Books[counter].getItemStock(), Books[counter].getItemPrice(), Books[counter].inventoryValue());
     	}
		  System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator
    
    //call sort method from inventory and display sorted inventory
    //>>>>>>>need to figure out how to call the sort method from the inventory class
    System.out.printf("Sorted Book Inventory%n");
    for(int counter = 0; counter < Books.length; counter++)
      {
      System.out.printf("%nItem Number:     %03.0f%nItem Name:       %s%nNumber in Stock: %.0f%nPrice:           $%.2f%nTotal Cost:      $%.2f%n",
			Books[counter].getItemNumber(), Books[counter].getItemName(), Books[counter].getItemStock(), Books[counter].getItemPrice(), Books[counter].inventoryValue());
     	}
      System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator
    
    
    //call total value of inventory method
      //>>>>>>>need to create a method for this in Inventory and call it here
   
    
	} // end main method
} // end class InventoryLauncher

[Carey Brown]

Inventory - line 6 - itemNumber should be an integer not a double.
Inventory - line 8 - not necessary. inventoryValue is calculated on the fly.
Launcher - Line 7 - not necessary.
Launcher - Line 10 - should be "books" with a lower case 'b'. This is the Java convention.
Inventory - line 75 - probably should have been declared 'static'. Returning 'Inventory[]' seems pointless as the sorting is done in-place and will modify the content of 'theinventory'.
Inventory - line 26 & 36 - could have been implemented as a toString() method in Inventory and then called here with System.out.println( Books[counter] );
Calling sort at line 32 just involves calling the Sortinventory() (again, should start with lower case) method. If you change the method to static then you need the class name, dot (.), method name. You'll have to pass in your array of Inventory as an argument. You could assign the return value back to your 'Books' variable, but as I mentioned, that doesn't really do anything given the way the sort was written.

Edit:
'itemStock' should probably be an integer also.

[Amie Mac]

Carey Brown wrote:Inventory - line 6 - itemNumber should be an integer not a double.
Inventory - line 8 - not necessary. inventoryValue is calculated on the fly.
Launcher - Line 7 - not necessary.
Launcher - Line 10 - should be "books" with a lower case 'b'. This is the Java convention.
Inventory - line 75 - probably should have been declared 'static'. Returning 'Inventory[]' seems pointless as the sorting is done in-place and will modify the content of 'theinventory'.
Inventory - line 26 & 36 - could have been implemented as a toString() method in Inventory and then called here with System.out.println( Books[counter] );
Calling sort at line 32 just involves calling the Sortinventory() (again, should start with lower case) method. If you change the method to static then you need the class name, dot (.), method name. You'll have to pass in your array of Inventory as an argument. You could assign the return value back to your 'Books' variable, but as I mentioned, that doesn't really do anything given the way the sort was written.

Edit:
'itemStock' should probably be an integer also.

Thank you for the suggestions. I will give these a go and see how it goes.

[Amie Mac]

Carey Brown wrote:Inventory - line 6 - itemNumber should be an integer not a double.
Inventory - line 8 - not necessary. inventoryValue is calculated on the fly.
Launcher - Line 7 - not necessary.
Launcher - Line 10 - should be "books" with a lower case 'b'. This is the Java convention.
Inventory - line 75 - probably should have been declared 'static'. Returning 'Inventory[]' seems pointless as the sorting is done in-place and will modify the content of 'theinventory'.
Inventory - line 26 & 36 - could have been implemented as a toString() method in Inventory and then called here with System.out.println( Books[counter] );
Calling sort at line 32 just involves calling the Sortinventory() (again, should start with lower case) method. If you change the method to static then you need the class name, dot (.), method name. You'll have to pass in your array of Inventory as an argument. You could assign the return value back to your 'Books' variable, but as I mentioned, that doesn't really do anything given the way the sort was written.

Edit:
'itemStock' should probably be an integer also.

OK.

First thing I did was take out inventoryValue from my variables and tried to compile it and got the below errors. You stated it wasn't necessary because it's created on the fly. What do you mean that it's created on the fly?

C:\Users\Amie\Documents\IT215JavaProgramming\Week6\InventoryPart2_v2\Inventory.java:80: error: cannot find symbol
inventoryValue = itemStock * itemPrice;
^
symbol: variable inventoryValue
location: class Inventory
C:\Users\Amie\Documents\IT215JavaProgramming\Week6\InventoryPart2_v2\Inventory.java:81: error: cannot find symbol
return inventoryValue;
^
symbol: variable inventoryValue
location: class Inventory
2 errors

[Amie Mac]

Carey Brown wrote:Inventory - line 6 - itemNumber should be an integer not a double.
Inventory - line 8 - not necessary. inventoryValue is calculated on the fly.
Launcher - Line 7 - not necessary.
Launcher - Line 10 - should be "books" with a lower case 'b'. This is the Java convention.
Inventory - line 75 - probably should have been declared 'static'. Returning 'Inventory[]' seems pointless as the sorting is done in-place and will modify the content of 'theinventory'.
Inventory - line 26 & 36 - could have been implemented as a toString() method in Inventory and then called here with System.out.println( Books[counter] );
Calling sort at line 32 just involves calling the Sortinventory() (again, should start with lower case) method. If you change the method to static then you need the class name, dot (.), method name. You'll have to pass in your array of Inventory as an argument. You could assign the return value back to your 'Books' variable, but as I mentioned, that doesn't really do anything given the way the sort was written.

Edit:
'itemStock' should probably be an integer also.

Second question I have is if I change itemNumber and itemStock to integers in my variables, do I also need to change them to integers through the rest of the code? such as in the constructor? I would assume yes.

[Amie Mac]

Second question I have is if I change itemNumber and itemStock to integers in my variables, do I also need to change them to integers through the rest of the code? such as in the constructor? I would assume yes.

Nevermind on this one. I changed them all to integers from doubles and the code runs fine. Thanks

Still working on the other suggestions...

[Carey Brown]

Inventory - line 70 - just return stock * price. Don't store it.

[Carey Brown]

Amie Mac wrote:I changed them all to integers from doubles and the code runs fine.

Because monetary values usually contain a decimal portion, I would leave price as a double. You will have to make allowance for the fact that an integer multiplied by a double yields a double.

[Amie Mac]

Carey Brown wrote:Inventory - line 70 - just return stock * price. Don't store it.

Thanks. Got it.


So I made all the changes that you recommended, but I am still having issues with calculating the total inventory value. I have put some code in place, but it's not working. I think I am missing some sort of for loop... but I am not sure how to go about getting each inventoryValue out of the populated arrays to add them together.

Here is my updated code (with the messed up totalInventoryValue()

Inventory.java

public class Inventory
{
	// variables
	private String itemName;
	private double itemPrice;
	private int itemNumber,
				itemStock;


	public Inventory( int itemNumber, String itemName, int itemStock, double itemPrice )
	{
		this.itemNumber = itemNumber;
		this.itemName = itemName;
		this.itemStock = itemStock;
		this.itemPrice = itemPrice;
	} // end constructor

  //---------------SET and GET METHODS --------------------
	public void setItemName(String itemName)
	{
		this.itemName = itemName;
	} //end setItemName

	public String getItemName()
	{
		return this.itemName;
	} // end getItemName


	public void setItemNumber(int itemNumber)
	{
		this.itemNumber = itemNumber;
	}//end setItemNmber

	public double getItemNumber()
	{
		return this.itemNumber;
	} // end getItemNumber


	public void setItemStock(int itemStock)
	{
		this.itemStock = itemStock;
	}//end setItemStock

	public double getItemStock()
	{
		return this.itemStock;
	} // end getItemStock


	public void setItemPrice(double itemPrice)
	{
		this.itemPrice = itemPrice;
	} // end setItemPrice

	public double getItemPrice()
	{
		return this.itemPrice;
	} // end getItemPrice


  //----------Calculate Inventory Value for each Item----------------
	public double inventoryValue()
	{
		//inventoryValue = itemStock * itemPrice;
		return itemStock * itemPrice;
	} // end inventoryValue


  //----------Sort Inventory Method------------------------
	public static Inventory[] sortInventory(Inventory[] theInventory)
	{
		Inventory tmp;
			for(int index = 0; index < theInventory.length; index++)
			{
				for(int anotherIndex = index + 1; anotherIndex < theInventory.length; anotherIndex++)
				{
					String s1 = theInventory[index].getItemName();
					String s2 = theInventory[anotherIndex].getItemName();
					if(s1.compareTo(s2) > 0)
					{
						tmp = theInventory[index];
						theInventory[index] = theInventory[anotherIndex];
						theInventory[anotherIndex] = tmp;
					}
				}
			}
			return theInventory;
	}

  // ----------convert to String----------
   public String toString()
   {
		return String.format("%nItem Number:     %03.0f%nItem Name:       %s%nNumber in Stock: %.0f%nPrice:           $%.2f%nTotal Cost:      $%.2f%n",
			getItemNumber(), getItemName(), getItemStock(), getItemPrice(), inventoryValue());
   } // end method toString


  //------------Calculate Total Inventory Value---------------------
    //>>>>>>>need to add together the inventoryValue of each item in the Books array
  public double totalInventoryValue()
  {
	double totalInventoryValue = 0;

	return totalInventoryValue;
  } // end totalInventoryValue


} // end class Inventory

InventoryLauncher.java

public class InventoryLauncher
{
	//main method launches Java application
	public static void main(String[] args)
	{
    	// construct an array of books
		Inventory[] books = new Inventory[3];

		// populate the array of books
		books[0] = new Inventory(1, "\"Java: A Beginner's Guide\"", 10, 22.32);
		books[1] = new Inventory(2, "\"Head First Java, 2nd Edition\"", 7, 26.97);
		books[2] = new Inventory(3, "\"Java: The Complete Reference\"", 5, 39.20);


		// display program title
		System.out.printf("Welcome to the Inventory Program%n%n");


    	// display Book Inventory
    	System.out.printf("Book Inventory%n");
    		for(int counter = 0; counter < books.length; counter++)
      		{
      			System.out.println(books[counter]);
      		}
		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator

    	//call sort method from inventory and display sorted inventory
    	books[0].sortInventory(books);
    		System.out.printf("Sorted Book Inventory%n");
    			for(int counter = 0; counter < books.length; counter++)
      			{
      				System.out.println(books[counter]);
      			}
      		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator


    //call total value of inventory method
      //>>>>>>>need to create a method for this in Inventory and call it here
	books[0].totalIventoryValue();
		System.out.printf("Total Inventory Value%n");
			for(int counter = 0; counter < books.length; counter++)
		    {
		     System.out.println(books[counter]);
      		}

	} // end main method
} // end class InventoryLauncher

[Amie Mac]

Carey Brown wrote:

Amie Mac wrote:I changed them all to integers from doubles and the code runs fine.

Because monetary values usually contain a decimal portion, I would leave price as a double. You will have to make allowance for the fact that an integer multiplied by a double yields a double.

Oh... yep. I kept that as a double.
Thanks

[Carey Brown]

Your getItemStock() method returns a double; what should it return? Ditto for getItemNumber().
Inventory - line 95 - you are using %f in some places where you have an integer value.
Line 28 - you changed the sort method to be declared 'static', therefore to call it you shouldn't use an Inventory object (ie books[0]), instead use Inventory.sortInventory().
Line 102 - you need to pass in an Inventory[]. The Inventory class knows nothing about your array unless you pass it in. As you guessed, you'll need a loop to go through the array to sum up the inventory values.

[Carey Brown]

For loop at line 41 no longer necessary, just use the value returned from totalInventoryValue().

[Amie Mac]

Carey Brown wrote:Your getItemStock() method returns a double; what should it return? Ditto for getItemNumber().
Inventory - line 95 - you are using %f in some places where you have an integer value.
Line 28 - you changed the sort method to be declared 'static', therefore to call it you shouldn't use an Inventory object (ie books[0]), instead use Inventory.sortInventory().
Line 102 - you need to pass in an Inventory[]. The Inventory class knows nothing about your array unless you pass it in. As you guessed, you'll need a loop to go through the array to sum up the inventory values.

- Changed the return values to int
- changed the %f to %i
Once I did this ^ then I was getting runtime illegal format conversion errors - changed them all back to doubles. Edit: I am not sure how the printf would get formatted with the ints instead of doubles.
- calling the sort method with Inventory.sortInventory()

- still working on the total inventory value method. will that method look like the sort method with the Inventory[]?

[Carey Brown]

Amie Mac wrote:

Carey Brown wrote:Your getItemStock() method returns a double; what should it return? Ditto for getItemNumber().
Inventory - line 95 - you are using %f in some places where you have an integer value.
Line 28 - you changed the sort method to be declared 'static', therefore to call it you shouldn't use an Inventory object (ie books[0]), instead use Inventory.sortInventory().
Line 102 - you need to pass in an Inventory[]. The Inventory class knows nothing about your array unless you pass it in. As you guessed, you'll need a loop to go through the array to sum up the inventory values.

- Changed the return values to int
- changed the %f to %i
Once I did this ^ then I was getting runtime illegal format conversion errors - changed them all back to doubles.
- calling the sort method with Inventory.sortInventory()

- still working on the total inventory value method. will that method look like the sort method with the Inventory[]?

Integers are formatted with %d.
Inventory.sortInventory(books);
will that method look like the sort method with the Inventory[]? -- yes

[Amie Mac]

Carey Brown wrote:

Amie Mac wrote:

Carey Brown wrote:Your getItemStock() method returns a double; what should it return? Ditto for getItemNumber().
Inventory - line 95 - you are using %f in some places where you have an integer value.
Line 28 - you changed the sort method to be declared 'static', therefore to call it you shouldn't use an Inventory object (ie books[0]), instead use Inventory.sortInventory().
Line 102 - you need to pass in an Inventory[]. The Inventory class knows nothing about your array unless you pass it in. As you guessed, you'll need a loop to go through the array to sum up the inventory values.

- Changed the return values to int
- changed the %f to %i
Once I did this ^ then I was getting runtime illegal format conversion errors - changed them all back to doubles.
- calling the sort method with Inventory.sortInventory()

- still working on the total inventory value method. will that method look like the sort method with the Inventory[]?

Integers are formatted with %d.
Inventory.sortInventory(books);
will that method look like the sort method with the Inventory[]? -- yes

Thanks for all the help! I will implement these changes and work on the total inventory value method more tomorrow. For now, I am very tired and need some sleep.

And, yes, I had: Inventory.sortInventory(books); I just forgot to type the books in there.

[Carey Brown]

Good night )

[Amie Mac]

Ugh... I feel like I am very close... am I just missing a string conversion? Like a String toString()? If so, I am not sure how are where to put this for the output on the Total Inventory Value.

In the output I get:
Total Inventory Value: [LInventory;@5f048099

Here is my updated code:
Inventory.java

public class Inventory
{
	// variables
	private String itemName;
	private double itemPrice;
	private int	itemNumber,
				itemStock;


	public Inventory( int itemNumber, String itemName, int itemStock, double itemPrice )
	{
		this.itemNumber = itemNumber;
		this.itemName = itemName;
		this.itemStock = itemStock;
		this.itemPrice = itemPrice;
	} // end constructor

  //---------------SET and GET METHODS --------------------
	public void setItemName(String itemName)
	{
		this.itemName = itemName;
	} //end setItemName

	public String getItemName()
	{
		return this.itemName;
	} // end getItemName


	public void setItemNumber(int itemNumber)
	{
		this.itemNumber = itemNumber;
	}//end setItemNmber

	public int getItemNumber()
	{
		return this.itemNumber;
	} // end getItemNumber


	public void setItemStock(int itemStock)
	{
		this.itemStock = itemStock;
	}//end setItemStock

	public int getItemStock()
	{
		return this.itemStock;
	} // end getItemStock


	public void setItemPrice(double itemPrice)
	{
		this.itemPrice = itemPrice;
	} // end setItemPrice

	public double getItemPrice()
	{
		return this.itemPrice;
	} // end getItemPrice


  //----------Calculate Inventory Value for each Item----------------
	public double inventoryValue()
	{
		return itemStock * itemPrice;
	} // end inventoryValue


  //----------Sort Inventory Method------------------------
	public static Inventory[] sortInventory(Inventory[] theInventory)
	{
		Inventory tmp;
			for (int index = 0; index < theInventory.length; index++)
			{
				for (int anotherIndex = index + 1; anotherIndex < theInventory.length; anotherIndex++)
				{
					String s1 = theInventory[index].getItemName();
					String s2 = theInventory[anotherIndex].getItemName();
					if (s1.compareTo(s2) > 0)
					{
						tmp = theInventory[index];
						theInventory[index] = theInventory[anotherIndex];
						theInventory[anotherIndex] = tmp;
					}
				}
			}
			return theInventory;
	}

  // ----------convert to String----------
   public String toString()
   {
		return String.format("%nItem Number:     %d%nItem Name:       %s%nNumber in Stock: %d%nPrice:           $%.2f%nTotal Cost:      $%.2f%n",
			getItemNumber(), getItemName(), getItemStock(), getItemPrice(), inventoryValue());
   } // end method toString


  //------------Calculate Total Inventory Value---------------------
    //>>>>>>>need to add together the inventoryValue of each item in the Books array
   public static Inventory[] totalInventoryValue(Inventory[] theInventory)
   {
	  double total = 0;
     for (int i =0; i < theInventory.length; i++)
      total += theInventory[i].getItemPrice();	  
     System.out.println("Total Inventory Value: " + theInventory);
     return theInventory;
   } // end totalInventoryValue
  
} // end class Inventory

InventoryLauncher.java

public class InventoryLauncher
{
	//main method launches Java application
	public static void main(String[] args)
	{
    	// construct an array of books
		Inventory[] books = new Inventory[3];

		// populate the array of books
		books[0] = new Inventory(100, "\"Java: A Beginner's Guide\"", 10, 22.32);
		books[1] = new Inventory(200, "\"Head First Java, 2nd Edition\"", 7, 26.97);
		books[2] = new Inventory(300, "\"Java: The Complete Reference\"", 5, 39.20);


		// display program title
		System.out.printf("Welcome to the Inventory Program%n%n");


    	// display Book Inventory
    	System.out.printf("Book Inventory%n");
    		for (int counter = 0; counter < books.length; counter++)
      		{
      			System.out.println(books[counter]);
      		}
		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator

    	//call sort method from inventory and display sorted inventory
    	Inventory.sortInventory(books);
    		System.out.printf("Sorted Book Inventory%n");
    			for (int counter = 0; counter < books.length; counter++)
      			{
      				System.out.println(books[counter]);
      			}
      		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator


      //call total value of inventory method
      Inventory.totalInventoryValue(books);

	} // end main method
} // end class InventoryLauncher

[Carey Brown]

Change

        Inventory.sortInventory(books);
            System.out.printf("Sorted Book Inventory%n");

to

            System.out.printf("Sorted Book Inventory %f%n", Inventory.sortInventory(books));

And forget the loop in Launch.

[Carey Brown]

Carey Brown wrote:Change

        Inventory.sortInventory(books);
            System.out.printf("Sorted Book Inventory%n");

to

            System.out.printf("Sorted Book Inventory %f%n", Inventory.sortInventory(books));

And forget the loop in Launch.

SORRY, FORGET THAT.

[Carey Brown]

Replace
System.out.println("Total Inventory Value: " + theInventory);
With
System.out.println("Total Inventory Value: " + total );

[Amie Mac]

Carey Brown wrote:Replace
System.out.println("Total Inventory Value: " + theInventory);
With
System.out.println("Total Inventory Value: " + total );

YAY! It works!

I also found that I calculated the wrong value and had to replace getItemPrice() with inventoryValue()

Thanks so much for your assistance! It is greatly appreciated!

Now I get to move on to Inventory Program Part 3, which is also due on Sunday. I may be back on the Ranch for assistance with that one.