Forum:

Swing / AWT / SWT

JLabel - issues displaying the total Inventory value

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Howdy ~

I am working on my Inventory Program part 4, which is to add a GUI that displays all the inventory information. I have the GUI working, but the only thing that is not working is the Total value of books in stock JLabel. It is calling a method from the Inventory class and it displays on the GUI but is showing LBooks;@16c0663d. and it still displays the value in the console.

Do I need to create a for loop in the InventoryLauncher class instead? I am not supposed to edit the Book or Inventory classes at all. Just the InventoryLauncher.
We are to use JLabel with FlowLayout for the GUI.

Here's the code. Any help is appreciated.

InventoryLauncher.java

// InventoryLauncher.java
// CheckPoint: Inventory Program Part 4
import java.awt.*;

import javax.swing.*;

import java.text.DecimalFormat;

public class InventoryLauncher extends JFrame
{
	private JLabel label1;
    private JLabel label2;
    
    public InventoryLauncher()
	{
		DecimalFormat doubleFormat = new DecimalFormat( "0.00" );

//get content pane and set its layout
		Container container = getContentPane();
			container.setLayout(new FlowLayout());
    	//setLayout(new FlowLayout());
			
	    // construct an array of books
		Books[] books = new Books[3];

// populate the array of books
		books[0] = new Books(100, "\"Java: A Beginner's Guide\"", "Herbert Schildt", 10, 22.32);
		books[1] = new Books(200, "\"Head First Java, 2nd Edition\"", "Kathy Sierra", 7, 26.97);
		books[2] = new Books(300, "\"Java: The Complete Reference\"", "Herbert Schildt", 5, 39.20);
		
		label1 = new JLabel("<html>Non Sorted Book Inventory List</html>");
	 	container.add(label1);
			
	 	for (int counter = 0; counter < books.length; counter++)
			{
		 		String labelText = 
		 				"<html>Item Number : " + books[counter].getItemNumber() +
		 				" | Item Name: " + books[counter].getItemName() +
		 				" | Author: " + books[counter].getBookAuthor() +
		 				" | Number in Stock: " + books[counter].getItemStock() +
		 				" | Restocking Fee: " + doubleFormat.format(books[counter].restockingFee()) +
		 				" | Price: " + doubleFormat.format(books[counter].getItemPrice()) +
		 				" | Inventory Value: " + doubleFormat.format(books[counter].inventoryValue());
		 				JLabel textLabel = new JLabel(labelText, JLabel.LEFT);
		 					container.add(textLabel);
			}
			
		// call sort method from inventory class and display sorted inventory
	 Books.sortInventory(books);
 
	 label2 = new JLabel("<html>Sorted Book Inventory List</html>");
	 	container.add(label2);
	 	
	 	for (int counter = 0; counter < books.length; counter++)
 			{
	 		String labelText = 
	 		 		"<html>Item Number : " + books[counter].getItemNumber() +
	 	 " | Item Name: " + books[counter].getItemName() +
	 	 " | Author: " + books[counter].getBookAuthor() +
	 	 " | Number in Stock: " + books[counter].getItemStock() +
	 	 " | Restocking Fee: " + doubleFormat.format(books[counter].restockingFee()) +
	 	 " | Price: " + doubleFormat.format(books[counter].getItemPrice()) +
	 	 " | Inventory Value: " + doubleFormat.format(books[counter].inventoryValue());
	 	 JLabel textLabel = new JLabel(labelText, JLabel.CENTER);
	 	 	container.add(textLabel);
 			}
	 	 
	 	// call total value of inventory method from inventory class
 	 String labelText =
	 "<html> Total value of all books in stock: " + (Books.totalInventoryValue(books));
	 JLabel TotalValue = new JLabel(labelText, JLabel.CENTER);
	 container.add(TotalValue);
	 
	}
	//main method launches Java application
	public static void main(String[] args)
	{
		InventoryLauncher frame = new InventoryLauncher();
 frame.setTitle(" Book Inventory Program ");
 frame.setSize(1100, 300);
 frame.setLocationRelativeTo(null); // center frame
 frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
 	frame.setVisible(true);

/* Code before GUI
  * 
		// display program title
		System.out.printf("Welcome to the Inventory Program%n%n");

// display Book Inventory
 	System.out.printf("Book Inventory%n%n");
 		for (int counter = 0; counter < books.length; counter++)
 		{
 			System.out.println(books[counter]);
 		}
		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator

// call sort method from inventory class and display sorted inventory
 	Books.sortInventory(books);
 		System.out.printf("Sorted Book Inventory%n");
 			for (int counter = 0; counter < books.length; counter++)
 			{
 				System.out.println(books[counter]);
 			}
 		System.out.printf("%n------------------------------------------------%n"); // prints a dashed line for a separator

// call total value of inventory method from inventory class
      Books.totalInventoryValue(books);
      System.out.println(); //prints a blank line
*/
    	
	} // end main method
} // end class InventoryLauncher

Inventory.java

// Inventory.java
//CheckPoint: Inventory Program Part 4

public class Inventory
{
	// variables
	private String itemName;
	private double itemPrice;
	private int itemNumber,
					itemStock;

public Inventory(int itemNumber, String itemName, int itemStock, double itemPrice)
	{
		this.itemNumber = itemNumber;
		this.itemName = itemName;
		this.itemStock = itemStock;
		this.itemPrice = itemPrice;
	} // end constructor

//---------------SET and GET METHODS --------------------
	public void setItemName(String itemName)
	{
		this.itemName = itemName;
	} //end setItemName

public String getItemName()
	{
		return this.itemName;
	} // end getItemName

public void setItemNumber(int itemNumber)
	{
		this.itemNumber = itemNumber;
	}//end setItemNmber

public int getItemNumber()
	{
		return this.itemNumber;
	} // end getItemNumber

public void setItemStock(int itemStock)
	{
		this.itemStock = itemStock;
	}//end setItemStock

public int getItemStock()
	{
		return this.itemStock;
	} // end getItemStock

public void setItemPrice(double itemPrice)
	{
		this.itemPrice = itemPrice;
	} // end setItemPrice

public double getItemPrice()
	{
		return this.itemPrice;
	} // end getItemPrice

//----------Calculate Inventory Value for each Item-------------
	public double inventoryValue()
	{
		return itemStock * itemPrice;
	} // end inventoryValue

//-------------Sort Inventory Method---------------------------
	public static Inventory[] sortInventory(Inventory[] theInventory)
	{
		Inventory tmp;
			for (int index = 0; index < theInventory.length; index++)
			{
				for (int anotherIndex = index + 1; anotherIndex < theInventory.length; anotherIndex++)
				{
					String s1 = theInventory[index].getItemName();
					String s2 = theInventory[anotherIndex].getItemName();
					if (s1.compareTo(s2) > 0)
					{
						tmp = theInventory[index];
						theInventory[index] = theInventory[anotherIndex];
						theInventory[anotherIndex] = tmp;
					}
				}
			}
			return theInventory;
	}

// ----------convert to String-------------------------
   public String toString()
   {
		return String.format("%nItem Number:     %d%nItem Name:       %s%nNumber in Stock: %d%nPrice:           $%.2f%nTotal Cost:      $%.2f%n",
			getItemNumber(), getItemName(), getItemStock(), getItemPrice(), inventoryValue());
   } // end method toString

//----------Calculate Total Inventory Value--------------
 public static Inventory[] totalInventoryValue(Inventory[] theInventory)
 {
	 double total = 0;
 for (int i =0; i < theInventory.length; i++)
 	total += theInventory[i].inventoryValue();
 		System.out.println("Total Inventory Value: " + total);
 return theInventory;
 } // end totalInventoryValue

} // end class Inventory

Books.java

// Books.java
// CheckPoint: Inventory Program Part 4

public class Books extends Inventory
{
	// variables
	private String bookAuthor;
	private double restockingFee;

//books constructor
	public Books(int itemNumber, String itemName, String author, int itemStock, double itemPrice)
	{
		super(itemNumber, itemName, itemStock, itemPrice);
		setBookAuthor(author);
	}// end constructor

public void setBookAuthor(String author)
	{
		bookAuthor = author;
	} // end setBookAuthor

public String getBookAuthor()
	{
		return bookAuthor;
	} // end getBookAuthor

//----restocking fee---
	public double restockingFee()
	{
		restockingFee = super.getItemPrice() * .05;
		return restockingFee;
	} // end restockingFee

//------------Override inventoryValue to add Restocking Fee-----------------
	@Override
	public double inventoryValue()
	{
		return ((restockingFee + super.getItemPrice()) * super.getItemStock());
	} // end inventoryValue

// ----------Override convert to String-------------------------
	@Override
	public String toString()
	{
		return String.format("%nItem Number:     %d%nItem Name:       %s%nAuthor:          %s%nNumber in Stock: %d%nPrice:           $%.2f%nRestocking Fee:  $%.2f%nTotal Cost:      $%.2f%n",
			getItemNumber(), getItemName(), getBookAuthor(), getItemStock(), getItemPrice(), restockingFee(), inventoryValue());
   	} // end method toString

} // end class Books

Claude Moore

Bartender

Posts: 1381

I like...

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Method totalInventoryValue returns an array of inventory, not the sum over items. You assigned its retuned value to labelText variable, that's a string, so you get default object tostring() method output.

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Claude Moore wrote:Method totalInventoryValue returns an array of inventory, not the sum over items. You assigned its retuned value to labelText variable, that's a string, so you get default object tostring() method output.

Yes, I figured it was outputting the string format... but I am still unsure of how to fix it. I am new to java programming... and am trying to wrap my head around all these concepts...

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Use a Stream. Only works in Java8.

Start by creating a Stream; probably easiest with the static overloaded stream method of the Arrays class.

That returns an IntStream and IntStream has a sum() method.

int i = Arrays.stream(myIntArray).sum()

Java 8 (verified skill)
Skill verified by Jeanne Boyarsky

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

A few minutes ago, Stephan van Hulst wrote:… accept that arrays and collections are not compatible, and to avoid accommodating the use of arrays.

It was on this thread.
See if you can't change the array to a List<Integer>.

You would need the mapToInt() method to make sure the compiler knows you are dealing with Integers. The i -> i.intValue() bit is because you know you are dealing with Integers and you know they have an intValue() method. There are probably much neater ways to do that conversion.

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Campbell Ritchie wrote:Use a Stream. Only works in Java8.

Start by creating a Stream; probably easiest with the static overloaded stream method of the Arrays class.
That returns an IntStream and IntStream has a sum() method.

int i = Arrays.stream(myIntArray).sum()

hmmm... the textbook we have covers JavaSE7... I am not sure that this would be accepted by the instructor since it's not covered in the book???

Are there any other options with Java7? do I need to create a new method in the InventoryLauncher for the Total Inventory Value? Besides it printing to the console as well, why am I not able to use the method that I have in the Inventory class? Is there a way to convert it back to double from string? I tried to do this with the decimal format variable, but that didn't work either.

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Campbell Ritchie wrote:

A few minutes ago, Stephan van Hulst wrote:… accept that arrays and collections are not compatible, and to avoid accommodating the use of arrays.

It was on this thread.
See if you can't change the array to a List<Integer>.

int sum = myIntegerList .stream() .mapToInt(i -> i.intValue()) .sum();
You would need the mapToInt() method to make sure the compiler knows you are dealing with Integers. The i -> i.intValue() bit is because you know you are dealing with Integers and you know they have an intValue() method. There are probably much neater ways to do that conversion.

Since this is a cost value, wouldn't I need to be dealing with doubles or floats? and not Integers?

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Amie Mac wrote: . . . Since this is a cost value, wouldn't I need to be dealing with doubles or floats? . . .

Don't use doubles for money. Don't use floats for anything, unless some other code requires floats. Look at this old post and the two links therein for what you should use for money. Be sure to read the whole of the threads for both those links.

As an alternative, denominate the money in pence, cents, centimes, or similar and use integer arithmetic.

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

If you have to write in Java7, you use a loopI trust we shan't see that sort of code in your GUI classes. That is application code which should be in different classes. You should have the application working before you try putting a GUI atop it. You must use the = operator because BigDecimal is immutable.

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Campbell Ritchie wrote:I trust we shan't see that sort of code in your GUI classes. That is application code which should be in different classes. You should have the application working before you try putting a GUI atop it. You must use the = operator because BigDecimal is immutable.

So what you are saying is that BigDecimal is what I should have used in my Inventory class to calculate the total inventory value?

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

If the value is in money, yes.

Read the old threads which show how BigDecimals work and a few things which can go wrong. Don't pass a double to a BigDecimal constructor.

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Campbell Ritchie wrote:If the value is in money, yes.

Read the old threads which show how BigDecimals work and a few things which can go wrong. Don't pass a double to a BigDecimal constructor.

OK. I will have to read up on this and try it out later on tonight. Work is getting in the way of my programming class right now. ;)

Thanks

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I guess I still don't understand. I tried to change my total inventory value to use BigDecimal in the Inventory class, but it does the same thing and shows LBooks;@16c0663d in the output.

Everything works other than that... how does that get converted to show the correct number? I also don't want it to print to the console window...

I've changed my code back to the original code posted here.

But here is the code with BigDecimal that I tried out.

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

You are not returning the sum, but the array of inventory. You have shown the printout wrongly; there should be a [ at its beginning. You are supposed to return the BigDecimal sum and if you print it out you get a number. What you are doing is printing the array and arrays don't have an overridden toString method. So you get the same as with Object#toString.
I trust your values from the inventory are not in double format, because otherwise using BigDecimal you will simply immortalise the imprecision. Either change the inventory to use a precise form of number or round the values.
sum = sum.add(new BigDecimal(theInventory[i].inventoryValue()).round(...));
Why are you using a for loop rather than a for‑each loop?

Amie Mac

Ranch Hand

Posts: 55

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Campbell Ritchie wrote:You are not returning the sum, but the array of inventory. You have shown the printout wrongly; there should be a [ at its beginning. You are supposed to return the BigDecimal sum and if you print it out you get a number. What you are doing is printing the array and arrays don't have an overridden toString method. So you get the same as with Object#toString.
I trust your values from the inventory are not in double format, because otherwise using BigDecimal you will simply immortalise the imprecision. Either change the inventory to use a precise form of number or round the values.
sum = sum.add(new BigDecimal(theInventory[i].inventoryValue()).round(...));
Why are you using a for loop rather than a for‑each loop?

So I got it working using double instead of Inventory []. I also got it working using BigDecimal but then the number was very long. At this point, for my assignment, I am not worried about the precision, but it will be something to look into because it will be important to be precise when I write code about money.

I didn't think I could use a for each loop because I need to add together just the inventoryValue() of each entry in the array. How would a for each loop work for this?

Campbell Ritchie

Marshal

Posts: 80230

424

posted 9 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I showed you a for‑each loop earlier. You simply need a total.
What do you mean about the number being too long? If it had about 40 places after the decimal point, that is because you have tried to pass the values directly from doubles without taking the precaution of rounding.

Willie Smits increased rainfall 25% in three years by planting trees. Tiny ad:

Smokeless wood heat with a rocket mass heater

https://woodheat.net