Tic tac Toe GUI not displaying winner

[Brad Siloya]

130 lines. So I'm trying to get this game to display a winner or tie at the end of the game by using JOptionPane.showMessageDialog (lines 65 to 75) but it does nothing. I get no error code when I run it, and can play the board, but it doesn't end or display the popup. The only error I have is line 67 which is unnecessary for the code to work anyway. (or at least i think so) and line 77 shows unreachable statement yet line 90 has no issues . Any ideas what I'm doing wrong or how to make it work? games.board is after the first code which is a source file.

package tictactoeguigame;

import javax.swing.*;
import java.awt.*;
import games.board.*;
import static games.board.Mark.*;
import java.awt.event.*;
import games.board.Cell;
import javax.swing.JOptionPane;



public class TicTacToeGUIGame extends JFrame {

    private Board gb;
    private int turn;
        String noughtOutcome = "O Wins!";
        String crossOutcome = "X Wins!";
        String tieOutcome = "Tie game!";
    
   
public static void main(String[] args) {
  
    SwingUtilities.invokeLater( new Runnable () {

public void run() { new TicTacToeGUIGame(); }
       });           
    }
    

    
private TicTacToeGUIGame() {

    gb = new Board(3, 3, new ActionListener() {

public void actionPerformed(ActionEvent ae) {
    
    Cell c = (Cell) ae.getSource();
    takeTurn(c);
         }
    });

        this.add(gb);
        this.setDefaultCloseOperation(EXIT_ON_CLOSE);
        this.setTitle("TIC-TAC-TOE");
        this.setSize(300, 300);
        this.setVisible(true);
       } 

private void takeTurn(Cell c) {

    Mark curMark = (turn++ % 2 == 0)?
        Mark.NOUGHT : Mark.CROSS;
            gb.setCell(curMark,c.getRow(),c.getColumn());
       
        }


public Outcome getOutcome() {

    Outcome getOutcome = null;
        if (getOutcome == Outcome.CONTINUE) {
            Mark curMark = (turn++ % 2 == 0) ? Mark.NOUGHT : Mark.CROSS;

         }

for (getOutcome){ 
    if (getOutcome == Outcome.PLAYER1_WIN)
        JOptionPane.showMessageDialog(this, noughtOutcome);
    else if (getOutcome == Outcome.PLAYER2_WIN) 
        JOptionPane.showMessageDialog(this, crossOutcome);
    else if (getOutcome == Outcome.TIE) 
        JOptionPane.showMessageDialog(this, tieOutcome);
            return null;
        }

for (int r =0; r < 3; r++){
    if (gb.getCell(r, 0).getContent() == Mark.NOUGHT
        && gb.getCell(r, 1).getContent() == Mark.NOUGHT
        && gb.getCell(r, 2).getContent() == Mark.NOUGHT) {
            return Outcome.PLAYER1_WIN;
       }
    if (gb.getCell(r,0).getContent() == Mark.CROSS
        && gb.getCell(r,1).getContent() ==Mark.CROSS
        && gb.getCell(r,2).getContent() == Mark.CROSS) {
            return Outcome.PLAYER2_WIN;
         }
     }

for (int c =0; c < 3; c++){
    if(gb.getCell(c,0).getContent() == Mark.NOUGHT
        && gb.getCell(c,1).getContent() == Mark.NOUGHT
        && gb.getCell(c,2).getContent() == Mark.NOUGHT){
            return Outcome.PLAYER1_WIN;
      }

    if(gb.getCell(c,0).getContent()== Mark.CROSS
        && gb.getCell(c,1).getContent() == Mark.CROSS
        && gb.getCell(c,2).getContent() == Mark.CROSS) {
            return Outcome.PLAYER2_WIN;
       }
   }

    if (gb.getCell(0,0).getContent()==Mark.NOUGHT &&
        gb.getCell(1,1).getContent()==Mark.NOUGHT &&
        gb.getCell(2,2).getContent() == Mark.NOUGHT ||
        gb.getCell(0,2).getContent() == Mark.NOUGHT &&
        gb.getCell(1, 1).getContent() == Mark.NOUGHT &&
        gb.getCell(2, 0).getContent() == Mark.NOUGHT){
            return Outcome.PLAYER1_WIN;
      }
    if (gb.getCell(0,0).getContent() == Mark.CROSS &&
        gb.getCell(1,1).getContent() == Mark.CROSS &&
        gb.getCell(2,2).getContent() == Mark.CROSS ||
        gb.getCell(0, 2).getContent() == Mark.CROSS &&
        gb.getCell(1, 1).getContent() == Mark.CROSS &&
        gb.getCell(2, 0).getContent() == Mark.CROSS) {
            return Outcome.PLAYER2_WIN;
     }

for (int r = 0; r < 3; ++r) {
for (int c = 0; c < 3; ++c) {
    if (gb.getCell(r, c).getContent() == Mark.EMPTY)
        return Outcome.CONTINUE;
        }
    }
        return Outcome.TIE;
    }
        
}

Board.java

package games.board;

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;


public class Board extends JPanel {
private Cell[][] cells;
public Board(int rows, int columns) {
cells = new Cell[rows][columns];
for(int r = 0; r < cells.length; r++) {
for (int c = 0; c < cells[r].length;c++) {
cells[r][c] = new Cell(r,c);
}
}
}
public void setCell(Mark mark, int row, int
column) throws IllegalArgumentException {
if (cells[row][column].getContent() ==
Mark.EMPTY)
cells[row][column].setContent(mark);
else throw new
IllegalArgumentException("Player already there!");
}
public Cell getCell(int row, int column) {
return cells[row][column];
}
public String toString() {
StringBuilder str = new StringBuilder();
for( int r = 0; r < cells.length; r++ ) {
str.append("|");
for (int c = 0; c < cells[r].length;
c++) {
switch(cells[r][c].getContent())
{
case NOUGHT:
str.append("O");
break;
case CROSS:
str.append("X");
break;
case YELLOW:
str.append("Y");
break;
case RED:
str.append("R");
break;
case BLUE:
str.append("B");
break;
case GREEN:
str.append("G");
break;
case MAGENTA:
str.append("M");
break;
case ORANGE:
str.append("M");
break;
default: //Empty
str.append(" ");
}
str.append("|");
}
str.append("\n");
}
return str.toString();
}
public Board(int rows, int columns, ActionListener ah) {
cells = new Cell[rows][columns];
this.setLayout(new GridLayout(0,3));
for( int r = 0; r < cells.length; r++ ) {
for (int c = 0; c < cells[r].length; c++) {
cells[r][c] = new Cell(r,c);
this.add(cells[r][c]);
cells[r][c].addActionListener(ah);
}
}
}

}

Cell.java

package games.board;

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;



public class Cell extends JButton {
private Mark content;
private int row, column;

public Cell(int row, int column) {
this.row = row;
this.column = column;
content = Mark.EMPTY;
}
public Mark getContent() { return content; }
public void setContent(Mark content) { this.content = content;
}
public int getRow() { return row; }
public int getColumn() { return column; }


public void paintComponent(Graphics g) {
//paint the basic button first
super.paintComponent(g);
int offset = 5;
Graphics2D g2 = (Graphics2D) g;
g2.setStroke(new BasicStroke(5));
switch(content) {
case NOUGHT:
g2.setColor(Color.RED);
//Draw O
g2.drawOval(offset, offset, this.getWidth() -
offset * 2, this.getHeight() - offset * 2);
break;
case CROSS:
g2.setColor(Color.BLACK);
//Draw X
g2.drawLine(offset, offset, this.getWidth() - offset ,
this.getHeight() - offset );
g2.drawLine(this.getWidth() - offset, offset , offset,
this.getHeight()- offset);
break;
}
}
}

Player.java

package games.board;


public enum Player{FIRST,SECOND} 

Mark.java

package games.board;


public enum Mark {EMPTY, NOUGHT, CROSS, YELLOW, RED,
BLUE, GREEN, MAGENTA, ORANGE}

Outcome.java

package games.board;


public enum Outcome {PLAYER1_WIN, PLAYER2_WIN,
CONTINUE, TIE}

[Mike. J. Thompson]

Brad Siloya wrote:130 lines. So I'm trying to get this game to display a winner or tie at the end of the game by using JOptionPane.showMessageDialog (lines 65 to 75) but it does nothing. I get no error code when I run it, and can play the board, but it doesn't end or display the popup. The only error I have is line 67 which is unnecessary for the code to work anyway. (or at least i think so) and line 77 shows unreachable statement yet line 90 has no issues . Any ideas what I'm doing wrong or how to make it work? games.board is after the first code which is a source file.

When you say you get an error on line 67 what do you mean? You need to be a little more precise than that. If you're getting a compilation error then that definitely does matter and will stop all of the code from working. If its not a compilation error then what is it?

Incidentally, line 67 definitely does not look right for a for loop. What are you trying to do there?

Another error that I see in the getOutcome() method is that you have created a getOutcome variable and set it to null (line 61). At no point that I can see do you ever set a meaningful value to that variable, and certainly you are using it in comparisons while it is still null. Your code deciding which messages to display is comparing it to enums, and those comparisons will always be false.

Another thing I would comment on is that you have if statements that do not use curly braces. This is a very bad thing to do, and is very likely to confuse you. You should never miss out the curly braces, even if the compiler let's you.

Now the general way to fix problems like yours is to watch exactly what your program is doing, either by stepping through the code in a debugger or by putting System.out.printLine() statements in your code. In your case I would suggest that once you have addressed the compilation errors that you add some print statements so you can see exactly which lines of code are running and what value things have.

[Campbell Ritchie]

Welcome to the Ranch

You should always format your code correctly; we have some suggestions here. If you don't indent your code, you can hide all sorts of errors from yourself. I have my own suggestions: use a decent text editor (not MS Notepad) and write backwards. If you go backwards into the {} you will get the indentation right.