Problem with printing variables

[Scott M Summers]

Hello,
Lines 102 to 124 is my inputSystemTask() method. It asks users to input a month, day, hour, minute, and a message. It then passes each variable to another class, UserInput(), to check for correct input.
Lines 94 to 100 is my toString() method that prints a message using the month, day, hour, minute, and message variables.
On lines 128 to 130 of my main method I am attempting to print the new user input variables using my toString() method. It will print my default values for my variables, but not my new user input variables.
Where am I going wrong?
Thank you.

import java.util.Scanner;
public class SystemTask { //Start of SystemTask class.
        public static String month;
        public static int day;
        public static int hour;
        public static int minute;
        public static String message;
    
    //No arg constructor.
    public SystemTask(){
        month = "Jan";
        day = 1;
        hour = 0;
        minute = 0;
        message = "No message";
    }
    //Constructor that assigns the values passed to each field.
    public SystemTask(String newMonth, int newDay, int newHour, int newMinute, 
            String newMessage){
        setMonth(newMonth);
        setDay(newDay);
        setHour(newHour);
        setMinute(newMinute);
        setMessage(newMessage);
        
    }

    /*Get methods for month, day, hour, minute, and message. */
    public static String getMonth(){ //Month get method.
        return month;
    }
    public int getDay(){ //Day get method.
        return day;
    }
    public int getHour(){ //Hour get method.
        return hour;
    }
    public int getMinute(){ //Minute get method.
        return minute;
    }
    public String getMessage(){ //Message get method.
        return message;
    }
    
    /*Set methods for month, day, hour, minute, and message. */
    public static void setMonth(String newMonth){ //Month set method.
        if(newMonth.length()== 3){
            month=newMonth;
        }
        else{
            System.out.println("Incorrect input for the month.");
        }
    }
    public void setDay(int newDay){ //Day set method.
        if(newDay >=1 && newDay <= 31){
            day=newDay;
        }
        else{
            System.out.println("Incorrect input for the day.");
        }
    }
    public void setHour(int newHour){ //Hour set method.
        if(newHour >= 0 && newHour <= 23){
            hour=newHour;
        }
        else{
            System.out.println("Incorrect input for the hour.");
        }
    }
    public void setMinute(int newMinute){ //Minute set method.
        if(newMinute >=0 && newMinute <= 59){
            minute=newMinute;
        }
        else{
            System.out.println("Incorrect input for the minute.");
        }
    }
    public void setMessage(String newMessage){ //Message set method.
        if(newMessage.length() >= 1 && newMessage.length() <=40){
            message=newMessage;
        }
        else{
            System.out.println("Incorrect input for the message.");
        }
    }
    
    //To String method.
        @Override
    public String toString(){
        return    "System Task"
                + "\nDate: " + month + " " + day
                + "\nTime: "+ hour + ":" + minute
                + "\nMessage: " + message +"\n";
    }
    
    public static void inputSystemTask(){ //Start of inputSystemTask() method.
        Scanner input = new Scanner(System.in);
        //Input for the month.
        System.out.println("Input the month: ");
        UserInput.getString(3,3);
        UserInput.string = month;
        //Input for the day.
        System.out.println("Input the day: ");
        UserInput.getInt(1, 31);
        UserInput.intValue = day;
        //Input for the hour.
        System.out.println("Input the hour: ");
        UserInput.getInt(0,23);
        UserInput.intValue = hour;
        //Input for the minute.
        System.out.println("Input the minute: ");
        UserInput.getInt(0,59);
        UserInput.intValue = minute;
        //Input for the message.
        System.out.println("Input the message: ");
        UserInput.getString(2,1000);
        UserInput.string = message;   
    } //End of inputSystemTask() method.
    
    public static void main(String[] args) {
        //Create SystemTask object, have it call inputSystemTask().
        SystemTask s1 = new SystemTask();
        inputSystemTask();
        System.out.println(s1.toString()); //Print inputSystemTask() using toString().
        
        //Prints default fields.
         SystemTask s2 = new SystemTask();
         System.out.println(s2);
    }
    
} //End of SystemTask class.

[Paul Clapham]

As far as I can see: your method where input takes place doesn't actually assign any values to month, day, and so on. It passes those things into your mysterious UserInput class, for why I don't know. Maybe those assignment statements are the wrong way around?

[Paul Clapham]

By the way, having those class-level variables (month, day, etc) be static is going to cause you problems. Shouldn't each SystemTask object have its own version of those things?

[Tushar Goel]

you are adding value in UserInput class methods but not system task class and you are class toString() method of system task class.

[Scott M Summers]

Right, I am sending values to my UserInput class, to check if it is within the correct parameters. I'm using

UserInput.string = month;

to set the value from the variable in UserInput to the value for my variable in SystemTask.

[Paul Clapham]

Scott M Summers wrote:Right, I am sending values to my UserInput class, to check if it is within the correct parameters. I'm using

UserInput.string = month;

to set the value from the variable in UserInput to the value for my variable in SystemTask.

But you already know that the value of the month variable is correct. It's "Jan", because you already assigned that value to it in the constructor. So what's the point of sending it to the UserInput class? Shouldn't you be checking the value which the user typed in instead?

Especially since you don't seem to do anything after that, based on whether it's acceptable or not. Especially, you don't assign any new value to the month variable, and that results in the problem you already complained about.

[Scott M Summers]

"Jan" is the default value for month.
I don't want to send my default value to my UserInput class, nor am I. I send the user input from inputSystemTask() to the UserInput class.
UserInput will check to see if the user input is within the parameters and returns a variable. I need the returned variable from UserInput to be assigned as my new month, new day, new hour, and new message. This way I can print the new variables that the user input using my toString() method.

Code for UserInput:

import java.util.Scanner; // Scanner is in java.util
public class UserInput {
//Variable string for the getString() and getString(int min, int max) methods.
        static String string;
//Variable c for the getChar() and getChar(char min, char max) methods.
        static char c;
//Variable intValue for the getInt() and getInt(int min, int max) methods.
        static int intValue;
//Variable d for the getDouble() and getDouble(double min, double max) methods.
        static double d;
    
    //Start of main method.
    public static void main(String [] args){
        /*Request user input for all eight methods and display their input*/
        
        //Request string input, call getString() method, and display input.
        System.out.println("Enter a string: ");
        getString();
        System.out.println("You entered the string: " + string);
        
        //Request char input, call getChar() method, and display input.
        System.out.println("Enter any character: ");
        getChar();
        System.out.println("You entered the character " + c);

        //Request int input, call getInt() method, and display input.
        System.out.println("Enter an integer: ");
        getInt();
        System.out.println("You entered the integer " + intValue);
        
        //Request double input, call getDouble() method, and display input.
        System.out.println("Enter a double value: ");
        getDouble();  
        System.out.println("You entered the double value of " + d);
        
        /* Request string input between two and one hundred characters, call 
         * getString(int min, int max) method, and display input. */
        System.out.println("Enter a string between two characters and one"
                + " hundred characters: ");
        getString(2,100);
        System.out.println("You entered the string: " + string);
        
        /* Request character input between A and Z, call 
         * getChar(char min, char max) method, and display input. */
        System.out.println("Enter a character between A and Z: ");
        getChar('a','z','A','Z');
        System.out.println("You entered the character " + c);
        
        /* Request integer input between 0 and 99, call getInt(int min, int max)
         * method, and display input. */
        System.out.println("Enter an integer between 0 and 99: ");
        getInt(0,99);
        System.out.println("You entered the integer " + intValue);
        
        /* Request double input between 0.10 and 199.99, call 
         * getDouble(double min, double max) method, and display input. */
        System.out.println("Enter a double value between 0.10 and 199.99: ");
        getDouble(0.1,199.99);
        System.out.println("You entered the double value of: " + d);
        
    } //End of main method.
    
    //String method with no parameters.
    public static String getString (){
        Scanner input = new Scanner(System.in);
        string = input.next(); //User input for the String.
        return string; // return user input.
    }
    //Character method with no parameters.
    public static char getChar(){
        Scanner reader = new Scanner(System.in);
        c = reader.next().charAt(0); //User input for the character.
        return c; //Returns user input.
    }
    //Integer method with no parameters.
    public static int getInt(){
        Scanner input = new Scanner(System.in);
        intValue = input.nextInt(); //User input for the integer.
        return intValue; // return user input.
    }
    //Double method with no parameters.
    public static double getDouble(){
        Scanner input = new Scanner(System.in);
        d = input.nextDouble(); //User input for the double value.
        return d; // return user input.
    }
    //String method with parameters.
    public static String getString(int minString, int maxString){
        getString(); //Call getString() method.
        /*Checking parameters*/
        if(string.length()>=minString && string.length() <=maxString){
            return string;
        }
        else{
            System.out.println("Invalid input,try again: ");
            getString(minString, maxString);
        }
        return string;
    }
    //Character method with parameters.
    public static char getChar(char minCharLowercase, char maxCharLowercase,
            char minCharUppercase, char maxCharUppercase){
        getChar(); //Call getChar() method.
        /*Checking parameters*/
        if(c >=minCharLowercase && c<=maxCharLowercase || c>=minCharUppercase
                && c<=maxCharUppercase){
            return c;
        }
        else{
            System.out.println("Invalid input, try again: ");
            getChar(minCharLowercase, maxCharLowercase,
            minCharUppercase, maxCharUppercase);
        }
        return c;
    }
    //Integer method with parameters.
    public static int getInt(int minInt, int maxInt){
        getInt(); //Call getInt() method.
        /*Checking parameters*/
        if(intValue >= minInt && intValue<= maxInt){
            return intValue;
        }
        else{
            System.out.println("Invalid input, try again: ");
            getInt(minInt, maxInt);
        }
        return intValue;
    }
    
    //Double method with parameters.
    public static double getDouble(double minDouble, double maxDouble){
        getDouble(); //Call getDouble() method.
        /*Checking parameters*/
        if(d >=minDouble && d <= maxDouble){
            return d;
        }
        else{
            System.out.println("Invalid input, try again: ");
            getDouble(minDouble, maxDouble);
        }
        return d;
    }
}

[Paul Clapham]

Scott M Summers wrote:"Jan" is the default value for month.
I don't want to send my default value to my UserInput class, nor am I.

On the contrary, that's exactly what this line of code does:

UserInput.string = month;

It assigns the value of variable "month", which until you change it (which you never do) contains the default value of "Jan", to something inside the UserInput class.

I need the returned variable from UserInput to be assigned as my new month, new day, new hour, and new message.

Well then, why don't you do that? You need to assign something from the UserInput class to the "month" variable, and you don't have any code which does it.