Double answer Problem

[Vin Ash]

Hi guys.
Ok first emersion into the program
got to ask to input age and day
then with given, I got to calculate the discount
when I input age Below 16 and over 65 I have no problems
All works fine
But when I enter between ages of 17 to 64, I get double answers , one right and one wrong of course
I went over it cm by cm and can get what is wrong
Any ideas
Thanks in advance

package tp1;

import java.util.Scanner;

public class TP1 {

    public static void main(String[] args) {
        
        final double PRIX_BILLET_FIXE = 100.00;
        final double FRAIS_ADMIN = 4.3/100;
        final double TPS = 5.00/100;
        final double TVQ = 9.975/100;
        double escompt1;
        double escompt2;
        double escompt3;
        double fraisadmin1;
        double fraisadmin2;
        double fraisadmin3;
        double fraisadmin4;
        double totalminusesc1;
        double totalminusesc2;
        double totalminusesc3;
        double soustotal1;
        double soustotal2;
        double soustotal3;
        double soustotal4;
        double grandtotal1;
        double grandtotal2;
        double grandtotal3;
        double grandtotal4;
        
        Scanner clavier = new Scanner (System.in);
        char jour;
        int age;
        double montant = 0;
        
        System.out.print( "Entree l'Age du Client S.V.P : ");
        age  = clavier.nextInt();
   
        //Algo//
        
        escompt1 = 100 * 0.3;
        escompt2 = 100 * 0.1;
        escompt3 = 100 * 0.2;
        totalminusesc1 = 100 - escompt1;
        totalminusesc2 = 100 - escompt2;
        totalminusesc3 = 100 - escompt3;
        fraisadmin1 = (PRIX_BILLET_FIXE - escompt1)* FRAIS_ADMIN;
        fraisadmin2 = (PRIX_BILLET_FIXE - escompt2)* FRAIS_ADMIN;
        fraisadmin3 = (PRIX_BILLET_FIXE - escompt3)* FRAIS_ADMIN;
        fraisadmin4 =  PRIX_BILLET_FIXE * FRAIS_ADMIN;
        soustotal1 = fraisadmin1+ totalminusesc1;
        soustotal2 = fraisadmin2+ totalminusesc2;
        soustotal3 = fraisadmin3+ totalminusesc3;
        soustotal4 = fraisadmin4+ PRIX_BILLET_FIXE;
        grandtotal1= (TPS * soustotal1) + (TVQ *soustotal1)+ soustotal1;
        grandtotal2= (TPS * soustotal2) + (TVQ *soustotal2)+ soustotal2;
        grandtotal3= (TPS * soustotal3) + (TVQ *soustotal3)+ soustotal3;
        grandtotal4= (TPS * soustotal4) + (TVQ *soustotal4)+ soustotal4;
        
                System.out.print("Entree le Jour D'Activité S.V.P (1 Dimanche, 2 Lundi , 3 Mardi, 4 Mercredi, 5 Jeudi, 6 Vendredi, 7 Samedi) : ");
        int choix = clavier.nextInt();
        
        if (choix == 1) { 
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Dimanche" );
        } 
        
        if (choix == 2) { 
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Lundi" );
        }   
        
        if (choix == 3) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Mardi" );
        }   
        
        if (choix == 4) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Mercredi" );
        
        }  
        
        if (choix == 5) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Jeudi" ); 
        
        }  
        
        if (choix == 6) {
        System.out.print("le client a "+ age+ " et s'est inscrit pour une activité du Vendredi" );
        
        } 
       
        if (choix == 7) {
        System.out.print("le client a "+ age+ " et s'est inscrit pour une activité du Samedi" );  
         
        } 
        //30%//
        if ((choix == 2|| choix==3 || choix == 4)||(age <=16 && age >=65) ) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt1);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin1);
        System.out.printf("Soustotal:%.2f$\n", soustotal1) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal1 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal1 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal1 );
        
        }   
        //10%//
        if ((choix == 5 || choix== 6 || choix == 7 || choix == 1) || (age <=16 && age >=65)) {
        System.out.println();    
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt2);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin2);
        System.out.printf("Soustotal:%.2f$\n", soustotal2) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal2 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal2 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal2 );
        
        }   
        //20%//
        if ((choix == 2|| choix==3 || choix == 4 )&& (age >=17 && age <=64)) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt3);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin3);
        System.out.printf("Soustotal:%.2f$\n", soustotal3) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal3 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal3 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal3 );
        
        } 
        
        //0%//
        if ((choix == 5 || choix==6 || choix == 7 || choix == 1 )&& (age >=17 && age <=64)) {
        
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$$");
        System.out.println("Escompte accorde:0.00$");
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin4);
        System.out.printf("Soustotal:%.2f$\n", soustotal4) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal4 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal4 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal4 );
        
        
}
    
}  
         

    }
    

[Carey Brown]

Seems like

if ((choix == 2|| choix==3 || choix == 4)||(age <=16 && age >=65) )

should be

if ((choix == 2|| choix==3 || choix == 4)&&(age <=16 || age >=65) )

[Vin Ash]

Carey Brown wrote:Seems like

if ((choix == 2|| choix==3 || choix == 4)||(age <=16 && age >=65) )

should be

if ((choix == 2|| choix==3 || choix == 4)&&(age <=16 || age >=65) )

When I change the two first || for &&, The programs does not go to the end. It stops have half and says build is successful and does not show any prices and discounts
If I put all || same results
If I put all && then I get double results for all like so

Entree l'Age du Client S.V.P : 12
Entree le Jour D'Activité S.V.P (1 Dimanche, 2 Lundi , 3 Mardi, 4 Mercredi, 5 Jeudi, 6 Vendredi, 7 Samedi) : 2
le client a 12 et s'est inscrit pour une activité du Lundi
Prix du Billet:100.00$
Escompte accorde:30.00$
Frais D admin:3.01$
Soustotal:73.01$
TPS:3.65$
TVQ:7.28$
Prix a Payer:83.94$

Prix du Billet:100.00$
Escompte accorde:20.00$
Frais D admin:3.44$
Soustotal:83.44$
TPS:4.17$
TVQ:8.32$
Prix a Payer:95.94$
BUILD SUCCESSFUL (total time: 4 seconds)

[Carey Brown]

Sounds like you're thrashing instead of thinking the logic through. For example, part of your original logic was

(age <=16 && age >=65)

There is no age that satisfies both the left and right hand side of the expression. Age can't be both less than 17 AND greater than 64. Impossible. So you need to reexamine your logic.

[Vin Ash]

even if I write them on separate lines it makes no difference

[Carey Brown]

Can you write down in English (sorry, my native tongue) what logic you are trying to implement with this if statement? I might then be able to be of more help. I don't quite follow when you say "write them on separate lines".

[Carey Brown]

When you give it an age of 17...

        //30%//
        if ((choix == 2|| choix==3 || choix == 4)||(age <=16 && age >=65) ) {
            // this will happen if choice is 2, 3, of 4, regardless of age
        }   

        //10%//
        if ((choix == 5 || choix== 6 || choix == 7 || choix == 1) || (age <=16 && age >=65)) {
            // this will happen if choice is 5, 6, 7, or 1, regardless of age
        }   

        //20%//
        if ((choix == 2|| choix==3 || choix == 4 )&& (age >=17 && age <=64)) {
            // this will happen if choice is 2, 3, or 4, AND age is 17
        } 
         
        //0%//
        if ((choix == 5 || choix==6 || choix == 7 || choix == 1 )&& (age >=17 && age <=64)) {
            // this will happen if choice is 5, 6, 7, or 1 AND age is 17
        }

[Carey Brown]

These two are logically identical so I'm guessing that this is not what you intended.

if ((choix == 5 || choix== 6 || choix == 7 || choix == 1) || (age <=16 && age >=65))

if ((choix == 5 || choix== 6 || choix == 7 || choix == 1) )

[Vin Ash]

Well with some tweaking this is what I have now (following your advice Carey Brown)

package tp1;

import java.util.Scanner;

public class TP1 {

    public static void main(String[] args) {
        
        final double PRIX_BILLET_FIXE = 100.00;
        final double FRAIS_ADMIN = 4.3/100;
        final double TPS = 5.00/100;
        final double TVQ = 9.975/100;
        double escompt1;
        double escompt2;
        double escompt3;
        double fraisadmin1;
        double fraisadmin2;
        double fraisadmin3;
        double fraisadmin4;
        double totalminusesc1;
        double totalminusesc2;
        double totalminusesc3;
        double soustotal1;
        double soustotal2;
        double soustotal3;
        double soustotal4;
        double grandtotal1;
        double grandtotal2;
        double grandtotal3;
        double grandtotal4;
        
        Scanner clavier = new Scanner (System.in);
        char jour;
        int age;
        double montant = 0;
        
        System.out.print( "Entree l'Age du Client S.V.P : ");
        age  = clavier.nextInt();
   
        //Algo//
        
        escompt1 = 100 * 0.3;
        escompt2 = 100 * 0.1;
        escompt3 = 100 * 0.2;
        totalminusesc1 = 100 - escompt1;
        totalminusesc2 = 100 - escompt2;
        totalminusesc3 = 100 - escompt3;
        fraisadmin1 = (PRIX_BILLET_FIXE - escompt1)* FRAIS_ADMIN;
        fraisadmin2 = (PRIX_BILLET_FIXE - escompt2)* FRAIS_ADMIN;
        fraisadmin3 = (PRIX_BILLET_FIXE - escompt3)* FRAIS_ADMIN;
        fraisadmin4 =  PRIX_BILLET_FIXE * FRAIS_ADMIN;
        soustotal1 = fraisadmin1+ totalminusesc1;
        soustotal2 = fraisadmin2+ totalminusesc2;
        soustotal3 = fraisadmin3+ totalminusesc3;
        soustotal4 = fraisadmin4+ PRIX_BILLET_FIXE;
        grandtotal1= (TPS * soustotal1) + (TVQ *soustotal1)+ soustotal1;
        grandtotal2= (TPS * soustotal2) + (TVQ *soustotal2)+ soustotal2;
        grandtotal3= (TPS * soustotal3) + (TVQ *soustotal3)+ soustotal3;
        grandtotal4= (TPS * soustotal4) + (TVQ *soustotal4)+ soustotal4;
        
                System.out.print("Entree le Jour D'Activité S.V.P (1 Dimanche, 2 Lundi , 3 Mardi, 4 Mercredi, 5 Jeudi, 6 Vendredi, 7 Samedi) : ");
        int choix = clavier.nextInt();
        
        if (choix == 1) { 
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Dimanche" );
        } 
        
        if (choix == 2) { 
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Lundi" );
        }   
        
        if (choix == 3) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Mardi" );
        }   
        
        if (choix == 4) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Mercredi" );
        
        }  
        
        if (choix == 5) {
        System.out.print("le client a " + age + " et s'est inscrit pour une activité du Jeudi" ); 
        
        }  
        
        if (choix == 6) {
        System.out.print("le client a "+ age+ " et s'est inscrit pour une activité du Vendredi" );
        
        } 
       
        if (choix == 7) {
        System.out.print("le client a "+ age+ " et s'est inscrit pour une activité du Samedi" );  
         
        } 
        //30%//
        else if ((choix == 2|| choix==3 || choix == 4) && age <=16) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt1);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin1);
        System.out.printf("Soustotal:%.2f$\n", soustotal1) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal1 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal1 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal1 );
        
        }   
        
        else if ((choix == 2|| choix==3 || choix == 4) && age >=65 ) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt1);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin1);
        System.out.printf("Soustotal:%.2f$\n", soustotal1) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal1 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal1 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal1 );
        
        }
        //10%//
        else if (choix == 5 || choix== 6 || choix == 7 || choix == 1 && age <=16) {
        System.out.println();    
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt2);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin2);
        System.out.printf("Soustotal:%.2f$\n", soustotal2) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal2 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal2 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal2 );
        
        }
        
        else if (choix == 5 || choix== 6 || choix == 7 || choix == 1 && age >=65) {
        System.out.println();    
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt2);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin2);
        System.out.printf("Soustotal:%.2f$\n", soustotal2) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal2 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal2 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal2 );
        
        }   
        //20%//
        else if (choix == 2|| choix==3 || choix == 4 && age >=17 ) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt3);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin3);
        System.out.printf("Soustotal:%.2f$\n", soustotal3) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal3 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal3 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal3 );
        
        }   
        //20%//
        else if (choix == 2|| choix==3 || choix == 4 &&  age <=64) {
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$");
        System.out.printf("Escompte accorde:%.2f$\n", escompt3);
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin3);
        System.out.printf("Soustotal:%.2f$\n", soustotal3) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal3 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal3 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal3 );
        
        } 
        
        //0%//
        else if (choix == 5 || choix==6 || choix == 7 || choix == 1 && age >=17 ) {
        
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$$");
        System.out.println("Escompte accorde:0.00$");
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin4);
        System.out.printf("Soustotal:%.2f$\n", soustotal4) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal4 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal4 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal4 );
        
        } 
        
        else if (choix == 5 || choix==6 || choix == 7 || choix == 1 && age <=64 ) {
        
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$$");
        System.out.println("Escompte accorde:0.00$");
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin4);
        System.out.printf("Soustotal:%.2f$\n", soustotal4) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal4 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal4 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal4 );
        
        
}
    
}  
         

    }
    

[Vin Ash]

the problem seems to lie with the last part

Whenever I put someone age >=17 or age <=64

there is supposed to be no discount

but it does not go to that equation but retraces the one on top which gives 10%

I guess it is reading that one because the "choix" are the same

I even tried a plain else since it is the last equation but no result

//0%//
        else if (choix == 5 || choix==6 || choix == 7 || choix == 1 && age >=17 ) {
        
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$$");
        System.out.println("Escompte accorde:0.00$");
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin4);
        System.out.printf("Soustotal:%.2f$\n", soustotal4) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal4 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal4 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal4 );
        
        } 
        
        else if (choix == 5 || choix==6 || choix == 7 || choix == 1 && age <=64 ) {
        
        System.out.println();
        System.out.printf("Prix du Billet:%.2f$\n" , PRIX_BILLET_FIXE ,"$$$$");
        System.out.println("Escompte accorde:0.00$");
        System.out.printf("Frais D admin:%.2f$\n",fraisadmin4);
        System.out.printf("Soustotal:%.2f$\n", soustotal4) ;
        System.out.printf("TPS:%.2f$\n",TPS * soustotal4 );
        System.out.printf("TVQ:%.2f$\n", TVQ * soustotal4 );
        System.out.printf("Prix a Payer:%.2f$\n", grandtotal4 );

[Carey Brown]

Whenever I put someone age >=17 or age <=64

Age    age >= 17    age <= 64           AorB       AandB
5        false            true            true    false
20      true             true            true     true
70      true             false           true     false

Your English description you are using OR, and as you can see from the table, AorB will always be true;

If you want to say: is varable V outside of the range of MIN and MAX, it would be

if( v < MIN || V > MAX )

if you want to find it if it's between MIN and MAX, that would be

if( V >= MIN && V <= MAX )

[Vin Ash]

Thanks Carey
I resolved the problem. It was a bracket thing
But your logic thing did make me think as well so thanks for that as well
Thanks for the help