• Post Reply Bookmark Topic Watch Topic
  • New Topic

Passing an object between the methods which has to keep adding data in all the methods.  RSS feed

 
janardhan jdev
Greenhorn
Posts: 1
Hibernate Java Spring
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi,

I have a requirement of passing the object between methods and adding data as below example. Is the below written code is a good programming practice?

 
Liutauras Vilda
Sheriff
Posts: 4928
334
BSD
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
No.

1. Bad code indentation
2. Badly named methods (all), such as "SetValue1", it is meaningless as well as doesn't follow naming convention... first lower case... every other word camel case.
3. No spaces in between successive methods.
 
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!