add Jlabel to Jinternalframe

[Chernenko Nencor]

hello,i dont understand why does my Label is not showing up,

import javax.swing.JInternalFrame;
import javax.swing.JDesktopPane;
import javax.swing.JLabel;
import javax.swing.JMenu;
import javax.swing.JMenuItem;
import javax.swing.JMenuBar;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.KeyStroke;
 
import java.awt.event.*;
import java.awt.*;
 
/*
 * InternalFrameDemo.java requires:
 *   MyInternalFrame.java
 */
public class InternalFrame_MasterConsole extends JFrame
                               implements ActionListener {
//    JDesktopPane desktop;
	
	Cl_Main mainform = new Cl_Main();
	InternalFrame_MasterConsole frame = null;
 
	static String form_name = "Gamestops Master Console";
	

	JPanel toppanel, bottompanel, leftpanel, rightpanel;
	JLabel labelnya;
	
    public InternalFrame_MasterConsole() {
        super(form_name);
 
        //Make the big window be indented 50 pixels from each edge
        //of the screen.
        int inset = 50;
        Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
        setBounds(inset, inset,
                  screenSize.width  - inset*2,
                  screenSize.height - inset*2);
 
        //Set up the GUI.
        mainform.desktopnya = new JDesktopPane(); //a specialized layered pane
        createFrame(); //create first "window"
        setContentPane(mainform.desktopnya);
//        setJMenuBar(createMenuBar());
 
        //Make dragging a little faster but perhaps uglier.
        mainform.desktopnya.setDragMode(JDesktopPane.OUTLINE_DRAG_MODE);
    } 
 
    //React to menu selections.
    public void actionPerformed(ActionEvent e) {
        if ("new".equals(e.getActionCommand())) { //new
            createFrame();
        } else { //quit
            quit();
        }
    }
 
    //Create a new internal frame.
    protected void createFrame() {
        JInternalFrame frame = new JInternalFrame();
        frame.setVisible(true); //necessary as of 1.3              
        mainform.desktopnya.add(frame);
        try {
            frame.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }
 
    //Quit the application.
    protected void quit() {
        System.exit(0);
    }
 
    /**
     * Create the GUI and show it.  For thread safety,
     * this method should be invoked from the
     * event-dispatching thread.
     */
    public void createGUI() {
        //Make sure we have nice window decorations.
        JFrame.setDefaultLookAndFeelDecorated(true);
        
        //Create and set up the window.
        toppanel = new JPanel();
        JLabel northlabel = new JLabel("North label");
        JLabel southlabel = new JLabel("South label");
        JLabel westlabel = new JLabel("West label");
        JLabel eastlabel = new JLabel("East label");
        toppanel.add(northlabel,BorderLayout.NORTH);
        toppanel.add(southlabel,BorderLayout.SOUTH);
        toppanel.add(westlabel,BorderLayout.WEST);
        toppanel.add(eastlabel,BorderLayout.EAST);
        setContentPane(toppanel);
        
        frame = new InternalFrame_MasterConsole();
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);        
        //Display the window.        
    }
    
    public void showGUI()
    {
    	frame.setVisible(true);
    }
 
    public static void main(String[] args) {
        //Schedule a job for the event-dispatching thread:
        //creating and showing this application's GUI.
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
//                createAndShowGUI();
            }
        });
    }
}

currently, i am able to show JInternalframe on my JDesktoppane. i just don't understand why my label is not showing inside Jinternalframe

[Rob Camick]

Cl_Main mainform = new Cl_Main();

What is that code for. Get rid of it.

I gave you a link to the Swing tutorial for a reason. I don't know why you are changing the code so dramatically.

If you want to add a label to the internal frame, then add the label when you create the internal frame.

    protected void createFrame() {
        MyInternalFrame frame = new MyInternalFrame();
        frame.getContentPane().setBackground(Color.WHITE);
        frame.getContentPane().add(new JLabel("I'm a label"), BorderLayout.PAGE_START); // add a label
        frame.setVisible(true); //necessary as of 1.3
        desktop.add(frame);
        try {
            frame.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }

I also have no idea what all this code is for:

        //Create and set up the window.
        toppanel = new JPanel();
        JLabel northlabel = new JLabel("North label");
        JLabel southlabel = new JLabel("South label");
        JLabel westlabel = new JLabel("West label");
        JLabel eastlabel = new JLabel("East label");
        toppanel.add(northlabel,BorderLayout.NORTH);
        toppanel.add(southlabel,BorderLayout.SOUTH);
        toppanel.add(westlabel,BorderLayout.WEST);
        toppanel.add(eastlabel,BorderLayout.EAST);
        setContentPane(toppanel);
         
        frame = new InternalFrame_MasterConsole();

The class already is a JFrame, there is no need to create a new JFrame.

You can't use setContentPane() twice. The desktop pane is the content pane for the JFrame. If you replace the content pane with another panel, then you no longer have a desktop pane to add internal frames to.

[Chernenko Nencor]

Rob Camick wrote:

Cl_Main mainform = new Cl_Main();

What is that code for. Get rid of it.

on Cl_main there's a desktoppane, i want the internalframe attached inside.

Rob Camick wrote:I gave you a link to the Swing tutorial for a reason. I don't know why you are changing the code so dramatically.

If you want to add a label to the internal frame, then add the label when you create the internal frame.

    protected void createFrame() {
        MyInternalFrame frame = new MyInternalFrame();
        frame.getContentPane().setBackground(Color.WHITE);
        frame.getContentPane().add(new JLabel("I'm a label"), BorderLayout.PAGE_START); // add a label
        frame.setVisible(true); //necessary as of 1.3
        desktop.add(frame);
        try {
            frame.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }

i've tried your code and still didn't work

Rob Camick wrote: I also have no idea what all this code is for:

        //Create and set up the window.
        toppanel = new JPanel();
        JLabel northlabel = new JLabel("North label");
        JLabel southlabel = new JLabel("South label");
        JLabel westlabel = new JLabel("West label");
        JLabel eastlabel = new JLabel("East label");
        toppanel.add(northlabel,BorderLayout.NORTH);
        toppanel.add(southlabel,BorderLayout.SOUTH);
        toppanel.add(westlabel,BorderLayout.WEST);
        toppanel.add(eastlabel,BorderLayout.EAST);
        setContentPane(toppanel);
         
        frame = new InternalFrame_MasterConsole();

i am intended to use the code above as my label to be printed on jpanel inside Jinternalframe

Rob Camick wrote: The class already is a JFrame, there is no need to create a new JFrame.

You can't use setContentPane() twice. The desktop pane is the content pane for the JFrame. If you replace the content pane with another panel, then you no longer have a desktop pane to add internal frames to.

take a look at the following picture,


my internalframe still move exceeding the desktoppane

and here's my current code

import javax.swing.JInternalFrame;
import javax.swing.JDesktopPane;
import javax.swing.JLabel;
import javax.swing.JMenu;
import javax.swing.JMenuItem;
import javax.swing.JMenuBar;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.KeyStroke;
 
import java.awt.event.*;
import java.awt.*;
 
/*
 * InternalFrameDemo.java requires:
 *   MyInternalFrame.java
 */
public class InternalFrame_MasterConsole extends JFrame
                               implements ActionListener {
//    JDesktopPane desktop;
	
	Cl_Main mainform = new Cl_Main();
	InternalFrame_MasterConsole frame = null;
 
	static String form_name = "Gamestops Master Console";
	

	JPanel toppanel, bottompanel, leftpanel, rightpanel;
	JLabel labelnya;
	
    public InternalFrame_MasterConsole() {
        super(form_name);
 
        //Make the big window be indented 50 pixels from each edge
        //of the screen.
        int inset = 50;
        Dimension screenSize = Toolkit.getDefaultToolkit().getScreenSize();
        setBounds(inset, inset,
                  screenSize.width  - inset*2,
                  screenSize.height - inset*2);
 
        //Set up the GUI.
        mainform.desktopnya = new JDesktopPane(); //a specialized layered pane
        createFrame(); //create first "window"
        setContentPane(mainform.desktopnya);
//        setJMenuBar(createMenuBar());
 
        //Make dragging a little faster but perhaps uglier.
        mainform.desktopnya.setDragMode(JDesktopPane.OUTLINE_DRAG_MODE);
    } 
 
    //React to menu selections.
    public void actionPerformed(ActionEvent e) {
        if ("new".equals(e.getActionCommand())) { //new
            createFrame();
        } else { //quit
            quit();
        }
    }
 
    //Create a new internal frame.
    protected void createFrame() {
        JInternalFrame frame = new JInternalFrame();
        frame.getContentPane().add(new JLabel("I'm a label"), BorderLayout.PAGE_START); // add a label
        frame.setVisible(true); //necessary as of 1.3              
        mainform.desktopnya.add(frame);
        try {
            frame.setSelected(true);
        } catch (java.beans.PropertyVetoException e) {}
    }
 
    //Quit the application.
    protected void quit() {
        System.exit(0);
    }
 
    /**
     * Create the GUI and show it.  For thread safety,
     * this method should be invoked from the
     * event-dispatching thread.
     */
    public void createGUI() {
        //Make sure we have nice window decorations.
        JFrame.setDefaultLookAndFeelDecorated(true);
        
        //Create and set up the window.
        toppanel = new JPanel();
        JLabel northlabel = new JLabel("North label");
        JLabel southlabel = new JLabel("South label");
        JLabel westlabel = new JLabel("West label");
        JLabel eastlabel = new JLabel("East label");
        toppanel.add(northlabel,BorderLayout.NORTH);
        toppanel.add(southlabel,BorderLayout.SOUTH);
        toppanel.add(westlabel,BorderLayout.WEST);
        toppanel.add(eastlabel,BorderLayout.EAST);        
        
        frame = new InternalFrame_MasterConsole();
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);        
        //Display the window.        
    }
    
    public void showGUI()
    {
    	frame.setVisible(true);
    }
 
    public static void main(String[] args) {
        //Schedule a job for the event-dispatching thread:
        //creating and showing this application's GUI.
        javax.swing.SwingUtilities.invokeLater(new Runnable() {
            public void run() {
//                createAndShowGUI();
            }
        });
    }
}

[Rob Camick]

Again, why are you changing the structure of the demo code if you don't understand what your are doing.

If you run the demo code the JInternalFrame is added to the JDesktopPane of the JFrame. The demo code extends JFrame so there is no need to create a second JFrame. There is no need for the CL_Main class. (Also that is not a proper classs name. Look in the Java API to you see any class names with an "_" in the class name? Follow conventions and don't make up your own.

First understand how the demo works and just add your components to the internal frame. That is you can always modify the demo code to create the JInternalFrame at the same time you add the JDesktop pane to the frame. The problem is you add trying to add the desktop pane to your mainform.desktopnya variable. There is no need for that variable. Keep all the code and variables in one class.

Then once you understand the basic concept you can restructure your code so that the main class does not extend JFrame.