Spring MVC form validation issue

Ranch Hand

Posts: 71

posted 4 years ago

I'm modifying a project from Spring In Action by Walls. The project is chapter six's thymeleaf mvc project. I'm adding a confirm password field to the registration form which is backed by a Spitter Object. I add validation to the project to check for the length of the password field and to check that the password and confirmPassword fields match. The Spitter form backing object is

The SpitterController is

package spittr.web;

... imports ...

@Controller
@RequestMapping("/spitter")
public class SpitterController {

private SpitterRepository spitterRepository;

@Autowired
  public SpitterController(SpitterRepository spitterRepository) {
    this.spitterRepository = spitterRepository;
  }
  
  @InitBinder
  public void initBinder(WebDataBinder binder) {
	  
	  binder.setAllowedFields(new String[] 
			  {"username", "password", "confirmPassword",
			   "firstName", "lastName", "email"});
	  
	  binder.registerCustomEditor(String.class, new StringTrimmerEditor(true));
  }
  
  @RequestMapping(value="/register", method=GET)
  public String showRegistrationForm(Model model) {
    model.addAttribute(new Spitter());
    //return "registerForm";
    return VN_REG_FORM;
  }
  
  @RequestMapping(value="/register", method=POST)
  public String processRegistration(
		  @ModelAttribute("spitter") @Valid Spitter form,
		  BindingResult result) {
	  
	  convertPasswordError(result);
	  return (result.hasErrors() ? VN_REG_FORM : VN_REG_OK);
  }
  
  private static void convertPasswordError(BindingResult result) {
	  for (ObjectError error: result.getGlobalErrors()) {
		  System.out.println("convertPasswordError...");
		  // Get the error message
		  String msg = error.getDefaultMessage();
		  // If the error message is spitter.password.mismatch.message
		  // check to see if another password error occured
		  if("spitter.password.mismatch.message".equals(msg)) {
		     // Add password mismatch error code only if no other 
			 // password errors exist 
		     if(!result.hasFieldErrors("password")) {
		       // MHT - Add an error code, this will then match
		       // the error message in our resource bundle of the
		       // form <error code>+<object name>+<field name> or
		       // error.mismatch.spitter.password
			   result.rejectValue("password", "error.mismatch");
		     }
		  }
	  }
   }
  
  @RequestMapping(value="/{username}", method=GET)
  public String showSpitterProfile(@PathVariable String username, Model model) {
    System.out.println("SpitterController.showSpitterProfile(): called with username: " + username);
	Spitter spitter = spitterRepository.findByUsername(username);
    model.addAttribute(spitter);
    return "profile";
  }
  
}

The registrationForm is

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:th="http://www.thymeleaf.org">
  <head>
    <title>Spitter</title>
    <link rel="stylesheet" type="text/css" 
          th:href="@{/resources/style.css}"></link>
  </head>
  <body>
    <div id="header" th:include="page :: header"></div>

<div id="content">
      <h1>Register</h1>
  
      <form method="POST" th:object="${spitter}">
        <div class="errors" th:if="${#fields.hasErrors('*')}">
                <h3>Please fix the following error(s)</h3>
          <ul>
            <li th:each="err : ${#fields.errors('*')}" 
                th:text="${err}">Input is incorrect</li>
          </ul>
        </div>
        <label th:class="${#fields.hasErrors('firstName')}? 'error'">First Name</label>: 
          <input type="text" th:field="*{firstName}"  
                 th:class="${#fields.hasErrors('firstName')}? 'error'" /><br/>
  
        <label th:class="${#fields.hasErrors('lastName')}? 'error'">Last Name</label>: 
          <input type="text" th:field="*{lastName}"
                 th:class="${#fields.hasErrors('lastName')}? 'error'" /><br/>
  
        <label th:class="${#fields.hasErrors('email')}? 'error'">Email</label>: 
          <input type="text" th:field="*{email}"
                 th:class="${#fields.hasErrors('email')}? 'error'" /><br/>
  
        <label th:class="${#fields.hasErrors('username')}? 'error'">Username</label>: 
          <input type="text" th:field="*{username}"
                 th:class="${#fields.hasErrors('username')}? 'error'" /><br/>
  
        <label th:class="${#fields.hasErrors('password')}? 'error'">Password</label>: 
          <input type="password" th:field="*{password}"  
                 th:class="${#fields.hasErrors('password')}? 'error'" /><br/>
        
        <label>Confirm Password</label>:
        <input type="password" th:field="*{confirmPassword}" /><br/>
        
        <input type="submit" value="Register" />
      
      </form>
    </div>
    <div id="footer" th:include="page :: copy"></div>
  </body>
</html>

I have a message resource bundle for Spring-manage messages, messages.properties:

And a ValidationMessages.properties for the JSR 303 and Hibernate Validator messages:

The message validation seems to work well except for one issue. When I force a password mismatch, I see something like the following (see attached png file):

Register

Please fix the following error(s)

spitter.password.mismatch.message
Your passwords don't match. Please try again
....

Instead of the single "Your passwords don't match. Please try again." message, I also see "spitter.password.mismatch.message" as a message and can't figure out why.

spttrRegister3.png

expectation is the root of all heartache - shakespeare. tiny ad:

Devious Experiments for a Truly Passive Greenhouse!

https://www.kickstarter.com/projects/paulwheaton/greenhouse-1