jpa associations issue

[maheedar sand]

Hi Everybody,

In my project we are having entity classes. We have two entity classes named User.java and Role.java. Both are connected using @OnetoMany (Many is the owning side of association).
In the case of editing user we are facing issue with user data. data is not getting into user object. For some other users it is working as expected. The code is as follows.

User.java

                 package com.nxl.auth.entities;

import java.util.List;

import javax.persistence.CascadeType;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.FetchType;
import javax.persistence.JoinColumn;
import javax.persistence.JoinTable;
import javax.persistence.ManyToMany;
import javax.persistence.ManyToOne;
import javax.persistence.NamedQueries;
import javax.persistence.NamedQuery;
import javax.persistence.Table;
import javax.persistence.Transient;
import javax.xml.bind.annotation.XmlTransient;

import org.codehaus.jackson.annotate.JsonIgnore;
import org.hibernate.annotations.Cache;
import org.hibernate.annotations.CacheConcurrencyStrategy;

import com.nxl.auth.api.AbstractEntity;

@Cache(usage = CacheConcurrencyStrategy.READ_WRITE, include = "all")
@Entity
@Table(name = "users")
@NamedQueries({
	@NamedQuery(name="users.fetchAll", query="SELECT instance from User instance"),
	@NamedQuery(name="users.fetchActiveUser", query="SELECT instance from User instance where instance.userId =:username and instance.status = 0"),
	@NamedQuery(name="users.fetchUser", query="SELECT instance from User instance where instance.userId =:username")
})
public class User extends AbstractEntity {

	private static final long serialVersionUID = 1L;
	
	private String userId;
	private String userName;
	private String password;
	private String password1;
	private String password2;
	private String password3;
	private String passwordStatus;
	private String mobile;
	private String email;
	private Integer status;
	private Role role;
	private Integer approvalType;
	private List<Long> approverList;
	
	private List<User> approvers;
	private List<User> users;
	
	private List<User> approverstemp;
	
	@Column(name = "userid", length=15, unique=true, nullable=false)
	public String getUserId() {
		return userId;
	}
	public void setUserId(String userId) {
		this.userId = userId;
	}
	
	@Column(name = "username", length=50, nullable=false)
	public String getUserName() {
		return userName;
	}
	public void setUserName(String userName) {
		this.userName = userName;
	}
	
	@JsonIgnore
	@XmlTransient
	@Column(name = "password", length=15, nullable=false)
	public String getPassword() {
		return password;
	}
	public void setPassword(String password) {
		this.password = password;
	}
	
	@Column(name = "mobile", length=10, unique=true, nullable=false)
	public String getMobile() {
		return mobile;
	}
	public void setMobile(String mobile) {
		this.mobile = mobile;
	}
	
	@Column(name = "email", length=50, unique=true, nullable=false)
	public String getEmail() {
		return email;
	}
	public void setEmail(String email) {
		this.email = email;
	}
	
	@Column(name = "status", columnDefinition="tinyint(1)", nullable=false)
	public Integer getStatus() {
		return status;
	}
	public void setStatus(Integer status) {
		this.status = status;
	}
	
	@ManyToOne ( cascade = { CascadeType.PERSIST, CascadeType.MERGE }, optional = true )
    @JoinColumn(name="role")
	public Role getRole() {
		return role;
	}
	public void setRole(Role role) {
		this.role = role;
	}
	
	@ManyToMany(cascade = { CascadeType.PERSIST, CascadeType.MERGE }, fetch = FetchType.LAZY)
	@JoinTable(name = "user_approvals", joinColumns = {
			@JoinColumn(name = "userid", nullable = false, updatable = false)}, inverseJoinColumns = {
			@JoinColumn(name = "approverid", nullable = false, updatable = false)})
	@JsonIgnore
	public List<User> getApprovers() {
		return approvers;
	}
	public void setApprovers(List<User> approvers) {
		this.approvers = approvers;
	}
	
	@ManyToMany(cascade = { CascadeType.PERSIST, CascadeType.MERGE }, fetch = FetchType.LAZY, mappedBy = "approvers")
    @JsonIgnore
    public List<User> getUsers() {
		return users;
	}
	public void setUsers(List<User> users) {
		this.users = users;
	}
	
	@Column(name = "approvaltype", columnDefinition="INT", nullable=false)
	public Integer getApprovalType() {
		return approvalType;
	}
	public void setApprovalType(Integer approvalType) {
		this.approvalType = approvalType;
	}
	
	@Transient
	@JsonIgnore
	public List<Long> getApproverList() {
		return approverList;
	}
	public void setApproverList(List<Long> approverList) {
		this.approverList = approverList;
	}
	
	@Column(name = "passwordstatus", length=50)
	public String getPasswordStatus() {
		return passwordStatus;
	}
	public void setPasswordStatus(String passwordStatus) {
		this.passwordStatus = passwordStatus;
	}
	
	@JsonIgnore
	@Column(name = "password1", length=50)
	public String getPassword1() {
		return password1;
	}
	public void setPassword1(String password1) {
		this.password1 = password1;
	}
	
	@JsonIgnore
	@Column(name = "password2", length=50)
	public String getPassword2() {
		return password2;
	}
	public void setPassword2(String password2) {
		this.password2 = password2;
	}
	
	@JsonIgnore
	@Column(name = "password3", length=50)
	public String getPassword3() {
		return password3;
	}
	public void setPassword3(String password3) {
		this.password3 = password3;
	}
	
	@Transient
	public List<User> getApproverstemp() {
		return approverstemp;
	}
	public void setApproverstemp(List<User> approverstemp) {
		this.approverstemp = approverstemp;
	}
	
}

        

Role.java

package com.nxl.auth.entities;

import java.util.List;

import javax.persistence.CascadeType;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.FetchType;
import javax.persistence.JoinColumn;
import javax.persistence.JoinTable;
import javax.persistence.ManyToMany;
import javax.persistence.NamedQueries;
import javax.persistence.NamedQuery;
import javax.persistence.OneToMany;
import javax.persistence.Table;
import javax.persistence.Transient;
import javax.xml.bind.annotation.XmlTransient;

import org.codehaus.jackson.annotate.JsonIgnore;
import org.codehaus.jackson.annotate.JsonIgnoreProperties;
import org.hibernate.annotations.Cache;
import org.hibernate.annotations.CacheConcurrencyStrategy;

import com.nxl.auth.api.AbstractEntity;

@Cache(usage = CacheConcurrencyStrategy.READ_WRITE, include = "all")
@Entity
@Table(name = "roles")
@NamedQueries({
	@NamedQuery(name="roles.fetchAll", query="SELECT instance from Role instance"),
	@NamedQuery(name="roles.fetchRoleByLevel", query="SELECT instance from Role instance where instance.level =:level"),
	@NamedQuery(name="roles.fetchRoleByName", query="SELECT instance from Role instance where instance.roleName =:name")
})
public class Role extends AbstractEntity {

	private static final long serialVersionUID = 1L;
	
	private String roleName;
	private List<Privilege> privileges ;
	private List<User> users;
	private String level;
	
	private List<Long> privilegeIds;
	
	
	@Column(name = "rolename", length=50, unique=true, nullable=false)
	public String getRoleName() {
		return roleName;
	}
	public void setRoleName(String roleName) {
		this.roleName = roleName;
	}
	
	@ManyToMany(fetch = FetchType.LAZY)
	@JoinTable(name = "roles_privs", joinColumns = { 
			@JoinColumn(name = "roleid") }, 
			inverseJoinColumns = { @JoinColumn(name = "privid") })
	public List<Privilege> getPrivileges() {
		return privileges;
	}
	public void setPrivileges(List<Privilege> privileges) {
		this.privileges = privileges;
	}
	
	@Transient
	public List<Long> getPrivilegeIds() {
		return privilegeIds;
	}
	public void setPrivilegeIds(List<Long> privilegeIds) {
		this.privilegeIds = privilegeIds;
	}
	
	@JsonIgnore
	@XmlTransient
	@OneToMany(fetch=FetchType.LAZY, mappedBy="role")
	public List<User> getUsers() {
		return users;
	}
	public void setUsers(List<User> users) {
		this.users = users;
	}
	
	@Column(name = "level")
	public String getLevel() {
		return level;
	}
	public void setLevel(String level) {
		this.level = level;
	}
	

}
        

users.jsp

<%@ taglib uri="http://displaytag.sf.net" prefix="display"%>
<%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core"%>
<%@ taglib prefix='fn' uri='http://java.sun.com/jsp/jstl/functions' %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/fmt" prefix="fmt" %>
<%@ taglib prefix="auth" uri="http://www.springframework.org/security/tags" %>
 <head>
 	<jsp:include page="/jsp/includes.jsp"></jsp:include>
 	<script type="text/javascript">
	 	$(document).ready(function(){
			
			$("#users-tab a").addClass("current");
			var rowsize_str ='<div id="tableRowSize" style="float: right;"><input type="text" class="row_size" class="small-txt-footer" value="${pageSize}"><input class="tableFooter row_size_submit" type="button" value="Go"></div>';
			$(rowsize_str).insertBefore($('.pagebanner')); 
	
			$(".addNew").live('click', function(){
				$("#edtHead").html("Add New User");
				$("#save-btn").val("Create");
				$("#id").val("");
				$("#userForm .inp").val('');
				$(".form-error").html('');
				$("#userForm .inp").css("border-color","#CCCCCC");
				
			});
			
			$(".editUser").live('click', function(){
				$("#edtHead").html("Update User");
				$("#save-btn").val("Update");
				var key = $(this).attr("key");
				$(".form-error").html('');
				$("#userForm .inp").css("border-color","#CCCCCC");
				$("#loadmsg label").html("Loading user data ..");
				$("#loadmsg").show();
				$("#approvers").val("");
				$.ajax({
					url: "<%=request.getContextPath() %>/users/find.htm?id="+key,
					type: 'GET',
					async:false,
					success: function(data){
						if(data!=null){
							console.log(data);
							$("#key").val(nullCheck(data.id));
							$("#id").val(nullCheck(data.id));
							$("#userid").val(nullCheck(data.userId));
							if(data.role != null) {
								$("#userType").val(nullCheck(data.role.id));
							}
							$("#username").val(nullCheck(data.userName));
							$("#mobile").val(nullCheck(data.mobile));
							$("#email").val(nullCheck(data.email));
							$("#apprType").val(nullCheck(data.approvalType));
							$("#status").val(nullCheck(data.status));
							if(data.role != null && data.approverstemp != null) {
								for(var i=0;i<data.approverstemp.length;i++){
									$("#approvers option[value='" + data.approverstemp[i].role.id + "']").prop("selected", true);
								}
							}
						}
						$("#loadmsg label").html("");
						$("#loadmsg").hide();
					}
				});
			});
			
			$(".deleteUser").live('click', function(){
				var key = $(this).attr("key");
				var user = $(this).attr("user");
	 			confirmBox('Do you want to delete user "'+user+'" ??',"><%=request.getContextPath() %>/users/delete.htm?id="+key);
			});
			
			$(".pwdReset").live('click', function(){
				var user = $(this).attr("user");
				var key = $(this).attr("key");
				 $("#dialog-message label" ).html('Do you want to reset the password for user "'+user+'" ??');
		 			$("#dialog-message" ).dialog({
		 				modal: true,
		 				buttons: {
		 					Yes: function() {
		 					$( this ).dialog( "close" );
			 					$.ajax({
									url: "<%=request.getContextPath() %>/users/reset.htm?id="+key,
									type: 'GET',
									async:false,
									success: function(data){
										if(data != null && data == true) {
											alertBox("Password has been reset successfully");
										} else {
											alertBox("Failed to reset the password");
										}
									}
								});
		 					},
		 					No: function() {
		 						$( this ).dialog( "close" );
		 					}
		 				}
		 			 });
			});
			
			$("#save-btn").live('click',function(){
	 			if(validate($("#userForm .inp")) == true) {
	 				if($("#save-btn").val() == "Create")	{
	 					$('#userForm').attr('action', '${pageContext.request.contextPath}/users/create.htm');
	 				}
	 				else	{
	 					$('#userForm').attr('action', '${pageContext.request.contextPath}/users/update.htm');
	 				}
		 			$("#userForm").trigger('submit');
	 			}
	 		});
			
			$("#apprType").live('change', function() {
				var type = $(this).val();
				getApprovers(type);
			});
			
		});
 	</script>
 </head>
 <body>
 	<jsp:include page="/jsp/header.jsp"></jsp:include>
	<div id="dialog-message" style="display:none;" title="Warning">
		<label>
			<span class="ui-icon ui-icon-circle-check" style="float:left; margin:0 7px 50px 0;"></span>
		</label>
	</div>
	<div class="content">
		<div class="in-header hidden" style="border:none;">
		<div>
		<div class="marg10 float-lft">
         	<form id="search" action="<%= request.getContextPath() %>/users/view.htm" method="GET">
				<input name="words" class="tgf-textbox" type="text" placeholder="Search Keywords" />
				<input class="go-btn custom_btn" type="submit" value="Go">
			</form>
		</div>
		<div class="marg10 float-rgt">
			<auth:authorize ifAnyGranted="ALL, NXLAUTH_ADMIN">
         		<div class="addNew float-lft tool-btn"><a   rel="nofollow">Create New</a></div>
         	</auth:authorize>
         	<c:if test="${fn:length(users) ge 1}">
	         	<img class="float-rgt"  id="excelExport"  />
			</c:if>
		</div>
		</div>
		</div>
		<div id="table-results">
			<c:catch var ="catchException">
				<display:table name="users" class="enableSearch" requestURI="/users/view.htm" export="true"  defaultsort="0" id="row" pagesize="${pageSize}" partialList="true" size="${total }" sort="external">
		            <display:setProperty name="export.excel.filename" value="Users.xls" />
		            <display:setProperty name="export.excel.export_amount" value="10"></display:setProperty>   
		            <display:setProperty name="basic.msg.empty_list" value="<span class='no-data'>No user data found</span>"> </display:setProperty>
		            <display:column property="userId" sortName="userId" sortable="true" title="User ID"></display:column>
		            <display:column property="userName" sortName="userName" sortable="true" title="Name"></display:column>
		            <display:column property="role.roleName" sortName="role.roleName" sortable="true" title="Role"></display:column>
		            <display:column value="${row.approvers[0].userId}" sortName="role.approvers.userId" sortable="true" title="Approver"></display:column>
		            <display:column property="mobile" sortName="mobile" sortable="true" title="Mobile"></display:column>
		            <display:column property="email" sortName="email" sortable="true" title="E-Mail"></display:column>
		           <c:choose>
			            <c:when test="${row.status eq 0 }">
			           		 <display:column style="color:green;font-weight:bold;" value="Active" sortName="status" sortable="true" title="Status"></display:column>
			            </c:when>
		           		<c:otherwise>
		           			<display:column style="color:green;font-weight:bold;" value="In Active" sortName="status" sortable="true" title="Status"></display:column>
		           		</c:otherwise>
		           </c:choose>
					<display:column property="changedBy" sortName="changedBy" sortable="true" title="Updated By"></display:column>
					<fmt:parseDate value="${row.changedOn}" type='both' timeStyle='long' dateStyle='short' var='parseDate' pattern="yyyy-MM-dd HH:mm:ss.S" />
			  		 <fmt:formatDate value='${parseDate}' type='both' timeStyle='long' dateStyle='short' var='dateFormat' pattern="yyyy-MM-dd HH:mm" />
                   <display:column value="${dateFormat}" sortName="changedOn" sortable="true" title="Updated On"></display:column>
              		 <auth:authorize ifAnyGranted="ALL, NXLAUTH_ADMIN">
		                <display:column media="html" title="Actions">
			                <div class="alloc actions">
			                		<img class="pwdReset"    />
		                			<img class="editBox editUser"   />
		                			<img class="deleteUser"    />
		                	</div>
		                </display:column>
               		</auth:authorize>
				</display:table>
				</c:catch>
					<c:if test = "${catchException != null}">
						<h1>${catchException}</h1>
					</c:if>
			</div>
	</div>
	
	<div id="createBox" style="display: none;">
			<form id="userForm" name="status" method="post" action="<%= request.getContextPath() %>/users/create.htm" >
		    <div class="popup-cont">
		        <div class="popup-box">
		            <div class="popup-head">
					    <label id="edtHead" class="label-1">Add New User</label>
					    <a  class="close" rel="nofollow"></a>
		            </div>
					        <div class="popup-content">
					        	<div class="general-form">
									<div class="dia-header">
										<input id="id" name="id" value="" type="hidden"/>
										<div class="gf-div">
											<h3 class="label-2">User ID</h3>
											<input id="userid" name="userId" datatype="alphanum_" attr="User ID" class="tgf-textbox inp" type="text"
												 maxlength="30">
												 <span class="form-error"></span>
										</div>
										<div class="gf-div">
											<h3 class="label-2">User Name</h3>
											<input id="username" name="userName" datatype="alphanumspace" attr="User Name" class="tgf-textbox inp" type="text"
												 maxlength="15">
												 <span class="form-error"></span>
										</div>
										<div class="gf-div">
											<h3 class="label-2">Role</h3>
											<select id="userType" name="role.id" datatype="num" attr="Role" class="tgf-textbox inp">
												<option value="">Select Role</option>
												<c:forEach items="${ roles }" var="role" varStatus="vrow">
													<option value="${ role.id }">${ role.roleName }</option>
												</c:forEach>
											</select>
											<span class="form-error"></span>
										</div>
										<div class="gf-div">
											<h3 class="label-2">Status</h3>
											<select id="status" name="status" datatype="num" attr="Status" class="tgf-textbox inp" >
												<option value="0">Active</option>
												<option value="1">Inactive</option>
											</select>
											<span class="form-error"></span>
										</div> 
										<div class="gf-div">
											<h3 class="label-2">Mobile</h3>
											<input id="mobile" name="mobile" datatype="mobile" attr="Mobile" class="tgf-textbox inp" type="text" maxlength="10">
											<span class="form-error"></span>
										</div>
										<div class="gf-div">
											<h3 class="label-2">Email</h3>
											<input id="email" name="email" datatype="email" attr="Email" class="tgf-textbox inp" type="text">
											<span class="form-error"></span>
										</div>
										<div class="gf-div">
											<h3 class="label-2">Approval Type</h3>
											<select id="apprType" name="approvalType" datatype="num" attr="Approval Type" class="tgf-textbox inp" >
												<option value="1">Role Based</option>
												<!-- <option value="2">User Based</option> -->
											</select>
											<span class="form-error"></span>
										</div> 
										<div class="gf-div">
											<h3 class="label-2">Approvers</h3>
											<select id="approvers" name="approverList" class="tgf-textbox inp" attr="Approvers" multiple="multiple">
												<c:forEach items="${ roles }" var="role" varStatus="vrow">
													<c:if test="${role.level ne 0}">
														<option value="${ role.id }">${ role.roleName }</option>
													</c:if>
												</c:forEach>
											</select>
											<span class="form-error"></span>
										</div>
									</div>
								</div>
					        </div>
					        <div class="popup-footer">
					        	<input id="save-btn" style="margin:0px;!important" class="choose_btn" type="button" value="Create" align="center" >
					        	<div id="loadmsg"><span class="popupload"></span><label></label></div>
					        </div>
		        </div>
		    </div>
        </form>
	</div>
	
</body>
<jsp:include page="/jsp/footer.jsp"></jsp:include>
 

The issue is during edit user we are fetching the roles information and user information in service implementation. For some users it is fetching user information. If I add new role and create a new user with
that role. If I want to edit the user it is not showing any user information in service implementation. null is available which is not useful for us.

Thank You very much for all the extended help.


Thanks and Regards,
G. Sathish Kumar