Space Invaders

[Alaric Mustoe]

ok so during the break I had to code some stuff for my project and I need help. This is the main class

package jforumanimationjunk;

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
import javax.swing.*;
import javax.swing.Timer;

/**
 *
 * @author mustoeal
 */
public class JForumAnimationJunk implements ActionListener, KeyListener {

    static final int FPS = 60;
    static final int TIMER = 1000 / FPS;
    static final int P_WIDTH = 500;
    static final int P_HEIGHT = 500;
    static final int O_WIDTH = 60;
    static final int O_HEIGHT = O_WIDTH / 3;
    int playerx = 400;
    int playery = 400;
    int playerbulletx = 200;
    int playerbullety = 200;
    int bulletx =100;
    int bullety = 100;
    static boolean playershot = false;
    int swoopx = 0;
    int swoopy = 0;
    boolean swoop = true;
    char key = 'g';
    Timer t = null;
    JFrame f = null;
    MyJPanel p = null;

    JForumAnimationJunk() {
        t = new Timer(TIMER, this);
        f = new JFrame();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.setTitle("SpaceInvaders");
        p = new MyJPanel();
        f.add(p);
        f.addKeyListener(this);

    }

    public void readimage(Graphics g) {

        int x = 50;    //width of the image
        int y = 50;   //height of the image

        Enemy[] enemies = new Enemy[6];
        Enemy[] enemies1 = new Enemy[6];

        for (int c = 0; c < enemies.length; c++) {
            enemies[c] = new Enemy("enemy 1.png");
            
            
            enemies1[c] = new Enemy("enemy 1.png");
      
        }
      
        

        Barrier[] barriers = new Barrier[3];

        for (int c = 0; c < barriers.length; c++) {

        }

        int barx = 30;
        int bary = 250;
        int barx1 = 200;
        int bary1 = 250;
        int barx2 = 350;
        int bary2 = 250;

        for (int c = 0; c < enemies.length; c++) {
            enemies[c].setPosition(50 * c, 75);
        }

        for (int d = 0; d < enemies.length; d++) {
            enemies1[d].setPosition(50 * d, 125);
        }
        for (int c = 0; c < enemies.length; c++) {
            drawImage(g, enemies[c].imageName, enemies[c].x + 100, enemies[c].y);

            for (int d = 0; d < enemies1.length; d++) {
                drawImage(g, enemies1[d].imageName, enemies1[d].x + 100, enemies1[d].y);
            }
           

        }
       
        BufferedImage image13 = null;
        File l = null;
        try {
            l = new File("barrier.png"); //image file path
            image13 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image13 = ImageIO.read(l);

            g.drawImage(image13, barx, bary, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image14 = null;
        File p = null;
        try {
            p = new File("barrier.png"); //image file path
            image14 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image14 = ImageIO.read(p);

            g.drawImage(image14, barx1, bary1, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image15 = null;
        File q = null;
        try {
            q = new File("barrier.png"); //image file path
            image15 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image15 = ImageIO.read(q);

            g.drawImage(image15, barx2, bary2, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }
        BufferedImage image16 = null;
        File n = null;
        try {
            n = new File("swoop.png"); //image file path
            image16 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image16 = ImageIO.read(n);

            g.drawImage(image16, swoopx, swoopy, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }

        
    }

    public static void main(String args[]) throws IOException {

        JForumAnimationJunk jfaj = new JForumAnimationJunk();
        jfaj.f.pack();
        jfaj.f.setVisible(true);
        jfaj.t.start();

    }

    public static void drawImage(Graphics g, String imageName, int x, int y) {
        BufferedImage image = null;
        try {
            image = ImageIO.read(new File(imageName));
        } catch (IOException e) {
            System.out.println("Image with name " + imageName + "not found!");
        }
        g.drawImage(image, x, y, null);
    }

    @Override
    public void actionPerformed(ActionEvent e) {
        switch (key) {

            case 'a':
                playerx--;    //key for left movement;

                break;
            case 'd':
                playerx++;    // key for right movement;
                break;

            case 'q':
                swoopx--;
                break;
            case 'e':
                swoopx++;

                break;
                      
            
            
            default:
                break;

        }
        //boundary checking
        if (playerx < 0) {
            playerx = 0;
        } else if (playerx > (P_WIDTH - O_WIDTH)) {
            playerx = P_WIDTH - O_WIDTH;
        }
        if (playery < 0) {
            playery = 0;
        } else if (playery > (P_HEIGHT - O_HEIGHT)) {
            playery = P_HEIGHT - O_HEIGHT;
        }
        if (swoopx < 0) {
            swoopx = 0;
        } else if (swoopx > (P_WIDTH - O_WIDTH)) {
            swoopx = P_WIDTH - O_WIDTH;
        }
        if (swoopy < 0) {
            swoopy = 0;
        } else if (swoopy > (P_HEIGHT - O_HEIGHT)) {
            swoopy = P_HEIGHT - O_HEIGHT;
        }

        p.repaint();
    }

    @Override
    public void keyPressed(KeyEvent k) {
        key = k.getKeyChar();  //read key for movement;
    }

    @Override
    public void keyReleased(KeyEvent k) {
        key = 'g'; //clears key to something not in the actionPerformed;

    }

    @Override
    public void keyTyped(KeyEvent k) {
        //intentionally left blank;
    }

    class MyJPanel extends JPanel {

        MyJPanel() {
            this.setPreferredSize(new Dimension(P_WIDTH, P_HEIGHT));
            this.setBackground(Color.BLACK);
        }

        @Override
        public void paintComponent(Graphics g) {

            g.setColor(Color.GREEN);
            super.paintComponent(g);

            g.fillOval(playerx, playery, O_WIDTH, O_HEIGHT);
            readimage(g);//read image
            
        }
    

    public void drop() {
        for (int c = 0; c < 10; c++) {
        bullety = bullety ++ ;   
        System.out.println("got here");
    }
}
}
}
    

This is the enemy class

package jforumanimationjunk;

import java.applet.Applet;
import java.awt.*;

public class Enemy extends Entity {

    private int positionX; //Center X coordinate
    private int positionY; //Bottom Y coordinate
    private int indexX; //The X index
    private int indexY; //The Y index 
    private int damage; //Damage to the enemy unit

    public Enemy(int startX, int startY, String imageName) {

        super(imageName);
        positionX = startX;
        positionY = startY;
        indexX = -1;
        indexY = -1;
        damage = 0;

    }

    public int getXPostion() {
        return positionX;
    }

    public int getYPosition() {
        return positionY;
    }

    /*Move the enemy units*/
    public void shiftXPosition(int increment) {
        positionX += increment;
    }

    public void shiftYPosition(int increment) {
        positionY += increment;
    }

    public int getXIndex() {
        return indexX;
    }

    public int getYIndex() {
        return indexY;
    }

    public void setIndex(int x, int y) {
        indexX = x;
        indexY = y;
    }

    /*Check if a location is within the hitbox*/
    public boolean contains(int x, int y) {
        if (x >= positionX && x <= positionX + 30) {
            return (y >= positionY && y <= positionY + 30);
        }
        return false;
    }

    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 0;
    }

    public void damage() {
        damage++;
    }

}
/*
 * @author Mustoe
 */

and this is the entity class

package jforumanimationjunk;

/**
 *
 * @author mustoeal
 */
public abstract class Entity {

    public int x;
    public int y;
    public final String imageName;

    public Entity(String imageName) {
        this.imageName = imageName;
    }

    public void setPosition(int x, int y) {
        this.x = x;
        this.y = y;
    }

    
}

So anyways I am stumped it is probably something easy but I can't see it.

[K. Tsang]

Wow space invaders fun fun!

So what you stumped on?

[Alaric Mustoe]

It has to do with the constructor within the Enemy class my array Enemies are the only things not working so ya.

[K. Tsang]

I see, your Enemy class constructor has 3 parameters. But when you use it in JForumAnimationJunk class (line 62), you pass in only 1 parm (the image), when it expects a int, int, String.

[Alaric Mustoe]

Ok now I have the problem of getting the enemies to move with this code I can't fix the errors regarding the move Saucer and move Enemies method.

package jforumanimationjunk;

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
import javax.swing.*;
import javax.swing.Timer;

/**
 *
 * @author mustoeal
 */
public class JForumAnimationJunk implements ActionListener, KeyListener {

    static final int FPS = 1;
    static final int TIMER = 1000 / FPS;
    static final int P_WIDTH = 500;
    static final int P_HEIGHT = 500;
    static final int O_WIDTH = 60;
    static final int O_HEIGHT = O_WIDTH / 3;
    int playerx = 400;
    int playery = 400;
    int playerbulletx = 200;
    int playerbullety = 200;
    int bulletx = 100;
    int bullety = 100;
    static boolean playershot = false;
    int saucerx = 0;
    int saucery = 0;
    boolean swoop = true;
    char key = 'g';
    Timer t = null;
    JFrame f = null;
    MyJPanel p = null;

    Enemy[] enemies;

    JForumAnimationJunk() {
        t = new Timer(TIMER, this);
        f = new JFrame();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.setTitle("SpaceInvaders");
        p = new MyJPanel();
        f.add(p);
        f.addKeyListener(this);
        System.out.printf("a");
        //ActionListener listen = new ActionListener() {
        enemies = new Enemy[12];
        for (int c = 0; c < enemies.length; c++) {
            if (c < 6) {
                enemies[c] = new Enemy(50+ (c*50), 50, "enemy 1.png");
            } else {
                enemies[c] = new Enemy(50 + ((c-6)*50), 100, "enemy 1.png");
            }
        }
    }

    public void readimage(Graphics g) {

        int x = 50;    //width of the image
        int y = 50;   //height of the image
        int startX = 50;
        int startY = 100;

        Barrier[] barriers = new Barrier[3];

        for (int c = 0; c < barriers.length; c++) {

        }

        int barx = 30;
        int bary = 250;
        int barx1 = 200;
        int bary1 = 250;
        int barx2 = 350;
        int bary2 = 250;

        for (int c = 0; c < enemies.length; c++) {
            enemies[c].setPosition(50 * c, 75);
        }

        for (int c = 0; c < enemies.length; c++) {
            drawImage(g, enemies[c].imageName, enemies[c].x1, enemies[c].y1);
        }

        BufferedImage image13 = null;
        File l = null;
        try {
            l = new File("barrier.png"); //image file path
            image13 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image13 = ImageIO.read(l);

            g.drawImage(image13, barx, bary, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image14 = null;
        File p = null;
        try {
            p = new File("barrier.png"); //image file path
            image14 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image14 = ImageIO.read(p);

            g.drawImage(image14, barx1, bary1, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image15 = null;
        File q = null;
        try {
            q = new File("barrier.png"); //image file path
            image15 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image15 = ImageIO.read(q);

            g.drawImage(image15, barx2, bary2, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }
        BufferedImage image16 = null;
        File n = null;
        try {
            n = new File("swoop.png"); //image file path
            image16 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image16 = ImageIO.read(n);

            g.drawImage(image16, saucerx, saucery, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }

    }

    public static void main(String args[]) throws IOException {

        JForumAnimationJunk jfaj = new JForumAnimationJunk();
        jfaj.f.pack();
        jfaj.f.setVisible(true);
        jfaj.t.start();

    }

    public static void drawImage(Graphics g, String imageName, int x, int y) {
        BufferedImage image = null;
        try {
            image = ImageIO.read(new File(imageName));
        } catch (IOException e) {
            System.out.println("Image with name " + imageName + "not found!");
        }
        g.drawImage(image, x, y, null);
    }

    @Override
    public void actionPerformed(ActionEvent e) {
        switch (key) {

            case 'a':
                playerx--;    //key for left movement;

                break;
            case 'd':
                playerx++;    // key for right movement;
                break;

            case 'q':
                saucerx--;
                break;
            case 'e':
                saucerx++;

                break;

            default:
                break;

        }
        //boundary checking
        if (playerx < 0) {
            playerx = 0;
        } else if (playerx > (P_WIDTH - O_WIDTH)) {
            playerx = P_WIDTH - O_WIDTH;
        }
        if (playery < 0) {
            playery = 0;
        } else if (playery > (P_HEIGHT - O_HEIGHT)) {
            playery = P_HEIGHT - O_HEIGHT;
        }
        if (saucerx < 0) {
            saucerx = 0;
        } else if (saucerx > (P_WIDTH - O_WIDTH)) {
            saucerx = P_WIDTH - O_WIDTH;
        }
        if (saucery < 0) {
            saucery = 0;
        } else if (saucery > (P_HEIGHT - O_HEIGHT)) {
            saucery = P_HEIGHT - O_HEIGHT;
        }

        p.repaint();
    }

    @Override
    public void keyPressed(KeyEvent k) {
        key = k.getKeyChar();  //read key for movement;
    }

    @Override
    public void keyReleased(KeyEvent k) {
        key = 'g'; //clears key to something not in the actionPerformed;

    }

    @Override
    public void keyTyped(KeyEvent k) {
        //intentionally left blank;
    }

    public void moveEnemies(ActionEvent evt, int[]) {
        for (int c = 0; c < 6; c++) {
            enemies[c].shiftXPosition(10);
            enemies[c].shiftXPosition(10);
            
        }
    public void moveSaucer(){
     boolean move = true;
     while(move = true){
     Saucer.shiftXPositionp(20);
     Saucer.shiftXPositionn(20);
     
     }
    }
        
    
    
    

    class MyJPanel extends JPanel {

        MyJPanel() {
            this.setPreferredSize(new Dimension(P_WIDTH, P_HEIGHT));
            this.setBackground(Color.BLACK);
        }

        @Override
        public void paintComponent(Graphics g) {

            g.setColor(Color.GREEN);
            super.paintComponent(g);

            g.fillOval(playerx, playery, O_WIDTH, O_HEIGHT);
            readimage(g);//read image

        }

    }
}

[Matt Cartwright]

hmm, the saucer works on my machine

package jforumanimationjunk;


import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyAdapter;
import java.awt.event.KeyEvent;
// import java.awt.event.KeyListener;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
import javax.swing.*;


/**
 * 
 * @author mustoeal
 */
public class JForumAnimationJunk implements ActionListener // , KeyListener
{

   static final int FPS           = 60;         // need for speed :D

   static final int TIMER         = 1000 / FPS;

   static final int P_WIDTH       = 500;

   static final int P_HEIGHT      = 500;

   static final int O_WIDTH       = 60;

   static final int O_HEIGHT      = O_WIDTH / 3;

   int              playerx       = 400;

   int              playery       = 400;

   int              playerbulletx = 200;

   int              playerbullety = 200;

   int              bulletx       = 100;

   int              bullety       = 100;

   static boolean   playershot    = false;

   int              saucerx       = 0;

   int              saucery       = 0;

   boolean          swoop         = true;

   char             key           = 'g';

   Timer            t             = null;

   JFrame           f             = null;

   MyJPanel         p             = null;

   Enemy[]          enemies;

   private Swoop    saucer        = null;


   JForumAnimationJunk()
   {
      super();

      this.saucer = new Swoop(0, 10, P_WIDTH /* - O_WIDTH */, 10);

      t = new Timer(TIMER, this);
      f = new JFrame();
      f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
      f.setTitle("SpaceInvaders");
      p = new MyJPanel();
      f.add(p);

      // f.addKeyListener(this);
      f.addKeyListener(new MyKeyListener());

      System.out.printf("a");
      // ActionListener listen = new ActionListener() {
      enemies = new Enemy[12];
      for ( int c = 0; c < enemies.length; c++ )
      {
         if ( c < 6 )
         {
            enemies[c] = new Enemy(50 + ( c * 50 ), 50, "enemy 1.png");
         }
         else
         {
            enemies[c] = new Enemy(50 + ( ( c - 6 ) * 50 ), 100, "enemy 1.png");
         }
      }
   }

   public void readimage( Graphics g )
   {

      int x = 50; // width of the image
      int y = 50; // height of the image
      int startX = 50;
      int startY = 100;

      // Barrier[] barriers = new Barrier[3];
      //
      // for (int c = 0; c < barriers.length; c++) {
      //
      // }

      int barx = 30;
      int bary = 250;
      int barx1 = 200;
      int bary1 = 250;
      int barx2 = 350;
      int bary2 = 250;

      for ( int c = 0; c < enemies.length; c++ )
      {
         enemies[c].setPosition(50 * c, 75);
      }

      for ( int c = 0; c < enemies.length; c++ )
      {
         drawImage(g, enemies[c].imageName, enemies[c].x, enemies[c].y);
      }

      BufferedImage image13 = null;
      File l = null;
      try
      {
         l = new File("barrier.png"); // image file path
         image13 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
         image13 = ImageIO.read(l);

         g.drawImage(image13, barx, bary, null);
      } catch( IOException e )
      {
         System.out.println("Error: " + e);
      }
      BufferedImage image14 = null;
      File p = null;
      try
      {
         p = new File("barrier.png"); // image file path
         image14 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
         image14 = ImageIO.read(p);

         g.drawImage(image14, barx1, bary1, null);
      } catch( IOException e )
      {
         System.out.println("Error: " + e);
      }
      BufferedImage image15 = null;
      File q = null;
      try
      {
         q = new File("barrier.png"); // image file path
         image15 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
         image15 = ImageIO.read(q);

         g.drawImage(image15, barx2, bary2, null);
      } catch( IOException e )
      {
         System.out.println("Error: " + e);

      }

      // no longer used
      // BufferedImage image16 = null;
      // File n = null;
      // try
      // {
      // n = new File("swoop.png"); // image file path
      // image16 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
      // image16 = ImageIO.read(n);
      //
      // g.drawImage(image16, saucerx, saucery, null);
      // } catch( IOException e )
      // {
      // System.out.println("Error: " + e);
      //
      // }

   }

   public static void main( String args[] ) throws IOException
   {

      JForumAnimationJunk jfaj = new JForumAnimationJunk();
      jfaj.f.pack();
      jfaj.f.setVisible(true);
      jfaj.t.start();

   }

   public static void drawImage( Graphics g, String imageName, int x, int y )
   {
      BufferedImage image = null;
      try
      {
         image = ImageIO.read(new File(imageName));
      } catch( IOException e )
      {
         System.out.println("Image with name " + imageName + "not found!");
      }
      g.drawImage(image, x, y, null);
   }

   @Override
   public void actionPerformed( ActionEvent e )
   {
      // whenever the timer calls this method
      this.saucer.move();

      // this dog won't hunt
      switch( key )
      {

      case 'a':
         playerx--; // key for left movement;

         break;
      case 'd':
         playerx++; // key for right movement;
         break;

      // no longer used
      // case 'q':
      // saucerx--;
      // break;
      // case 'e':
      // saucerx++;
      //
      // break;

      default:
         break;

      }
      // boundary checking
      if ( playerx < 0 )
      {
         playerx = 0;
      }
      else if ( playerx > ( P_WIDTH - O_WIDTH ) )
      {
         playerx = P_WIDTH - O_WIDTH;
      }
      if ( playery < 0 )
      {
         playery = 0;
      }
      else if ( playery > ( P_HEIGHT - O_HEIGHT ) )
      {
         playery = P_HEIGHT - O_HEIGHT;
      }

      // no longer used
      // if ( saucerx < 0 )
      // {
      // saucerx = 0;
      // }
      // else if ( saucerx > ( P_WIDTH - O_WIDTH ) )
      // {
      // saucerx = P_WIDTH - O_WIDTH;
      // }
      // if ( saucery < 0 )
      // {
      // saucery = 0;
      // }
      // else if ( saucery > ( P_HEIGHT - O_HEIGHT ) )
      // {
      // saucery = P_HEIGHT - O_HEIGHT;
      // }

      p.repaint();
   }

   // no longer used
   // @Override
   // public void keyPressed( KeyEvent k )
   // {
   // key = k.getKeyChar(); // read key for movement;
   // }
   //
   // @Override
   // public void keyReleased( KeyEvent k )
   // {
   // key = 'g'; // clears key to something not in the actionPerformed;
   //
   // }
   //
   // @Override
   // public void keyTyped( KeyEvent k )
   // {
   // // intentionally left blank;
   // }

   public void moveEnemies( ActionEvent evt/* , int[] */)
   {
      for ( int c = 0; c < 6; c++ )
      {
         enemies[c].shiftXPosition(10);
         enemies[c].shiftXPosition(10);

      }
   }


   // unused
   // public void moveSaucer()
   // {
   // boolean move = true;
   // while(move = true){
   // Saucer.shiftXPositionp(20);
   // Saucer.shiftXPositionn(20);
   // }

   class MyJPanel extends JPanel
   {

      MyJPanel()
      {
         this.setPreferredSize(new Dimension(P_WIDTH, P_HEIGHT));
         this.setBackground(Color.BLACK);
      }

      @Override
      public void paintComponent( Graphics g )
      {

         g.setColor(Color.GREEN);
         super.paintComponent(g);

         if ( saucer.isVisible() )
         {
            g.drawImage(saucer.getImage(), saucer.getX(), saucer.getY(), this);
         }

         g.fillOval(playerx, playery, O_WIDTH, O_HEIGHT);
         readimage(g);// read image

         Toolkit.getDefaultToolkit().sync();
         g.dispose();
      }
   }


   public abstract class Sprite extends KeyAdapter
   {

      private boolean visible = false;

      private int     x       = -1;

      private int     y       = -1;

      private int     dx      = -1;

      private int     dy      = -1;

      private int     minX    = -1;

      private int     minY    = -1;

      private int     maxX    = -1;

      private int     maxY    = -1;

      private int     width   = -1;

      private int     height  = -1;


      public Sprite( final int minX,
                     final int minY,
                     final int maxX,
                     final int maxY )
      {
         super();
         this.minX = minX;
         this.minY = minY;
         this.maxX = maxX;
         this.maxY = maxY;
         this.x = this.minX;
         this.y = this.minY;
      }

      protected final void setDeltaX( final int dx )
      {
         this.dx = dx;
      }

      protected final void setDeltaY( final int dy )
      {
         this.dy = dy;
      }

      public void move()
      {
         this.x += this.dx;
         if ( this.x <= this.minX ) this.x = this.minX;
         if ( this.x >= this.maxX ) this.x = this.maxX;

         this.y += this.dy;
         if ( this.y <= this.minY ) this.y = this.minY;
         if ( this.y >= this.maxY ) this.y = this.maxY;
      }

      public final void setWidth( final int width )
      {
         this.width = width;
      }

      public final void setHeight( final int height )
      {
         this.height = height;
      }

      public final int getWidth()
      {
         return this.width;
      }

      public final int getHeight()
      {
         return this.height;
      }

      public final void setVisible( final boolean visible )
      {
         this.visible = visible;
      }

      public final boolean isVisible()
      {
         return this.visible;
      }

      public final int getX()
      {
         return this.x;
      }

      public final int getY()
      {
         return this.y;
      }

   }


   public abstract class ImageSprite extends Sprite
   {

      private Image image = null;


      public ImageSprite( final int minX,
                          final int minY,
                          final int maxX,
                          final int maxY )
      {
         super(minX, minY, maxX, maxY);
      }

      public final void setImage( final Image image )
      {
         this.image = image;
      }

      public final void setImage( final ImageIcon imageIcon )
      {
         super.setHeight(imageIcon.getIconHeight());
         super.setWidth(imageIcon.getIconWidth());
         this.setImage(imageIcon.getImage());
      }

      public final Image getImage()
      {
         return this.image;
      }
   }


   public class Swoop extends ImageSprite
   {

      public Swoop( final int minX,
                    final int minY,
                    final int maxX,
                    final int maxY )
      {
         super(minX, minY, maxX, maxY);
         super.setImage(new ImageIcon("swoop.png"));
      }

      @Override
      public final void keyPressed( final KeyEvent evt )
      {
         int key = evt.getKeyCode();

         // any key to make it visible
         if ( !super.isVisible() ) super.setVisible(true);

         if ( key == KeyEvent.VK_Q )
         {
            super.setDeltaX(-2);
         }

         if ( key == KeyEvent.VK_E )
         {
            super.setDeltaX(2);
         }
      }

      @Override
      public final void keyReleased( final KeyEvent evt )
      {
         int key = evt.getKeyCode();

         if ( key == KeyEvent.VK_Q )
         {
            super.setDeltaX(0);
         }

         if ( key == KeyEvent.VK_E )
         {
            super.setDeltaX(0);
         }
      }

   }


   // only override what we are actually using
   private class MyKeyListener extends KeyAdapter
   {

      @Override
      public void keyReleased( final KeyEvent evt )
      {
         saucer.keyReleased(evt);
      }

      @Override
      public void keyPressed( final KeyEvent evt )
      {
         saucer.keyPressed(evt);
      }
   }

}

maybe you should get some IDE and structure your code???
HTH
Matt

[Alaric Mustoe]

I think you misunderstand but thanks for the code I tried it out i would like the saucer to move without human input so move automatically.

Thanks again

[Dave Tolls]

Where do you actually move the saucer?
I can't see that (offhand) in the actionPerformed.

[Matt Cartwright]

@Dave
that is correct,

@Override
   public void actionPerformed( ActionEvent e )
   {
      // whenever the timer calls this method
      this.saucer.move();
   ...
   }

is called by the timer and in the Sprite's move() method we do the boundary checking after adding the deltas from key events..

@Alaric
there were key events (q &e) defined for the saucer, that's what I implemented....
just take it as an example and use it for your laser cannon.
The saucer isn't visible in the beginning of the game and scrolls from left (off) to right off.
So the minX for it would need to be adjusted for that.
Why not have a counter incremented in in actionPerformed() that triggers the appearance of the saucer?
I think you got the idea...

HTH
Matt

[Alaric Mustoe]

Ok so I have moving enemies now I have the question of shooting using keybinding.
help?

package jforumanimationjunk;



/**
 *
 * @author Mustoe
 */
public class shot extends Entity {
   
    public shot(int startX, int startY,String imageName) {
        super(imageName);
        x1 = startX;
        y1 = startY;
    }
public int getXPosition() {
        return x1;
    }

    public int getYPosition() {
        return y1;
    }

    /*Move the enemy units*/
    public void shiftYPosition(int increment) {
        x1 += increment;
    
    
    }

    
}

shot

package jforumanimationjunk;

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
import javax.swing.*;
import javax.swing.Timer;

/**
 *
 * @author mustoeal
 */
public class JForumAnimationJunk implements ActionListener, KeyListener {

    static final int FPS = 5;
    static final int TIMER = 1000 / FPS;
    static final int P_WIDTH = 700;
    static final int P_HEIGHT = 700;
    static final int O_WIDTH = 60;
    static final int O_HEIGHT = O_WIDTH / 3;
    int playerx = 600;
    int playery = 600;
    int playerbulletx = 200;
    int playerbullety = 200;
    int bulletx = 100;
    int bullety = 100;
    static boolean playershot = false;
    int saucerx = 0;
    int saucery = 0;

    char key = 'g';
    Timer t = null;
    JFrame f = null;
    MyJPanel p = null;

    Enemy[] enemies;
    Saucer saucer1;
    shot bullet;

    JForumAnimationJunk() {
        t = new Timer(TIMER, this);
        t.setActionCommand("timer tick");
        f = new JFrame();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.setTitle("SpaceInvaders");
        p = new MyJPanel();
        f.add(p);
        f.addKeyListener(this);
        System.out.printf("a");
        //ActionListener listen = new ActionListener() {
        enemies = new Enemy[12];
        saucer1 = new Saucer(0, 0, "swoop.png");
        //Create Enemies
        for (int c = 0; c < enemies.length; c++) {
            if (c < 6) {
                enemies[c] = new Enemy(100 + (c * 50), 50, "enemy 1.png");
            } else {
                enemies[c] = new Enemy(50 + ((c - 6) * 50), 100, "enemy 1.png");
            }
        }

        //Create Saucer
    }

    public void readimage(Graphics g) {

        int x = 50;    //width of the image
        int y = 50;   //height of the image
        int startX = 50;
        int startY = 100;

        Barrier[] barriers = new Barrier[3];

        for (int c = 0; c < barriers.length; c++) {

        }

        int barx = 50;
        int bary = 400;
        int barx1 = 250;
        int bary1 = 400;
        int barx2 = 500;
        int bary2 = 400;
//sets position of enemies
        for (int c = 0; c < enemies.length; c++) {
            drawImage(g, enemies[c].imageName, enemies[c].x1, enemies[c].y1);
        }
//draws barriers
        BufferedImage image13 = null;
        File l = null;
        try {
            l = new File("barrier.png"); //image file path
            image13 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image13 = ImageIO.read(l);

            g.drawImage(image13, barx, bary, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image14 = null;
        File p = null;
        try {
            p = new File("barrier.png"); //image file path
            image14 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image14 = ImageIO.read(p);

            g.drawImage(image14, barx1, bary1, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image15 = null;
        File q = null;
        try {
            q = new File("barrier.png"); //image file path
            image15 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image15 = ImageIO.read(q);

            g.drawImage(image15, barx2, bary2, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }
        BufferedImage image16 = null;
        File n = null;
        try {
            n = new File("swoop.png"); //image file path
            image16 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image16 = ImageIO.read(n);

            g.drawImage(image16, saucer1.x1, saucer1.y1, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }

    }

    public static void main(String args[]) throws IOException {
//main
        JForumAnimationJunk jfaj = new JForumAnimationJunk();
        jfaj.f.pack();
        jfaj.f.setVisible(true);
        jfaj.t.start();

    }

    public static void drawImage(Graphics g, String imageName, int x, int y) {
       //drawing image
        BufferedImage image = null;
        try {
            image = ImageIO.read(new File(imageName));
        } catch (IOException e) {
            System.out.println("Image with name " + imageName + "not found!");
        }
        g.drawImage(image, x, y, null);
    }

    @Override
    //enemy movement
    public void actionPerformed(ActionEvent e) {
        if (e.getActionCommand().equals("timer tick")) {
            System.out.println("Timer has ticked");
            for (int c = 0; c < enemies.length; c++) {

                System.out.println("Move enemy");
                enemies[c].shiftXPosition(5);
                enemies[c].shiftXPosition(-1);
               
                System.out.println("Enemy " + c + " at: x: " + enemies[c].x1 + " y: " + enemies[c].y1);
            }

            saucer1.shiftXPositionp(10);
            saucer1.shiftXPositionn(-5);
            p.repaint();
        }
        switch (key) {

            case 'a':
                playerx--;    //key for left movement;

                break;
            case 'd':
                playerx++;    // key for right movement;
                break;

            
            default:
                break;

        }
        //boundary checking
        if (playerx < 0) {
            playerx = 0;
        } else if (playerx > (P_WIDTH - O_WIDTH)) {
            playerx = P_WIDTH - O_WIDTH;
        }
        if (playery < 0) {
            playery = 0;
        } else if (playery > (P_HEIGHT - O_HEIGHT)) {
            playery = P_HEIGHT - O_HEIGHT;
        }
        if (saucer1.x1 < 0) {
            saucer1.x1 = 0;
        } else if (saucer1.x1 > (P_WIDTH - O_WIDTH)) {
            saucer1.x1 = P_WIDTH - O_WIDTH;
        }
        if (saucer1.y1 < 0) {
            saucer1.y1 = 0;
        } else if (saucer1.y1 > (P_HEIGHT - O_HEIGHT)) {
            saucer1.y1 = P_HEIGHT - O_HEIGHT;
        }
        if (enemies.length < 6) {

        } else if (enemies.length > (P_WIDTH - O_WIDTH)) {

        }
    }

    @Override
    public void keyPressed(KeyEvent k) {
        key = k.getKeyChar();  //read key for movement;
        if (key == KeyEvent.VK_SPACE) {
          drawImage(g, "shot.png", 600, 600);
           //shooting
            for (int c = 0; c < 6; c++) {
                bullet.shiftYPosition(20);
        }
        }
    }

    @Override
    public void keyReleased(KeyEvent k) {
        key = 'g'; //clears key to something not in the actionPerformed;
        if (key == KeyEvent.VK_Q) {
         System.out.println("shoot");
           
            }
        }
    

    @Override
    public void keyTyped(KeyEvent k) {
        //intentionally left blank;
    }
//moves enemies

    class MyJPanel extends JPanel {
//draws

        MyJPanel() {
            this.setPreferredSize(new Dimension(P_WIDTH, P_HEIGHT));
            this.setBackground(Color.BLACK);
        }

        @Override
        public void paintComponent(Graphics g) {

            g.setColor(Color.GREEN);
            super.paintComponent(g);

            g.fillOval(playerx, playery, O_WIDTH, O_HEIGHT);
            readimage(g);//read image

        }

    }
}

[Alaric Mustoe]

ok so then I need help with collision detection for my barriers and enemies along with the player can you help?

public class Barrier extends Entity {
    private int damage;
    public Barrier(String imageName) {
        super(imageName);
  
    
    
    }
public boolean contains(int x, int y) {
  //hit box     
    if (x >= x1 && x <= x1 + 30) {
            return (y >= y1 && y <= y1 + 30);
        }
        return false;
    }

    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 3;
    }

    public void damage() {
        damage++;
    }

}

this is the barrier

import java.awt.*;

public class Enemy extends Entity {

    private int damage; //Damage to the enemy unit

    public Enemy(int startX, int startY, String imageName) {

        super(imageName);
        x1 = startX;
        y1 = startY;

        damage = 0;

    }

    public int getXPosition() {
        return x1;
    }

    public int getYPosition() {
        return y1;
    }

    /*Move the enemy units*/
    public void shiftXPosition(int increment) {
        x1 += increment;
    }
    public void shiftYPosition(int increment) {
        y1 += increment;
    }

    /*Check if a location is within the hitbox*/
    public boolean contains(int x, int y) {
        if (x >= x1 && x <= x1 + 30) {
            return (y >= y1 && y <= y1 + 30);
        }
        return false;
    }

    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 0;
    }

    public void damage() {
        damage++;
    }

}
/*
 * @author Mustoe
 */

enemy