Space Invaders Collision detection

[Alaric Mustoe]

So I have some code all of it works but I can't figure this one out.

package jforumanimationjunk;

import java.awt.*;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.awt.event.KeyEvent;
import java.awt.event.KeyListener;
import java.awt.image.BufferedImage;
import java.io.File;
import java.io.IOException;
import javax.imageio.ImageIO;
import javax.swing.*;
import javax.swing.Timer;

/**
 *
 * @author mustoeal
 */
public class JForumAnimationJunk implements ActionListener, KeyListener {

    static final int FPS = 60;
    static final int TIMER = 1000 / FPS;
    static final int P_WIDTH = 700;
    static final int P_HEIGHT = 700;
    static final int O_WIDTH = 60;
    static final int O_HEIGHT = O_WIDTH / 3;
    static int saucerdirection = 1;
    static int enemiesdirection = 1;
    
    int playerX = 600;
    int playerY = 600;
    
    
    shot bullet = new shot(-100, -100, "shot.png");

    static boolean playershot = false;
    int saucerx = 0;
    int saucery = 0;
    static boolean doShot = false;

    char key = 'g';
    Timer t;
    JFrame f;
    MyJPanel p;

    Enemy[] enemies;
    Saucer saucer1;

    JForumAnimationJunk() {
        t = new Timer(TIMER, this);
        t.setActionCommand("timer tick");
        f = new JFrame();
        f.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
        f.setTitle("SpaceInvaders");
        p = new MyJPanel();
        f.add(p);
        f.addKeyListener(this);
        System.out.printf("a");
        //ActionListener listen = new ActionListener() {
        enemies = new Enemy[12];
        saucer1 = new Saucer(0, 0, "swoop.png");
        //Create Enemies
        for (int c = 0; c < enemies.length; c++) {
            if (c < 6) {
                enemies[c] = new Enemy(100 + (c * 50), 50, "enemy 1.png");
            } else {
                enemies[c] = new Enemy(50 + ((c - 6) * 50), 100, "enemy 1.png");
            }
        }

        //Create Saucer
    }

    public void readimage(Graphics g) {

        int x = 50;    //width of the image
        int y = 50;   //height of the image
        int startX = 50;
        int startY = 100;

        Barrier[] barriers = new Barrier[3];

        for (int c = 0; c < barriers.length; c++) {

        }

        int barx = 50;
        int bary = 400;
        int barx1 = 250;
        int bary1 = 400;
        int barx2 = 500;
        int bary2 = 400;
//sets position of enemies
        for (int c = 0; c < enemies.length; c++) {
            drawImage(g, enemies[c].imageName, enemies[c].x, enemies[c].y);
        }
//draws barriers
        BufferedImage image13 = null;
        File l = null;
        try {
            l = new File("barrier.png"); //image file path
            image13 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image13 = ImageIO.read(l);

            g.drawImage(image13, barx, bary, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image14 = null;
        File p = null;
        try {
            p = new File("barrier.png"); //image file path
            image14 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image14 = ImageIO.read(p);

            g.drawImage(image14, barx1, bary1, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
        BufferedImage image15 = null;
        File q = null;
        try {
            q = new File("barrier.png"); //image file path
            image15 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image15 = ImageIO.read(q);

            g.drawImage(image15, barx2, bary2, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);

        }
        BufferedImage image16 = null;
        File n = null;
        try {
            n = new File("swoop.png"); //image file path
            image16 = new BufferedImage(x, y, BufferedImage.TYPE_INT_ARGB);
            image16 = ImageIO.read(n);

            g.drawImage(image16, saucer1.x, saucer1.y, null);
        } catch (IOException e) {
            System.out.println("Error: " + e);
        }
    }

    public static void main(String args[]) throws IOException {
//main
        JForumAnimationJunk jfaj = new JForumAnimationJunk();
        jfaj.f.pack();
        jfaj.f.setVisible(true);
        jfaj.t.start();

    }

    public static void drawImage(Graphics g, String imageName, int x, int y) {
        //drawing image
        BufferedImage image = null;
        try {
            image = ImageIO.read(new File(imageName));
        } catch (IOException e) {
            System.out.println("Image with name " + imageName + "not found!");
        }
        g.drawImage(image, x, y, null);
    }

    @Override
    //enemy movement
    public void actionPerformed(ActionEvent e) {

        if (e.getActionCommand().equals("timer tick")) {
            System.out.println("Timer has ticked");

            for (int c = 0; c < enemies.length; c++) {

                System.out.println("Move enemy");

                enemies[c].shiftXPosition(1, enemiesdirection);
                //enemies[c].shiftXPosition(4,1);
                //enemies[c].shiftXPosition(-5,-1);
                //enemies[c].shiftXPosition(-4,-1);

                System.out.println("Enemy " + c + " at: x: " + enemies[c].x + " y: " + enemies[c].y);
            }
            for (int c = 0; c < 4; c++) {
                saucer1.shiftXPosition(1, saucerdirection);
                //saucer1.shiftXPosition(4,1);
                //saucer1.shiftXPosition(-5,-1);
                //saucer1.shiftXPosition(-4,-1);

                p.repaint();
            }

            bullet.y -= 10;
        }

        switch (key) {

            case 'a':
                playerX--;    //key for left movement;

                break;
            case 'd':
                playerX++;    // key for right movement;
                break;

            default:
                break;

        }
        //boundary checking
        if (playerX < 0) {
            playerX = 0;
        } else if (playerX > (P_WIDTH - O_WIDTH)) {
            playerX = P_WIDTH - O_WIDTH;
        }
        if (playerY < 0) {
            playerY = 0;
        } else if (playerY > (P_HEIGHT - O_HEIGHT)) {
            playerY = P_HEIGHT - O_HEIGHT;
        }
        if (saucer1.x < 0) {
            saucerdirection *= -1;
        } else if (saucer1.x > (P_WIDTH - O_WIDTH)) {
            //saucer1.x = P_WIDTH - O_WIDTH;
            saucerdirection *= -1;
        }
        if (saucer1.y < 0) {
            saucer1.y = 0;
        } else if (saucer1.y > (P_HEIGHT - O_HEIGHT)) {
            saucer1.y = P_HEIGHT - O_HEIGHT;
        }

        if (enemies[0].getXPosition() + 250 > P_WIDTH - O_WIDTH) {
            System.out.println("Enemies at the end.");
            enemiesdirection *= -1;
        } else if (enemies[0].getXPosition() < 50) {
            enemiesdirection *= -1;
        }
    }

    public void keyPressed(KeyEvent k) {

        key = k.getKeyChar();  //read key for movement;
        if (key == KeyEvent.VK_SPACE) {
            if (bullet.y < -50) {
                bullet.setPosition(playerX, playerY);
            }
        }
    }

    @Override
    public void keyReleased(KeyEvent k) {
        key = 'g'; //clears key to something not in the actionPerformed;
        if (key == KeyEvent.VK_SPACE) {
            System.out.println("shoot");

        }
    }

    @Override
    public void keyTyped(KeyEvent k) {
        //intentionally left blank;
    }

  
   
//moves enemies

    /*@Override
     public void keyPressed(KeyEvent e) {
     throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
     }
     */
    class MyJPanel extends JPanel {

//draws
        MyJPanel() {
            this.setPreferredSize(new Dimension(P_WIDTH, P_HEIGHT));
            this.setBackground(Color.BLACK);
        }

        @Override
        public void paintComponent(Graphics g) {

            g.setColor(Color.GREEN);
            super.paintComponent(g);

            g.fillOval(playerX, playerY, O_WIDTH, O_HEIGHT);
            readimage(g);//read image

            drawImage(g, bullet.imageName, bullet.x, bullet.y);
            
        }
    }

}

Along with the objects

package jforumanimationjunk;

import java.awt.*;

public class Saucer extends Entity {

    private int damage;

    public Saucer(int startx, int starty, String imageName) {
        
        super(imageName);
        x = startx;
        y = starty;
        damage = 0;
    }

    public int getXPosition() {
        return x;
    }
//shifts position positive
    public void shiftXPosition(int increment, int direction) {
       x += increment*direction;
    }
//shifts position negative
   

    
//hit box
    public boolean contains(int x, int y) {
        if (x >= this.x && x <= this.x + 30) {
            return (y >= this.y && y <= this.y + 30);
        }
        return false;
    }
boolean collisionCheck(Rectangle rect1, Rectangle rect2) {
 return hitCheck(rect1.x, rect1.y, rect2) ||
        hitCheck(rect1.x+rect1.width, rect1.y, rect2) ||
        hitCheck(rect1.x, rect1.y+rect1.height, rect2) ||
        hitCheck(rect1.x+rect1.width,
                 rect1.y+rect1.height, rect2);
}
    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 0;
    }

    public void damage() {
        damage++;
    }

    private boolean hitCheck(int x, int y, Rectangle rect2) {
        throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
    }

    /**
     *
     * @author mustoeal
     */
}

package jforumanimationjunk;

/**
 *
 * @author mustoeal
 */
public class Barrier extends Entity {
    private int damage;
    public Barrier(String imageName) {
        super(imageName);
  
    
    
    }
public boolean contains(int x, int y) {
  //hit box     
    if (x >= this.x && x <= this.x + 50) {
            return (y >= this.y && y <= this.y + 50);
        }
        return false;
    }

    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 3;
    }

    public void damage() {
        damage++;
    }

}

package jforumanimationjunk;



/**
 *
 * @author Mustoe
 */
public class shot extends Entity {
  public int damage; 
    public shot(int startX, int startY,String imageName) {
        super(imageName);
        x = startX;
        y = startY;
        damage = 1;
    }
public int getXPosition() {
        return x;
    }

    public int getYPosition() {
        return y;
    }

    /*Move the enemy units*/
    public void shiftYPosition(int increment) {
        y += increment;
    
    
    }

    
}

package jforumanimationjunk;

import java.awt.*;

public class Enemy extends Entity {

    private int damage; //Damage to the enemy unit

    public Enemy(int startX, int startY, String imageName) {

        super(imageName);
        int movement = 0;
        x = startX;
        y = startY;
       damage = 0;
       
        

    }
    public int getXPosition() {
        return x;
    }

    public int getYPosition() {
        return y;
    }

    /*Move the enemy units*/
    public void shiftXPosition(int increment, int direction ) {
        x += increment*direction;
    }
    public void shiftYPosition(int increment) {
        y += increment;
    }

    /*Check if a location is within the hitbox*/
    public boolean contains(int x, int y) {
        if (x >= this.x && x <= this.x + 30) {
            return (y >= this.y && y <= this.y + 30);
        }
        return false;
    }
boolean collisionCheck(Rectangle rect1, Rectangle rect2) {
 return hitCheck(rect1.x, rect1.y, rect2) ||
        hitCheck(rect1.x+rect1.width, rect1.y, rect2) ||
        hitCheck(rect1.x, rect1.y+rect1.height, rect2) ||
        hitCheck(rect1.x+rect1.width,
                 rect1.y+rect1.height, rect2);

}
    /*Check if the unit has been hit*/
    public boolean isDestroyed() {
        return damage > 0;
    }

    public void damage() {
        damage++;
    }

    private boolean hitCheck(int i, int i0, Rectangle rect2) {
        throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.
    }

}
/*
 * @author Mustoe
 */

Can you help me out it is urgent

[Alaric Mustoe]

So if the bullet hits the saucer or the enemies for it to repaint without it there

[Campbell Ritchie]

That is far too much code for us to read. I can see a few things, however.
I can see a class which appears to encapsulate game logic and implement listener interfaces. It is also much bigger than the others, which makes me suspect it is a God class. That is a well‑known “anti‑pattern” and should be changed.

[Les Morgan]

Alaric Mustoe wrote:So if the bullet hits the saucer or the enemies for it to repaint without it there

Alaric, here is a link to a question that was asked yesterday on collision detection: Point Subtraction The theory on collision detection is explained there and you will be able to see how to detect collisions.

As far as movement and removing the object from the screen when the collision happens here comes some stern words: you basically need to go back and do what I suggested when this all started. You need to make each object responsible for it's own actions. Each of your ships, bullets, and barricades needs to be added to a screen objects' collection and take activation from the timer event and check if they hit something or if they move. If they hit something they need to be removed from the screen objects' collection so they no longer receive activation from the timer event.

You are not doing this.

When you started this project, I gave you a basic animation/game loop, container, that you could experiment with and offered help for what ever you may need. You didn't like learning enough Java to actually progress down the path of making the classes for your screen objects properly, so you have been begging code from the community ever since. You have reached the point now where you need to man up, and go back and fix your object design. That means you have to actually start learning Java, then study 2D animation and how that applies to object oriented programming in Java. I suggest you take this opportunity to go back and learn Java, then do some more simple animations and put emphasis on making objects to interact in your game container--your animation/game loop.

If I would have known you were not going to experiment with objects while learning Java, but just jump in over your head and try to get a game up and running, I would have never given you the container to use. It's time to go back and learn enough Java, so you can at least know what people are talking about when they offer you help.

Les