ArrayList index out of bounds exception

[Warren Lucero]

I am stuck, I have been working this assignment so long I cannot see the forest for the trees. I have ran the debugger but I am not understanding the error message. I also have a Auto, Customer,and Rental class that WreckDriver calls back to. Any help would be appreciated.

package wluceromod5;

import java.util.*;
import java.text.*;

public class WreckDriver {


	public static void main(String[] args) 
	{

		Scanner scan = new Scanner(System.in);
		boolean more = true;   

		ArrayList<Customer> c = new ArrayList<Customer>();
		ArrayList<Auto> a = new ArrayList<Auto>();
		ArrayList<Rental> r = new ArrayList<Rental>();

		loadNewData(a, c);

		while (more == true){

			System.out.println("Customers: ");
			showCustomers(c);

			System.out.println("\nWhich customer?");
			int custNum = scan.nextInt();
			Customer cTemp = c.get(custNum - 1); 
			
			if(cTemp.isGoldCardMember()){
			System.out.println ("\nThis customer is a gold card member so we will treat him well!");
			}

			System.out.println("\nThe folowing cars are available to rent...");
			showCars(a);

			System.out.println("\nWhich Auto: ");
			int carNum = scan.nextInt();
			Auto aTemp = a.get(carNum - 1); 

			System.out.println("\nHow many days do you wish to have this beautiful vehicle? ");
			int daysNum = scan.nextInt();
			Rental rTemp = r.get(daysNum);
			
			scan.nextLine();
			System.out.println("More rentals(true/false)");
			more=scan.nextBoolean();
			scan.nextInt();
		}
	}

	public static void loadNewData(ArrayList<Auto> a, ArrayList<Customer> c)
	{
		a.add(new Auto(2009,"Ford" , "Mustang","ABC123", 1256.54));
		a.add(new Auto(2010,"Chevy","Camero","QWI459", 33.98));
		a.add(new Auto(1970,"Pink","Cadillac","950AKH", 212874.51));
		a.add(new Auto(2007,"Lotus","Elise MkII","1A2D3F", 12859.90));

		c.add(new Customer( "1 Brett Farve",false));
		c.add(new Customer( "2 Bruce Springsteen",true));
		c.add(new Customer( "3 Mickey Mouse", true));
		c.add(new Customer( "4 Peyton Manning", true));
		c.add(new Customer( "5 Donald Duck", true));
	}

	//Prints the cars that are available for rent
	public static void showCars(ArrayList<Auto> a)
	{
		for (int j=0;j<a.size();j++)
		{	
			Auto auto = a.get(j);
			System.out.println((j+1) + ":" + auto.toString());
		}  
	}

	public static void showCustomers(ArrayList<Customer> c)
	{
		for (int j=0;j<c.size();j++)
		{
			Customer customer = c.get(j);
			System.out.println(customer.toString());
		}
	}

	// prints all the rentals that have been made
	public static void printRentals(ArrayList<Rental> r)
	{
		for (int j=0;j<r.size();j++)
		{
			Rental rental = r.get(j);
			System.out.println(rental.toString());
		}
	}
}

Console output:

Customers:
1 Brett Farve (custID: 100)
2 Bruce Springsteen (custID: 101)
3 Mickey Mouse (custID: 102)
4 Peyton Manning (custID: 103)
5 Donald Duck (custID: 104)

Which customer?
1

The folowing cars are available to rent...
1: a 2009 Ford Mustang with a VIN# of ABC123 and a mileage of 1256.54
2: a 2010 Chevy Camero with a VIN# of QWI459 and a mileage of 33.98
3: a 1970 Pink Cadillac with a VIN# of 950AKH and a mileage of 212874.51
4: a 2007 Lotus Elise MkII with a VIN# of 1A2D3F and a mileage of 12859.9

Which Auto:
2

How many days do you wish to have this beautiful vehicle?
5
Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 5, Size: 0
at java.util.ArrayList.rangeCheck(ArrayList.java:638)
at java.util.ArrayList.get(ArrayList.java:414)
at wluceromod5.WreckDriver.main(WreckDriver.java:43)

[Knute Snortum]

I'm not sure what you are trying to do with this code...

System.out.println("\nHow many days do you wish to have this beautiful vehicle? ");
            int daysNum = scan.nextInt();
            Rental rTemp = r.get(daysNum);

...but you are trying to get an index of dayNum (in this case 5) from r which is an ArrayList that is empty.

[Warren Lucero]

I am suppose to ask many days do you want to rent the car for. After entering the number of days, it should calculate the cost based on the number of days as well as a 10% discount for 6 or more days, and additional 15% if you are a gold card member. See other classes below.

System.out.println("\nHow many days do you wish to have this beautiful vehicle? ");
            int daysNum = scan.nextInt();
            Rental rTemp = r.get(daysNum);

package wluceromod5;

public class Auto {
	
	// the Auto class has two fields
		private int year;        
        private String make;
        private String model;
        private String vin;
        private double miles;
	
	
	// empty constructor
	public Auto()
	{
		
	}
        
	// full constructor
        public Auto(int year, String make, String model, String vin, double miles) {
        this.year = year;
        this.make = make;
        this.model = model;
        this.vin = vin;
        this.miles = miles;
    }

	
	// toString method (the wording does not make sense until you realize
	// that you will be calling this after calling the customer toString method
	public String toString()
	{
            return " a " + year + " " +  make + " " + model +
                    " with a VIN# of " + vin + " and a mileage of " + miles;

            //return "a car with a vin of " + vin + " and a mileage of " + miles;
	}
	
	
	// getters and setters
	public double getMiles() {
		return miles;
	}

	public void setMiles(double miles) {
		this.miles = miles;
	}

	public String getVin() {
		return vin;
	}

	public void setVin(String vin) {
		this.vin = vin;
	}

        public String getMake() {
            return make;
        }

        public void setMake(String make) {
            this.make = make;
        }

        public String getModel() {
            return model;
        }

        public void setModel(String model) {
            this.model = model;
        }

        public int getYear() {
            return year;
        }

        public void setYear(int year) {
            this.year = year;
        }
}
 

package wluceromod5;

public class Customer {

	// the Customer class has three fields
	private int custId;
	private String name;
	private boolean goldDude;

	// the following will be used to automatically generate customer ids
	//so they will be unique
	private static int nextNum = 100;

	// empty constructor
	public Customer()
	{	
		custId = nextNum;
		nextNum++;
	}

	// constructor for creating a new customer where the id is
	// automatically created
	public Customer(String n)
	{
		name = n;
		custId = nextNum;
		nextNum++;
	}

	// full constructor
	public Customer( String n, boolean gcm)
	{
		custId = nextNum;
		nextNum++;
		name = n;
		goldDude = gcm;
	}


	// toString method
	public String toString()
	{
		return name + " (custID: " + custId + ")";
	}


	//getters and setters
	public int getCustId() {
		return custId;
	}

	public void setCustId(int custId) {
		this.custId = custId;
	}

	public String getName() {
		return name;
	}

	public void setName(String name) {
		this.name = name;
	}

	public int getNextNum() {
		return nextNum;
	}

	public void setNextNum(int nextNum) {
		this.nextNum = nextNum;
	}

	public boolean isGoldCardMember()
	{
		return goldDude;
	}

	public void setGoldCardMember(boolean goldCardMember) {
		this.goldDude = goldDude;
	}


}

package wluceromod5;

import java.text.NumberFormat;

public class Rental {
	
	// the Rental class has four fields
	
	private Customer cust;
	private Auto auto;
	private int numDays;
	private double rentalCost;
	private char discount;   // N = none  G = gold  D = days  B = both
	
	// all cars rent for $15.00 per day	
	final private double COST_PER_DAY = 15.00;
    // TO DO!!write an empty and a full constructor
    
	public Rental ()
	{
	}
	
	public Rental(Customer c, Auto a, int n, double r, char d)
	{
		cust=c;
		auto =a;
		numDays=n;
		rentalCost = r;
		discount =d;
	}
	// toString method
	//remember that each class should print out its own fields
	// so we let the Auto and Customer class print out theirs
	// this class only prints out the number of days field
    @Override
	public String toString()
	{
    	NumberFormat nf = NumberFormat.getCurrencyInstance();    	
		String string;
		string =  cust.toString() + " rented " ; 
		string = string + auto.toString() + " for " + numDays + " days.";
		string = string + "\n   The cost was " + nf.format(rentalCost) + "\n";
		switch  (discount) {
		case 'B':
			string = string + "This person was both a gold card memeber and rented over six days and received a a 25% discount";
			break;
		case 'G':
			string = string + "This person was  a gold card memeber and received a a 10% discount";
			break;
		case 'D':
			string = string + "This person rented over six days and received a 15% discount";
			break;
		case 'N':
			string = string + "This person did not qualify for a discount";
		
		}
			
		return string;
	}
	
	// TO DO!!!the setRentalCost is where the cost is set
	public void setRentalCost()
	{
		// give them a 15% discount if they rent over 6 days.  Also Gold card members get an
		//extra 10% off the original cost regardless of the number of days
		// note next line is just a place holder.  Also set the discount code
		if( cust.isGoldCardMember() ){
        	rentalCost = rentalCost*0.10+rentalCost;
        }
		if (numDays > 6){
        	 rentalCost = rentalCost*0.15+rentalCost;

		}
	}
		
	// generate getters and setters
	public Customer getCust() {
		return cust;
	}

	public void setCust(Customer cust) {
		this.cust = cust;
	}

	public Auto getAuto() {
		return auto;
	}

	public void setAuto(Auto auto) {
		this.auto = auto;
	}

	public int getNumDays() {
		return numDays;
	}

	public void setNumDays(int numDays) {
		this.numDays = numDays;
	}

	public double getRentalCost() {
		return rentalCost;
	}

	public void setRentalCost(double rentalCost) {
		this.rentalCost = rentalCost;
	}

	public char getDiscount() {
		return discount;
	}

	public void setDiscount(char discount) {
		this.discount = discount;
	}

	public double getCOST_PER_DAY() {
		return COST_PER_DAY;
	}
}

[Warren Lucero]

The final output should look like this:

How many days do you wish to have this beautiful vehicle? 15
Brett Farve (custID: 100) rented a 2009 Ford Mustang with a VIN# of ABC123 and a mileage of 1256.54 for 15 days.
The cost was $191.25
This person rented over six days and received a 15% discount

More rentals (true/false)? false

Rental summary:
Bruce Springsteen (custID: 101) rented a 1970 Pink Cadillac with a VIN# of 950AKH and a mileage of 212874.51 for 10 days.
The cost was $112.50
This person was both a gold card member and rented over six days and received a a 25% discount
Peyton Manning (custID: 103) rented a 2007 Lotus Elise MkII with a VIN# of 1A2D3F and a mileage of 12859.9 for 1 days.
The cost was $13.50
This person was a gold card member and received a a 10% discount
Brett Farve (custID: 100) rented a 2009 Ford Mustang with a VIN# of ABC123 and a mileage of 1256.54 for 15 days.
The cost was $191.25
This person rented over six days and received a 15% discount

[Winston Gutkowski]

Warren Lucero wrote:I am suppose to ask many days do you want to rent the car for. After entering the number of days, it should calculate the cost based on the number of days as well as a 10% discount for 6 or more days, and additional 15% if you are a gold card member.

Yes, but none of that has any relation to the problem you're having, which - as Knute tried to point out - is that you're asking for the 6th element from an ArrayList of Rental objects that is EMPTY.

Winston

[Warren Lucero]

I see what you all are saying now. I do not want to ask for element from the arraylist. Working on the fix now.

[Nigel Browne]

The original question has already been answered by other posters, however you have numerous issues in the code you have written so far. If you had broken the project down into smaller tasks and then tested along the way, then you would of already found them by now.
For example your method to calculate the rental cost doesn't take in any arguments so how does it know which customer and auto it is calculating the cost for ?
Your COST_PER_DAY constant should be static and then you dont need a getCOST_PER_DAY method
Your test for day discount starts at 7 days and not 6
There are more issues but I'll let you re-evaluate your code before point out anything else.

Keep on asking questions and posting your work and you'll get the help needed.

[Campbell Ritchie]

Nigel Browne wrote:. . . Your COST_PER_DAY constant should be static . . .

Why? Won't cost vary from car to car, and won't it be a variable?

Why has the Rental class got an empty constructor?

[Warren Lucero]

The professor pre-populated that empty constructor.

[Liutauras Vilda]

Warren Lucero wrote:

while (more == true)

One tinny thing. You avoided logical error this time, but next time could be not that successful if you ever manage to write:

while (more = true)

Then you would end up in the infinity loop, probably more right - you wouldn't end up at all

Just use:

while(more)

[Warren Lucero]

Thank you Liutauras . I did correct but a few minutes before I saw your message. The professor gives us half the code so we can work out the rest. Right now I am stuck on getting the days entered and calculated based three criteria: less then 6 days no discount, over 6 days 15% discount, and extra 10% if a gold card member.

[Warren Lucero]

Okay, I am lost. Trying to resolve the entering days and passing it back over to Rental to be calculated then pick the switch string that fits the criteria of days. This is what I started on the WreckDriver class

System.out.println("\nHow many days do you wish to have this beautiful vehicle? ");
			int daysNum = scan.nextInt();
			if (daysNum < 6)
			{ String  discount = "N";
				System.out.println(
			}

Here is the Rental class.

public double setRentalCost()
	{
		// give them a 15% discount if they rent over 6 days.  Also Gold card members get an
		//extra 10% off the original cost regardless of the number of days
		// note next line is just a place holder.  Also set the discount code
		if (numDays<6)
		{
			rentalCost = numDays*COST_PER_DAY;
		}
		return rentalCost;
		//if( cust.isGoldCardMember() ){
        //	rentalCost = rentalCost*0.10+rentalCost;
        //}
		//if (numDays > 6){
       // 	 rentalCost = rentalCost*0.15+rentalCost;
		//}
		

I learn faster by seeing examples. Not looking for you all to do my homework. Anyone's guidance would truly appreciated. This assignment is due by tomorrow at noon.

[Liutauras Vilda]

less then 6 days no discount, over 6 days 15% discount, and extra 10% if a gold card member.

Forget Java. Probably we you don't have time for sermon, but you really need to solve that first on paper.
As you see you wrote lots of code, even more of it is commented out - and no result basically.

Write down in English what steps you'd take to get that logic which is in quote?

[Liutauras Vilda]

On technical part, discount shouldn't be a String, i'd think about boolean.
goldCardMember = true / false

After you come up with logic, create method, don't cram everything to whenever you just choose.
It should be similar to (syntax not valid):

basePrice = ...
daysToRent = askForDays("How many days do you want to rent this car? ")
offeredDiscount = calculateDiscount(daysToRent)
finalPriceForRent = calucatePrice(basePrice, days, offeredDiscount)

There are many ways to polish that, by spending more time on choosing variable names than I did, thinking better about the structure, but basic idea could be like that.