JSF / Primefaces Inputtext inside datatable trouble with passing value to ArrayList

[Mikael Ghazarian]

Hi there,

I'm working on a new School Project.
I've got a datatable with Patient data also I've created for that a Model Patient.
Now I've add one column more inside this column I've got four inputtext(inputmask) (Morning, Afternoon, Evening, Night) field which allows just one number.

Each field got a binding of type String. In the getter Method I add each of this values in a ArrayList.
The User Need to pass one number to each field to say how many cigarettes the Patient smoked each day.
There is a submit button in my Controller I check if every field got a value inside if not there will Popup a Message.

If there User changes the value after Submit it just adding new values to the ArrayList and doesn't Change the first value.
I want that it changes the value inside the Arraylist at the right Position rather than to add a new one and Keep the old (and wrong) value inside the Arraylist.

Patient Model

private Integer id;
private String Name;

// +getter and setter

My Controller

@ManagedBean
@ViewScoped
public class InputController implements Serializable {

    private static final long serialVersionUID = 1L;
    
    private String morning;    
    private String afternoon;    
    private String evening;    
    private String night;    

    private List<String> morningList = new ArrayList<>();    
    private String afternoonList= new ArrayList<>();
    private String eveningList = new ArrayList<>();
    private String nightList = new ArrayList<>();

    public InputController(){

   }

   public List<Patient> showPatient(){
   
   ...
   return patients;
  }

   public void setMorning(String morning) {
      this.morning = morning;
      this.morningList.add(morning);
   }


  
  // +getter and setter

}

My Datatable

    <p:dataTable id="patientDT" var="patient" value="#{inputController.showPatient()}" selection="#{inputController.selectedPatient}" 
                                         rowKey="#{Patient.id}" tableStyle="width:75%; margin-left: 10%; margin-right: 10%;"
                                         reflow="true">

      <p:column selectionMode="multiple" style="width:16px;text-align:center"/>

      <p:column headerText="Name">
         <h:outputText value="#{Patient.name}" />
      </p:column>

      <p:column headerText="Interval" >

         <p:outputLabel for="morning" value="M"  />
         <p:inputMask id="morning" value="#{handingController.morning}" mask="9" />

          <p:outputLabel for="afternoon" value="A"  />
          <p:inputMask id="afternoon" value="#{handingController.afternoon}" mask="9"/>

           <p:outputLabel for="evening" value="E"  />
           <p:inputMask id="evening" value="#{handingController.evening}" mask="9" />

           <p:outputLabel for="night" value="N"  />
           <p:inputMask id="night" value="#{handingController.night}" mask="9" />

        </p:column>
   </p:dataTable>

[Tim Holloway]

Your "Controller" is not a Controller and I don't care what the NetBeans people say otherwise. JSF backing beans are Models with optional business logic and event listeners. In JSF the real Controllers are the FacesServlet and the logic within the tags that handles keeping the Model and View in sync (which is the very definition of a MVC Controller).

Also, this codeis just plain wrong:
value="#{inputController.showPatient()}"

A value is supposed to be a property reference not a method call.

In fact, your Table Model seems to be tilted 90 degrees. As I read it, you have a separate array for each column. The common usage is to define a Model class for the table row with a property corresponding to each column. The actual Table DataModel then consists of a collection (array, List, or other ordered collection) of Model class row instances.

Finally, if you wrap such a Table Model with a JSF DataModel class (ListDataModel or ArrayDataModel), then your action method can easily determine the row that was selected and its row number.

[Mikael Ghazarian]

Hi Tim thank your for your answer.

I tried to Change my code as you told me.
Also created a Model for my datatable.

<p:dataTable id="patientDT" var="patient" value="#{inputController.patientList}" selection="#{inputController.selectedPatient}"
                                      rowKey="#{Patient.id}" tableStyle="width:75%; margin-left: 10%; margin-right: 10%;"
                                      reflow="true">
 
   <p:column selectionMode="multiple" style="width:16px;text-align:center"/>
 
   <p:column headerText="Name">
      <h:outputText value="#{patient.name}" />
   </p:column>
 
   <p:column headerText="Interval" >
 
      <p:outputLabel for="morning" value="M"  />
      <p:inputMask id="morning" value="#{patient.morning}" mask="9" />
 
       <p:outputLabel for="afternoon" value="A"  />
       <p:inputMask id="afternoon" value="#{patient.afternoon}" mask="9"/>
 
        <p:outputLabel for="evening" value="E"  />
        <p:inputMask id="evening" value="#{patient.evening}" mask="9" />
 
        <p:outputLabel for="night" value="N"  />
        <p:inputMask id="night" value="#{patient.night}" mask="9" />
 
     </p:column>
</p:dataTable>

 

But I still got the Problem, that I can't pass the Input values from morning, noon, evening and night.
If I put a value in it and press my commandbutton I get null returned.