Send universal File over Socket (pdf,txt,doc,jpeg, png etc.) between Client And Server

[travis Haycock]

Hello I am having difficulties sending files to my server I have successfully designed a few voice messaging methods which send a wav file over the network which work great but I am unable to send a file... I see lots of examples and try to make my own but it either stalls or throws exceptions I have been reading and can't find a real credible source that neither functional or provides theory can someone please help me out? my Server is receiving and my client is sending

CLIENT

 public void chooseFile() throws IOException {
        JFileChooser fc = new JFileChooser();
        fc.setDialogTitle("Send File");
        fc.setMultiSelectionEnabled(true);
        fc.setFileSelectionMode(JFileChooser.FILES_AND_DIRECTORIES);
        int dialog = fc.showSaveDialog(this);
        if (dialog == JFileChooser.APPROVE_OPTION) {

            File inputFile = fc.getSelectedFile();
            System.out.println("the extension type:" + fc.getTypeDescription(inputFile));

            inputFile.getName();
            inputFile.getAbsoluteFile();
            String nameOf = inputFile.getName();
            System.out.println(" File: " + inputFile);

            sendFile(inputFile);

        }

    }

    public void sendFile(File inputFile) throws IOException {
        connection3 = new Socket(InetAddress.getByName(serverIP), 1991);
      
        byte[] mybytearray = new byte[(int) inputFile.length()];  
           
        FileInputStream fis = new FileInputStream(inputFile);  
        BufferedInputStream bis = new BufferedInputStream(fis);  
        bis.read(mybytearray, 0, mybytearray.length);  
           
        DataInputStream dis = new DataInputStream(bis);     
        dis.readFully(mybytearray, 0, mybytearray.length);  
           
        OutputStream os = connection3.getOutputStream();  
           
        //Sending file name and file size to the server  
        DataOutputStream dos = new DataOutputStream(os);     
        dos.writeUTF(inputFile.getName());     
        dos.writeLong(mybytearray.length);     
        dos.write(mybytearray, 0, mybytearray.length);     
        dos.flush();  
           
        //Sending file data to the server  
        os.write(mybytearray, 0, mybytearray.length);  
        os.flush();  
           
        //Closing socket
        os.close();
        dos.close();  
        connection3.close();  
     

SERVER

class downloadFile implements Runnable {

    public static final int BUFFER_SIZE = 100;
     Echo echo;
    ServerSocket server_download;
    Socket connection_download;
    FileOutputStream fos;
    DataInputStream dis;
    OutputStream output;
    InputStream input;
     int bytesRead;  
    int current = 0;
    
    public downloadFile() {
    }

    @Override
    public void run() {

        try { 
            server_download = new ServerSocket(1991, 100);
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        try {
            connection_download = server_download.accept();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
     System.out.println("waiting for file to be sent");
     
     InputStream in = null;  
        try {
            in = connection_download.getInputStream();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
           
        DataInputStream clientData = new DataInputStream(in);   
           
        String fileName = null;     
        try {
            fileName = clientData.readUTF();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        OutputStream output = null;     
        try {
            output = new FileOutputStream(fileName);
        } catch (FileNotFoundException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        long size = 0;     
        try {
            size = clientData.readLong();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        byte[] buffer = new byte[1024];     
        try {
            while (size > 0 && (bytesRead = clientData.read(buffer, 0, (int)Math.min(buffer.length, size))) != -1)
            {
                output.write(buffer, 0, bytesRead);
                size -= bytesRead;  
            }
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
           
        try {
            // Closing the FileOutputStream handle
            in.close();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        try {
            clientData.close();
        } catch (IOException ex) {
            Logger.getLogger(downloadFile.class.getName()).log(Level.SEVERE, null, ex);
        }
        try {
            output.close();
            

[Paul Clapham]

Look at lines 30 and 33 in your sendFile method. Also 41 and 45.

You don't have a good handle on the problems, I think, but I suggest doing more logging in the server.

[travis Haycock]

Thanks for the reply, why would this code be allowing only ZIP files to go through? it seems I can send those files without any modification of the code