Invoking Method Returns 0

[Abu Apu]

I have a working test class, but the JFrame class JTextArea displays 0. Basically I upload a .txt file and my method counts the total of words for it. The JDialog box appears and I select the .txt file, but the Words Count display is always 0. I am assuming I need a while loop... but it always crashes the GUI application lol. I have the buttons and addActionListeners setup. I just need the Action Performed event handler to display the Words Count part. Thank you for helping me out!
-------------------------------------------------------------------

    private void analyzeTextButtonActionPerformed(java.awt.event.ActionEvent evt) {
 
        JFileChooser filename = new JFileChooser();
        // WORKS, now add next things once opened
        // logTextArea is the display 
        int result = filename.showOpenDialog(logTextArea);

        //boolean wordStart = false; 
        //while (!(wordStart)) { }
            
        start = System.currentTimeMillis();
        if( result == JFileChooser.APPROVE_OPTION) {
            
            if (useTreeMapRadioButton.isSelected()) {
                FrameAnalyzer = new TextA_1("treemap");
            } else { FrameAnalyzer = new TextA_1("hashmap"); }
            
        }
            
            File selectedFile = filename.getSelectedFile();
            // Instead of print (console) use logTextArea.append to gui app
         logTextArea.append("Selected file: " + selectedFile.getAbsolutePath()
         + "\n");
         
         logTextArea.append("Total words: " + FrameAnalyzer.getWordCount() +
                 "\n");
         end = System.currentTimeMillis();
         startEnd = end - start;
         double elapsedSeconds = startEnd / 1000.0;
         logTextArea.append("Time elapsed: " + elapsedSeconds + "\n"); }

[Matthew Brown]

We can't see the code for FrameAnalyzer, but the first thing that leaps out is that you don't appear to do anything with the file you select, other than display its name. You don't read the file anywhere. And FrameAnalyzer.getWordCount() doesn't seem to have any way to tell what it's counting.

[K. Tsang]

How big is the txt file?

You should put the reading file part in a Callable (able to get the result back) to prevent the GUI to block/hang.

[Abu Apu]

K. Tsang wrote:How big is the txt file?

You should put the reading file part in a Callable (able to get the result back) to prevent the GUI to block/hang.

The txt file has around 12,000 words :P

[Abu Apu]

Matthew Brown wrote:We can't see the code for FrameAnalyzer, but the first thing that leaps out is that you don't appear to do anything with the file you select, other than display its name. You don't read the file anywhere. And FrameAnalyzer.getWordCount() doesn't seem to have any way to tell what it's counting.

Hmmmmmm interesting. If the file is being selected why isn't it being read anywhere?

[Knute Snortum]

FrameAnalyzer.getWordCount()

Here FrameAnalyzer is an instance variable (please use lowercase for the first letter) but we don't know what type it is, so we don't know what getWordCount() does. If the class is one you wrote, could you post the code of that method? Also, how does FrameAnalyzer get the name of the file?

[Abu Apu]

Knute Snortum wrote:

FrameAnalyzer.getWordCount()

Here FrameAnalyzer is an instance variable (please use lowercase for the first letter) but we don't know what type it is, so we don't know what getWordCount() does. If the class is one you wrote, could you post the code of that method? Also, how does FrameAnalyzer get the name of the file?

public class TextA_1 implements ITextAnalyzer {

    private Map<String, IWordData> words;

    public TextA_1(String mapType) {
        if (mapType.equalsIgnoreCase("treemap")) { words = new TreeMap(); }
    }

    private String removeCrap(String extra) {
        return extra.replaceAll("[^a-zA-Z]+","").toLowerCase();
    }

    // Words only stored in line variable, update count, each line put inside 
    // map as key, value frequency default is 1, if duplicate keys then ++
    @Override
    public void analyzeText(String filename) throws FileNotFoundException, 
            IOException {
        
        Scanner inp = new Scanner(new FileReader(filename));
        while (inp.hasNext()) {
            String line = removeCrap(inp.next());
            if (!words.containsKey(line)) {
                words.put(line, new WordData_1(1, line));
            } else {
                WordData_1 key = (WordData_1) words.get(line);
                key.updateFrequencyCount();
            }
        }
    } 
    
    // IWordData objects in map are iterated
    // Adding words together for total
    @Override
    public long getWordCount() {
        long totalWordCount = 0;

        for (Map.Entry<String, IWordData> entry : words.entrySet()) {
            totalWordCount += entry.getValue().getFrequencyCount();
        }
        return totalWordCount;
    }

FrameAnalyzer is type TextA_1

[K. Tsang]

Ah in your getWordCount method, the map words is empty when you instantiate it.

You have a analyzeText method that looks like reading the file and populating the map words. Yet you didn't call this method.

Steps are:
1. instantiate FrameAnalyzer variable
2. call analyzeText method
3. call getWordCount method


After this you should get a non-zero value.

By the way in the analzeText method, FileNotFoundException is a subclass of IOException. Just a thought, is Scanner a good choice for reading files?

[Abu Apu]

K. Tsang wrote:Ah in your getWordCount method, the map words is empty when you instantiate it.

You have a analyzeText method that looks like reading the file and populating the map words. Yet you didn't call this method.

Steps are:
1. instantiate FrameAnalyzer variable
2. call analyzeText method
3. call getWordCount method


After this you should get a non-zero value.

By the way in the analzeText method, FileNotFoundException is a subclass of IOException. Just a thought, is Scanner a good choice for reading files?

Aw okay. I noticed I was never calling

 analyzeText

method from TextA_1 -____________- Also

 .getSelectedFile(), .getPath();

were not implemented correctly in their respectful places.

Anyways, it is working now !!! Boooooooooooooyah!!! Thanks for the help guys!