Beginner with problems in code

[Joe Robinson]

//******************************************************
// Author: Student Name Goes Here
// Date    : MM/DD/YY
// Class   : IT-145
// Assignment: #-#
// Description: This program is designed to ...
//*****************************************************
 
import javax.swing.JOptionPane;
 
public class NonDescending
{
   public static void main(String[] args)
   {
      // Declare three variables as integers
     
      int number1, number2, number3; // Comment
     
      // Declare multiple variables of type String.
     
      String outPutStr = "";
      String num1Str = "";
      String num2Str = "";
      String num3Str = "";
     
               
      // Use the JOptionPane.showMessageDialog(...) method to
      // ask the end user to input three numbers
     
     
      // Use the JOptionPane.showInputDialog(...) to enter the
      // three integers.
     
      num1Str = JOptionPane.showInputDialog("Enter the first number"); // Comment
      num2Str = JOptionPane.showInputDialog("Enter the second number"); // Comment
      num3Str = JOptionPane.showInputDialog("Enter the third number"); // Comment
     
      // Assign each integer entered to one of the integer
      // variables created above.
     
      number1 = Integer.parseInt(num1Str);  // Comment
      number2 = Integer.parseInt(num2Str);  // Comment
      number3 = Integer.parseInt(num3Str);  // Comment
     
     
      // Compare the three integer numbers and make sure that no
      // two numbers are the same.
     
      if (number1 = number2) or (number1 = number3); or (number2 = number3); {
         // Use the JOptionPane.showMessageDialog(...) method to
         // display an error message and then exit the program.
         System exit; // Terminates the program
    
     
     
      // Build the "outPutStr" variable
     
      if (number1 < number2) or (number1 < number3); then
           outPutStr = number1 + number2 + number3; // Comment
      } else
           outPutStr = number3 + number2 + number1; // Comment
      end
     
      // Use the JOptionPane.showMessageDialog(...) method to
      // display the "outPutStr" variable
     
      System; // Terminates the program

I am getting errors in this code and i am quite honestly lost, i have been reading text and examples for a week and am just not understanding this.  Any help would be great.

[Carey Brown]

The code you posted is incomplete, can you post the whole thing? Can you also post the text of the error message that you're getting?

[Joe Robinson]

We were given this as a template to use and i have no idea where to go with this.  i have filled in a lot of the information and got it to compile down to line 60.

Nondesending.java:60: error: 'else' without 'if'
     else{
     ^
Nondesending.java:69: error: reached end of file while parsing
}        

[Carey Brown]

      if (number1 = number2) or (number1 = number3); or (number2 = number3); {

This is not a properly formatted if() statement. First off, the entire boolean expression should be enclosed in parenthesis. The '=' is an assignment operator, use '==' to compare to values. 'or' is not a Java keyword, use '||'. Having ';' embedded int the expression will cause the following block to always be executed, rather than based on the outcome of the expression.

[Carey Brown]

On line 49 you have an open brace '{' which is the start of a block. On line 53 you should have the closing brace '}'.

[Joe Robinson]

//******************************************************
// Author: Student Name Goes Here
// Date    : MM/DD/YY
// Class   : IT-145
// Assignment: #-#
// Description: This program is designed to ...
//*****************************************************
 
import javax.swing.JOptionPane;
 
public class NonDescending
{
   public static void main(String[] args)
   {
      // Declare three variables as integers
     
      int number1, number2, number3; // Comment
     
      // Declare multiple variables of type String.
     
      String outPutStr = "";
      String num1Str = "";
      String num2Str = "";
      String num3Str = "";
     
               
      // Use the JOptionPane.showMessageDialog(...) method to
      // ask the end user to input three numbers
     
     
      // Use the JOptionPane.showInputDialog(...) to enter the
      // three integers.
     
      num1Str = JOptionPane.showInputDialog("Enter the first number"); // Comment
      num2Str = JOptionPane.showInputDialog("Enter the second number"); // Comment
      num3Str = JOptionPane.showInputDialog("Enter the third number"); // Comment
     
      // Assign each integer entered to one of the integer
      // variables created above.
     
      number1 = Integer.parseInt(num1Str);  // Comment
      number2 = Integer.parseInt(num2Str);  // Comment
      number3 = Integer.parseInt(num3Str);  // Comment
     
     
      // Compare the three integer numbers and make sure that no
      // two numbers are the same.
     
     { if (number1 == number2) || (number1 == number3) || (number2 == number3); 
         // Use the JOptionPane.showMessageDialog(...) method to
         // display an error message and then exit the program.
         System exit; // Terminates the program
 }   
     
     
      // Build the "outPutStr" variable
     
      if (number1 < number2) || (number1 < number3); then
           outPutStr = number1 + number2 + number3; // Comment
      else{
           outPutStr = number3 + number2 + number1; // Comment
      end
     
      // Use the JOptionPane.showMessageDialog(...) method to
      // display the "outPutStr" variable
     
      System; // Terminates the program
   }
}         

Nondesending.java:49: error: illegal start of expression
    { if (number1 == number2) || (number1 == number3) || (number2 == number3);
                              ^
Nondesending.java:49: error: not a statement
    { if (number1 == number2) || (number1 == number3) || (number2 == number3);
                                                      ^
Nondesending.java:58: error: illegal start of expression
     if (number1 < number2) || (number1 < number3); then
                            ^
Nondesending.java:60: error: 'else' without 'if'
     else{
     ^
Nondesending.java:69: error: reached end of file while parsing
}        
^
5 errors

----jGRASP wedge: exit code for process is 1.
----jGRASP: operation complete.

[Carey Brown]

      if (number1 < number2) or (number1 < number3); then
           outPutStr = number1 + number2 + number3; // Comment
      } else
           outPutStr = number3 + number2 + number1; // Comment
      end

See previous comment about if().

There is no 'then' or 'end' keywords in java.

You have a closing block brace '}' with no corresponding open brace.

You are adding the numbers together which will result in an int. You can't assign an int to a String.

[Carey Brown]

A typical if() construct looks like this

if( some_boolean_expression )
{
    // one or more statements
}

[Joe Robinson]

I honestly do appreciate your help on this problem.  i think to more fully understand how this should look i would have to see a before and after.  This assignment was due like 2 weeks ago, i was just trying to get a better understanding of how it should look when completed as it would help me in further assignments.

[Joe Robinson]

import javax.swing.JOptionPane;

public class NonDescending
{
   public static void main(String[] args)
   {
      int number1;
      int number2;
      int number3;
      
      String outputStr="";
      String num1Str="";
      String num2Str="";
      String num3Str="";
      
      JOptionPane.showMessageDialog(null,"Enter Three Numbers", "Non-Descending Numbers", JOptionPane.INFORMATION_MESSAGE);
      
      num1Str=JOptionPane.showInputDialog("Enter the first number");
      num2Str=JOptionPane.showInputDialog("Enter the second number");
      num3Str=JOptionPane.showInputDialog("Enter the third number");
      
      number1 = Integer.parseInt(num1Str);
      number2 = Integer.parseInt(num2Str);
      number3 = Integer.parseInt(num3Str);
      
      
      if(number1==number2 || number1==number3 || number2==number3)
         JOptionPane.showMessageDialog(null,"Duplicate Number", "Error",JOptionPane.ERROR_MESSAGE);
         
         System.exit(0);
         
       if(number1 < number2 || number1 < number3)
         outputStr=Integer.toString(number1+number2+number3);
         else
         outputStr=Integer.toString(number3+number2+number1);
         
      JOptionPane.showMessageDialog(null, outputStr, "Three Numbers", JOptionPane.INFORMATION_MESSAGE);
         
      System.exit(0);
      }
}

OK i have gotten to the point where i can enter the numbers but now it will not output them after the 3rd number is entered

[Carey Brown]

Joe Robinson wrote:I honestly do appreciate your help on this problem.  i think to more fully understand how this should look i would have to see a before and after.  This assignment was due like 2 weeks ago, i was just trying to get a better understanding of how it should look when completed as it would help me in further assignments.

We don't do your assignment for you. We are here to help and guide you in coming up with your own solution.

Do you have a Java book that you're working from? You should be able to find info on the syntax for boolean expressions and conditional statements (i.e. if()). There's also plenty of online tutorials. Example: https://docs.oracle.com/javase/tutorial/java/nutsandbolts/if.html

[Carey Brown]

      if(number1==number2 || number1==number3 || number2==number3)
         JOptionPane.showMessageDialog(null,"Duplicate Number", "Error",JOptionPane.ERROR_MESSAGE);
          
         System.exit(0);

Close, but missing braces

      if(number1==number2 || number1==number3 || number2==number3)
      {
         JOptionPane.showMessageDialog(null,"Duplicate Number", "Error",JOptionPane.ERROR_MESSAGE);
          
         System.exit(0);
      }

[Joe Robinson]

I think that i have it.  Thanks so much

[Carey Brown]

outputStr=Integer.toString(number1+number2+number3);

Adding the integers: 1 + 5 + 4
results in: 10

Adding the integers: 4 + 1 + 5
is also: 10

This what your output string will contain.

If you want your output string to have the list of the three integers, then
outputStr = num1Str + " " + num2Str + " " + num3Str;

[Joe Robinson]

Ok i see how that is adding the numbers instead of putting them in order.

[Campbell Ritchie]

. . . and welcome to the Ranch