• Post Reply Bookmark Topic Watch Topic
  • New Topic

Where can i ask a request for code review?  RSS feed

 
Seba Doe
Greenhorn
Posts: 15
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Hi,

Do You have a special category for it? Maybe somewhere exists a web where i can add my project do review by other programmers?

Please, help me
 
Campbell Ritchie
Marshal
Posts: 56525
172
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Try here. It depends on the length of the code; please don't post a link to it.
 
Seba Doe
Greenhorn
Posts: 15
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Why? Link do GitHub repo is bad?
 
Stephan van Hulst
Saloon Keeper
Posts: 7964
143
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Not necessarily bad, especially if it's easier to clone the entire project, but in general people are less willing to review code unless they can view it directly from the topic.

Not only that, but code reviews also benefit people who may be reading this topic many years later, possibly when your repository doesn't exist anymore.
 
Seba Doe
Greenhorn
Posts: 15
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Yes. But if i will have a (for instance) 20 files. So it wil be hard to copy and paste all this files etc. And it will be much simpler to do review after clone my repo.
 
Stephan van Hulst
Saloon Keeper
Posts: 7964
143
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Well, you can of course always post the link and see who's willing to have a look
 
fred rosenberger
lowercase baba
Bartender
Posts: 12563
49
Chrome Java Linux
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
And remember...the people here are volunteers. They give up what time they can, but are under no obligation to do so. The easier you make it for them to help you, the better your chances are of getting that help.  Sure, it may be more work for you to post all the code here, but it makes it easier for those who are donating their time.
 
Paul Clapham
Sheriff
Posts: 22819
43
Eclipse IDE Firefox Browser MySQL Database
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Sebastian Wie wrote:Yes. But if i will have a (for instance) 20 files.


Then don't post all of them. For a code review you don't need an SSCCE, because executing the code is not what you're asking about. Post one or two of those 20 classes; you might get people grumbling about not being able to see potentially relevant code, but if you post a thousand lines of code then likely nobody will want to look at it. Besides, the comments you get on one or two classes are almost certainly going to apply equally well to the code you don't post.
 
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!