Class code

[Jason Patton]

package salesweek3;
import java.text.DecimalFormat;
import java.util.Scanner; 

/**
 *
 * 
 */
public class SalesWeek3 {

    

    public static void main(String[] args) {
        String input;
        double income = (75000);
        double commission;
        double sales;
        double compensation = 0;
        Scanner salesinput = new Scanner (System.in);
        DecimalFormat Final = new DecimalFormat("$#,###.00");
        
       
        System.out.println ("What are the total sales?");
        sales = salesinput.nextDouble();
    
        
        
        System.out.println ("Your annual income is: $" + income);
        
        System.out.println ("If sales target is met compensation is below");
        
        
        if (sales <=112000)
        {
            commission = 0;
        }
        
       if (sales >= 140000)
       {
           commission = 0.2625; 
        }
        else
    {
        commission = 0.25;
    }
      
       compensation = income + (sales * commission);
        System.out.println(Final.format(compensation) + " is what you made this year  ");
        
        System.out.println ("Sales Total  \t\t  Total Annual Compensation");
        System.out.println ("------------------------------------------------------------");
        
        
        
        
     for(double salesTarget=sales; salesTarget < sales * 1.5; salesTarget=salesTarget + 5000) {
       
       double salesTarget1=sales * commission + income + compensation;
            System.out.println("Sales: " + salesTarget + "  Annual Compensation: " + salesTarget1);

This code gives the following output. It works I am just banging my head up against the wall trying to figure out why the annual compensation is so high. I can't figure it out. Any help, suggestions would be eternally grateful!!

run:
What are the total sales?
150000
Your annual income is: $75000.0
If sales target is met compensation is below
$114,375.00 is what you made this year  
Sales Total    Total Annual Compensation
------------------------------------------------------------
Sales: 150000.0  Annual Compensation: 228750.0
Sales: 155000.0  Annual Compensation: 228750.0
Sales: 160000.0  Annual Compensation: 228750.0
Sales: 165000.0  Annual Compensation: 228750.0
Sales: 170000.0  Annual Compensation: 228750.0
Sales: 175000.0  Annual Compensation: 228750.0
Sales: 180000.0  Annual Compensation: 228750.0
Sales: 185000.0  Annual Compensation: 228750.0
Sales: 190000.0  Annual Compensation: 228750.0
Sales: 195000.0  Annual Compensation: 228750.0
Sales: 200000.0  Annual Compensation: 228750.0
Sales: 205000.0  Annual Compensation: 228750.0
Sales: 210000.0  Annual Compensation: 228750.0
Sales: 215000.0  Annual Compensation: 228750.0
Sales: 220000.0  Annual Compensation: 228750.0
BUILD SUCCESSFUL (total time: 5 seconds)

[Knute Snortum]

What is the formula for annual compensation in non-programming terms?

[Jason Patton]

Knute Snortum wrote:What is the formula for annual compensation in non-programming terms?

The current sales target for every salesperson is $140,000.
The sales incentive will only start when 80% of the sales target is met. The current commission is 25% of total sales.
If a salesperson exceeds the sales target, the commission will increase based on an acceleration factor. The acceleration factor is 1.25.
The application should ask the user to enter annual sales, and it should display the total annual compensation.
The application should also display a table of potential total annual compensation that the salesperson could have earned, in $5000 increments above the salesperson's annual sales, until it reaches 50% above the salesperson's annual sales.

Anything less than 112000 does not receive commission. Between 112,000 and 139,999 does receive 25%

[Knute Snortum]

Let's look at the code you wrote to calculate commision.

        if (sales <=112000)
        {
            commission = 0;
        }
         
       if (sales >= 140000)
       {
           commission = 0.2625; 
       }
       else
       {
           commission = 0.25;
       }

What happens if the sales is 100000?

[Jason Patton]

Knute Snortum wrote:Let's look at the code you wrote to calculate commision.

        if (sales <=112000)
        {
            commission = 0;
        }
         
       if (sales >= 140000)
       {
           commission = 0.2625; 
       }
       else
       {
           commission = 0.25;
       }

What happens if the sales is 100000?

Nothing because there is no commission at that point. Anything below 112,000 gains 0 commission.

[Carey Brown]

Jason Patton wrote:

Knute Snortum wrote:Let's look at the code you wrote to calculate commision.

        if (sales <=112000)
        {
            commission = 0;
        }
         
       if (sales >= 140000)
       {
           commission = 0.2625; 
       }
       else
       {
           commission = 0.25;
       }

What happens if the sales is 100000?

Nothing because there is no commission at that point. Anything below 112,000 gains 0 commission.

Look again.

[Knute Snortum]

Hint: there are two if-statements, not one.

[Jason Patton]

Knute Snortum wrote:Hint: there are two if-statements, not one.

Ok so now I changed the statements to look like this:

if (sales <=112000)  //defines parameters for amount of sales
       {
           commission = 0.0;
       }
       
       else if (sales >= 112000 && sales < 140000)  //continues to define parameters for amount of sales.
      {
          commission = 0.25;
       }
       else if (sales > 140000)
   {
       commission = 0.2625;  //declares what to do if either parameter above is not met.
       }
       else
       }
       income = 75000;
{

But that has not changed the outcome of my table whatsoever!

[Carey Brown]

Much better. But in your new code, what happens if it is exactly 140000?

[Paul Clapham]

Let me repost that code with suitable indentation, so that the reader isn't misled:

if (sales <=112000)  //defines parameters for amount of sales
        {
            commission = 0.0;
        }
        else if (sales >= 112000 && sales < 140000)  //continues to define parameters for amount of sales.
        {
           commission = 0.25;
        }
        else if (sales > 140000)
        {
            commission = 0.2625;  //declares what to do if either parameter above is not met.
        }
        else
        }
        income = 75000;
{ 

Actually I don't think that will even compile, there isn't a valid code block after the last "else".

[Liutauras Vilda]

Jason, try the way to start from the largest commision, you should be able to come up with less complex structure of if-then-else statements.
i.e.:

if (sales > 14000) {
    ...
}
else if (sales >= 112000) {
    ...
}
...

[Dave Tolls]

Outside of the if statement, there is an issue with your calculation:

compensation = income + (sales * commission);

...

double salesTarget1=sales * commission + income + compensation;

The second one is inside the loop with the increasing salesTarget.
Note that you are using sales in there and not salesTarget, so the calculation will always be the same.

However, also note that compensation calculation, so the latter one can be rewritten:

double salesTarget1=sales * commission + income + (income + (sales * commission));

Now that doesn't look correct to me...

[Campbell Ritchie]

Sorry to appear a pedantic so‑and‑so, but you have two options for 112000. Look at lines 1 and 5 in Paul C's post. And you have no option for exactly 140000. You won't notice the two occurrences of 112000 because of the else, but things will go horribly wrong if you sell exactly 140000. I like to write if‑elses in order, either ascending or descending, depending on what you do with the boundary values. I also try to use < or > rather than >=/≥ or <=/≤ because the former two are usually easier to read.

if (value < 20)
{
   // ...
}
else if (value < 30)
{
   // ...
}
else if (value < 40)
{
   // ...
}
else
{
   // action for everything else
}

if (value > 80)
{
   // ...
}
else if (value > 70)
{
   // ...
}
else if (value > 60)
{
   // ...
}
else
{
   // action for everything else
}

I think that format is easier to read, and also, if you stick to one operator, there is no risk of missing out values like 140000.