Make program more object oriented?

[Jeremy Pierson]

Hello everyone,

I just finished my first semester in Java and for my final project I decided to create a program that would read an excel sheet, sort the data, and output the new data to a new excel sheet. I got the program to work and my professor loved the idea. He said I could make the project easier by making it more object oriented. I wasn't able to get him to elaborate on specifics before the semester ended, so I figured I would ask here. I decided to re-do a good portion of the program. Some of the comments are irrelevant, I had to teach myself to use Java with excel, so a few comments are just instructions/reminders.

Here is what I have so far.

Here is the excel sheet I am reading from (minus the names): http://imgur.com/a/dLZbu  (image tags didn't work)
Here is an example of the output: http://imgur.com/a/2AgT4

Code:

import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.CellStyle;
import org.apache.poi.ss.usermodel.Font;
import org.apache.poi.xssf.usermodel.*;


public class ReadWriteExcel {
	
	//declared instance variables
	String[][] names;
	String[][] times;
	String[][] sections;
	String[][] mobile;
	String[] allNames;
	String[] sectionsFinal;
	String[] shiftTimesFinal;
	int rowCount;
	boolean end;
	String off;
	String pto;
	String loa;
	int daysInAWeek;
	
	
	//constructor, initialize variables
	public ReadWriteExcel(){
		daysInAWeek = 7;
		names = new String[daysInAWeek][30];
		times = new String[daysInAWeek][30];
		sections = new String[daysInAWeek][];
		mobile = new String[daysInAWeek][];
		allNames = new String[30];
		rowCount = 0;
		end = false;
		off = "OFF";
		pto = "PTO";
		loa = "LOA";
	}
	
	////////////////////////////////////////////////////////////////
	//					setAllEmployeeNames                		  //	
	// Method gets the names of all employees currently employed  //
	// and listed on the excel sheet for that shift(i.e swing)    //
	////////////////////////////////////////////////////////////////
	public void setAllEmployeeNames() throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx"); //location of excel file, import 'File' (java.io) class,
                // specifying excel file sheet location

		FileInputStream fis = new FileInputStream(src); //specify file source, import 'FileInputStream' (java.io), add
                // throw exception, base exception recommended

		XSSFWorkbook wb = new XSSFWorkbook(fis); //create fileinputstream class object, coming from apache poi,
                // changed to XSSFWorkbook on both sides, loads total workbook.. XSSFWorkbook is needed for .xlsx files

		XSSFSheet sheet1 = wb.getSheetAt(0); //index 0 = sheet one, if needed, can get sheet 2 = getSheetAt(1), etc...
		
		//declare and initialize local variables
		int startingRow = 9;
		String nameData;
		Pattern p = Pattern.compile(", ([A-Za-z]+)");
		
		while (!end){
			try{
				for(int i = 0; i < allNames.length; i++){
					nameData = sheet1.getRow(startingRow).getCell(1).getStringCellValue();
					Matcher m = p.matcher(nameData);
					m.find();
					allNames[i] = m.group(1);
					startingRow+=1;
				}
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close(); //close wb, prevent memory leak
	}
	
	////////////////////////////////////////////////////////////////
	//					setEmployeeNames                		  //	
	// Method reads excel sheet and gets the names of the         //
	// employees working for the day passed through the parameter //
	////////////////////////////////////////////////////////////////
	public void setEmployeeNames(int weekday) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx"); //location of excel file, import 'File' (java.io) class,
                // specifying excel file sheet location

		FileInputStream fis = new FileInputStream(src); //specify file source, import 'FileInputStream' (java.io), add
                // throw exception, base exception recommended

		XSSFWorkbook wb = new XSSFWorkbook(fis); //create fileinputstream class object, coming from apache poi,
                // changed to XSSFWorkbook on both sides, loads total workbook.. XSSFWorkbook is needed for .xlsx files

		XSSFSheet sheet1 = wb.getSheetAt(0); //index 0 = sheet one, if needed, can get sheet 2 = getSheetAt(1), etc...
		
		//declare and initialize local variables
		String nameData;
		int nameCell = 1;
		Pattern p = Pattern.compile(", ([A-Za-z]+)");
		int k = 0;
		int startingRow = 9;
		
		//Loop, get names, partially fill array with correct name format (first name only)
		while (!end){
			try{
				String dayData = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
				if(dayData.equals(off) || dayData.equals(pto) || dayData.equals(loa)){
					startingRow+=1;
					k+=1;
					continue;
				}
				else
					nameData = sheet1.getRow(startingRow).getCell(nameCell).getStringCellValue();
					Matcher m = p.matcher(nameData);
					m.find();
					names[weekday-3][startingRow-k-9] = m.group(1);
					startingRow+=1;
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close();  //close wb, memory leak warning
	}
	
	////////////////////////////////////////////////////////////////
	//					setWorkHours	                		  //	
	// Method reads excel sheet and gets the shift hours of the   //
	// employees working for the specified weekday				  //
	////////////////////////////////////////////////////////////////
	public void setEmployeeHours(int weekday) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx"); //location of excel file, import 'File' (java.io) class,
                // specifying excel file sheet location

		FileInputStream fis = new FileInputStream(src); //specify file source, import 'FileInputStream' (java.io), add
                // throw exception, base exception recommended

		XSSFWorkbook wb = new XSSFWorkbook(fis); //create fileinputstream class object, coming from apache poi,
                // changed to XSSFWorkbook on both sides, loads total workbook.. XSSFWorkbook is needed for .xlsx files

		XSSFSheet sheet1 = wb.getSheetAt(0); //index 0 = sheet one, if needed, can get sheet 2 = getSheetAt(1), etc...
		
		//declare and initialize local variables
		int index = 0;
		int startingRow = 9;
		
		while (!end){
			try{
				String dayData = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
				if(dayData.equals(off) || dayData.equals(pto) || dayData.equals(loa)){
					startingRow+=1;
					continue;
				}
				else
					times[weekday-3][index] = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
					index+=1;
					startingRow+=1;
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close(); //close wb, prevent memory leak
	}
	
	
	////////////////////////////////////////////////////////////////
	//					setSections		                		  //	
	// Method sets the sections based on the number of employees  //
	// available for any given day								  //
	////////////////////////////////////////////////////////////////
	public void setSections(int weekday) throws IOException{
		this.setEmployeeNames(weekday);
		int scheduleSize = this.getEmployeeNames(weekday).length;
		
		if(scheduleSize == 13)
			sections[weekday-3] = new String[] {"Front Floater", "1", "2", "3", "Breaker Front", "Back Floater",
                                "4", "5", "8", "9", "6", "7", "Breaker Back"};
		else if(scheduleSize == 12)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker Front", "Float All", "Breaker Back", "4",
                                "5", "8", "9", "6", "7"};
		else if(scheduleSize == 11)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker Front", "4", "5", "8", "9", "6", "7",
                                "Breaker Back"};
		else if(scheduleSize == 10)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker All", "4", "5", "8", "9", "6", "7"};
		else if(scheduleSize == 9)
			sections[weekday-3] = new String[] {"1", "2", "3", "4", "5", "8", "9", "6", "7"};
		else if(scheduleSize == 8)
			sections[weekday-3] = new String[] {"1,2", "2,1", "3,6,7", "4,5", "5,4", "8,9", "9,8", "6,7,3"};
		else if(scheduleSize == 7)
			sections[weekday-3] = new String[] {"1,2", "2,3", "4", "5", "8", "9", "6,7"};
		else if(scheduleSize == 6)
			sections[weekday-3] = new String[] {"1,2", "2,3", "Breaker All", "4,5", "8,9", "6,7"};
		else if(scheduleSize == 5)
			sections[weekday-3] = new String[] {"1,2", "2,3", "4,5", "8,9", "6,7"};
		else if(scheduleSize == 4)
			sections[weekday-3] = new String[] {"1,2,3", "6,7", "4,5", "8,9"};
		else if(scheduleSize == 3)
			sections[weekday-3] = new String[] {"1,2,3", "6,7,NSA", "4,5,8,9"};
	}
	
	////////////////////////////////////////////////////////////////
	//					setMobile		                		  //	
	// Method sets the mobile responders based on the number      //
	// of employees available for any given day					  //
	////////////////////////////////////////////////////////////////
	public void setMobile(int weekday) throws IOException{
		this.setEmployeeNames(weekday);
		int scheduleSize = this.getEmployeeNames(weekday).length;
		
		if(scheduleSize == 13)
			mobile[weekday-3] = new String[] {"1-3", "1,2,3", "1,2,3", "1,2,3", "1,2,3", "4-9", "4,5",
                              "5,4", "8,9", "9,8", "6,7", "7,6", "4-9"};
		else if(scheduleSize == 12)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "1,2,3", "All", "4-9", "4,5",
                              "5,4", "8,9", "9,8", "6,7", "7,6"};
		else if(scheduleSize == 11)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "1,2,3", "4,5", "5,4", "8,9",
                              "9,8", "6,7", "7,6", "4-9"};
		else if(scheduleSize == 10)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "All", "4,5", "5,4", "8,9",
                               "9,8", "6,7", "7,6"};
		else if(scheduleSize == 9)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "4,5", "5,4", "8,9", "9,8",
                              "6,7", "7,6"};
		else if(scheduleSize == 8)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "3,6,7", "4,5", "5,4", "8,9", "9,8",
                              "6,7,3"};
		else if(scheduleSize == 7)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "4,5", "5,4,8", "8,9,5", "9,8,5",
                              "6,7,3"};
		else if(scheduleSize == 6)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "All", "4,5,8", "8,9,5", "6,7,3"};
		else if(scheduleSize == 5)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL", "ALL", "ALL"};
		else if(scheduleSize == 4)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL", "ALL"};
		else if(scheduleSize == 3)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL"};
	}
	
	////////////////////////////////////////////////////////////////
	//					setRowCount			               		  //	
	// Method makes sure the number of rows in employee column is //
	// equal to the number of employees working that day		  //
	////////////////////////////////////////////////////////////////
	public void setRowCount() throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Daily Master.xlsx"); //location of excel file, import
                        // 'File' (java.io) class, specifying excel file sheet location
		FileInputStream fis = new FileInputStream(src); //specify file source, import 'FileInputStream'
                       // (java.io), add throw exception, base exception recommended
		XSSFWorkbook wb = new XSSFWorkbook(fis); //create fileinputstream class object, coming
                       // from apache poi, changed to XSSFWorkbook on both sides, loads total workbook..
                       // XSSFWorkbook is needed for .xlsx files
		XSSFSheet sheet1 = wb.getSheetAt(0); //index 0 = sheet one, if needed, can get sheet
                      // 2 = getSheetAt(1), etc...
		
		int startingRow = 5;
		String cellString = "";
		String host = "Casino Host";
		
		//Counts rows in weekly schedule excel file and stops at "Casino Host" string
		while (!end){
			try{
				for(int i = 0; i < 30; i++){
				cellString = sheet1.getRow(startingRow).getCell(0).getStringCellValue();
				startingRow++;
				rowCount++;
					if(cellString.equals(host)){
						end = true;
						break;
					}
				}
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		
		rowCount = rowCount - 5;
		
		wb.close();
	}
	
	////////////////////////////////////////////////////////////////
	//					getAllEmployeeNames                		  //	
	// Method returns an array of the names of all employees on   //
	// the excel sheet, working or off shift(i.e. swing) 		  //
	////////////////////////////////////////////////////////////////
	public String[] getAllEmployeeNames(){
		int nulls = 0;
		
		for(int i = 0; i < allNames.length; i++){
			if(allNames[i] != null)
				continue;
			else
				nulls++;
		}
		
		int newLength = (allNames.length) - nulls;
		String[] newAllNames = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newAllNames[j] = allNames[j];
		}
		return newAllNames;
	}
	
	////////////////////////////////////////////////////////////////
	//					getEmployeeNames                		  //	
	// Method returns an array of the names of employees working  //
	// for that day, parallel array with times[]                  //
	////////////////////////////////////////////////////////////////
	public String[] getEmployeeNames(int weekday){
		int nulls = 0;
		
		for(int i = 0; i < names[weekday-3].length; i++){
			if(names[weekday-3][i] != null)
				continue;
			else
				nulls++;
		}
		
		int newLength = (names[weekday-3].length) - nulls;
		String[] newNames = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newNames[j] = names[weekday-3][j];
		}
		return newNames;
	}
	
	
	////////////////////////////////////////////////////////////////
	//					getEmployeeTimes                		  //	
	// Method returns an array of the shift times the employees   //
	// are working for that day, parallel array with names[]      //
	////////////////////////////////////////////////////////////////
	public String[] getEmployeeHours(int weekday){
		int nulls = 0;
		
		//counts number of null values in array
		for(int i = 0; i < times[weekday-3].length; i++){
			if(times[weekday-3][i] != null)
				continue;
			else
				nulls++;
		}
		
		//creates new array without the null values
		int newLength = (times[weekday-3].length) - nulls;
		String[] newTimes = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newTimes[j] = times[weekday-3][j];
		}
		return newTimes;
	}
	
	////////////////////////////////////////////////////////////////
	//					formatShiftTimes			              //	
	// Removes the 'a' and 'p' from shift times (from Master) and //
	// creates a new array with the formatted shift times		  //
	////////////////////////////////////////////////////////////////
	public String[] formatEmployeeHours(String[] shiftTimes){
		String unformatTime = "";
		int length = shiftTimes.length;
		String[] shiftTimesFinal = new String[length];
		for(int i = 0; i < shiftTimes.length; i++){
			unformatTime = shiftTimes[i];
			String newTime = "";
			for(int j = 0; j < unformatTime.length(); j++){
				char c = unformatTime.charAt(j);
				if(c == 'a' || c == 'p')
					continue;
				else
					newTime += c;
			}
			shiftTimesFinal[i] = newTime;
		}
	return shiftTimesFinal;
	}
	
	////////////////////////////////////////////////////////////////
	//					getSections			               		  //	
	// Method returns an array of the sections the employees      //
	// are working in that day								      //
	////////////////////////////////////////////////////////////////
	public String[] getSections(int weekday){
		return sections[weekday-3];
	}
	
	////////////////////////////////////////////////////////////////
	//					getMobile			               		  //	
	// Method returns an array of the mobile values the employees //
	// are using for that day, parallel array with getSections[]  //
	////////////////////////////////////////////////////////////////
	public String[] getMobile(int weekday){
		return mobile[weekday-3];
	}
	
	////////////////////////////////////////////////////////////////
	//					getRowCount		               		      //	
	// Method returns an the row count for number of employees    //
	////////////////////////////////////////////////////////////////
	public int getRowCount(){
		return rowCount;
	}
	
	
	////////////////////////////////////////////////////////////////
	//					outputExcel								  //	
	// Method takes in arrays in their organized format and 	  //
	// outputs them to a new excel document (daily schedules)	  //
	////////////////////////////////////////////////////////////////
	@SuppressWarnings("deprecation")
	public void outputExcel(int weekday, String[] names, String[] shifts, String[] break1, String[] break2) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Daily Master.xlsx"); //location of excel file, import 'File'
                // (java.io) class, specifying excel file sheet location
		FileInputStream fis = new FileInputStream(src); //specify file source, import 'FileInputStream' (java.io),
                // add throw exception, base exception recommended
		XSSFWorkbook wb = new XSSFWorkbook(fis); //create fileinputstream class object, coming from apache
                // poi, changed to XSSFWorkbook on both sides, loads total workbook.. XSSFWorkbook is needed for .xlsx files
		XSSFSheet sheet1 = wb.getSheetAt(0); //index 0 = sheet one, if needed, can get sheet 2 = getSheetAt(1), etc...
		
		//local variables
		//int finalRowNum = this.getEmployeeNames(weekday).length;
                // (use length of array to determine number of rows in excel 
		//	sheet, NOT USED, format problem after row shift)
		int rowNum = 5;
		String fileName = "";
		Cell cell = sheet1.getRow(0).getCell(0);
		int columnSection = 0;
		int columnName = 2;
		int columnShift = 3;
		int columnBreak1 = 4;
		int columnBreak2 = 5;
		int columnMobileResp = 6;
		
		String[] arraySections = this.getSections(weekday);
		String[] arrayNames = names;
		String[] arrayShift = shifts;
		String[] arrayBreak1 = break1;
		String[] arrayBreak2 = break2;
		String[] arrayMobile = this.getMobile(weekday);
		
		//determine file name for daily excel sheet
		if(weekday == 3)
			fileName = "MONDAY";
		else if(weekday == 4)
			fileName = "TUESDAY";
		else if(weekday == 5)
			fileName = "WEDNESDAY";
		else if(weekday == 6)
			fileName = "THURSDAY";
		else if(weekday == 7)
			fileName = "FRIDAY";
		else if(weekday == 8)
			fileName = "SATURDAY";
		else
			fileName = "SUNDAY";
		
		// Create a new font and alter it.
	    Font font = wb.createFont();
	    font.setFontHeightInPoints((short)14);
	    font.setFontName("Century Gothic");

	    // Sets new font and cell style appropriate for output
	    XSSFCellStyle style = wb.createCellStyle();
	    style.setFont(font);
	    style.setAlignment(CellStyle.ALIGN_CENTER);
	    style.setVerticalAlignment(CellStyle.VERTICAL_CENTER);
	    style.setBorderBottom(CellStyle.BORDER_THIN);
	    style.setBorderTop(CellStyle.BORDER_THIN);
	    style.setBorderRight(CellStyle.BORDER_THIN);
	    style.setBorderLeft(CellStyle.BORDER_THIN);
	    
	    // Output day of the week
	    cell = sheet1.getRow(2).getCell(5);
	    cell.setCellValue(fileName);
	    cell.setCellStyle(style);
	    
	    // Output Sections
	    rowNum = 5;
	    for(int i = 0; i < arraySections.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnSection);
		    cell.setCellValue(arraySections[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    
	    // Output names
	    rowNum = 5;
	    for(int i = 0; i < arrayNames.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnName);
		    cell.setCellValue(arrayNames[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output shift
	    rowNum = 5;
	    for(int i = 0; i < arrayShift.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnShift);
		    cell.setCellValue(arrayShift[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	  
	 
	    // Output break1
	    rowNum = 5;
	    for(int i = 0; i < arrayBreak1.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnBreak1);
		    cell.setCellValue(arrayBreak1[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output break2
	    rowNum = 5;
	    for(int i = 0; i < arrayBreak2.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnBreak2);
		    cell.setCellValue(arrayBreak2[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output mobile responders
	    rowNum = 5;
	    for(int i = 0; i < arrayMobile.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnMobileResp);
		    cell.setCellValue(arrayMobile[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
		
		FileOutputStream fileOut = new FileOutputStream(new File("D:\\Eclipse\\Schedule\\Daily Schedules\\" + fileName + ".xlsx"));
	    wb.write(fileOut);
	    fileOut.close();
	    System.out.println(fileName + " file output complete");
		
	    fis.close(); 
		wb.close();
	}
}

import java.io.File;
import java.io.FileInputStream;
import java.io.FileOutputStream;
import java.io.IOException;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.CellStyle;
import org.apache.poi.ss.usermodel.Font;
import org.apache.poi.ss.usermodel.Row;
import org.apache.poi.xssf.usermodel.XSSFCellStyle;
import org.apache.poi.xssf.usermodel.XSSFSheet;
import org.apache.poi.xssf.usermodel.XSSFWorkbook;

import java.util.*;

public class Driver {

	public static void main(String[] args) throws IOException 
	{
		//declare variables
		int MON = 3;
		int TUE = 4;
		int WED = 5;
		int THUR = 6;
		int FRI = 7;
		int SAT = 8;
		int SUN = 9;
		
		ReadWriteExcel schedule = new ReadWriteExcel();
		
		schedule.setAllEmployeeNames();
		
		schedule.setEmployeeNames(MON);
		
		schedule.setEmployeeHours(MON);
		
		schedule.formatEmployeeHours(schedule.getEmployeeHours(MON));
		
		schedule.setSections(MON);
		
		schedule.setMobile(MON);
		
		//set the number of rows available in excel sheet for employee spaces
		//Daily Master currently has 13 rows available for employees
		schedule.setRowCount();
		
		//schedule.outputExcel(MON, MONDAY.names(), MONDAY.shifts(), MONDAY.breaks1(), MONDAY.breaks2());
		
	}

}

One thing I wanted the program to do, but was having a hard time implementing was a rotation for the employees (rotate the employees through the sections so they wouldn't work the same section multiple times a week). I was thinking I could serialize an array for each employee, for example {0,0,0,0, etc...} with the available sections as the index. The program would deserialize the array, compare the values (lowest value assigns employee to that section, if values are equal (multiple zeros), randomly picks an employee for that section), +1 to the element of that index if employee is assigned to the section, and serialize the array again. This would occur for some period of time (2 weeks?) or deserialization amount and then reset the values back to zero.

I have never worked with serializing objects, so I'm not sure if it's possible. Would this method work?

Thankyou for any feedback!

[Carey Brown]

int newLength = (allNames.length) - nulls;

Drop the parens, they are unnecessary. You should become very familiar with operator precedence in order to avoid clutter. On the flip side, parens are encouraged when doing bit manipulation because most programmers are only somewhat familiar with bit operator precedence.

String off;
...
off = "OFF";

should be

private static final String OFF = "OFF";

This is really a constant and as such the name should be in all CAPS. You have a number of variables that should be implemented as constants.

            try{
                String dayData = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
                if(dayData.equals(off) || dayData.equals(pto) || dayData.equals(loa)){
                    startingRow+=1;
                    k+=1;
                    continue;
                }
                else
                    nameData = sheet1.getRow(startingRow).getCell(nameCell).getStringCellValue();
                    Matcher m = p.matcher(nameData);
                    m.find();
                    names[weekday-3][startingRow-k-9] = m.group(1);
                    startingRow+=1;
            }
            catch(Exception e)
                {end = true;}

The "else" is missing braces and the indentation implies that the 5 statements below are part of the "else" block, which they are not.

As far as OOP goes, look for nouns, e.g. "Employee". That will suggest classes that you will need to make. Look for "is-a" relationship between classes, that will suggest using inheritance (may not apply to your specific application. Look for "has-a" relationships, that will suggest what classes should contain other classes as fields, especially fields that need to be implemented as a collection, e.g. list-of or array-of.

Working with POI is a bit tricky. My inclination is to read the spreadsheet file into classes, do all my work with the classes, then write all the classes back out to a spreadsheet file. Where this gets weird is that the spreadsheet has knowledge of things like column headers. POI will read them into the POI structure but doesn't really give you a way to recreate some of that structure starting from data stored in class instances. The POI structure is also implemented as a sparse array which is not always easily replicated when going from classes back to spreadsheet.

When you break this down into OOP you should end up with only one read() and one write() (or load() and save()) method.

[Carey Brown]

I don't know if this site will let you go back and edit your original post but your long lines (anything longer than 80-120 characters) are making your post extremely difficult to read. Please edit and fix if you can.

[Carey Brown]

Jeremy Pierson wrote:Hello everyone,

I just finished my first semester in Java and for my final project I decided to create a program that would read an excel sheet, sort the data, and output the new data to a new excel sheet. I got the program to work and my professor loved the idea. He said I could make the project easier by making it more object oriented. I wasn't able to get him to elaborate on specifics before the semester ended, so I figured I would ask here. I decided to re-do a good portion of the program. Some of the comments are irrelevant, I had to teach myself to use Java with excel, so a few comments are just instructions/reminders.

Here is what I have so far.

Here is the excel sheet I am reading from (minus the names): http://imgur.com/a/dLZbu  (image tags didn't work)

Your image link above didn't work either.

Here is an example of the output: http://imgur.com/a/2AgT4

One thing I wanted the program to do, but was having a hard time implementing was a rotation for the employees (rotate the employees through the sections so they wouldn't work the same section multiple times a week). I was thinking I could serialize an array for each employee, for example {0,0,0,0, etc...} with the available sections as the index. The program would deserialize the array, compare the values (lowest value assigns employee to that section, if values are equal (multiple zeros), randomly picks an employee for that section), +1 to the element of that index if employee is assigned to the section, and serialize the array again. This would occur for some period of time (2 weeks?) or deserialization amount and then reset the values back to zero.

I have never worked with serializing objects, so I'm not sure if it's possible. Would this method work?

It's hard to guide you through OO without having more information about the problem domain.

Does a Schedule have Employees? Or does a Schedule have Shifts that have Sections that have Employees? You see where I'm going? You need to break the problem down into relationships between entities.

        if(scheduleSize == 13)
            sections[weekday-3] = new String[] {"Front Floater", "1", "2", "3", "Breaker Front", "Back Floater", "4", "5", "8", "9", "6", "7", "Breaker Back"};
        else if(scheduleSize == 12)
            sections[weekday-3] = new String[] {"1", "2", "3", "Breaker Front", "Float All", "Breaker Back", "4", "5", "8", "9", "6", "7"};

Code like above may indicate what you want to see in the output spreadsheet but it doesn't give you a logical representation that you can process easily. These strings shouldn't be necessary until you go to write the output. For a logical representation you might consider making an enum of all of the individual cases, e.g. "Breaker Back" or "3", and have a list of those for each section.

Regarding serialization/deserialization (assuming you mean this in the Java vernacular), forget about it. If you have a good logical layout to your classes you should easily be able to copy lists or arrays of data or you can create copy constructors for your own classes to copy them.

[Jeremy Pierson]

Your image link above didn't work either.

Sorry, try this:  https://postimg.org/gallery/2uip5qyn4/

It's hard to guide you through OO without having more information about the problem domain.

Does a Schedule have Employees? Or does a Schedule have Shifts that have Sections that have Employees? You see where I'm going? You need to break the problem down into relationships between entities.  

That makes sense. I'll give it some thought. Thankyou

.....
Code like above may indicate what you want to see in the output spreadsheet but it doesn't give you a logical representation that you can process easily. These strings shouldn't be necessary until you go to write the output. For a logical representation you might consider making an enum of all of the individual cases, e.g. "Breaker Back" or "3", and have a list of those for each section.

Regarding serialization/deserialization (assuming you mean this in the Java vernacular), forget about it. If you have a good logical layout to your classes you should easily be able to copy lists or arrays of data or you can create copy constructors for your own classes to copy them

I use those arrays more as constants. Depending on the number of employees, those arrays will remain the same, the other arrays are changed depending on other circumstances and are then aligned with the "constant" arrays. I had to look up enum data types, I don't remember using those much. "An enum type is a special data type that enables for a variable to be a set of predefined constants." You're correct, it would make more sense if they were enum lists rather than arrays. I'll work on that.

As for the serialization issue. I'm not really following how the copy lists or copy constructors would work for that. Would the data be saved when the program is closed and re-opened the following day? i.e. Employee1 worked "3" yesterday, therefore they aren't assigned "3" today?

Drop the parens, they are unnecessary. You should become very familiar with operator precedence in order to avoid clutter. On the flip side, parens are encouraged when doing bit manipulation because most programmers are only somewhat familiar with bit operator precedence.

Fixed, not sure what I was doing there.

"OFF" ... This is really a constant and as such the name should be in all CAPS. You have a number of variables that should be implemented as constants.

The "else" is missing braces and the indentation implies that the 5 statements below are part of the "else" block, which they are not.

Fixed, thankyou

As far as OOP goes, look for nouns, e.g. "Employee". That will suggest classes that you will need to make. Look for "is-a" relationship between classes, that will suggest using inheritance (may not apply to your specific application. Look for "has-a" relationships, that will suggest what classes should contain other classes as fields, especially fields that need to be implemented as a collection, e.g. list-of or array-of.
...
When you break this down into OOP you should end up with only one read() and one write() (or load() and save()) method.

I had a hard time thinking of a way to implement inheritance (is-a relationship). I actually had an "Employee" class in the previous version I made, but was planning on re-doing it.

import java.util.regex.*;
public class Employee
{
    private String name;
    private boolean pregnant = false;
    private boolean fullTime;
    private int[] starts = new int[7];
    private int[] finishes = new int[7];
    private String[] week = new String[7];
    private int[] history = {0,0,0,0,0,0,0,0,0,0,0,0,0};
    private int[] firstBreaks = new int[7];
    private int[] secondBreaks = new int[7];
    //holds an array of their past sections
    //weekday is associated by index ie - 
    //0 == monday, 1 == tuesday etc
    //breaker front = 12, breaker back = 13, float all = 14
    
    public Employee(String localName){
        name = localName;
    }
    public String getName(){
        return name;
    }
    public void setPregnancy(){
        pregnant = true;
    }
    public boolean getPregnancy(){
        return pregnant;
    }
    public boolean getContract(){
        return fullTime;
    }
    public void setStart(int day, int start){
        starts[day] = start;
    }
    public void setFinish(int day, int finish){
        finishes[day] = finish;
    }
    public void setShift(int day, int start, int finish){
        starts[day] = start;
        finishes[day] = finish;
    }
    public void setType(boolean type){
        fullTime = type;
    }
    public int[] start(){
        return starts;
    }
    public int[] finish(){
        return finishes;
    }
    //called by saying the weekday ie 3 for thursday
    public void setSection(int day, String section){
        week[day] = section;
        int[] sections = HelperFunctions.convertSection(section);
        for (int sect : sections){
            history[sect] += 1;
        }
    }
    public String[] getWeek(){
        return week;
    }
    public int[] getHistory(){
        return history;
    }
    public void setBreaks(int first, int second, int day){
        firstBreaks[day] = first;
        secondBreaks[day] = second;
    }
    public void setFirstBreaks(int first, int day){
        firstBreaks[day] = first;
    }
    public void setSecondBreaks(int second, int day){
        secondBreaks[day] = second;
    }
    public int[] firstBreaks(){
        return firstBreaks;
    }
    public int[] secondBreaks(){
        return secondBreaks;
    }
} 

I don't know if this site will let you go back and edit your original post but your long lines (anything longer than 80-120 characters) are making your post extremely difficult to read. Please edit and fix if you can.

It doesn't appear I am able to edit the original post, but here is the cleaned up code:

import java.io.File;
import java.io.FileInputStream;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

import org.apache.poi.ss.usermodel.Cell;
import org.apache.poi.ss.usermodel.CellStyle;
import org.apache.poi.ss.usermodel.Font;
import org.apache.poi.xssf.usermodel.*;


public class ReadWriteExcel {
	
	//constants
	private static final String OFF = "OFF";
	private static final String PTO = "PTO";
	private static final String LOA = "LOA";
	private static final int DAYS_IN_WEEK = 7;
	
	//declared instance variables
	String[][] names;
	String[][] times;
	String[][] sections;
	String[][] mobile;
	String[] allNames;
	String[] sectionsFinal;
	String[] shiftTimesFinal;
	int rowCount;
	boolean end;
	
	
	//constructor, initialize variables
	public ReadWriteExcel(){
		names = new String[DAYS_IN_WEEK][30];
		times = new String[DAYS_IN_WEEK][30];
		sections = new String[DAYS_IN_WEEK][];
		mobile = new String[DAYS_IN_WEEK][];
		allNames = new String[30];
		rowCount = 0;
		end = false;
	}
	
	////////////////////////////////////////////////////////////////
	//					setAllEmployeeNames                		  //	
	// Method gets the names of all employees currently employed  //
	// and listed on the excel sheet for that shift(i.e swing)    //
	////////////////////////////////////////////////////////////////
	public void setAllEmployeeNames() throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx"); 
		FileInputStream fis = new FileInputStream(src); 
		XSSFWorkbook wb = new XSSFWorkbook(fis); 
		XSSFSheet sheet1 = wb.getSheetAt(0); 
		
		//declare and initialize local variables
		int startingRow = 9;
		String nameData;
		Pattern p = Pattern.compile(", ([A-Za-z]+)");
		
		while (!end){
			try{
				for(int i = 0; i < allNames.length; i++){
					nameData = sheet1.getRow(startingRow).getCell(1).getStringCellValue();
					Matcher m = p.matcher(nameData);
					m.find();
					allNames[i] = m.group(1);
					startingRow+=1;
				}
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close(); //close wb, prevent memory leak
	}
	
	////////////////////////////////////////////////////////////////
	//					setEmployeeNames                		  //	
	// Method reads excel sheet and gets the names of the         //
	// employees working for the day passed through the parameter //
	////////////////////////////////////////////////////////////////
	public void setEmployeeNames(int weekday) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx"); 
		FileInputStream fis = new FileInputStream(src); 
		XSSFWorkbook wb = new XSSFWorkbook(fis); 
		XSSFSheet sheet1 = wb.getSheetAt(0); 
		
		//declare and initialize local variables
		String nameData;
		int nameCell = 1;
		Pattern p = Pattern.compile(", ([A-Za-z]+)");
		int k = 0;
		int startingRow = 9;
		
		//Loop, get names, partially fill array with correct name format (first name only)
		while (!end){
			try{
				String dayData = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
				if(dayData.equals(OFF) || dayData.equals(PTO) || dayData.equals(LOA)){
					startingRow+=1;
					k+=1;
					continue;
				}
				else{
					nameData = sheet1.getRow(startingRow).getCell(nameCell).getStringCellValue();
				}
				Matcher m = p.matcher(nameData);
				m.find();
				names[weekday-3][startingRow-k-9] = m.group(1);
				startingRow+=1;
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close();  //close wb, memory leak warning
	}
	
	////////////////////////////////////////////////////////////////
	//					setWorkHours	                		  //	
	// Method reads excel sheet and gets the shift hours of the   //
	// employees working for the specified weekday				  //
	////////////////////////////////////////////////////////////////
	public void setEmployeeHours(int weekday) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Weekly.xlsx");
		FileInputStream fis = new FileInputStream(src); 
		XSSFWorkbook wb = new XSSFWorkbook(fis);
		XSSFSheet sheet1 = wb.getSheetAt(0); 
		
		//declare and initialize local variables
		int index = 0;
		int startingRow = 9;
		
		while (!end){
			try{
				String dayData = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
				if(dayData.equals(OFF) || dayData.equals(PTO) || dayData.equals(LOA)){
					startingRow+=1;
					continue;
				}
				else
					times[weekday-3][index] = sheet1.getRow(startingRow).getCell(weekday).getStringCellValue();
					index+=1;
					startingRow+=1;
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		wb.close(); //close wb, prevent memory leak
	}
	
	
	////////////////////////////////////////////////////////////////
	//					setSections		                		  //	
	// Method sets the sections based on the number of employees  //
	// available for any given day								  //
	////////////////////////////////////////////////////////////////
	public void setSections(int weekday) throws IOException{
		this.setEmployeeNames(weekday);
		int scheduleSize = this.getEmployeeNames(weekday).length;
		
		if(scheduleSize == 13)
			sections[weekday-3] = new String[] {"Front Floater", "1", "2", "3", "Breaker Front", 
												"Back Floater", "4", "5", "8", "9", "6", "7", "Breaker Back"};
		else if(scheduleSize == 12)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker Front",
												"Float All", "Breaker Back", "4", "5", "8", "9", "6", "7"};
		else if(scheduleSize == 11)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker Front",
												"4", "5", "8", "9", "6", "7", "Breaker Back"};
		else if(scheduleSize == 10)
			sections[weekday-3] = new String[] {"1", "2", "3", "Breaker All", "4", "5", "8", "9", "6", "7"};
		else if(scheduleSize == 9)
			sections[weekday-3] = new String[] {"1", "2", "3", "4", "5", "8", "9", "6", "7"};
		else if(scheduleSize == 8)
			sections[weekday-3] = new String[] {"1,2", "2,1", "3,6,7", "4,5", "5,4", "8,9", "9,8", "6,7,3"};
		else if(scheduleSize == 7)
			sections[weekday-3] = new String[] {"1,2", "2,3", "4", "5", "8", "9", "6,7"};
		else if(scheduleSize == 6)
			sections[weekday-3] = new String[] {"1,2", "2,3", "Breaker All", "4,5", "8,9", "6,7"};
		else if(scheduleSize == 5)
			sections[weekday-3] = new String[] {"1,2", "2,3", "4,5", "8,9", "6,7"};
		else if(scheduleSize == 4)
			sections[weekday-3] = new String[] {"1,2,3", "6,7", "4,5", "8,9"};
		else if(scheduleSize == 3)
			sections[weekday-3] = new String[] {"1,2,3", "6,7,NSA", "4,5,8,9"};
	}
	
	////////////////////////////////////////////////////////////////
	//					setMobile		                		  //	
	// Method sets the mobile responders based on the number      //
	// of employees available for any given day					  //
	////////////////////////////////////////////////////////////////
	public void setMobile(int weekday) throws IOException{
		this.setEmployeeNames(weekday);
		int scheduleSize = this.getEmployeeNames(weekday).length;
		
		if(scheduleSize == 13)
			mobile[weekday-3] = new String[] {"1-3", "1,2,3", "1,2,3", "1,2,3", "1,2,3",
											  "4-9", "4,5", "5,4", "8,9", "9,8", "6,7", "7,6", "4-9"};
		else if(scheduleSize == 12)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "1,2,3", 
											  "All", "4-9", "4,5", "5,4", "8,9", "9,8", "6,7", "7,6"};
		else if(scheduleSize == 11)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "1,2,3",
											  "4,5", "5,4", "8,9", "9,8", "6,7", "7,6", "4-9"};
		else if(scheduleSize == 10)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "All",
											  "4,5", "5,4", "8,9", "9,8", "6,7", "7,6"};
		else if(scheduleSize == 9)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "1,2,3", "4,5",
											  "5,4", "8,9", "9,8", "6,7", "7,6"};
		else if(scheduleSize == 8)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "3,6,7", "4,5", "5,4", "8,9", "9,8", "6,7,3"};
		else if(scheduleSize == 7)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "4,5", "5,4,8", "8,9,5", "9,8,5", "6,7,3"};
		else if(scheduleSize == 6)
			mobile[weekday-3] = new String[] {"1,2,3", "1,2,3", "All", "4,5,8", "8,9,5", "6,7,3"};
		else if(scheduleSize == 5)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL", "ALL", "ALL"};
		else if(scheduleSize == 4)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL", "ALL"};
		else if(scheduleSize == 3)
			mobile[weekday-3] = new String[] {"ALL", "ALL", "ALL"};
	}
	
	////////////////////////////////////////////////////////////////
	//					setRowCount			               		  //	
	// Method makes sure the number of rows in employee column is //
	// equal to the number of employees working that day		  //
	////////////////////////////////////////////////////////////////
	public void setRowCount() throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Daily Master.xlsx");
		FileInputStream fis = new FileInputStream(src);
		XSSFWorkbook wb = new XSSFWorkbook(fis);
		XSSFSheet sheet1 = wb.getSheetAt(0); 
		
		int startingRow = 5;
		String cellString = "";
		String host = "Casino Host";
		
		//Counts rows in weekly schedule excel file and stops at "Casino Host" string
		while (!end){
			try{
				for(int i = 0; i < 30; i++){
				cellString = sheet1.getRow(startingRow).getCell(0).getStringCellValue();
				startingRow++;
				rowCount++;
					if(cellString.equals(host)){
						end = true;
						break;
					}
				}
			}
			catch(Exception e)
				{end = true;}
		}
		end = false;
		
		rowCount = rowCount - 5;
		
		wb.close();
	}
	
	////////////////////////////////////////////////////////////////
	//					getAllEmployeeNames                		  //	
	// Method returns an array of the names of all employees on   //
	// the excel sheet, working or off shift(i.e. swing) 		  //
	////////////////////////////////////////////////////////////////
	public String[] getAllEmployeeNames(){
		int nulls = 0;
		
		for(int i = 0; i < allNames.length; i++){
			if(allNames[i] != null)
				continue;
			else
				nulls++;
		}
		
		int newLength = allNames.length - nulls;
		String[] newAllNames = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newAllNames[j] = allNames[j];
		}
		return newAllNames;
	}
	
	////////////////////////////////////////////////////////////////
	//					getEmployeeNames                		  //	
	// Method returns an array of the names of employees working  //
	// for that day, parallel array with times[]                  //
	////////////////////////////////////////////////////////////////
	public String[] getEmployeeNames(int weekday){
		int nulls = 0;
		
		for(int i = 0; i < names[weekday-3].length; i++){
			if(names[weekday-3][i] != null)
				continue;
			else
				nulls++;
		}
		
		int newLength = (names[weekday-3].length) - nulls;
		String[] newNames = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newNames[j] = names[weekday-3][j];
		}
		return newNames;
	}
	
	
	////////////////////////////////////////////////////////////////
	//					getEmployeeTimes                		  //	
	// Method returns an array of the shift times the employees   //
	// are working for that day, parallel array with names[]      //
	////////////////////////////////////////////////////////////////
	public String[] getEmployeeHours(int weekday){
		int nulls = 0;
		
		//counts number of null values in array
		for(int i = 0; i < times[weekday-3].length; i++){
			if(times[weekday-3][i] != null)
				continue;
			else
				nulls++;
		}
		
		//creates new array without the null values
		int newLength = (times[weekday-3].length) - nulls;
		String[] newTimes = new String[newLength];
		
		for(int j = 0; j < newLength; j++){
			newTimes[j] = times[weekday-3][j];
		}
		return newTimes;
	}
	
	////////////////////////////////////////////////////////////////
	//					formatShiftTimes			              //	
	// Removes the 'a' and 'p' from shift times (from Master) and //
	// creates a new array with the formatted shift times		  //
	////////////////////////////////////////////////////////////////
	public String[] formatEmployeeHours(String[] shiftTimes){
		String unformatTime = "";
		int length = shiftTimes.length;
		String[] shiftTimesFinal = new String[length];
		for(int i = 0; i < shiftTimes.length; i++){
			unformatTime = shiftTimes[i];
			String newTime = "";
			for(int j = 0; j < unformatTime.length(); j++){
				char c = unformatTime.charAt(j);
				if(c == 'a' || c == 'p')
					continue;
				else
					newTime += c;
			}
			shiftTimesFinal[i] = newTime;
		}
	return shiftTimesFinal;
	}
	
	////////////////////////////////////////////////////////////////
	//					getSections			               		  //	
	// Method returns an array of the sections the employees      //
	// are working in that day								      //
	////////////////////////////////////////////////////////////////
	public String[] getSections(int weekday){
		return sections[weekday-3];
	}
	
	////////////////////////////////////////////////////////////////
	//					getMobile			               		  //	
	// Method returns an array of the mobile values the employees //
	// are using for that day, parallel array with getSections[]  //
	////////////////////////////////////////////////////////////////
	public String[] getMobile(int weekday){
		return mobile[weekday-3];
	}
	
	////////////////////////////////////////////////////////////////
	//					getRowCount		               		      //	
	// Method returns an the row count for number of employees    //
	////////////////////////////////////////////////////////////////
	public int getRowCount(){
		return rowCount;
	}
	
	
	////////////////////////////////////////////////////////////////
	//					outputExcel								  //	
	// Method takes in arrays in their organized format and 	  //
	// outputs them to a new excel document (daily schedules)	  //
	////////////////////////////////////////////////////////////////
	@SuppressWarnings("deprecation")
	public void outputExcel(int weekday, String[] names, String[] shifts,
							String[] break1, String[] break2) throws IOException{
		File src = new File("D:\\Eclipse\\Schedule\\Daily Master.xlsx");
		FileInputStream fis = new FileInputStream(src); 
		XSSFWorkbook wb = new XSSFWorkbook(fis);
		XSSFSheet sheet1 = wb.getSheetAt(0); 
		
		//local variables
		//int finalRowNum = this.getEmployeeNames(weekday).length; 
		//(use length of array to determine number of rows in excel 
		//sheet, NOT USED, format problem after row shift)
		
		int rowNum = 5;
		String fileName = "";
		Cell cell = sheet1.getRow(0).getCell(0);
		int columnSection = 0;
		int columnName = 2;
		int columnShift = 3;
		int columnBreak1 = 4;
		int columnBreak2 = 5;
		int columnMobileResp = 6;
		
		String[] arraySections = this.getSections(weekday);
		String[] arrayNames = names;
		String[] arrayShift = shifts;
		String[] arrayBreak1 = break1;
		String[] arrayBreak2 = break2;
		String[] arrayMobile = this.getMobile(weekday);
		
		//determine file name for daily excel sheet
		if(weekday == 3)
			fileName = "MONDAY";
		else if(weekday == 4)
			fileName = "TUESDAY";
		else if(weekday == 5)
			fileName = "WEDNESDAY";
		else if(weekday == 6)
			fileName = "THURSDAY";
		else if(weekday == 7)
			fileName = "FRIDAY";
		else if(weekday == 8)
			fileName = "SATURDAY";
		else
			fileName = "SUNDAY";
		
		// Create a new font and alter it.
	    Font font = wb.createFont();
	    font.setFontHeightInPoints((short)14);
	    font.setFontName("Century Gothic");

	    // Sets new font and cell style appropriate for output
	    XSSFCellStyle style = wb.createCellStyle();
	    style.setFont(font);
	    style.setAlignment(CellStyle.ALIGN_CENTER);
	    style.setVerticalAlignment(CellStyle.VERTICAL_CENTER);
	    style.setBorderBottom(CellStyle.BORDER_THIN);
	    style.setBorderTop(CellStyle.BORDER_THIN);
	    style.setBorderRight(CellStyle.BORDER_THIN);
	    style.setBorderLeft(CellStyle.BORDER_THIN);
	    
	    // Output day of the week
	    cell = sheet1.getRow(2).getCell(5);
	    cell.setCellValue(fileName);
	    cell.setCellStyle(style);
	    
	    // Output Sections
	    rowNum = 5;
	    for(int i = 0; i < arraySections.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnSection);
		    cell.setCellValue(arraySections[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    
	    // Output names
	    rowNum = 5;
	    for(int i = 0; i < arrayNames.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnName);
		    cell.setCellValue(arrayNames[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output shift
	    rowNum = 5;
	    for(int i = 0; i < arrayShift.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnShift);
		    cell.setCellValue(arrayShift[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	  
	 
	    // Output break1
	    rowNum = 5;
	    for(int i = 0; i < arrayBreak1.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnBreak1);
		    cell.setCellValue(arrayBreak1[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output break2
	    rowNum = 5;
	    for(int i = 0; i < arrayBreak2.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnBreak2);
		    cell.setCellValue(arrayBreak2[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
	    
	    // Output mobile responders
	    rowNum = 5;
	    for(int i = 0; i < arrayMobile.length; i++){
		    cell = sheet1.getRow(rowNum).getCell(columnMobileResp);
		    cell.setCellValue(arrayMobile[i]);
		    cell.setCellStyle(style);
		    rowNum++;
	    }
		
		FileOutputStream fileOut = new FileOutputStream(new File("D:\\Eclipse\\Schedule\\Daily Schedules\\" + fileName + ".xlsx"));
	    wb.write(fileOut);
	    fileOut.close();
	    System.out.println(fileName + " file output complete");
		
	    fis.close(); 
		wb.close();
	}
}

[Carey Brown]

Carey Brown wrote:Regarding serialization/deserialization (assuming you mean this in the Java vernacular), forget about it. If you have a good logical layout to your classes you should easily be able to copy lists or arrays of data or you can create copy constructors for your own classes to copy them...

Jeeremy Pierson wrote:As for the serialization issue. I'm not really following how the copy lists or copy constructors would work for that. Would the data be saved when the program is closed and re-opened the following day? i.e. Employee1 worked "3" yesterday, therefore they aren't assigned "3" today?

Sorry, I may have misinterpreted your intentions for serialization. There's a trick you can do with serialization to copy a complex structure of classes and that is what I thought you were talking about. Now I see you mean serialization for the persistence layer.

[Carey Brown]

Jeremy Pierson wrote:I had a hard time thinking of a way to implement inheritance (is-a relationship).

You don't necessarily have an "is-a" relationship, but just keep your eye out in case one becomes apparent. As an example, you might have an Employee and a subclass Contractor, in which case you would have Contractor is-an Employee.

Some comments on your Employee class, mostly based on Java programming conventions.

Often when you have a boolean field the name will be prefixed with "is", as in "isPregnant" and "isFullTime". Then the setters would be setPregnant() and setFullTime() and the getters would be isPregnant() and isFullTime().

You have a method getContract() but it returns fullTime. Again, better expressed as isFullTime().

You use the magic number '7', you might want to define a constant "DAYS_IN_WEEK", if that's what you are meaning. Then use the constant.

You have "starts", "finishes", "firstBreaks", and "secondBreaks", all with a size of '7'. A possiblility would be to combine these into a class like "Period"(?, or something more appropriately named). Then have a Period array of length '7'. Perhaps you "week" should be a part of this as well. It's a little difficult here for me to infer your intended usage.

[Jeremy Pierson]

Carey Brown wrote:

Jeremy Pierson wrote:I had a hard time thinking of a way to implement inheritance (is-a relationship).

You don't necessarily have an "is-a" relationship, but just keep your eye out in case one becomes apparent. As an example, you might have an Employee and a subclass Contractor, in which case you would have Contractor is-an Employee.

Often when you have a boolean field the name will be prefixed with "is", as in "isPregnant" and "isFullTime". Then the setters would be setPregnant() and setFullTime() and the getters would be isPregnant() and isFullTime().

You have a method getContract() but it returns fullTime. Again, better expressed as isFullTime().

I see. To be honest. That class was thrown together pretty quick when the project's due date was coming up. I was not familiar with the boolean convention. That helps. I will keep an eye out for any possible inheritence. Thank you for your feedback. Gives me a bit to work on. Ill check back when I make some progress to see if there are any other areas I need to work on.