Intent doesn't work from onClickListener

[Milos Gojic]

Hello ..to make long story short, root of my problem and my frustation :

I am making an app with two Floating Buttons

When user click my floating button he will be able to go to dial up screen and call phone number.For some reason doesn't work..

I already have intent,in the same activity, where he will able to go to SMS screen and be able to send a text.For some reason work just fine.

in first case nothing happened.If i put Toast in onClick listener also nothing happens.I just do not know why. Do i need to put another activity in my manifest? but this is not new activity?how to name it in my manifest....or problem is something completly different. When i say nothing happens...well nothing happens.There is no error,or some strange behavior or something else.There is no error message in my LogCat also. It is completly possible to mess up intent but my toast message also doesn't pop up.What leeds me to conclusion that i messed up something with onClickListener. But what?it is completly normal, like other listeners that i used before.Or i am just tired to see elephant in the room. I am on my computer for about 10ish hours

My full code:

package com.dsk.android.decijisvetknjiga;


import android.content.Intent;
import android.net.Uri;
import android.os.Bundle;
import android.support.design.widget.FloatingActionButton;
import android.support.v7.app.AppCompatActivity;
import android.view.View;
import android.widget.Toast;

import com.github.barteksc.pdfviewer.PDFView;


public class CetvrtaKnjiga extends AppCompatActivity {
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.knjiga);

        PDFView pdfView = (PDFView) findViewById(R.id.pdfView);
        pdfView.fromAsset("diskretna.pdf").load();
        pdfView.enableSwipe(true);

        FloatingActionButton fab = (FloatingActionButton) findViewById(R.id.myFAB);
        fab.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent cetvrtaKinjigaIntent = new Intent(CetvrtaKnjiga.this, Narudzbina.class);
                startActivity(cetvrtaKinjigaIntent);
            }
        });

        FloatingActionButton fabKontakt = (FloatingActionButton) findViewById(R.id.myFAB_kontakt);
        fabKontakt.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent = new Intent(Intent.ACTION_DIAL);
                intent.setData(Uri.parse("tel:" + "[phone]"));
                startActivity(intent);
                Toast.makeText(CetvrtaKnjiga.this, "Radi", Toast.LENGTH_SHORT).show();

            }

        });
    }
}

my full xml code:

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical">

    <com.github.barteksc.pdfviewer.PDFView
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:id="@+id/pdfView">

        <android.support.design.widget.FloatingActionButton
            android:id="@+id/myFAB"
            android:layout_width="64dp"
            android:layout_height="64dp"
            android:src="@drawable/shopping_cart"
            app:elevation="5dp"
            app:borderWidth="0dp"
            android:layout_alignParentBottom="true"
            android:layout_alignParentRight="true"
            android:layout_alignParentEnd="true"
            android:layout_marginRight="32dp"
            android:layout_marginEnd="32dp"
            android:layout_marginBottom="24dp" />


        <android.support.design.widget.FloatingActionButton
            android:id="@+id/myFAB_kontakt"
            android:layout_width="64dp"
            android:layout_height="64dp"
            android:src="@drawable/phone"
            app:elevation="5dp"
            app:borderWidth="0dp"
            android:layout_alignTop="@+id/myFAB"
            android:layout_alignParentLeft="true"
            android:layout_alignParentStart="true"
            android:layout_marginLeft="32dp"
            android:layout_marginStart="32dp" />
    </com.github.barteksc.pdfviewer.PDFView>

</LinearLayout>

My "problematic" onClickListener is second one..this one:

FloatingActionButton fabKontakt = (FloatingActionButton) findViewById(R.id.myFAB_kontakt);
        fabKontakt.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent = new Intent(Intent.ACTION_DIAL);
                intent.setData(Uri.parse("tel:" + "+xxxxxxx"));
                startActivity(intent);
                Toast.makeText(CetvrtaKnjiga.this, "Radi", Toast.LENGTH_SHORT).show();

            }

        });

[John Joe]

Remove the intent first. Check Toast get displayed or not.

[John Joe]

You should never add Toast after startActivity(intent);. I guess Toast will never get called because your application have intent to  ACTION_DIAL....maybe ?

[Tim Moores]

You should never add Toast after startActivity(intent);

No, it will get called, but you might not see it because it's tied to the activity - which gets switched out. Better to use android.util.Log to write something to the logcat output.