This week's book giveaway is in the OCP forum.
We're giving away four copies of OCP Java SE 8 Programmer II Exam Study Guide and have Kathy Sierra, Bert Bates, & Elizabeth Robson on-line!
See this thread for details.
Win a copy of OCP Java SE 8 Programmer II Exam Study Guide this week in the OCP forum!
  • Post Reply Bookmark Topic Watch Topic
  • New Topic

Problem performing change password application using jsp  RSS feed

 
Ranch Hand
Posts: 38
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator


This is the Javascript and designing page
the jsp connection file with the database is:


Database consists of only id and oldpassword fields.
The problem here the update query in not firing and there is no change in the database.Please help
 
Saloon Keeper
Posts: 4339
108
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
Several points, in no particular order:

Java code belongs in a backing bean or a servlet, not jn JSPs (which should only be used to generate the view).

The code is wide open to SQL injection attacks; start using PreparedStatement. You seem to have started doing that, but the parameter isn't added correctly, and it isn't actually being used.

The passwords seem to be stored in cleartext, which is another big no-no; they should be hashed using an algorithm such as SHA-2. That way they can not ever be accessed as cleartext.

As to debugging, I suggest to print out the full stack trace of exceptions, not just what line 43 does.
 
VarunS Singh
Ranch Hand
Posts: 38
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
thanks for the help
 
Author and ninkuma
Marshal
Posts: 66540
160
IntelliJ IDE Java jQuery Mac Mac OS X
  • Likes 1
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

VarunS Singh wrote:This is the Javascript ...


That is not JavaScript. It's just Java code that is inappropriately (as Tim pointed out) placed in the JSP.

JavaScript is a completely different language.
 
Rancher
Posts: 3385
38
  • Likes 1
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator
I think that was referring to the code block above it, and not the one below.
 
Bear Bibeault
Author and ninkuma
Marshal
Posts: 66540
160
IntelliJ IDE Java jQuery Mac Mac OS X
  • Likes 1
  • Mark post as helpful
  • send pies
  • Quote
  • Report post to moderator

Dave Tolls wrote:I think that was referring to the code block above it, and not the one below.


Could be. Best to make sure.
 
It is sorta covered in the JavaRanch Style Guide.
  • Post Reply Bookmark Topic Watch Topic
  • New Topic
Boost this thread!