not printing everything I want

[Adam Chalkley]

Hi guys I am using a buffered Reader to read text from a file into my program so I can use that data I have a text file with the following contents

1,HELLO,2,HI,3 HALLO,4 GUTEN TAG

I want the while loop to basically create a new print File until there is no more text

but what I find is I only get the output 1 and Hello and nothing else is printed I have no idea what I'm doing wrong

public class Main{
   
	public static ArrayList<print> list = new ArrayList<>();
	
	static{
		
		BufferedReader reader = null;
		try{
		
		reader = new BufferedReader(new FileReader("hello.txt"));
		String line = reader.readLine();
		int i = 0;
		int j = 1;
		
		while(line != null){
		
	
			
		String[] chunks = line.split(",");
		int num = Integer.parseInt(chunks[i]);
		String s = chunks[j];
		list.add(new print(num,s));
		
		i++;
		j++;
        line = reader.readLine();
	
		
		}
		
		}catch(IOException e){
			try{
			reader.close();
			}catch(IOException b){
				
				e.printStackTrace();
			}
			
			
		}
		
		
		
	}
	
	
	public static void main(String[] args) throws IOException {
		
		/*BufferedWriter writer = new BufferedWriter(new FileWriter("hello.txt"));
		writer.write("1,HELLO,2,HI,3 HALLO,4 GUTEN TAG");
		writer.close();*/
		
		for(print p : list){
			
			System.out.print("--- ");
			p.printDetails();
		}

	}

}

[Norm Radder]

Where is the code for the print class?

Where is the loop to go through the chunks array from the split method?


Note: Java conventions say class names should begin with an uppercase letter.

[Adam Chalkley]

print class

public class print {

	  int number;
	  String name;
	
	  public print(int i,String s){
		  
		  number = i;
		  name = s;
		  
	  }
	  
	  public void printDetails(){
		  
		  System.out.println(number + " " + name);
	  }
	
	
}

[Norm Radder]

Where is the code that loads the contents of the String into the list?

[Adam Chalkley]

thats the new code I removed i and j but it still only prints the first entry 1 and hello not the rest of the text

and the code that loads the content into the string is in the static block

import java.io.BufferedReader;
import java.io.BufferedWriter;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.IOException;
import java.util.ArrayList;

public class Main{
   
	public static ArrayList<print> list = new ArrayList<>();
	
	static{
		
		BufferedReader reader = null;
		try{
		
		reader = new BufferedReader(new FileReader("hello.txt"));
		String line = reader.readLine();
		
		
		while(line != null){
		
			
		String[] chunks = line.split(",");
		int num = Integer.parseInt(chunks[0]);
		String s = chunks[1];
		list.add(new print(num,s));
		
        line = reader.readLine();
	
		
		}
		
		}catch(IOException e){
			try{
			reader.close();
			}catch(IOException b){
				
				e.printStackTrace();
			}
			
			
		}
		
		
		
	}
	
	
	public static void main(String[] args) throws IOException {
		
	/*	BufferedWriter writer = new BufferedWriter(new 
                FileWriter("hello.txt"));
		writer.write("1,HELLO,2,HI,3,HALLO,4,GUTEN TAG");
		writer.close();*/
		
		for(print p : list){
			
			System.out.print("--- ");
			p.printDetails();
		}

	}

}

[Adam Chalkley]

1,HELLO,
2,HI,
3,HALLO,
4,GUTEN TAG

I noticed when I change the contents of my file to display top down it works fine and prints all the output,so my question is why can't the text be beside each other I'm guessing because it reads from line to line? but how to solve this?

[Norm Radder]

but how to solve this?

Write code that reads a line, parses/splits it and puts its values into the list.

The code needs to know if there are multiple tuples on a line
of if there is only one tuple on each line.

Use the results of the split to determine which. 2 elements == one tuple
otherwise number of tuples = array.length/2

[Adam Chalkley]

Write code that reads a line, parses/splits it and puts its values into the list. [/code]

hey Norm thanks for the reply,thats what my code is currently doing I'm looking for a way to get input without using nextLine because nextLine reads the whole line

[Adam Chalkley]

I could do it without a while loop and assign multiple values and multiple add methods but that would take a lot of code and defeat the whole purpose

[Norm Radder]

There are several ways to do it.  You have tried two: All on one line vs each tuple on its own line.  Its up to you how you want it done.

[Adam Chalkley]

thanks for the help Norm I figured out a way that works in my case

static{
		
		BufferedReader reader = null;
		try{
		
		reader = new BufferedReader(new FileReader("hello.txt"));
		String line = reader.readLine();
		
		
		while(line != null){
		
		
		int i = 0;
		int j = 1;
		String[] chunks = line.split(",");
		System.out.println(chunks.length);
		for(int x = 0; x <= chunks.length; x++){
			
			if(i >= chunks.length){
				
				break;
			}
			
			int  data1 = Integer.parseInt(chunks[i]);
			String data2 = chunks[j];
			
		    list.add(new print(data1,data2));
		    
		    i+=2;
		    j+=2;
		}
		
        line = reader.readLine();
	
		}
		
		}catch(IOException e){
			try{
			reader.close();
			}catch(IOException b){
				
				e.printStackTrace();
			}
			
			
		}
		
		
		
	}

[Norm Radder]

Why have three variables: x,i,j?  It can be done with one index that is incremented by 2.
Value at the index is a number
value at index+1 is the word

[Adam Chalkley]

true I could just increment i each time after I add some data

[Norm Radder]

I could just increment i each time

Incrementing the loop variable is the job of the third expression in the for loop.

[Adam Chalkley]

there we go tidied it a lot, a lot of unnecessary code that made it look more complicated than it should be

static{
		
		BufferedReader reader = null;
		try{
		
		reader = new BufferedReader(new FileReader("hello.txt"));
		String line = reader.readLine();
		
		while(line != null){
		
		int i = 0;
		String[] chunks = line.split(",");
		System.out.println(chunks.length);
		for(int x = i; i < chunks.length;){
			
			int  data1 = Integer.parseInt(chunks[i]);
			i++;
			String data2 = chunks[i];
			i++;
		    list.add(new print(data1,data2)); 
		}
        line = reader.readLine();
	
		}
		
		}catch(IOException e){
			try{
			reader.close();
			}catch(IOException b){
				
				e.printStackTrace();
			}
			
			
		}

[Norm Radder]

What is the purpose of x?  Why not have i be the loop variable?

[Campbell Ritchie]

Why have you got all that code in a static initialiser? Why have you indented it wrongly?

[Adam Chalkley]

sorry meant to change x with i

and I used a static block because I wanted it to run before the constructor and also so I could populate the static ArrayList list

[Knute Snortum]

I have some suggestions for your code.  See comments.

	static {
		
		// Use try-with-resources
		try (BufferedReader reader = new BufferedReader(new FileReader("hello.txt"))) {
			String line;

			// Set line inside while condition.  This is a Java idiom.
			// Now you only have to call readLine() once.
			while ((line = reader.readLine()) != null) {
				String[] chunks = line.split(",");
				System.out.println(chunks.length);
				int i = 0;
				
				// Use while loop or for (int i = 0; i < chunks.length; i = i + 2) {
				while (i < chunks.length) {
					int data1 = Integer.parseInt(chunks[i++]);
					String data2 = chunks[i++];
					list.add(new print(data1,data2));
				}
			}
		} catch (IOException e) {
			e.printStackTrace();
		}
	}

[Campbell Ritchie]

Adam Chalkley wrote:. . . populate the static ArrayList list

So why have you got a static reference to the List?

OI work on the assumption that the keyword static is a mistake unless I can see a good explanation for it.