Forums:

How to get an instance of a controller class and use one of its methods

Greenhorn

Posts: 8

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi. I found a lot of answered questions about this topic but nothing seems to work for me and I just cant get my head around it. The idea is to clear a StackPane (changablePane in my code) so that another item can be displayed depending on the selected item in the filter combo boxes.

Here is my code

MainWindowController.java

package gui;

import gui.mainWindow.issues.NotesScreenController;
import javafx.fxml.FXML;
import javafx.fxml.FXMLLoader;
import javafx.fxml.Initializable;
import javafx.scene.control.*;
import javafx.scene.control.Button;
import javafx.scene.control.MenuBar;
import javafx.scene.layout.*;
import javafx.stage.Stage;
import java.io.IOException;
import java.net.URL;
import java.util.ResourceBundle;

public class MainWindowController implements Initializable {

private Stage stage = null;
    private StackPane paneNotes = null;
    private NotesScreenController secondPane;

@FXML
    private AnchorPane mainContainer;

@FXML
    private VBox vBoxContainer;

@FXML
    private MenuBar menuBarTop;

@FXML
    private HBox hBoxContainer;

@FXML
    private StackPane navigationSection;

@FXML
    private TreeView<Button> treeView;

@FXML
    private StackPane changablePane;

public static Button issuesNotes;

//TAB SO FILTRI
    @Override
    public void initialize(URL location, ResourceBundle resources) {
        createTreeView();
    }

private void createTreeView()   {
        Button treeViewHeader = new Button("Zdravo");
        TreeItem<Button> treeViewHeaderItem = new TreeItem<>(treeViewHeader);
        treeViewHeader.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");
        treeViewHeaderItem.setExpanded(true);
        //ROOT FOR ISSUES TRACKING
        Button rootForIssues = new Button("Issues Tracker");
        Button issuesTable = new Button("Issues Table");
        issuesNotes = new Button("Request Notes");
        TreeItem<Button> rootForIssuesItem = new TreeItem<>(rootForIssues);
        TreeItem<Button> issuesTableItem = new TreeItem<>(issuesTable);
        TreeItem<Button> issuesNotesItem = new TreeItem<>(issuesNotes);

rootForIssues.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");
        issuesTable.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");
        issuesNotes.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");

rootForIssuesItem.setExpanded(true);
        rootForIssuesItem.getChildren().addAll(issuesTableItem, issuesNotesItem);

//ROOT ZA NEKOE DRUGO - PROBNO
        Button buttonA = new Button("Proba");
        Button buttonB = new Button("Proba");
        Button buttonC = new Button("Proba");
        TreeItem<Button> nodeA = new TreeItem<>(buttonA);
        TreeItem<Button> nodeB = new TreeItem<>(buttonB);
        TreeItem<Button> nodeC = new TreeItem<>(buttonC);

buttonA.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");
        buttonB.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");
        buttonC.getStylesheets().add("styles/Notes/TreeViewStyles/TreeButton.css");

nodeA.setExpanded(true);
        nodeA.getChildren().addAll(nodeB, nodeC);

//ADDING ALL ROOTs OF THE TREEVIEW
        treeViewHeaderItem.getChildren().addAll(rootForIssuesItem, nodeA);

issuesNotes.setOnAction(event ->{
            clearPane();
            URL paneOneUrl = getClass().getClassLoader().getResource("gui/mainWindow/issues/NotesScreen.fxml");
            FXMLLoader loader = new FXMLLoader();
            //NotesScreenController nsc = new NotesScreenController();
            //loader.setController(nsc);
            loader.setLocation(paneOneUrl);
            try {
                paneNotes = loader.load(paneOneUrl);
                changablePane.getChildren().add(paneNotes);
            } catch (IOException e) {
                e.printStackTrace();
            }
        });
        issuesTable.setOnAction(event ->    {
            clearPane();
        });

//TREE VIEW
        treeView.setId("tree-view-issues");
        treeView.getStylesheets().addAll("styles/Notes/TreeViewStyles/TreeView.css");
        treeView.setRoot(treeViewHeaderItem);
    }

public void clearPane()  {
        changablePane.getChildren().clear();
    }

public void getMainScreenController()   {

}

public static Button getIssuesNotes()   {
        return issuesNotes;
    }

public void setStage(Stage stage)   {
        this.stage = stage;
        stage.setResizable(true);
        stage.setTitle("SoloStats - Welcome");
    }

public void closeStage()    {
        if (this.stage != null) {
            this.stage.close();
        }
    }
}

MainWindow.fxml

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.geometry.Insets?>
<?import javafx.scene.control.Menu?>
<?import javafx.scene.control.MenuBar?>
<?import javafx.scene.control.MenuItem?>
<?import javafx.scene.control.TreeView?>
<?import javafx.scene.layout.AnchorPane?>
<?import javafx.scene.layout.HBox?>
<?import javafx.scene.layout.StackPane?>
<?import javafx.scene.layout.VBox?>

NotesScreenController.java

package gui.mainWindow.issues;

import gui.MainWindowController;
import javafx.beans.value.ChangeListener;
import javafx.beans.value.ObservableValue;
import javafx.collections.FXCollections;
import javafx.fxml.FXML;
import javafx.fxml.FXMLLoader;
import javafx.fxml.Initializable;
import javafx.scene.control.ComboBox;
import javafx.scene.control.ScrollPane;
import javafx.scene.layout.*;
import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.util.ResourceBundle;

public class NotesScreenController implements Initializable {
    private NotesDirectory notesDirectory = new NotesDirectory();
    private MainWindowController mainController;

@FXML
    private StackPane mainContainer;

@FXML
    private VBox vBoxContainer;

@FXML
    private HBox hBoxFilterContainer;

@FXML
    private ScrollPane scrollPane;

@FXML
    private TilePane tilePaneNotesScreen;

@FXML
    private ComboBox<String> generalSortBox;

@FXML
    private ComboBox<String> sortByNameBox;

@Override
    public void initialize(URL location, ResourceBundle resources) {
        loadScreen();
    }

public void loadScreen()    {
        try {
            notesDirectory.insertNotesToTilePane(tilePaneNotesScreen, notesDirectory.deserializedNotesList(notesDirectory.getFileName(new File("src/notesDirectory")), "src/notesDirectory/"));
        } catch (IOException e) {
            e.printStackTrace();
        }
        generalSortBox.setItems(FXCollections.observableArrayList("Flagged", "Date added", "Done Notes"));
        sortByNameBox.setItems(FXCollections.observableArrayList("Priority", "Priority", "Priority", "Priority",
                "Priority", "Priority", "Priority", "Priority", "Priority", "Priority", "Priority", "Priority",
                "Priority", "Priority"));
        generalSortBox.getSelectionModel().selectedItemProperty().addListener(new ChangeListener<String>() {
            @Override
            public void changed(ObservableValue<? extends String> selected, String oldValue, String newValue) {
                if (newValue != null)   {
                    switch (newValue)   {
                        case "Done Notes": try {
                            //THE ACTION NEEDS TO TAKE PLACE HERE
                            mainController.clearPane();
                            notesDirectory.insertNotesToTilePane(tilePaneNotesScreen, notesDirectory.deserializedNotesList(notesDirectory.getFileName(new File("src/notesRecycleBin")), "src/notesRecycleBin/"));
                        } catch (IOException e) {
                            e.printStackTrace();
                        }
                    }
                }
            }
        });
    }

public void setMainController(MainWindowController controller) {
        this.mainController = controller;
    }
}

NotesScreen.fxml

<?xml version="1.0" encoding="UTF-8"?>

<?import javafx.geometry.Insets?>
<?import javafx.scene.control.ComboBox?>
<?import javafx.scene.control.ScrollPane?>
<?import javafx.scene.layout.HBox?>
<?import javafx.scene.layout.StackPane?>
<?import javafx.scene.layout.TilePane?>
<?import javafx.scene.layout.VBox?>

Everything i tried gives an nullPointerException.

Grant Callant

Greenhorn

Posts: 11

I like...

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Filip,

I commend you for working with JavaFX- it's pretty nifty, and offers a lot of advantageous over AWT/swing. I do have to say though mate, you posted a lot of code. JavaFX with the FXML allows for dynamic run-time loading, so you don't have to use as much code-behind. This is convenient, but there's several places where a variable could be uninitialized. Have you tried running this in debug? Where does the program get to right before it gets a NullPointer? A little more detail of the line the exception is occurring on, or the calling function would be very helpful here.

Thanks,

-Grant

Filip Kekev

Greenhorn

Posts: 8

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Grant. I should have mentioned where i get the nullPointerException and post the code that i used to try and get an instance of the MainWindowController, sorry for that. Wtih the code above i got a nullPointer in the call of mainController.clearPane. I tried a different approach:

generalSortBox.getSelectionModel().selectedItemProperty().addListener(new ChangeListener<String>() {
            @Override
            public void changed(ObservableValue<? extends String> selected, String oldValue, String newValue) {
                if (newValue != null)   {
                    switch (newValue)   {
                        case "Done Notes": try {
                            //THE ACTION NEEDS TO TAKE PLACE HERE
                            URL paneOneUrl = getClass().getClassLoader().getResource("gui/MainWindow.fxml");
                            FXMLLoader loader = new FXMLLoader();
                            MainWindowController controller = new MainWindowController();
                            loader.setController(controller);
                            loader.setLocation(paneOneUrl);
                            controller.clearPane();
                            notesDirectory.insertNotesToTilePane(tilePaneNotesScreen, notesDirectory.deserializedNotesList(notesDirectory.getFileName(new File("src/notesRecycleBin")), "src/notesRecycleBin/"));
                        } catch (IOException e) {
                            e.printStackTrace();
                        }
                    }
                }
            }
        });

and now i get a null pointer exception in the clearPane method in mainWindowController.
Here is the whole stacktrace of the nullPointer

Exception in thread "JavaFX Application Thread" java.lang.NullPointerException
	at gui.MainWindowController.clearPane(MainWindowController.java:118)
	at gui.mainWindow.issues.NotesScreenController$1.changed(NotesScreenController.java:73)
	at gui.mainWindow.issues.NotesScreenController$1.changed(NotesScreenController.java:60)
	at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:361)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.ReadOnlyObjectPropertyBase.fireValueChangedEvent(ReadOnlyObjectPropertyBase.java:74)
	at javafx.beans.property.ReadOnlyObjectWrapper.fireValueChangedEvent(ReadOnlyObjectWrapper.java:102)
	at javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:112)
	at javafx.beans.property.ObjectPropertyBase.set(ObjectPropertyBase.java:146)
	at javafx.scene.control.SelectionModel.setSelectedItem(SelectionModel.java:102)
	at javafx.scene.control.ComboBox$ComboBoxSelectionModel.lambda$new$154(ComboBox.java:494)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:137)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.ReadOnlyIntegerPropertyBase.fireValueChangedEvent(ReadOnlyIntegerPropertyBase.java:72)
	at javafx.beans.property.ReadOnlyIntegerWrapper.fireValueChangedEvent(ReadOnlyIntegerWrapper.java:102)
	at javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:113)
	at javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:147)
	at javafx.scene.control.SelectionModel.setSelectedIndex(SelectionModel.java:68)
	at javafx.scene.control.SingleSelectionModel.updateSelectedIndex(SingleSelectionModel.java:215)
	at javafx.scene.control.SingleSelectionModel.select(SingleSelectionModel.java:149)
	at com.sun.javafx.scene.control.skin.ComboBoxListViewSkin.lambda$createListView$323(ComboBoxListViewSkin.java:484)
	at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:349)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
	at javafx.beans.property.ReadOnlyIntegerPropertyBase.fireValueChangedEvent(ReadOnlyIntegerPropertyBase.java:72)
	at javafx.beans.property.ReadOnlyIntegerWrapper.fireValueChangedEvent(ReadOnlyIntegerWrapper.java:102)
	at javafx.beans.property.IntegerPropertyBase.markInvalid(IntegerPropertyBase.java:113)
	at javafx.beans.property.IntegerPropertyBase.set(IntegerPropertyBase.java:147)
	at javafx.scene.control.SelectionModel.setSelectedIndex(SelectionModel.java:68)
	at javafx.scene.control.MultipleSelectionModelBase.select(MultipleSelectionModelBase.java:404)
	at javafx.scene.control.MultipleSelectionModelBase.clearAndSelect(MultipleSelectionModelBase.java:356)
	at javafx.scene.control.ListView$ListViewBitSetSelectionModel.clearAndSelect(ListView.java:1403)
	at com.sun.javafx.scene.control.behavior.CellBehaviorBase.simpleSelect(CellBehaviorBase.java:256)
	at com.sun.javafx.scene.control.behavior.CellBehaviorBase.doSelect(CellBehaviorBase.java:220)
	at com.sun.javafx.scene.control.behavior.CellBehaviorBase.mousePressed(CellBehaviorBase.java:150)
	at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:95)
	at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:89)
	at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:218)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
	at javafx.event.Event.fireEvent(Event.java:198)
	at javafx.scene.Scene$MouseHandler.process(Scene.java:3757)
	at javafx.scene.Scene$MouseHandler.access$1500(Scene.java:3485)
	at javafx.scene.Scene.impl_processMouseEvent(Scene.java:1762)
	at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2494)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:381)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$354(GlassViewEventHandler.java:417)
	at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:416)
	at com.sun.glass.ui.View.handleMouseEvent(View.java:555)
	at com.sun.glass.ui.View.notifyMouse(View.java:937)
	at com.sun.glass.ui.win.WinApplication._enterNestedEventLoopImpl(Native Method)
	at com.sun.glass.ui.win.WinApplication._enterNestedEventLoop(WinApplication.java:218)
	at com.sun.glass.ui.Application.enterNestedEventLoop(Application.java:511)
	at com.sun.glass.ui.EventLoop.enter(EventLoop.java:107)
	at com.sun.javafx.tk.quantum.QuantumToolkit.enterNestedEventLoop(QuantumToolkit.java:583)
	at javafx.stage.Stage.showAndWait(Stage.java:474)
	at gui.HomeScreenController.showMainWidow(HomeScreenController.java:115)
	at gui.HomeScreenController.lambda$initialize$2(HomeScreenController.java:63)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:86)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:49)
	at javafx.event.Event.fireEvent(Event.java:198)
	at javafx.scene.Node.fireEvent(Node.java:8413)
	at javafx.scene.control.Button.fire(Button.java:185)
	at com.sun.javafx.scene.control.behavior.ButtonBehavior.mouseReleased(ButtonBehavior.java:182)
	at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:96)
	at com.sun.javafx.scene.control.skin.BehaviorSkinBase$1.handle(BehaviorSkinBase.java:89)
	at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:218)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.event.Event.fireEvent(Event.java:198)
	at javafx.scene.Scene$MouseHandler.process(Scene.java:3757)
	at javafx.scene.Scene$MouseHandler.access$1500(Scene.java:3485)
	at javafx.scene.Scene.impl_processMouseEvent(Scene.java:1762)
	at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2494)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:381)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295)
	at java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$354(GlassViewEventHandler.java:417)
	at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:416)
	at com.sun.glass.ui.View.handleMouseEvent(View.java:555)
	at com.sun.glass.ui.View.notifyMouse(View.java:937)
	at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
	at com.sun.glass.ui.win.WinApplication.lambda$null$148(WinApplication.java:191)
	at java.lang.Thread.run(Thread.java:748)

My plan is to use the same code for a bunch of other things in my app. If you think that i should try a different way and somehow restructure my app please let me know, i would really appreciate any suggestion.

Thanks

Knute Snortum

Sheriff

Posts: 7125

184

I like...

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I suspect this is the line causing the problem. What happens when nothing is selected in the sort box?

All things are lawful, but not all things are profitable.

Filip Kekev

Greenhorn

Posts: 8

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

When the user opens the window the sort box is empty, and then he selects something which should run the code from the mainWindowController. I know that the problem is with the way I'm getting the instance of the controller so I made some changes and now the changablePane is not created by the fxml file, I'm creating it by java code and made it static. That way I can make the clearPane() mehod static and call it from another class without creating an instance of the MainWindowCotroller. Now the problem is that the app doesnt show the changablePane with the filtered notes after it clears it.

Knute Snortum

Sheriff

Posts: 7125

184

I like...

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

I still think code like this is safer:

All things are lawful, but not all things are profitable.

Knute Snortum

Sheriff

Posts: 7125

184

I like...

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Filip Kekev wrote:When the user opens the window the sort box is empty, and then he selects something which should run the code from the mainWindowController. I know that the problem is with the way I'm getting the instance of the controller so I made some changes and now the changablePane is not created by the fxml file, I'm creating it by java code and made it static. That way I can make the clearPane() mehod static and call it from another class without creating an instance of the MainWindowCotroller. Now the problem is that the app doesnt show the changablePane with the filtered notes after it clears it.

Can you post your code?

All things are lawful, but not all things are profitable.

Filip Kekev

Greenhorn

Posts: 8

posted 7 years ago

Number of slices to send:

Optional 'thank-you' note:

Send

Hi Knute, I managed to get the functionality that i wanted with using static getter methods that i call from NotesScreenController. Here is the code:

MainScreenController:

package gui;

import gui.mainWindow.issues.NotesScreenController;
import javafx.beans.value.ChangeListener;
import javafx.beans.value.ObservableValue;
import javafx.collections.FXCollections;
import javafx.fxml.FXML;
import javafx.fxml.FXMLLoader;
import javafx.fxml.Initializable;
import javafx.scene.control.*;
import javafx.scene.control.Button;
import javafx.scene.control.MenuBar;
import javafx.scene.layout.*;
import javafx.stage.Stage;
import java.io.IOException;
import java.net.URL;
import java.util.ResourceBundle;

public class MainWindowController implements Initializable {

private Stage stage = null;
    private StackPane paneNotes = null;
    private NotesScreenController secondPane;

@FXML
    private AnchorPane mainContainer;

@FXML
    private VBox vBoxContainer;

@FXML
    private MenuBar menuBarTop;

@FXML
    private HBox hBoxContainer;

@FXML
    private StackPane navigationSection;

@FXML
    private TreeView<Button> treeView;

@FXML
    private VBox containerForFilterAndChangablePane;

@FXML
    private HBox filterBox;
    
    private static StackPane changablePane = new StackPane();
    private static ComboBox<String> generalSortBox = new ComboBox<>();
    private static ComboBox<String> sortByNameBox = new ComboBox<>();
    private static String filteredRequest = "Sort By...";
    private static Button issuesNotes;

//TAB SO FILTRI
    @Override
    public void initialize(URL location, ResourceBundle resources) {
        createTreeView();
    }

rootForIssuesItem.setExpanded(true);
        rootForIssuesItem.getChildren().addAll(issuesTableItem, issuesNotesItem);

nodeA.setExpanded(true);
        nodeA.getChildren().addAll(nodeB, nodeC);

//ADDING ALL ROOTs OF THE TREEVIEW
        treeViewHeaderItem.getChildren().addAll(rootForIssuesItem, nodeA);

createChangablePane(issuesNotes);

issuesTable.setOnAction(event ->    {
            clearPane();
            filterBox.setVisible(false);
        });

public static String getFilteredRequest()  {
        return filteredRequest;
    }

public static void clearPane()  {
        changablePane.getChildren().clear();
    }

public static void addPane(TilePane pane)   {
        changablePane.getChildren().add(pane);
    }

public void setStage(Stage stage)   {
        this.stage = stage;
        stage.setResizable(true);
        stage.setTitle("SoloStats - Welcome");
    }

public static Button getIssuesNotes()  {
        return issuesNotes;
    }

public void createChangablePane(Button btn) {
        btn.setOnAction(event -> {
            filterBox.getChildren().clear();
            containerForFilterAndChangablePane.getChildren().clear();
            generalSortBox.setPrefSize(250, 25);
            sortByNameBox.setPrefSize(250, 25);
            generalSortBox.getStylesheets().add("styles/MainWindow/ChoiceBox/ComboBox.css");
            sortByNameBox.getStylesheets().add("styles/MainWindow/ChoiceBox/ComboBox.css");
            generalSortBox.setValue("Sort by...");
            sortByNameBox.setValue("Sort By Name");

generalSortBox.setItems(FXCollections.observableArrayList("Flagged", "Date added", "Done Notes"));
            sortByNameBox.setItems(FXCollections.observableArrayList("Priority", "Priority", "Priority", "Priority",
                    "Priority", "Priority", "Priority", "Priority", "Priority", "Priority", "Priority", "Priority",
                    "Priority", "Priority"));
            filterBox.getChildren().addAll(generalSortBox, sortByNameBox);
            filterBox.getStylesheets().add("styles/MainWindow/ChoiceBox/HBoxFilters.css");
            changablePane.setPrefSize(950, 4000);
            changablePane.setMaxSize(1.7976931348623157E308, 1.7976931348623157E308);
            containerForFilterAndChangablePane.getChildren().add(filterBox);
            containerForFilterAndChangablePane.getChildren().add(changablePane);

filterBox.setVisible(true);

filteredRequest = "Sort By...";
            generalSortBox.setValue(filteredRequest);

loadChangablePane();

private void loadChangablePane()    {
        URL paneOneUrl = getClass().getClassLoader().getResource("gui/mainWindow/issues/NotesScreen.fxml");
        FXMLLoader loader = new FXMLLoader();
        NotesScreenController nsc = new NotesScreenController();
        loader.setController(nsc);
        loader.setLocation(paneOneUrl);
        try {
            paneNotes = loader.load(paneOneUrl);
            changablePane.getChildren().add(paneNotes);
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

public void closeStage()    {
        if (this.stage != null) {
            this.stage.close();
        }
    }
}

NotesScreenController

package gui.mainWindow.issues;

import gui.Main;
import gui.MainWindowController;
import javafx.beans.value.ChangeListener;
import javafx.beans.value.ObservableValue;
import javafx.collections.FXCollections;
import javafx.fxml.FXML;
import javafx.fxml.FXMLLoader;
import javafx.fxml.Initializable;
import javafx.scene.Parent;
import javafx.scene.control.ComboBox;
import javafx.scene.control.ScrollPane;
import javafx.scene.layout.*;
import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.util.ResourceBundle;

public class NotesScreenController implements Initializable {
    private NotesDirectory notesDirectory = new NotesDirectory();
    private MainWindowController mainController;

@FXML
    private StackPane mainContainer;

@FXML
    private VBox vBoxContainer;

@FXML
    private HBox hBoxFilterContainer;

@FXML
    private ScrollPane scrollPane;

@FXML
    private TilePane tilePaneNotesScreen;

@Override
    public void initialize(URL location, ResourceBundle resources){
        String filteredRequest = MainWindowController.getFilteredRequest();
        switch (filteredRequest)    {
            case "Sort By...": loadAllNotes();
            case "Done Notes": loadDoneNotes();
            default: loadAllNotes();
        }
    }

private void loadAllNotes()    {
        try {
            notesDirectory.insertNotesToTilePane(tilePaneNotesScreen, notesDirectory.deserializedNotesList(notesDirectory.getFileName(new File("src/notesDirectory")), "src/notesDirectory/"));
        } catch (IOException e) {
            e.printStackTrace();
        }
    }

private void loadDoneNotes()    {
        try {
            notesDirectory.insertNotesToTilePane(tilePaneNotesScreen, notesDirectory.deserializedNotesList(notesDirectory.getFileName(new File("src/notesRecycleBin")), "src/notesRecycleBin/"));
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
}

My pie came with a little toothpic holding up this tiny ad:

Gift giving made easy with the permaculture playing cards

https://coderanch.com/t/777758/Gift-giving-easy-permaculture-playing