Can't find problem with my blackjack game

[J Hiddleston]

Trying to create a javascript blackjack game. It is a simplified version with no suits, just number values. Whenever the player tries to hit it just repeats the beginning of my code. I think it might be something to do with my Do While loop, but i am unsure.

import java.util.Scanner;
import java.util.Random;

  public class JMProject3
  {
   public static void main( String[] args)
   {
     Scanner x = new Scanner(System.in);
     System.out.println ("Welcome to Joel's BlackJack Game!");
     Random [tt]r[/tt] = new Random();
     String choice,extracard, tryagain = "y";
     int card1, card2, total, dealer1, dealer2, dealertotal, dealercard, nextcard;
     do
     {
     card1 = 1 + r.nextInt(11);
     card2 = 1 + r.nextInt(11);
     total = 0;
     total = card1 + card2;
     System.out.println ("You first two cards that you are dealt are " + card1 + " and " + card2);
     System.out.println ("Your current hand totals " + total + ".");
     dealer1 = 1 + r.nextInt(11);
     dealer2 = 1 + r.nextInt(11);
     dealertotal = dealer1 + dealer2;
     dealercard = 1 + r.nextInt(11);
     System.out.println (" \nThe dealer's visible card is a " + dealer1 + " and a hidden card! You do not know his total.");
     System.out.println (" Would you like to 'hit' or 'stay'?");
     choice = x.next();
     
     while (choice.equalsIgnoreCase ("hit"));
     {
       nextcard = 1 + r.nextInt (11);
       total += nextcard;
       System.out.println ("You chose to hit. You were dealt a " + nextcard + "Your total is now " + total + ".");
       
       if (total > 21)
       {
         System.out.println (" Uh oh! You busted! Would you like to try again? (y/n) ");
         tryagain = x.next();
       }
       
       else if (total <= 21)
       
       System.out.println (" Would you like to 'hit' or 'stay' ?");
       extracard = x.next();
     }
       
       if (extracard.equals ("stay"))
       {
         System.out.println("You chose to stay. That means it's the dealers turn now!");
         System.out.println ("The dealer's hidden card was " + dealer2 + ". His total is " + dealertotal + ".");
       
         while (dealertotal >=2 && dealertotal <= 16)
         {
           dealertotal += dealercard;
           System.out.println (" The dealer has decided that his total was not high enough, and has chosen to hit. \n He deals himself a " + dealercard + ".");
           System.out.println (" His total is now " + dealertotal + ".");
         }
         
         if (dealertotal >= 17 && dealertotal <= 21 )
         {
           System.out.println ("The dealer has chosen to stay, and feels confident he can beat you.");
         }
         else if ( dealertotal >= 22 )
         {
           System.out.println ("The dealer busted! You win!");
           System.out.println ("Try again? (y/n)");
           tryagain = x.next();
         }
         
         if (total <= dealertotal && dealertotal <= 21 )
         {
           System.out.println (" The dealer's total is " + dealertotal + ".");
           System.out.println (" You cards total " + total + ".");
           System.out.println (" You lose!");
           System.out.println ("Try again? (y/n)");
           tryagain = x.next();
         }
         else if ( total > dealertotal )
         {
           System.out.println (" The dealer's total is " + dealertotal + ".");
           System.out.println ("Your cards total " + total + ".");
           System.out.println ("You win!");
           System.out.println (" Try again? (y/n)");
           tryagain = x.next();
         }
       }
       }
     }
  }

[Carey Brown]

I see you attempted to use Code tags. They weren't quite right so I fixed them, this time. For future reference you need to use the mouse to highlight then entire block of code and then click the Code button. It also helps to click the "Preview" button to make sure everything's ok before clicking "Submit".

[Carey Brown]

Seems like you may have several problems. For starters I would highly recommend

cleaning up your formatting. Lines 4 and 5 should start at the margin, and all other blocks should be indented by four spaces for each level of nesting.

Line 41 does not have any braces. It might be the way you want, but if so, your indents don't agree.

Line 29 you are checking the 'choice' variable, and line 44 you are assigning to the 'extracard' variable.

[Bear Bibeault]

Joel Middleton wrote:Trying to create a javascript blackjack game.

Your code is Java, not JavaScript. They are distinct and unrelated languages.

[Bear Bibeault]

Carey Brown wrote:all other blocks should be indented by four spaces for each level of nesting.

Or 2 (which seems to rapidly become the convention). As long is it's consistent.

[Prasad Saya]

Hello Joel,

I did some re-formatting your code. I also I tried compiling it. I ran into some issues.

import java.util.Scanner;
import java.util.Random;
 
public class JMProject3 {

	public static void main( String[] args) {

		Scanner x = new Scanner(System.in);
		System.out.println ("Welcome to Joel's BlackJack Game!");
		Random r = new Random();
		String choice, extracard, tryagain = "y";
		int card1, card2, total, dealer1, dealer2, dealertotal, dealercard, nextcard;

		do {
			card1 = 1 + r.nextInt(11);
			card2 = 1 + r.nextInt(11);
			total = 0;
			total = card1 + card2;
			System.out.println ("You first two cards that you are dealt are " + card1 + " and " + card2);
			System.out.println ("Your current hand totals " + total + ".");
			dealer1 = 1 + r.nextInt(11);
			dealer2 = 1 + r.nextInt(11);
			dealertotal = dealer1 + dealer2;
			dealercard = 1 + r.nextInt(11);
			System.out.println (" \nThe dealer's visible card is a " + dealer1 + " and a hidden card! You do not know his total.");
			System.out.println (" Would you like to 'hit' or 'stay'?");
			choice = x.next();
		} // added brace } to complete the do-while
		while (choice.equalsIgnoreCase ("hit")); 
		
		nextcard = 1 + r.nextInt (11);
		total += nextcard;
		System.out.println ("You chose to hit. You were dealt a " + nextcard + "Your total is now " + total + ".");
        
		if (total > 21) {
			System.out.println (" Uh oh! You busted! Would you like to try again? (y/n) ");
			tryagain = x.next();
		}
		else if (total <= 21) { // added brace { to start the else-if
			System.out.println (" Would you like to 'hit' or 'stay' ?");
			extracard = x.next();
		}
        
		if (extracard.equals ("stay")) {
			System.out.println("You chose to stay. That means it's the dealers turn now!");
			System.out.println ("The dealer's hidden card was " + dealer2 + ". His total is " + dealertotal + ".");
        
			while (dealertotal >=2 && dealertotal <= 16) {
				dealertotal += dealercard;
				System.out.println (" The dealer has decided that his total was not high enough, and has chosen to hit. \n He deals himself a " + dealercard + ".");
				System.out.println (" His total is now " + dealertotal + ".");
			}
          
			if (dealertotal >= 17 && dealertotal <= 21 ) {
				System.out.println ("The dealer has chosen to stay, and feels confident he can beat you.");
			}
			else if ( dealertotal >= 22 ) {
				System.out.println ("The dealer busted! You win!");
				System.out.println ("Try again? (y/n)");
				tryagain = x.next();
			}
          
			if (total <= dealertotal && dealertotal <= 21 ) {
				System.out.println (" The dealer's total is " + dealertotal + ".");
				System.out.println (" You cards total " + total + ".");
				System.out.println (" You lose!");
				System.out.println ("Try again? (y/n)");
				tryagain = x.next();
			}
			else if ( total > dealertotal ) {
				System.out.println (" The dealer's total is " + dealertotal + ".");
				System.out.println ("Your cards total " + total + ".");
				System.out.println ("You win!");
				System.out.println (" Try again? (y/n)");
				tryagain = x.next();
			}
		}
	}
	//} removed this brace }, not required
}

But, here is what I have done (I am referring to the code I have re-formatted above).
1. I added braces on lines 28 and 39 (see comments at the lines)
2. I removed closing brace on line 79

Now this has one compiler error:

JMProject3.java:45: error: variable extracard might not have been initialized
               if (extracard.equals ("stay")) {
                   ^
1 error

You should be able to fix this error, by initializing the variable extracard before it is used. The code will compile without any errors (I haven't tried running it, yet).

Now, is this of any help to you?

[Carey Brown]

'tryagain' is set but not used.

[J Hiddleston]

Prasad Saya wrote:Hello Joel,

I did some re-formatting your code. I also I tried compiling it. I ran into some issues.

import java.util.Scanner;
import java.util.Random;
 
public class JMProject3 {

	public static void main( String[] args) {

		Scanner x = new Scanner(System.in);
		System.out.println ("Welcome to Joel's BlackJack Game!");
		Random r = new Random();
		String choice, extracard, tryagain = "y";
		int card1, card2, total, dealer1, dealer2, dealertotal, dealercard, nextcard;

		do {
			card1 = 1 + r.nextInt(11);
			card2 = 1 + r.nextInt(11);
			total = 0;
			total = card1 + card2;
			System.out.println ("You first two cards that you are dealt are " + card1 + " and " + card2);
			System.out.println ("Your current hand totals " + total + ".");
			dealer1 = 1 + r.nextInt(11);
			dealer2 = 1 + r.nextInt(11);
			dealertotal = dealer1 + dealer2;
			dealercard = 1 + r.nextInt(11);
			System.out.println (" \nThe dealer's visible card is a " + dealer1 + " and a hidden card! You do not know his total.");
			System.out.println (" Would you like to 'hit' or 'stay'?");
			choice = x.next();
		} // added brace } to complete the do-while
		while (choice.equalsIgnoreCase ("hit")); 
		
		nextcard = 1 + r.nextInt (11);
		total += nextcard;
		System.out.println ("You chose to hit. You were dealt a " + nextcard + "Your total is now " + total + ".");
        
		if (total > 21) {
			System.out.println (" Uh oh! You busted! Would you like to try again? (y/n) ");
			tryagain = x.next();
		}
		else if (total <= 21) { // added brace { to start the else-if
			System.out.println (" Would you like to 'hit' or 'stay' ?");
			extracard = x.next();
		}
        
		if (extracard.equals ("stay")) {
			System.out.println("You chose to stay. That means it's the dealers turn now!");
			System.out.println ("The dealer's hidden card was " + dealer2 + ". His total is " + dealertotal + ".");
        
			while (dealertotal >=2 && dealertotal <= 16) {
				dealertotal += dealercard;
				System.out.println (" The dealer has decided that his total was not high enough, and has chosen to hit. \n He deals himself a " + dealercard + ".");
				System.out.println (" His total is now " + dealertotal + ".");
			}
          
			if (dealertotal >= 17 && dealertotal <= 21 ) {
				System.out.println ("The dealer has chosen to stay, and feels confident he can beat you.");
			}
			else if ( dealertotal >= 22 ) {
				System.out.println ("The dealer busted! You win!");
				System.out.println ("Try again? (y/n)");
				tryagain = x.next();
			}
          
			if (total <= dealertotal && dealertotal <= 21 ) {
				System.out.println (" The dealer's total is " + dealertotal + ".");
				System.out.println (" You cards total " + total + ".");
				System.out.println (" You lose!");
				System.out.println ("Try again? (y/n)");
				tryagain = x.next();
			}
			else if ( total > dealertotal ) {
				System.out.println (" The dealer's total is " + dealertotal + ".");
				System.out.println ("Your cards total " + total + ".");
				System.out.println ("You win!");
				System.out.println (" Try again? (y/n)");
				tryagain = x.next();
			}
		}
	}
	//} removed this brace }, not required
}

But, here is what I have done (I am referring to the code I have re-formatted above).
1. I added braces on lines 28 and 39 (see comments at the lines)
2. I removed closing brace on line 79

Now this has one compiler error:

JMProject3.java:45: error: variable extracard might not have been initialized
               if (extracard.equals ("stay")) {
                   ^
1 error

You should be able to fix this error, by initializing the variable extracard before it is used. The code will compile without any errors (I haven't tried running it, yet).

Now, is this of any help to you?

Hi! I greatly appreciate you fixing up my code for me! However, I tried to run the code that you fixed and  was able to get the variable extracard to initialise, however, whenever the user inputs 'hit' it does not give another card, it simply starts again from the beginning, and when the user types 'stay' it does what should happen when hit is received.

[Prasad Saya]

Hi! I greatly appreciate you fixing up my code for me!

You are welcome!

What is it  that you want the program to do? Based on that (requirement) the program or code has to be written. Now, I don't know what this program is supposed to do; what it is about (Blackjack card game, yes, but how are you playing it in this program).

For instance, what is the input from the user and the expected output. What are various scenarios? Once, you know all those scenarios you should be able to write or fix the code logic as you want it.

[Stephan van Hulst]

Your first job is to remove all that code from the main() method, and create a bunch of methods that handle smaller tasks. Right now your game logic is mixed with display code. Java is an object oriented language, you should use classes to your advantage!

[Carey Brown]

I think enough time has gone by...so...

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.Random;
import java.util.Scanner;

public class GameBlackjackSimple
{
	private static final boolean ALL = true;
	private static final boolean VISIBLE = false;
	private static final Scanner keyboard = new Scanner( System.in );
	private static final Random rand = new Random();
	
	public static void main( String[] args )
	{
		do
		{
			playNewGame();
		} while( promptForYN( "Try again" ) );
		System.out.println( "\nDone." );
	}
	
	private static void playNewGame()
	{
		System.out.println();
		System.out.println( "Welcome to BlackJack Game!" );
		System.out.println( "==========================" );
		System.out.println();
		
		Hand		playerHand = new Hand( "player", 0 );
		Hand		dealerHand = new Hand( "dealer", 1 );

		System.out.println( dealerHand.toString(VISIBLE) );
		
		while( true )
		{
			System.out.println( playerHand.toString(ALL) );
			
			if( playerHand.getTotal(ALL) > 21 )
			{
				System.out.println( "Uh oh! You busted! Dealer wins!" );
				System.out.println();
				return;
			}
			
			int		idx = promptForOneOf( "Would you like to", "hit", "stay" );
			System.out.println();
			
			if( idx == 1 ) // stay
				break;
			
			playerHand.addRandomCard();
		}

		while( dealerHand.getTotal(ALL) < playerHand.getTotal(ALL) ) // dealerHand.getTotal(ALL) <= 16 )
		{
			System.out.println(
				"The dealer has decided that his total was not high enough, and has chosen to hit." );
			System.out.println();
			dealerHand.addRandomCard();
			System.out.println( dealerHand.toString(VISIBLE) );
		}
		
		if( dealerHand.getTotal(ALL) > 21 )
		{
			System.out.println( dealerHand.toString(ALL) );
			System.out.println( "Uh oh! Dealer busted! You win!" );
			System.out.println();
			return;
		}
		
		System.out.println( "The dealer has decided to stay." );
		System.out.println();

		System.out.println( dealerHand.toString(ALL) );
		System.out.println( playerHand.toString(ALL) );

		if( dealerHand.getTotal(ALL) > playerHand.getTotal(ALL) )
			System.out.println( "You lose!\n" );
		else if( dealerHand.getTotal(ALL) < playerHand.getTotal(ALL) )
			System.out.println( "You win!\n" );
		else
			System.out.println( "Tie.\n" );
	}
	
	private static boolean promptForYN( String msg )
	{
		while( true )
		{
			System.out.print( msg + " (y/n)? " );
			String s = keyboard.nextLine().toLowerCase();
			if( "y".equals( s ) || "yes".equals( s ) )
				return true;
			if( "n".equals( s ) || "no".equals( s ) )
				return false;
			System.out.println( "ERROR Expecting a y/n response." );
		}
	}
	
	private static int promptForOneOf( String msg, String... varargs )
	{
		StringBuilder		sb = new StringBuilder();
		for( int idx=0 ; idx < varargs.length ; idx++ )
		{
			varargs[idx] = varargs[idx].toLowerCase();
			sb.append( '\'' );
			sb.append( varargs[idx] );
			sb.append( "' or " );
		}
		String varargsStr = sb.toString();
		if( varargsStr.endsWith( " or " ) )
			varargsStr = varargsStr.substring( 0, varargsStr.length()-4 );
		while( true )
		{
			System.out.print( msg + " " + varargsStr + "? " );
			String s = keyboard.nextLine().toLowerCase();
			for( int idx=0 ; idx < varargs.length ; idx++ )
				if( varargs[idx].equals( s ) )
					return idx;
			System.out.println( "ERROR Expecting a response of one of the choices." );
		}
	}
	
	//======================================================================
	private static class Hand
	{
		String				name;
		int					faceDown;
		List<Integer>		cards = new ArrayList<>();
		
		public Hand( String name, int faceDown )
		{
			this.name = name;
			this.faceDown = faceDown;
			for( int i=faceDown ; i >= 0 ; i-- )
				addRandomCard();
		}
		
		public void addRandomCard()
		{
			cards.add( getRandomCard() );
		}
		
		private static int getRandomCard()
		{
			int card = 1 + rand.nextInt( 13 );
			if( card > 10 ) // face cards
				card = 10;
			return card;
		}
		
		public String toString( boolean isAll )
		{
			if( faceDown == 0 )
				isAll = true;
			return name + ":\n  Your " + (isAll?"":"visible ")+ "hand has: " + cardsToString(isAll) +
				"\n  Whose " + (isAll?"":"visible ") + "total is: " + getTotal(isAll) +
				"\n";
		}
	
		public String cardsToString( boolean isAll )
		{
			if( faceDown == 0 )
				isAll = true;
			StringBuilder	sb = new StringBuilder();
			int				i = isAll ? 0 : faceDown;
			for( ; i < cards.size() ; i++ )
				sb.append( cards.get( i ) + ", " );
			if( sb.length() > 2 )
				sb.delete( sb.length()-2, sb.length() );
			return sb.toString();
		}
		
		public int getTotal( boolean isAll )
		{
			if( faceDown == 0 )
				isAll = true;
			int total = 0;
			int				i = isAll ? 0 : faceDown;
			for( ; i < cards.size() ; i++ )
				total += cards.get( i );
			return total;
		}
	}
}

[Prasad Saya]

Cool. I played to win and loose!

I had to lookup Blakjack @ wikipedia, though.