org.springframework.beans.factory. UnsatisfiedDependencyException when autowiring

[Paul Herrerias]

I am having an issue when publishing my project to my server, I have tried several solutions and I couldn't make it work, I have all annotations in place and the XML configuration done correctly as well.

UserController.java

   

@Controller
    @RequestMapping("/user")
    public class UserController {
	
	@Autowired
	private UserServiceIface userService;
	
	@RequestMapping(value="/home")
	public String home(ModelMap model, Authentication authentication) {
		
		authentication.getPrincipal();
		model.addAttribute("user", userService.getUser(authentication.getName()));
		
		return "user-info";
	}
	
	public String error() {
		return "access-denied";
	}
    }

UserServiceImpl.java

 

 @Service
    public class UserServiceImpl implements UserServiceIface{

	@Autowired(required=true)
	@Qualifier("userDAO")
	private UserDAOIface userDAO;
	
	@Override
	public UserEntity getUser(String userName) {
		return userDAO.getUser(userName);
	}

    }

UserDAOImpl.java

   

@Repository
    @Transactional
    public class UserDAOImpl implements UserDAOIface{
	
	@Autowired
	private SessionFactory sessionFactory;
	
	public UserEntity getUser(String userName) {
		return sessionFactory.getCurrentSession().get(UserEntity.class, 
    userName);
	}
    }

UserDetailsServiceImpl.java

   

@Service
    public class UserDetailsServiceImpl implements UserDetailsService{

	@Autowired
	@Qualifier("userDAOService")
	private UserDAOIface userDAO;
	
	@Override
	public UserDetails loadUserByUsername(String username) throws 
    UsernameNotFoundException {
		UserEntity user = userDAO.getUser(username);
		
		UserBuilder userBuilder = null;
		
		if(user != null) {
			userBuilder = User.withUsername(username);
			userBuilder.password(user.getPassword());
			userBuilder.authorities(user.getRole());
		}else {
			throw new UsernameNotFoundException("User not found");
		}
		
		return userBuilder.build();
	}
	
    }

db-config.xml

   <?xml version="1.0" encoding="UTF-8"?>    <beans xmlns="http://www.springframework.org/schema/beans"     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"     xmlns:tx="http://www.springframework.org/schema/tx"     xmlns:context="http://www.springframework.org/schema/context"     xsi:schemaLocation="http://www.springframework.org/schema/beans            http://www.springframework.org/schema/beans/spring-beans.xsd            http://www.springframework.org/schema/tx            http://www.springframework.org/schema/tx/spring-tx.xsd            http://www.springframework.org/schema/context            http://www.springframework.org/schema/context/spring-context.xsd">         <context:property-placeholder location="classpath:database.properties" />     <bean id="dataSource"     class="org.apache.commons.dbcp2.BasicDataSource"     destroy-method="close">     <property name="driverClassName"     value="${database.driverClassName}" />     <property name="url" value="${database.url}" />     <property name="username" value="${database.username}" />     <property name="password" value="${database.password}" />     </bean>     <bean id="sessionFactory"     class="org.springframework.orm.hibernate5.LocalSessionFactoryBean">     <property name="dataSource" ref="dataSource" />     <property name="hibernateProperties">     <props>     <prop key="hibernate.dialect">${hibernate.dialect}</prop>     <prop key="hibernate.show_sql">${hibernate.show_sql}</prop>     <prop key="hibernate.format_sql">${hibernate.format_sql}</prop>     </props>     </property>     <property name="packagesToScan" value="com.prh.entities"></property>     </bean>     <bean id="transactionManager" class="org.springframework.orm.hibernate5.HibernateTransactionManager">     <property name="sessionFactory" ref="sessionFactory" />     </bean>     <bean id="hibernateTemplate" class="org.springframework.orm.hibernate5.HibernateTemplate">     <constructor-arg name="sessionFactory" ref="sessionFactory" />     </bean>     <bean class="com.prh.tracking.dao.impl.UserDAOImpl" />     <tx:annotation-driven transaction-manager="transactionManager" />    </beans>

dispatcher-servlet.xml

   <?xml version="1.0" encoding="UTF-8"?>    <beans:beans xmlns="http://www.springframework.org/schema/mvc" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:beans="http://www.springframework.org/schema/beans" xmlns:context="http://www.springframework.org/schema/context" xsi:schemaLocation="http://www.springframework.org/schema/mvc    http://www.springframework.org/schema/mvc/spring-mvc.xsd http://www.springframework.org/schema/beans    http://www.springframework.org/schema/beans/spring-beans.xsd http://www.springframework.org/schema/context    http://www.springframework.org/schema/context/spring-context.xsd"> <!-- DispatcherServlet Context: defines this servlet's request-processing    infrastructure --> <!-- Enables the Spring MVC @Controller programming model --> <annotation-driven /> <!-- Handles HTTP GET requests for /resources/** by efficiently serving up    static resources in the ${webappRoot}/resources directory --> <resources mapping="/resources/**" location="/resources/" /> <!-- Resolves views selected for rendering by @Controllers to .jsp resources    in the /WEB-INF/views directory --> <beans:bean    class="org.springframework.web.servlet.view.InternalResourceViewResolver"> <beans:property name="prefix" value="/WEB-INF/views/" /> <beans:property name="suffix" value=".jsp" /> </beans:bean> <context:component-scan base-package="com.prh.tracking" /> </beans:beans>
 

[Paul Herrerias]

web.xml

   <?xml version="1.0" encoding="UTF-8"?>    <web-app version="2.5" xmlns="http://java.sun.com/xml/ns/javaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/javaee    http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd"> <!-- The definition of the Root Spring Container shared by all Servlets and    Filters --> <context-param> <param-name>contextConfigLocation</param-name> <param-value> /WEB-INF/spring/root-context.xml /WEB-INF/dispatcher-servlet.xml /WEB-INF/db-config.xml /WEB-INF/security-config.xml </param-value> </context-param> <!-- Creates the Spring Container shared by all Servlets and Filters --> <listener> <listener-    class>org.springframework.web.context.ContextLoaderListener</listener-class> </listener> <!-- Processes application requests --> <servlet> <servlet-name>dispatcher</servlet-name> <servlet-    class>org.springframework.web.servlet.DispatcherServlet</servlet-class> <load-on-startup>1</load-on-startup> </servlet> <servlet-mapping> <servlet-name>dispatcher</servlet-name> <url-pattern>/</url-pattern> </servlet-mapping> <listener> <listener-    class>org.springframework.web.context.ContextLoaderListener</listener-class> </listener> <!-- Spring Security Configuration --> <filter> <filter-name>springSecurityFilterChain</filter-name> <filter-    class>org.springframework.web.filter.DelegatingFilterProxy</filter-class> </filter> <filter-mapping> <filter-name>springSecurityFilterChain</filter-name> <url-pattern>/*</url-pattern> </filter-mapping>    </web-app>

The exception I get:

     

 
    Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'userService': Unsatisfied dependency expressed through field 'userDAO'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: 
No qualifying bean of type 'com.prh.tracking.dao.iface.UserDAOIface' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true), @org.springframework.beans.factory.annotation.Qualifier(value=userDAO)}
    	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:586)
    	at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:91)
    	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessPropertyValues(AutowiredAnnotationBeanPostProcessor.java:372)
    	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1341)
    	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:572)
    	at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:495)
    	at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:317)
    	at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:222)
    	at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:315)
    	at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:199)
    	at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:251)
    	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1135)
    	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1062)
    	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:583)
    	... 24 more
    Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.prh.tracking.dao.iface.UserDAOIface' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: 
{@org.springframework.beans.factory.annotation.Autowired(required=true), @org.springframework.beans.factory.annotation.Qualifier(value=userDAO)}
    	at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoMatchingBeanFound(DefaultListableBeanFactory.java:1506)
    	at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1101)
    	at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1062)
    	at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcesso
This is the structure of my project:

[Salil Wadnerkar]

It says in the error log:

Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'com.prh.tracking.dao.iface.UserDAOIface' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations:
{@org.springframework.beans.factory.annotation.Autowired(required=true), @org.springframework.beans.factory.annotation.Qualifier(value=userDAO)}
    at org.springframework.beans.factory.support.DefaultListableBeanFactory.raiseNoMatchingBeanFound(DefaultListableBeanFactory.java:1506)

[Al Hobbs]

The problem might be because of the qualifier names.

[Al Hobbs]

Also you didn't post the code for UserDAOIface.  Does that even exist?

[Paul Herrerias]

This is the code:

public interface UserDAOIface {

	UserEntity getUser(String userName);

}

And why would the qualifier names be the issue?

[Rob Spoor]

You require the injected UserDAOIface to have name userDAO, but you never give the actual bean that name. That's why the autowiring fails. There are two solutions:
1) Remove the @Qualifier annotation.
2) Specify the name in the @Repository annotation.

[Paul Herrerias]

I use the Qualifier name because I autowire UserDAOIface twice and therefore I get this:

Caused by: org.springframework.beans.factory.NoUniqueBeanDefinitionException: No qualifying bean of type 'com.prh.tracking.dao.iface.UserDAOIface' available: expected single matching bean but found 2: userDAOImpl,com.prh.tracking.dao.impl.UserDAOImpl#0

And I do not know how to specify the name in the @Repository annotation.

[Al Hobbs]

You don't need to even use qualifier unless you have more than one bean of the same type.

[Paul Herrerias]

Al Hobbs wrote:You don't need to even use qualifier unless you have more than one bean of the same type.

I know, and I autowire 2 beans of the same type UserDAOIface that's why I am using Qualifier besides I already tried to remove them and I showed what I get.

[Tim Nachreiner]

Paul,

Here is a series of steps that will fix your problem:

1. Use a better naming convention; ie, stick to camel-case.  Rename your interfaces to: UserDao, UserService.
2. Even though you are autowiring UserDao twice, you still use the singleton instance created by the Spring container.
3. Remove @Qualifier annotation; it is not needed.
4. Remove line 41 from db-config.xml, since Component scanning will create this bean anyway.
5. In Web.xml remove lines 38-41.  You've already created a ContextLoaderListener in lines 20-23

[Paul Herrerias]

Tim Nachreiner wrote:Paul,

Here is a series of steps that will fix your problem:

1. Use a better naming convention; ie, stick to camel-case.  Rename your interfaces to: UserDao, UserService.
2. Even though you are autowiring UserDao twice, you still use the singleton instance created by the Spring container.
3. Remove @Qualifier annotation; it is not needed.
4. Remove line 41 from db-config.xml, since Component scanning will create this bean anyway.
5. In Web.xml remove lines 38-41.  You've already created a ContextLoaderListener in lines 20-23

This worked but now I am getting a whole different error, if this can be replied here please, help me if not, I will create a new topic, I must say this is the first time I am working with Hibernate therefore there are some concepts I miss:

ERROR: org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter - An internal error occurred while trying to authenticate the user.
org.springframework.security.authentication.InternalAuthenticationServiceException: Unable to locate persister: com.prh.tracking.entities.UserEntity
	at org.springframework.security.authentication.dao.DaoAuthenticationProvider.retrieveUser(DaoAuthenticationProvider.java:119)
	at org.springframework.security.authentication.dao.AbstractUserDetailsAuthenticationProvider.authenticate(AbstractUserDetailsAuthenticationProvider.java:144)
	at org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:174)
	at org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:199)
	at org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter.attemptAuthentication(UsernamePasswordAuthenticationFilter.java:94)
	at org.springframework.security.web.authentication.AbstractAuthenticationProcessingFilter.doFilter(AbstractAuthenticationProcessingFilter.java:212)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:116)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.csrf.CsrfFilter.doFilterInternal(CsrfFilter.java:124)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:66)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:56)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:105)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:334)
	at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:215)
	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:178)
	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:357)
	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:270)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:198)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:493)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:81)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:650)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:800)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:800)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1471)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Unknown Source)
Caused by: org.hibernate.UnknownEntityTypeException: Unable to locate persister: com.prh.tracking.entities.UserEntity
	at org.hibernate.metamodel.internal.MetamodelImpl.locateEntityPersister(MetamodelImpl.java:687)
	at org.hibernate.internal.SessionImpl.locateEntityPersister(SessionImpl.java:3018)
	at org.hibernate.internal.SessionImpl.access$1800(SessionImpl.java:207)
	at org.hibernate.internal.SessionImpl$IdentifierLoadAccessImpl.<init>(SessionImpl.java:2769)
	at org.hibernate.internal.SessionImpl$IdentifierLoadAccessImpl.<init>(SessionImpl.java:2755)
	at org.hibernate.internal.SessionImpl.byId(SessionImpl.java:1220)
	at org.hibernate.internal.SessionImpl.get(SessionImpl.java:1093)
	at com.prh.tracking.dao.impl.UserDAOImpl.getUser(UserDAOImpl.java:22)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:343)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:197)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:294)
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:98)
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:185)
	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:212)
	at com.sun.proxy.$Proxy27.getUser(Unknown Source)
	at com.prh.tracking.services.impl.UserDetailsServiceImpl.loadUserByUsername(UserDetailsServiceImpl.java:24)
	at org.springframework.security.authentication.dao.DaoAuthenticationProvider.retrieveUser(DaoAuthenticationProvider.java:104)
	... 42 more

[Tim Nachreiner]

I'm guessing it's something in the UserController.
Line 11 looks suspicious; it doesn't return anything.
Try this:
comment out line 11
change line 12 to model.addAttribute("user", userService.getUser(authentication.getPrincipal.getName()));

[Tim Nachreiner]

I forgot the braces on the getPrincipal function.....

model.addAttribute("user", userService.getUser(authentication.getPrincipal().getName()));

[Tim Nachreiner]

Here's a better solution:

@RequestMapping(value="/home")
    public String home(ModelMap model, Principal principal) {
         
        model.addAttribute("user", userService.getUser(principal.getName()));
         
        return "user-info";
    }