BlackJack Game Initial code

[Ganesh Patekar]

Player:

package com.coderanch.blackjack.users;
import java.util.ArrayList;
import java.util.List;

class Player {
	
	protected List<Hand> handList;

	protected Player() {
		handList = new ArrayList<>();
	}

	public List<Hand> getHand() {
		return handList;
	}

}

Dealer:

package com.coderanch.blackjack.users;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Random;
import com.coderanch.blackjack.utilities.Card;
import com.coderanch.blackjack.utilities.Deck;

class Dealer extends Player {

	private Deck deckOne;
	private List<Card> cardsInDeck;
	private List<Integer> shuffleIndex;

	Dealer() {

		deckOne = new Deck();
		cardsInDeck = deckOne.getCardDeck();
		shuffleIndex = new ArrayList<>(52);

		handList.add(new Hand(1));
	}

	public Deck getDeckOne() {
		return deckOne;
	}

	public List<Card> getCardDeck() {
		return cardsInDeck;
	}

	// Method to find next index where card to be set for shuffling
	private int nextIndex() {

		Random ran = new Random();
		int cardIndex;
		boolean flag = true;
		do {
			cardIndex = ran.nextInt(52);

			if (!shuffleIndex.contains(cardIndex)) {

				shuffleIndex.add(cardIndex);
				flag = false;

			}

		} while (flag);

		return cardIndex;
	}

	void shuffle(Deck deck) {
		List<Card> cardDeck = deck.getCardDeck();
		List<Card> shuffledDeck = new ArrayList<>(cardDeck);

		Iterator<Card> cardItr = cardDeck.iterator();

		while (cardItr.hasNext()) {
			// System.out.println("Inside Shuffle loop");

			Card tempCard = cardItr.next();
			Card newTempCard = new Card(tempCard.getSuit(), tempCard.getFaceValue());
			shuffledDeck.set(nextIndex(), newTempCard);
		}
		deck.setCardDeck(shuffledDeck);
	}

	public String toString() {
		return "Dealer: " + this.handList.get(0).toString();
	}
}

Regular Player:

package com.coderanch.blackjack.users;
import static com.coderanch.blackjack.utilities.InputUtilities.isValidName;

public class RegularPlayer extends Player {

	private String name;
	private int balance;
	private int betAmount;
	private boolean betStatus;
	private boolean balancetStatus;

	public RegularPlayer(String name) {
		if (name == null || (!isValidName(name))) {
			throw new IllegalArgumentException("Invalid Name ...");
		}
		this.name = name;
	}

	public void setBetStatus(boolean betStatus) {
		this.betStatus = betStatus;
	}

	public void setBalancetStatus(boolean balancetStatus) {
		this.balancetStatus = balancetStatus;
	}

	public void setBalance(int balance) {
		if (balance <= 0 || balance > 10000) {
			System.out.println("Invalid balance amount ...");
			return;
			// throw new IllegalArgumentException("Invalid balance ...");
		}
		this.balance = this.balance + balance;
		this.balancetStatus = true;
	}

	public boolean isBetStatus() {
		return betStatus;
	}

	public boolean isBalancetStatus() {
		return balancetStatus;
	}

	public int getBalance() {
		return balance;
	}

	public int getBetAmount() {
		return betAmount;
	}

	public void setBetAmount(int betAmount) {
		if (betAmount <= 0) {
			System.out.println("Invalid bet amount");
			return;
		}

		if (this.betStatus) {
			if ((this.balance + this.betAmount) - betAmount < 0) {
				System.out.println("Invalid bet amount");
				return;
			}

			this.balance = (this.balance + this.betAmount) - betAmount;
			this.betAmount = betAmount;
		} else {
			if ((this.balance - betAmount) < 0) {
				System.out.println("Doesn't have enough balance");
				return;
				// throw new IllegalArgumentException("Doesn't have enough
				// balance");
			}
			this.balance = this.balance - betAmount;
			this.betAmount = betAmount;
			this.betStatus = true;

		}
	}

	public String toString() {
		return "Player Name: " + this.name + " Balance: " + this.balance + " Bet Amount: " + this.betAmount;
	}
}

Hand:

package com.coderanch.blackjack.users;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import com.coderanch.blackjack.utilities.*;

class Hand {

	private int no;
	private int value;
	private List<Card> cardsOfHand;

	Hand(int no) {
		if (no != 1 && no != 2) {
			throw new IllegalArgumentException("Invalid hand number");
		}

		this.no = no;
		cardsOfHand = new ArrayList<>();
	}

	public int getNo() {
		return no;
	}

	public void setValue(int value) {
		this.value = value;
	}

	public int getValue() {
		return value;
	}

	public String toString() {
		Iterator<Card> itr = cardsOfHand.iterator();
		String cardsInfo = "";
		while (itr.hasNext()) {
			Card temCard = itr.next();
			cardsInfo = temCard.getSuit() + " " + temCard.getFaceValueName();
		}
		return "Hand No: " + this.no + " Score: " + this.value + " " + cardsInfo;
	}
}

BlackJackGame:

package com.coderanch.blackjack.users;

import java.util.Scanner;
import com.coderanch.blackjack.utilities.Deck;
import com.coderanch.blackjack.utilities.InputUtilities;

public class BlackJackGame {

	private Dealer dlrObj1;

	BlackJackGame() {
		dlrObj1 = new Dealer();
	}

	void mainMenu() {
		Scanner sc = new Scanner(System.in);
		int choice;
		String mainMenuStr = "1. Play Game \n10. Exit\nEnter choice";
		do {
			System.out.println(mainMenuStr);
			choice = InputUtilities.getIntValue();
			switch (choice) {
			case 1:
				createPlayer();
				break;
			case 10:

				break;
			default:
				System.out.println("Invalid choice");
			}

		} while (choice != 10);
		System.out.println("Thank you! Visit again...");
	}

	private void subMenu(Player playerObj) {
		int choice;
		Scanner sc = new Scanner(System.in);

		String subMenuStr = "1. Add Balance\n2. Set/Update Bet\n3. Deal\n4. Display Info\n" + "10. Exit\nEnter choice";
		do {
			System.out.println(subMenuStr);
			choice = InputUtilities.getIntValue();
			switch (choice) {
			case 1:
				System.out.println("Enter balance");
				int balance = sc.nextInt();
				((RegularPlayer) playerObj).setBalance(balance);
				break;
			case 2:

				if (!((RegularPlayer) playerObj).isBalancetStatus()) {
					System.out.println("Please add balance first");

				} else {
					System.out.println("Enter Bet Amount");
					int betAmount = sc.nextInt();
					((RegularPlayer) playerObj).setBetAmount(betAmount);
				}
				break;
			case 3:

				if (((RegularPlayer) playerObj).isBetStatus()) {

					Deck dobj = dlrObj1.getDeckOne();
					dlrObj1.shuffle(dobj);

				} else {
					System.out.println("Please set bet amount ");
				}
				break;
			case 4:
				System.out.println(playerObj);
				break;
			case 10:
				System.out.println("Thank you! Visit again...");
				System.exit(0);
				break;
			default:
				System.out.println("Invalid choice");
			}
		} while (choice != 10);
	}

	private void createPlayer() {
		Scanner sc = new Scanner(System.in);
		System.out.println("Enter player name");
		String playerName = sc.nextLine();
		Player playeObj;
		try {
			playeObj = new RegularPlayer(playerName);

		} catch (IllegalArgumentException e) {
			System.out.println("Invalid player name ...");
			return;
		}
		System.out.println("Welcome " + playerName + " !");
		subMenu(playeObj);
	}
}

BlackJackLauncher:

package com.coderanch.blackjack.users;

final public class BlackJackLauncher {

	private BlackJackLauncher() {

	}

	public static void main(String[] args) {
		BlackJackGame obj1 = new BlackJackGame();
		obj1.mainMenu();
	}
}

Card:

package com.coderanch.blackjack.utilities;
public class Card {

	private Suit suit;
	private FaceValue faceValue;

	enum Suit {
		HEART, DIAMOND, CLUB, SPADE
	}
	
	enum FaceValue {
		KING(10), QUEEN(10), JACK(10), ACE(11), TWO(2), THREE(3), FOUR(4), FIVE(5), SIX(6), SEVEN(7), EIGHT(8), NINE(
				9), TEN(10);
		private int value;

		public int getCardValue() {
			return value;
		}

		private FaceValue(int value) {
			this.value = value;
		}
	}

	
	public Card(Suit suit, FaceValue faceValue) {

		this.suit = suit;
		this.faceValue = faceValue;
	}

	public Suit getSuit() {
		return suit;
	}

	public FaceValue getFaceValue() {
		return faceValue;
	}
	public String getFaceValueName() {
		return faceValue.name();
	}
}

CardUtilities:

package com.coderanch.blackjack.utilities;
import java.util.List;

public class CardUtilities {

	static void setCardDeck(List<Card> cardDeck) {
		Card.Suit suits[] = Card.Suit.values();
		for (Card.Suit s : suits) {

			Card.FaceValue face[] = Card.FaceValue.values();

			for (Card.FaceValue f : face) {

				Card card = new Card(s, f);
				cardDeck.add(card);
			}
		}
	}
}

Deck:

package com.coderanch.blackjack.utilities;
import java.util.ArrayList;
import java.util.List;

public class Deck {

	private List<Card> cardDeck;
	private static int countCards;
	private static final int CARDSINDECK = 52;

	public Deck() {
		countCards = 0;
		cardDeck = new ArrayList<>(CARDSINDECK);
		CardUtilities.setCardDeck(cardDeck);
	}

	public void setCardDeck(List<Card> cardDeck) {
		this.cardDeck = cardDeck;
	}

	public List<Card> getCardDeck() {
		return cardDeck;
	}
}

InputUtilities:

package com.coderanch.blackjack.utilities;
import java.util.Scanner;

public class InputUtilities {

	public static boolean isValidName(String name) {
		if (name.length() < 3 || name.length() > 20) {
			return false;
		}
		name = name.toUpperCase();
		for (int i = 0; i < name.length(); i++) {

			char ch = name.charAt(i);

			if ((!(ch >= 65 && ch <= 90)) && (ch != ' ')) {

				return false;
			}
		}
		return true;
	}

	/**
	 * @return Returns -1 If user input is not an int value.
	 */
	public static int getIntValue() {
		Scanner sc = new Scanner(System.in);
		return sc.hasNextInt() ? sc.nextInt() : -1;
	}
}

[Stephan van Hulst]

I suggest you branch off from the master branch of our repository, and merge your work in. Try to minimize impact unless you have good arguments for it (for instance, if you decide to create a new Card class in a different package rather than updating the existing Card class).

When you're happy with your merge, create a pull request and you will get an automated review from our code analysis. The team will comment on anything that code analysis didn't pick up.

[Stephan van Hulst]

Any luck?

[Ganesh Patekar]

Okay as mentioned in Contributing I created a personal test branch and added my whole project ( which looks weird since added unnecessary files too, It's easy in Git bash way to add those in .gitignore file than Eclipse ) which I posted above. I did this using Eclipse IDE.

I find It difficult to copy the structure of project you created. I learned most of Git commands using Git bash and documented them with examples too so took little more time sorry for that. I find It is much easier than using Eclipse may be I couldn't find a good tutorial on how to use Eclipse for Github?

So the class we have in our master branch Cards is nothing but a Deck class? which I have in my code hope I'm correct.  I want to add new classes Player and It's sub classes Dealer and RegularPlayer which may not be same as It's in above code for features/feature-name for features.

It is easier for me to create a file and write code in Eclipse and copy paste that file in C:\Users\GANESH\git\Blackjack\core\src\main\java\com\coderanch\blackjack   then use Git bash to add file to stage area then commit to local repo then push to remote repo ? what will you suggest? I'm feeling a bit awkward now cause of dearth of knowledge regarding Git and all.

[Stephan van Hulst]

The problem here is that you're not using Maven to build your project. Eclipse IDE for Java Developers comes with native Maven support.

Delete the projects from your workspace and also delete the .settings/ folder and the .classpath and .project files. In the "File" menu of Eclipse, select "Open Projects from File System...". Eclipse will automatically detect that Blackjack and the core module are Maven projects.

You need to update the .gitignore to ignore .settings/, .classpath and .project as Eclipse will generate those from the Maven POM, and auto-generated files should not be part of the source repository.

Move your classes to the appropriate packages in the core/src/main/java folder. Instead of writing main() methods to test your code, write test cases inside the core/src/test/java folder. You can execute your test cases by running the "Coverage" action in Eclipse on the core module.

If you want to add a user interface, add a new module to the project. The "core" module is for the basic game logic of blackjack. I suggest you add a new module named "cli" where you can add classes for interacting with the console.

If you get stuck on any of these instructions, let us know.

[Ganesh Patekar]

Stephan van Hulst wrote:The problem here is that you're not using Maven to build your project. Eclipse IDE for Java Developers comes with native Maven support.

Ah! I see, now got that

Delete the projects from your workspace and also delete the .settings/ folder and the .classpath and .project files. In the "File" menu of Eclipse, select "Open Projects from File System...". Eclipse will automatically detect that Blackjack and the core module are Maven projects.

Seems I did as you suggested.

Move your classes to the appropriate packages in the core/src/main/java folder. Instead of writing main() methods to test your code, write test cases inside the core/src/test/java folder. You can execute your test cases by running the "Coverage" action in Eclipse on the core module.

Now things are getting clear about Maven and JUnit ( not thoroughly but at least got what they are about ) writing simple classes using Maven and testing them using JUnit locally. Very soon will add a Player class in core/main... module, hopefully with test class of It as well in test/....

If you want to add a user interface, add a new module to the project. The "core" module is for the basic game logic of blackjack. I suggest you add a new module named "cli" where you can add classes for interacting with the console.

Added a module cli ( having core as parent ), appears added correctly.

[Ganesh Patekar]

In screenshot cliModulePart you can see the red round which has .java files in packages where I can create new Java classes and edit them too and blue rounded part seems folder view of project? where I think we can't create new Java files because right clicking on It shows menu shown in menu screenshot but If you look at screenshot coreModulePart which has only folder view part why there is no such packages which we have rounded in red color in cliModulePart screenshot?

[Stephan van Hulst]

You created your "cli" module inside of the "core" module. The "src" folder that you can't create new classes in is actually the source folder for the "core" module.

The command line interface should not be part of the core module, but it should be a separate submodule of the Blackjack project. It may use the classes from the core module by declaring a dependency on it in the POM.

[Ganesh Patekar]

Stephan van Hulst wrote:You created your "cli" module inside of the "core" module. The "src" folder that you can't create new classes in is actually the source folder for the "core" module.

I think I created separate module cli correctly? but the POM file of core module showing an error "failed to read artifact descriptor for org.hamcrest:hamcrest-library.jar:1.3"

[Ganesh Patekar]

This is what I did

In Eclipse Git Repositories window:
cloned Git repository from our Github  link https://github.com/CoderanchCorral/Blackjack.git since I created a separate branch named Ganesh and have to make changes in that only so I just cloned that branch only but not the master, is that correct? Or have to clone master branch too? see in the screenshot.

After that imported project by right click on repository shown in another screenshot then imported two Maven projects Blackjack and Blackjack/core    hope did correct?

[Ganesh Patekar]

By the way I'm wondering how members of a project team communicate how many classes Or objects going to be there in the project?  I mean not just about objects Or classes but the flow of project, methods etc. not sure I'm able to convey what I meant. How they coordinate because everyone things differently?

As Pete already posted objects in this project here  I also drew UML class diagram on ruff page and object were almost same. I think there is Player class which will have sub classes Dealer and RegularPlayer ( You can suggest good meaning full name for this) but I couldn't find more common fields Or methods (at least by now) of Dealer and RegularPlayer to be declare Or defined in Player class so they will be inherited by both sub classes. Do you still think we suppose to create a Player class having Dealer and RegularPlayer as sub classes?

[Ganesh Patekar]

Ganesh Patekar wrote:but the POM file of core module showing an error "failed to read artifact descriptor for org.hamcrest:hamcrest-library.jar:1.3"

I solved this by creating a System variable named M2_HOME and Its value is the location of Maven folder i.e. on my system It's C:\Program Files\Apache Software Foundation\apache-maven-3.5.4  and then in System variables appended the path of maven bin folder to PATH variables value i.e. %M2_HOME%\bin;

[Stephan van Hulst]

Ganesh Patekar wrote:By the way I'm wondering how members of a project team communicate how many classes Or objects going to be there in the project?  I mean not just about objects Or classes but the flow of project, methods etc. not sure I'm able to convey what I meant. How they coordinate because everyone things differently?

Well, normally we would take a look at our backlog to see what issues we have to resolve, and then assign an issue to a contributor. For simple bugfixes or enhancements, you would probably just immediately add new types as you see fit, and then let other members review them in a pull request. For large enhancements, you may want to create a technical design first (which might include a class diagram) which other contributors would comment on before you start writing code.

So really, the person who is assigned to the issue makes suggestions for new types and methods etc., but other contributors will always have a chance to review. The problem is that our backlog isn't filled with issues yet, which is probably something we should work on.

I think there is Player class which will have sub classes Dealer and RegularPlayer ( You can suggest good meaning full name for this) but I couldn't find more common fields Or methods (at least by now) of Dealer and RegularPlayer to be declare Or defined in Player class so they will be inherited by both sub classes. Do you still think we suppose to create a Player class having Dealer and RegularPlayer as sub classes?

I think you're going overboard with inheritance. I think we only need a Player class that encapsulates a name, a hand and a Strategy. At the appropriate moments, the game will ask each player's strategy to come up with a choice based on the current hands of the player and the dealer. There would then be different strategies such as DealerStrategy (which makes a choice based on house rules) and HumanPlayerStrategy (which blocks until the player has input a choice). For a first version, you can just implement one strategy that always hits and lets the player go bust. More advanced strategies can be added in later pull request.