Smallest and Largest Integer - Someone Rescue Me!

[Damon Ponder]

I am having a problem with some code I am running for a class. I can get it to run, however, it is not returning the smallest and largest integer entered by the user. The program is running great on everything but this. I will enter the code below and see if anyone can help me to figure this out.

// Fig. 2.7: Addition.java
	// Addition program that inputs two numbers then displays their sum import java.util.scanner; // program uses class scanner

import java.util.Scanner;

	// program uses class scanner

public class Addition2 {
    private static final int Max = 100;
	private static final int Min = -100;

	// main method begins execution of Java application

public static void main(String[] args){
    // create a Scanner to obtain input from the command window

        Scanner input = new Scanner(System.in);

        System.out.println ("Please Enter Three Integers Below!!! ");

        System.out.print("Enter First integer: "); // prompt
        int number1 = input.nextInt() ; //read first number from user

        System.out.print("Enter Second integer: "); // prompt
        int number2 = input.nextInt() ; // read second number from user

        System.out.print("Enter Third integer: "); // prompt
        int number3 = input.nextInt() ; // read second number from user

        int sum1 = number1 + number2 + number3; // add numbers, then store total in sum

        int Avg1 = ((number1+number2+number3)/3); // multiply numbers

        int sum3 = number1 * number2 * number3; // subtract numbers

        int Smallest = Max(number1, number2, number3);

        int Largest = Min(number1, number2, number3); 
        
        System.out.printf("Sum 1 is the Sum : %d%n", sum1); // display sum

        System.out.printf("Avg 1 is the Average: %d%n", Avg1); // display sum

        System.out.printf("Sum 3 is Product: %d%n", sum3); // display sum

        System.out.printf("Of -1, 29, and 99: %d%n", Smallest); //display smallest number

        System.out.printf("Of -1, 29, and 99: %d%n", Largest); //display largest number


    } //end method main

    private static int Max(int number1, int number2, int number3) {
        // TODO Auto-generated method stub
        return 100;
    }

    private static int Min(int number1, int number2, int number3) {
            // TODO Auto-generated method stub
            return -100;
    }
} // end class Addition

[Henry Wong]

Damon Ponder wrote:I am having a problem with some code I am running for a class. I can get it to run, however, it is not returning the smallest and largest integer entered by the user. The program is running great on everything but this. I will enter the code below and see if anyone can help me to figure this out.

The way you have your program coded, it will always return 100 for the smallest integer, and -100 for the largest integer. This would be true regardless of what was entered by the user... perhaps, it would be good to actually write a working Min() and Max() methods?

Henry

[Carey Brown]

When you post code or any other pre-formatted text (e.g. error message) you MUST always enclose them in "Code" tags. Paste the code into the post and then highlight it with your mouse. Then click on the "Code" button above the edit window. Then click on the "Preview" button below the edit window to see if your code has been formatted correctly. Formatted code should not include any other tags such as: bold, italic, underline, color, etc..

I'll fix it for you this time.

And welcome to the Ranch.

[Campbell Ritchie]

Welcome to the Ranch

Please don't double‑space code; it isn't easier to read. I won't add to what Henry has said.

[Carey Brown]

Your code is a mess.

You have comments that don't match the code: "subtract numbers" is actually a "product", and "sum" is also a "product".

You have a variable name "sum3" when it is not a "sum" but is a "product".

Your print statement starts with "Sum 3 is ...", it is not a sum. You could just leave this off the print and have "Product: ...".

If you use appropriate variable names and prints then the comments shouldn't even be necessary. Note that I only picked on product but your code is riddled with these issues.

        int sum3 = number1 * number2 * number3; // subtract numbers
        ... 
        System.out.printf("Sum 3 is Product: %d%n", sum3); // display sum

Also, you have variables Max and Min as well as methods Max and Min. Are you even using all of these? And variable names and method names must start with a lower case letter.