Move all parts of the Snowman with setLocation (Wheels)

[Daniel Andersson]

Assignment
Modify the snowman so it can be placed at a valid position in the window. Do this by implementing a setLocation() method in the Snowman class which moves all the components of the snowman, including Hat and SpeechBubble (look at the Hat class for an example how this can be done). Do not forget to modify the constructor so that you specify the starting position of the Snowman using your new function.  
----------------------------------------------------------------------------------------------------------------------------------

Hello there
I have some trouble with implementing a setLocation() that moves the Snowman +  Hat + SpeechBubble.
I got setLocation for  the parts of the snowman working, eye, body etc with this code:
Snowman.java

	public void setLocation(int x, int y) { 
		_body.setLocation(x + 10,y + 300);
		_head.setLocation(x + 20,y + 240);
		_leftEye.setLocation(x+ 35,y + 265);
		_rightEye.setLocation(x+ 75,x+ 265);
	}

All the parts of the snowman are then moved with this code:
SnowCartoon.java

	_snowman.setLocation(0,0)

However i don't understand how to get the hat and the speech-bubble to move with the snowman.  
My guess is that i should

_hat = new Hat();

in the snowman.java class but eclipse says that _hat cant be resolved to a variable.
When i create hat in the SnowCartoon.java class there's no problem. But then i don't know how to make them all move together.

Here's the whole code:
----------------------------------------------------------------------------------------------------------------------------------
Hat.java

import wheels.users.*;

public class Hat {
	private Rectangle _hatBrim, _hatUpper;

	public Hat() {
		_hatBrim = new Rectangle(java.awt.Color.black);
		_hatBrim.setSize(80, 20);
		_hatUpper = new Rectangle(java.awt.Color.black);
		_hatUpper.setSize(60, 60);
	}

	public void setLocation(int x, int y) { 
		_hatBrim.setLocation(x, y + 50);
		_hatUpper.setLocation(x + 10, y);
	}
}
 

Snowman.java

import wheels.users.*;

public class Snowman {
	private Ellipse _head, _body, _leftEye, _rightEye;
	
	public Snowman() {
		_body = new Ellipse(java.awt.Color.white);
		_body.setSize(100, 100);
		_head = new Ellipse(java.awt.Color.white);
		_head.setSize(80, 80);
		_leftEye = new Ellipse(java.awt.Color.black);
		_leftEye.setSize(15, 15);
		_rightEye = new Ellipse(java.awt.Color.black);
		_rightEye.setSize(15, 15);

	
		
		
	
		setOutline(java.awt.Color.black, 2);
	}
	
	
	public void setLocation(int x, int y) { 
		_body.setLocation(x + 10,y + 300);
		_head.setLocation(x + 20,y + 240);
		_leftEye.setLocation(x+ 35,y + 265);
		_rightEye.setLocation(x+ 75,x+ 265);
	}
 

	public void setOutline (java.awt.Color color, int thickness) {
		_body.setFrameColor(color);
		_body.setFrameThickness(thickness);
		_head.setFrameColor(color);
		_head.setFrameThickness(thickness);
	}
}


 

SnowCartoon.java

/* 
 * Chapter 2: SnowCartoonApp.java
 * Displays a yellow sun, a snowman with a hat, and a 
 * conversation bubble.
 * This program contains three classes.
 */
import wheels.users.*;

public class SnowCartoon extends Frame {
	private Snowman  _snowman;
	private Hat _hat;
	private Ellipse _sun;
	private ConversationBubble _bubble;

	public SnowCartoon() {
		_snowman = new Snowman();
		_snowman.setLocation(0,0);
		_hat = new Hat();
		_hat.setLocation(20,180); 


		_sun = new Ellipse(java.awt.Color.red);
		_sun.setLocation (300, 40);
		_sun.setSize(60, 60);

		_bubble = new ConversationBubble("Hello!", ConversationBubble.TAIL_DIR_LEFT);
		_bubble.setLocation(110, 110);
		
	}
	
	public void setLocation(int x, int y){ 
		_snowman.setLocation(x,y);
		_bubble.setLocation(x + 110,y + 110);
		_hat.setLocation(x + 20,y + 180);
		
	}

	public static void main ( String[] argv ) {
		SnowCartoon cartoon = new SnowCartoon();
	}
	
}
 

[Campbell Ritchie]

That suggests to me that you want to have all the part as fields in the Snowman class. Now you can implement setLocation() by moving from the old location and implement move() methods on all the parts.

[Daniel Andersson]

Campbell Ritchie wrote:That suggests to me that you want to have all the part as fields in the Snowman class. Now you can implement setLocation() by moving from the old location and implement move() methods on all the parts.

Yes i solved the problem by creating hat and bubble in the snowman class instead.

import wheels.users.*;

public class Snowman {
	private Ellipse _head, _body, _leftEye, _rightEye;
	private Hat _hat;
	private ConversationBubble _bubble;
	
	public Snowman() {
		_body = new Ellipse(java.awt.Color.white);
		_body.setSize(100, 100);
		_head = new Ellipse(java.awt.Color.white);
		_head.setSize(80, 80);
		_leftEye = new Ellipse(java.awt.Color.black);
		_leftEye.setSize(15, 15);
		_rightEye = new Ellipse(java.awt.Color.black);
		_rightEye.setSize(15, 15);
		_hat = new Hat();
		_bubble = new ConversationBubble("Hello!", ConversationBubble.TAIL_DIR_LEFT);
	
		
		
	
		setOutline(java.awt.Color.black, 2);
	}
	
	
	public void setLocation(int x, int y) { 
		_body.setLocation(x + 10,y + 300);
		_head.setLocation(x + 20,y + 240);
		_leftEye.setLocation(x+ 35,y + 265);
		_rightEye.setLocation(x+ 75,x+ 265);
		_hat.setLocation(x + 20,y + 180);
		_bubble.setLocation(x + 110,y + 110);
	}
 

	public void setOutline (java.awt.Color color, int thickness) {
		_body.setFrameColor(color);
		_body.setFrameThickness(thickness);
		_head.setFrameColor(color);
		_head.setFrameThickness(thickness);
	}
}


 

[Daniel Andersson]

Campbell Ritchie wrote:That suggests to me that you want to have all the part as fields in the Snowman class. Now you can implement setLocation() by moving from the old location and implement move() methods on all the parts.

But my solution is bad because the next part of the assignment wants you to create a new snowman, but with a different text in the speech-bubble. Hmmm...

[Campbell Ritchie]

Maybe you will have to pass the speech bubble text to a constructor or setXXX() method.

[Daniel Andersson]

Campbell Ritchie wrote:Maybe you will have to pass the speech bubble text to a constructor or setXXX() method.

I'm going to pass the speech bubble to a constructor. But could you show me how that code would look?

[Campbell Ritchie]

public Snowman(String message)
{
   hat = new Hat(...);
   bubble = new SpeechBubble(..., text);
   // ...
}

[Daniel Andersson]

Campbell Ritchie wrote:

public Snowman(String message)
{
   hat = new Hat(...);
   bubble = new SpeechBubble(..., text);
   // ...
}

When defining the text with:

public Snowman(String message) 

How can i change the code below to respond to that?

_bubble = new ConversationBubble("Hello!", ConversationBubble.TAIL_DIR_LEFT); 

[Daniel Andersson]

Campbell Ritchie wrote:

public Snowman(String message)
{
   hat = new Hat(...);
   bubble = new SpeechBubble(..., text);
   // ...
}

i figured it out.

private String _string; 
	
	public Snowman(String s1) {
		*
		*
		_bubble = new ConversationBubble(_string, ConversationBubble.TAIL_DIR_LEFT);

[Knute Snortum]

Good job figuring it out!

Just one point: using an underscore (_) in variable names is frowned upon and, I believe, is now deprecated. And either way, using any character to signal that a variable is a field is frowned upon.

[Junilu Lacar]

Knute Snortum wrote:Just one point: using an underscore (_) in variable names is frowned upon and, I believe, is now deprecated. And either way, using any character to signal that a variable is a field is frowned upon.

The tutorial for Java 8 has this:

Java 8 Tutorial wrote:The convention, however, is to always begin your variable names with a letter, not "$" or "_". Additionally, the dollar sign character, by convention, is never used at all. You may find some situations where auto-generated names will contain the dollar sign, but your variable names should always avoid using it. A similar convention exists for the underscore character; while it's technically legal to begin your variable's name with "_", this practice is discouraged.

The "_" may become a keyword in future versions of Java. Starting in Java 9, you cannot specify an underscore by itself as an identifier name and your code will not compile if you try to do so.

People who use a special marker character to designate a member variable will often claim that the practice is useful because you can immediately distinguish member variables from local variables. Many Android apps use "m" to designate member variables and in fact, that seems to be a convention. My personal opinion is that it's an unfortunate precedent that has now become accepted convention.

The argument against that convention is that if you cannot easily discern local from non-local variables, then maybe your methods and/or your classes are too big and you've violated Kent Beck's 4th Rule for Simple Design: Code is small (classes, methods, scope, etc.)  If you keep methods and classes small, it's not that hard to see which variables are declared locally.

(Hungarian) Name warts like "m" and "_" also violate one rule of Clean Code and good naming: Choose names that are pronounceable.

[Harry Kar]

...Additionally, the dollar sign character, by convention, is never used at all. You may find some situations where auto-generated names will contain the dollar sign, but your variable names should always avoid using it. A similar convention exists for the underscore character; while it's technically legal to begin your variable's name with "_", this practice is discouraged.

$ and sometimes _ are currently generated/used from tools that's why is discouraged use them explicitly

[Campbell Ritchie]

I think it was in Java10, but _ has since become a keyword. Like const and goto, it is never used.

By the way: while on about new keywords, I know var isn't a keyword, but is it a reserved word?

[Harry Kar]

Campbell Ritchie.... [/tt wrote:isn't a keyword, but is it a reserved word?

In Java keyword Vs reserved word have the semantics as in common knowledge? mean (i use a "recursive" definition)

Keywords: are actual(=part of the actual languages syntax) reserved words

Reserved words: aren't  keywords

?

[Piet Souris]

@Danielx
Does your _bubble with TAIL_DIR_LEFT always fit on screen? If not, do you have also a TAIL_DIR_RIGHT, and if so, shouldn't the location of it depend on the message?

[Campbell Ritchie]

Harry Kar wrote:. . . In Java keyword Vs reserved word have the semantics as in common knowledge? . . .

No.

The keywords are all devoid of semantic content, but they have syntactic significance and may (eight of them) determine types of things.
The three traditional reserved words had semantic content but didn't determine syntax. All the keywords were also reserved. There are some languages which have non‑reserved keywords.

[Harry Kar]

Campbell Ritchie wrote:

Harry Kar wrote:. . . In Java keyword Vs reserved word have the semantics as in common knowledge? . . .

No.

The keywords are all devoid of semantic content, but they have syntactic significance and may (eight of them) determine types of things.
The three traditional reserved words had semantic content but didn't determine syntax. All the keywords were also reserved.

with mine

... have the semantics as in common...

meant significance, meaning

your

The keywords are all devoid of semantic content, but they have syntactic significance

corresponds exactly to mine

Keywords: are actual(=part of the actual languages syntax) reserved words

or I miss something?

and may (eight of them) determine types of things

what are they 8?

There are some languages which have non‑reserved keywords.

such as...?

[Campbell Ritchie]

Harry Kar wrote:. . .

and may (eight of them) determine types of things

what are they 8?

boolean byte,, char, double, float, int, long and short.

There are some languages which have non‑reserved keywords.

such as...?

Old Fortran, for one.

Maybe I was mistaken about all keywords; this and super probably have semantic content.

[Harry Kar]

Ah yes i forgot about Fortran some time has passed back then
Thanks Campbell