Number guessing program

[Pedro Da Silva]

Hi everyone,

I would really appreciate some help here.

What I am trying to achieve is to create a simple program that guesses a number from 1 - 15 (which I have done and works).

What I then wanted to do is include some code that reads from and writes to an array. This array includes information about the players, for example;

1. How many players are going to play the game and then reference to how old each player is.

This is purely to demonstrate the use of arrays so even though it doesn't really seem "functional", it will help to understand how it can be used.

So far I have been abler to create the array, but can't seem to work out how to put it all together so the Player 1 and matching age can then be displayed back to the user at the end of the input phase.

It should do the following

1. How many users will play
2. Input how old in years each user is
3. Display back to the user each player number / age ("Player 1 is 42 years old", Player 2 is 18 years old" and so on.
4. Then asks for player names
5. Game begins and goes through the while loop and ends

import java.util.Random; //random generator calling, generates a random number
import java.util.Scanner; //scanner calling generator


//Must include the following
//IF
//ELSE IF
//WHILE

public class Assignment2 { //this is a public and can be called by other objects within the code.
    public static void main(String[] args) {  //the void declares the method has no value so it's not expecting an int for example.
    	
        Scanner userinput = new Scanner(System.in); //text scanner reading / writing from System.in, in this case
        											//the userinput is playername and number guessed by the player.
        Random rand = new Random(); //new random number is generated

        int random = rand.nextInt(20) + 1;  //20 numbers that can be generated, the + 1 adds one as numbers 
        									//will start from 0 - 19 and we want 1 - 20
        
     	System.out.print("How many people will play this game: ");
		int playerNumber = Integer.parseInt(userinput.nextLine());
		
		int playerAge[] =   new int[playerNumber];
		for (int i = 0; i < playerAge.length; i++) {
			System.out.print("Enter age of players" + (i+1) + " : ");
				playerAge[i] = userinput.nextLine();
		}
		
		
		
		
		System.out.print("Hello mind reader, please enter your name:"); //Prompt for user name
		String yourname = userinput.next(); //expecting a string for player name yourname.
	
        System.out.print("Hello "+yourname+" , can you guess my chosen random number, ");
        //input from user stored in string yourname now shown back to user with part of question
        
        System.out.print("please pick a number between 1-20: ");//Asking the user to guess a number between 1 - 20
        int number = userinput.nextInt();

        boolean found = false; //boolean condition and "not" condition response, we are testing for the opposite of this condition
        while (!found) { //not operator testing the variable found
           if (number == random) { //if number entered is equal to random number generated then...
                System.out.println("Good guess, your a mind reader!");
               found = true; //while condition / loop closed
               
            } else if (number > random) { //else if the number entered by user is > the random, then print the following
                System.out.println("You guess is too high, please try again:");
                number = userinput.nextInt();
                
            } else if (number < random) { //else if the number entered by user is < the random, then print the following
                System.out.println("Your guess is too low, please try again:");
                number = userinput.nextInt();
                
            }
        }
    }
}

[Daniel Demesmaecker]

I would create a playerclass and create an array of players. And what are you trying to do does a player have to keep guessing while the number isn't found or should everyone take turns?

[Knute Snortum]

Pedro Da Silva: please edit the subject line so that it describes the problem you want solved.  "Need help please" is not a good subject line.

[Knute Snortum]

       int playerAge[] =   new int[playerNumber];        for (int i = 0; i < playerAge.length; i++) {            System.out.print("Enter age of players" + (i+1) + " : ");                playerAge[i] = userinput.nextLine();        } You will need to parse an int from the user input for line 26 to work.

[Knute Snortum]

System.out.print("Hello mind reader, please enter your name:"); //Prompt for user name Good: lots of comments / documentation.  Bad: this particular comment (and others) are not needed, as the function of the code is obvious.

[Daniel Demesmaecker]

Knute Snortum wrote:System.out.print("Hello mind reader, please enter your name:"); //Prompt for user name Good: lots of comments / documentation.  Bad: this particular comment (and others) are not needed, as the function of the code is obvious.

I don't think he added the comments, this is a schoolassignment and I think the teacher added it as to do's...

[Knute Snortum]

          if (number == random) { //if number entered is equal to random number generated then...                System.out.println("Good guess, your a mind reader!");               found = true; //while condition / loop closed                            } else if (number > random) { //else if the number entered by user is > the random, then print the following                System.out.println("You guess is too high, please try again:");                number = userinput.nextInt();                            } else if (number < random) { //else if the number entered by user is < the random, then print the following                System.out.println("Your guess is too low, please try again:");                number = userinput.nextInt();                            } I see that you must include an "if / then / else if" structure and you written one that works.  One way to improve this is this: if the three conditions cover all possible conditions, then the last "else if" can be just an "else."  My preference would be to have the "less than" and "greater than" conditions first and second , and leave the last condition (equals) off.  So...

if (number > random) {
    // ...
} else if (number < random) {
    // ...
} else { // at this point you know number and random are equal
    // congratulations, you picked the number, etc.
}

[Pedro Da Silva]

Hi all, i appreciate the comments and suggestions. Will make some changes and run the code again to see how it goes.

I also can't see any option on the forum pages to change / edit my post - if anyone would be kind enough to point me where i can make changes / edit posts, that would be great.

[Daniel Demesmaecker]

you might have not enough experience(posts, like or cows) to edit your posts

[Knute Snortum]

Meanwhile, you can ask a staff member (like me) to edit your post for you.