Hi guys. I would love to hear any opinions from your site about my application.
It is responsible for fetching data from National Polish Bank about buying rate and selling rate from days between given two dates. Next it calculates average buying rate from these days + standard deviation of selling rate.
For example we put 2018-01-28 and 2018-01-31 and it counts 28,29,30,31 of January.
I would like to hear:
1) if tests are properly written.
2) if NBPParserEngine is properly written (what does it mean? - if method names are good, if methods are not too long, if they are, how to shorten them)
3) if DataFetcher is properly written (same as 2) )
To sum up, Im not sure about methods names and if they have proper length.
* You're method and variable names are long, but long is often good. It's more descriptive. Here's one place where I might shorten a method name:
Since this method returns a boolean, start the name with "is", maybe something like "isDayIncludedInCurrentYear()"
* I tend to put all my public-facing methods higher in the code and all the private methods lower. This is so the API is more noticable.
* Sometimes if you have a very long then clause for an if statement...
I instead use a short statement with a return (this is up for debate, though)
* Don't use ALL_CAPS for variable names unless they are constants (static final).
All things are lawful, but not all things are profitable.