string literal not properly closed by double quotes

[imdad gayaz]

<a href="delete.jsp?d=<%=resultSet.getInt("empid") %>"> Delete</a></td>
string literal not properly closed by double quotes

[Campbell Ritchie]

Welcome to the Ranch

<a href="delete.jsp?d=<%=resultSet.getInt("empid") %>"> Delete</a></td> 

Maybe the compiler is interpreting the text as the code tags do: “empid” is after the second quote and therefore isn't part of the String literal. What happens if you escape the quotes around “empid”? Otherwise, don't know. Somebody else will know.

[Bear Bibeault]

Why are you using scriptlets versus the JSTL/EL?

[Mike Simmons]

You're trying to use " for two different things - it's marking the boundaries of the href attribute value, and it's part of that value, as part of the Java code string literal "empId".  Aside from escaping those as Campbell suggested, try changing the outer quotes to be single quotes:

<a href='delete.jsp?d=<%=resultSet.getInt("empid") %>'> Delete</a></td>

HTML lets you choose between " and ' for precisely this reason - to avoid a clash with other uses of the characters.

[Bear Bibeault]

I'll also throw up a seriously red flag that you are sending a resultset to a JSP.

[Ron McLeod]

Also, I would suspect that bad guys would be able to arbitrarily delete records from the database by calling the delete.jsp endpoint with whatever values they please.

And depending on what the scriplet in the in the delete.jsp looks like, you may be vulnerable to SQL injection with something like delete.jsp?d=0; DELETE FROM employees; (like in this example).

[Tim Holloway]

Bear Bibeault wrote:Why are you using scriptlets versus the JSTL/EL?

<a href='delete.jsp?d=${resultSet["empid"]}>'> Delete</a>

Scriptlets are sooo last millenium!