Not able to return a value from a method because of its try catch block

[Marin Capranov]

Hi everyone! I have encountered a problem that I cannot solve for a couple of days. The thing is I have created a parser class that has a method called parseJSON. The method returns a String value that has the list of place_ids from google places API. When I debug the code I can see that the method works fine and the return value contains the information I need. However, when I try to call this method outside of the parser class it always returns the value of the string that was initialised first, whether is null or any other value. The main functionality of the code is inside a try-catch block because the new JSONObject throws JSONException error. I tried many ways to solve however nothing changed yet. Hope that you can see something I can't.

Parser Class.

 public String parseJSON(String source){

        String[] placesById = new String[20];
        String readyCodes = "";    // initially empty. However retruned always empty outside of the class.

        try {
            JSONObject jsonObject1 = new JSONObject(source);
            JSONArray results = jsonObject1.optJSONArray("results");

            List<String> listOfIds = new ArrayList<>();

            for (int i = 0; i < results.length(); i++) {
                String places_id = results.optJSONObject(i).optString("place_id");
                listOfIds.add("place_id:" + places_id);
                for (int j = 0; j < listOfIds.size(); j++) {
                    placesById = listOfIds.toArray(new String[j]);
                }
                readyCodes = Arrays.toString(placesById).replace("," ,"|")
                        .replace("[","")
                        .replace("]","")
                        .replace(" " , "");
            }

            Log.d("string", readyCodes);

        }
         catch (JSONException e) {
            Log.d("Error", "I go to sleep" + " " + e);
        }

        return readyCodes;  // return a list of places here when debugging.
    }

MapsActivity.Class

 Parser parser = new Parser();

                        String placesId = parser.parseJSON(url);
                        String url1 = getDistanceUrl(placesId);   // retruns the string = "" without the places.
                        dataTransfer[2] = url1;
                        Log.i("DISTANCE", url1);

Basically the code works inside the method but outside when called returns nothing. I have googled and it seems there is a problem with the try-catch block. JSON exception is thrown but without catching it the code won't compile.

This is where my parser is called as well. Maybe there is a connection.

package com.example.authorisationfirebase;

import android.graphics.Color;
import android.os.AsyncTask;

import com.google.android.gms.maps.GoogleMap;
import com.google.android.gms.maps.model.PolylineOptions;

import java.io.IOException;

public class GetDirectionsData extends AsyncTask<Object,String, String> {


    GoogleMap mMap;
    String url;
    String googleDirectionsData;
    String url1;

    @Override
    protected String doInBackground(Object... objects) {

        mMap = (GoogleMap) objects[0];
        url = (String) objects[1];
        url1 = (String) objects[2];

        DownloadUrl downloadUrl = new DownloadUrl();
        try {
            googleDirectionsData = downloadUrl.readUrl(url);
        } catch (IOException e) {
            e.printStackTrace();
        }

        return googleDirectionsData;
    }

    @Override
    protected void onPostExecute(String s) {
        Parser parser = new Parser();
            String directionList = parser.parseJSON(s);
            displayDirection(directionList);

    }

    private void displayDirection(String directionList) {

        int count = directionList.length();

        for (int i = 0; i < count; i++){
            PolylineOptions options = new PolylineOptions();
            options.color(Color.CYAN);
            options.width(10);
           // options.addAll(PolyUtil.decode(directionList[i]));

            mMap.addPolyline(options);
        }

    }

}

[Adrian Grabowski]

What does the error say?

[Marin Capranov]

org.json.JSONException: Value https of type java.lang.String cannot be converted to JSONObject

But the debugging does not show any errors. Why is that. And the code is simmilar to the other method I got, nonetheless that one works just fine. This one is getting the places on the map.

public List<HashMap<String, String>> parse(String jsonData)
    {
        JSONArray jsonArray = new JSONArray();
        JSONObject jsonObject;

        Log.d("json data", jsonData);

        try {
            jsonObject = new JSONObject(jsonData);
            jsonArray = jsonObject.getJSONArray("results");

        } catch (JSONException e) {
            e.printStackTrace();
        }
        return getPlaces(jsonArray);
    }

[Liutauras Vilda]

Marin Capranov wrote: I have encountered a problem that I cannot solve for a couple of days. The thing is I have created a parser class that has a method called parseJSON

Probably it throws an exception this method hence it returns a value assigned during variable's declaration.

But forget that for the moment - main problem in my opinion is, that this method does more than it should and so becomes more difficult to debug. Name also not descriptive.

Decompose this method to few smaller methods and you possibly at the same time will narrow down where the problem is.

The proposed methods may look like:

1.

/* it could get more generic to get not just place ids... but leave that out for now */
public List<String> getPlaceIDs(String jsonString) {
    // implement 
}

2.

pubilc String buildCodes(List<String> placeIDs) {
    // implement
}

And what exception message gives you as an error?

[Marin Capranov]

the error message is org.json.JSONException: Value https of type java.lang.String cannot be converted to JSONObject

Honestly, I can't see why?

[Liutauras Vilda]

Marin Capranov wrote:the error message is org.json.JSONException: Value https of type java.lang.String cannot be converted to JSONObject

Honestly, I can't see why?

You have such line of code:

String placesId = parser.parseJSON(url);

Does url is a well formed json object?

[Marin Capranov]

This is what my class for downloading urls does. I have tried to change it to JSONObject but unlucky so far.

package com.example.authorisationfirebase;

import android.util.Log;

import org.json.JSONObject;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;

public class DownloadUrl {

    public String readUrl(String myUrl) throws IOException
    {
        JSONObject jObj = null;
        String data = "";
        InputStream inputStream = null;
        HttpURLConnection urlConnection = null;

        try {
            URL url = new URL(myUrl);
            urlConnection=(HttpURLConnection) url.openConnection();
            urlConnection.connect();

            inputStream = urlConnection.getInputStream();
            BufferedReader br = new BufferedReader(new InputStreamReader(inputStream));
            StringBuffer sb = new StringBuffer();

            String line = "";
            while((line = br.readLine()) != null)
            {
                sb.append(line);
            }

            data = sb.toString();
            br.close();


//            try {
//                jObj = new JSONObject(data);
//            } catch (JSONException e) {
//                Log.e("JSON Parser", "Error parsing data " + e.toString());
//                System.out.println("error on parse data in jsonparser.java");
//            }

        } catch (MalformedURLException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        finally {
            inputStream.close();
            urlConnection.disconnect();
        }
        Log.d("DownloadURL","Returning data= "+data);

        return data;
    }

}

And regarding that line of code I will show what I have got:

 private String getUrl(double latitude , double longitude , String nearbyPlace, Object minPrice, Object maxPrice)
    {

        int placeRadius = 1000;

        StringBuilder googlePlaceUrl = new StringBuilder("https://maps.googleapis.com/maps/api/place/textsearch/json?");
        googlePlaceUrl.append("query="+nearbyPlace);
        googlePlaceUrl.append("&location="+latitude+","+longitude);
        googlePlaceUrl.append("&radius=" + placeRadius);
        googlePlaceUrl.append("&opennow");
        googlePlaceUrl.append("&minprice=" +minPrice);
        googlePlaceUrl.append("&maxprice=" +maxPrice);
        googlePlaceUrl.append("&key="+"you_api_key");
        Log.d("MapsActivity", "url = "+googlePlaceUrl);

        return googlePlaceUrl.toString();
    }

and that's when I call that method

String url = getUrl(lat, lng, (String) placeType, minPrice, maxPrice);

I hope it will clarify a bit

[Liutauras Vilda]

Marin Capranov wrote:I hope it will clarify a bit

It adds to complexity and reveals that you have a bit of a mess.

https://coderanch.com/t/726814/java/return-method-catch-block#3379733
In this post of yours (link right above), MapsActivity.java, Line: 3 you have line of code:

String placesId = parser.parseJSON(url);

By looking to parseJSON() method implementation of yours:

public String parseJSON(String source){
    ...
    String readyCodes = "";    // initially empty. However retruned always empty outside of the class.
 
    try {
       JSONObject jsonObject1 = new JSONObject(source);
       ...
   catch (JSONException e) [
       ...
   }
   return readyCodes;
}

And in one of your post you write:

Marin Capranov wrote:The main functionality of the code is inside a try-catch block because the new JSONObject throws JSONException error. I tried many ways to solve however nothing changed yet. Hope that you can see something I can't.
...
org.json.JSONException: Value https of type java.lang.String cannot be converted to JSONObject

So the problem is clear, that you are passing an String url and trying to treat it as string representation of json object. So that is a problem.

Example:

You pass: "https://coderanch.com"
Expected: {"name":"John", "age":30}

And a bit unclear after you posted bunch of unrelated code whether we are talking about the same problem you initialy raised or something else?

[Marin Capranov]

You pass: "https://coderanch.com"
Expected: {"name":"John", "age":30}

I believe that's the problem, too. But what you suggest to do? I can't see any other ways of parsing that URL. After all, I got that from the official Google website. I don't want to pass an entire JSON file because it is huge. That's why I got that URL.

And regarding the bunch of code:

This one here is just a demonstration that the parser actually works and it is pretty similar to parseJSON where JSON is as a string.

public List<HashMap<String, String>> parse(String jsonData)
    {
        JSONArray jsonArray = new JSONArray();
        JSONObject jsonObject;

        Log.d("json data", jsonData);

        try {
            jsonObject = new JSONObject(jsonData);
            jsonArray = jsonObject.getJSONArray("results");

        } catch (JSONException e) {
            e.printStackTrace();
        }
        return getPlaces(jsonArray);
    }

[Liutauras Vilda]

Marin Capranov wrote:I believe that's the problem, too. But what you suggest to do? I can't see any other ways of parsing that URL. After all, I got that from the official Google website. I don't want to pass an entire JSON file because it is huge. That's why I got that URL.

Well, if the code construct requires a string json representation to be passed in order successfully to be parsed to JsonObject - that is exactly what you need to do -> to pass string json representation. No other options.

To me what it sounds like what you may want to do, is having some sort of URL which submitting you get back json object, if that's the case, this is what you need to pass, the returned string json. Once you have JsonObject, then you move on further - get needed attribute(s), which is perhaps what you refering to as "place_id".

I'm a bit lost to be honest with all that amount of code on which part you are still confused.

[Marin Capranov]

As you mention I need to return an object out of the URL. I don't know if you ever heard of the Places API but they provide this URL that you can use in order to get full JSON file. Therefore, when putting in the browser search bar the: https://maps.googleapis.com/maps/api/place/textsearch/json?query=ATM&location=52.448044,-1.8870055&radius=1000&opennow&minprice=null&maxprice=null&key=<YOUR_API_KEY>;
you get a massive JSON file.

And that's how I build up the URL link that I pass into JSONObject parameter.

 private String getUrl(double latitude , double longitude , String nearbyPlace, Object minPrice, Object maxPrice)
    {

        int placeRadius = 1000;

        StringBuilder googlePlaceUrl = new StringBuilder("https://maps.googleapis.com/maps/api/place/textsearch/json?");
        googlePlaceUrl.append("query="+nearbyPlace);
        googlePlaceUrl.append("&location="+latitude+","+longitude);
        googlePlaceUrl.append("&radius=" + placeRadius);
        googlePlaceUrl.append("&opennow");
        googlePlaceUrl.append("&minprice=" +minPrice);
        googlePlaceUrl.append("&maxprice=" +maxPrice);
        googlePlaceUrl.append("&key="+"your_api_key");

        Log.d("MapsActivity", "url = "+googlePlaceUrl);

        return googlePlaceUrl.toString();
    }

[Liutauras Vilda]

Ok, so you build an URL, which consists of an API address + query parameters you pass on in order to filter resulting response/json object. That’s as a concept is correct.

Now, as a response of submitting request to that URL, you should get back json object, which you are going to pass (json response and not url) on to your parseJson() method.

How ado you submit a request to that URL? Please show us the code which handles that.

[Marin Capranov]

That's is the code that handles urls.

package com.example.authorisationfirebase;

import android.util.Log;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;

public class DownloadUrl {

    public String readUrl(String myUrl) throws IOException
    {
        String data = "";
        InputStream inputStream = null;
        HttpURLConnection urlConnection = null;

        try {
            URL url = new URL(myUrl);
            urlConnection=(HttpURLConnection) url.openConnection();
            urlConnection.connect();

            inputStream = urlConnection.getInputStream();
            BufferedReader br = new BufferedReader(new InputStreamReader(inputStream));
            StringBuffer sb = new StringBuffer();

            String line = "";
            while((line = br.readLine()) != null)
            {
                sb.append(line);
            }

            data = sb.toString();
            br.close();

//
//            try {
//                jObj = new JSONObject(data);
//            } catch (JSONException e) {
//                Log.e("JSON Parser", "Error parsing data " + e.toString());
//                System.out.println("error on parse data in jsonparser.java");
//            }

        } catch (MalformedURLException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        finally {
            inputStream.close();
            urlConnection.disconnect();
        }
        Log.d("DownloadURL","Returning data= "+data);

        return data;
    }

}

Also, you can have a look at this class as well as it is involved in the process.

package com.example.authorisationfirebase;

import android.graphics.Color;
import android.os.AsyncTask;

import com.google.android.gms.maps.GoogleMap;
import com.google.android.gms.maps.model.PolylineOptions;

import java.io.IOException;

public class GetDirectionsData extends AsyncTask<Object,String, String> {


    GoogleMap mMap;
    String url;
    String googleDirectionsData;
    String url1;



    @Override
    protected String doInBackground(Object... objects) {

        mMap = (GoogleMap) objects[0];
        url = (String) objects[1];
        url1 = (String) objects[2];

        DownloadUrl downloadUrl = new DownloadUrl();
        try {
            googleDirectionsData = downloadUrl.readUrl(url);
        } catch (IOException e) {
            e.printStackTrace();
        }

        return googleDirectionsData;
    }

    @Override
    protected void onPostExecute(String s) {
        Parser parser = new Parser();
            String directionList = parser.parseJSON2(s);
            displayDirection(directionList);

    }

    private void displayDirection(String directionList) {

        int count = directionList.length();

        for (int i = 0; i < count; i++){
            PolylineOptions options = new PolylineOptions();
            options.color(Color.CYAN);
            options.width(10);
           // options.addAll(PolyUtil.decode(directionList[i]));

            mMap.addPolyline(options);
        }

    }

}

[Dave Tolls]

So you need to pass the data returned by that method (that is, the response from the Places API which is JSON) into your json parsing method, not the URL.

[Liutauras Vilda]

Marin Capranov wrote:... Places API but they provide this URL that you can use in order to get full JSON... you get a massive JSON file.

You mentioned couple of times that it returns a massive JSON file. Do you see it as a problem in any way? Other than that, as been mentioned few times already, you need to pass that "massive" string representation of json object to your json parser.

[Marin Capranov]

ok, ok! So if I understand right? all I need is the [{object: bla, bla bla}] and not the https://maps.googleapis.com/maps/api/directions/json?origin=52.473772,-1.898288&destination=52.4744417,-1.8966049&alternatives=true&mode=DRIVING...?

But if is that how do I extract that json object out of the https link?

[Dave Tolls]

In your readUrl method above that's exactly what you're doing (at least that's what it looks like to me).
That is what should be in the data String that is returned.

[Liutauras Vilda]

Marin Capranov wrote:But if is that how do I extract that json object out of the https link?

You don't extract it from URL. URL is an address of a resource (representation of something in a json format in your case), hence the name URL - universal resource locator. It knows how to find the resource on the Internet given the path it is located.

In dumb analogy, think of it, as calling method getName() which returns you a name. So you "call" url which returns you a json object.

[Marin Capranov]

Is this a good way of parsing urls?

package com.example.authorisationfirebase;

import android.util.Log;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.net.HttpURLConnection;
import java.net.MalformedURLException;
import java.net.URL;

public class DownloadUrl {

    public String readUrl(String myUrl) throws IOException
    {
        String data = "";
        InputStream inputStream = null;
        HttpURLConnection urlConnection = null;

        try {
            URL url = new URL(myUrl);
            urlConnection=(HttpURLConnection) url.openConnection();
            urlConnection.connect();

            inputStream = urlConnection.getInputStream();
            BufferedReader br = new BufferedReader(new InputStreamReader(inputStream));
            StringBuffer sb = new StringBuffer();

            String line = "";
            while((line = br.readLine()) != null)
            {
                sb.append(line);
            }

            data = sb.toString();
            br.close();


        } catch (MalformedURLException e) {
            e.printStackTrace();
        } catch (IOException e) {
            e.printStackTrace();
        }
        finally {
            inputStream.close();
            urlConnection.disconnect();
        }
        Log.d("DownloadURL","Returning data= "+data);

        return data;
    }

}

Also, I have a theory that this does not work because it is not the first task to be completed.

package com.example.authorisationfirebase;

import android.graphics.Color;
import android.os.AsyncTask;

import com.google.android.gms.maps.GoogleMap;
import com.google.android.gms.maps.model.PolylineOptions;

import java.io.IOException;

public class GetDirectionsData extends AsyncTask<Object,String, String> {


    GoogleMap mMap;
    String url;
    String googleDirectionsData;
    String url1;


    @Override
    protected String doInBackground(Object... objects) {

        mMap = (GoogleMap) objects[0];
        url = (String) objects[1];
        url1 = (String) objects[2];

        DownloadUrl downloadUrl = new DownloadUrl();
        try {
            googleDirectionsData = downloadUrl.readUrl(url);
        } catch (IOException e) {
            e.printStackTrace();
        }

        return googleDirectionsData;
    }

    @Override
    protected void onPostExecute(String s) {
        Parser parser = new Parser();
        String directionList;
        directionList = parser.parseJSON2(s);
    }


    private void displayDirection(String directionList) {

        int count = directionList.length();

        for (int i = 0; i < count; i++) {
            PolylineOptions options = new PolylineOptions();
            options.color(Color.CYAN);
            options.width(10);
            // options.addAll(PolyUtil.decode(directionList[i]));

            mMap.addPolyline(options);
        }

    }

}

And that's the code where I have the method

package com.example.authorisationfirebase;

import android.util.Log;

import org.json.JSONArray;
import org.json.JSONException;
import org.json.JSONObject;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
import java.util.List;

public class Parser {


    public List<String> test(){
        List<String> list = new ArrayList<>();
        list.add("1");
        list.add("2");
        list.add("3");

        return list;
    }


    public String parseJSON2(String jsonData) {

        String[] placesById = new String[20];
        String readyCodes = "23";
        List<String> listOfIds = new ArrayList<>();

        Log.d("json data", jsonData);

        try {

            JSONObject jsonObject = new JSONObject(jsonData);
            JSONArray jsonArray = jsonObject.getJSONArray("results");

            for (int i = 0; i < jsonArray.length(); i++) {
                String places_id = jsonArray.optJSONObject(i).optString("place_id");
                listOfIds.add("place_id:" + places_id);
                for (int j = 0; j < listOfIds.size(); j++) {
                    placesById = listOfIds.toArray(new String[j]);
                }
                readyCodes = Arrays.toString(placesById).replace("," ,"|")
                        .replace("[","")
                        .replace("]","")
                        .replace(" " , "");
            }

            Log.d("string", readyCodes);

        } catch (JSONException e) {
            Log.d("Error", "Error: " + e);
        }
        return readyCodes;
    }

    public List<HashMap<String, String>> parse(String jsonData)
    {
        JSONArray jsonArray = new JSONArray();
        JSONObject jsonObject;

        Log.d("json data", jsonData);

        try {
            jsonObject = new JSONObject(jsonData);
            jsonArray = jsonObject.getJSONArray("results");

        } catch (JSONException e) {
           Log.d("Error2 ",  "Error " + e);
        }
        return getPlaces(jsonArray);
    }

    private List<HashMap<String, String>> getPlaces(JSONArray jsonArray)
    {
        int count = jsonArray.length();
        List<HashMap<String, String>> placeList = new ArrayList<>();
        HashMap<String, String> placeMap;

        for(int i = 0; i<count;i++)
        {
            try {
                placeMap = getPlace((JSONObject) jsonArray.get(i));
                placeList.add(placeMap);
            } catch (JSONException e) {
                e.printStackTrace();
            }
        }
        return placeList;
    }

    private HashMap<String, String> getPlace(JSONObject googlePlaceJson)
    {
        HashMap<String, String> googlePlaceMap = new HashMap<>();
        String placeName = "--NA--";
        String vicinity= "--NA--";
        String latitude= "";
        String longitude="";
        String reference="";

        Log.d("DataParser","jsonobject ="+googlePlaceJson.toString());

        try {
            if (!googlePlaceJson.isNull("name")) {
                placeName = googlePlaceJson.getString("name");
            }
            if (!googlePlaceJson.isNull("vicinity")) {
                vicinity = googlePlaceJson.getString("vicinity");
            }

            latitude = googlePlaceJson.getJSONObject("geometry").getJSONObject("location").getString("lat");
            longitude = googlePlaceJson.getJSONObject("geometry").getJSONObject("location").getString("lng");

            reference = googlePlaceJson.getString("reference");

            googlePlaceMap.put("place_name", placeName);
            googlePlaceMap.put("vicinity", vicinity);
            googlePlaceMap.put("lat", latitude);
            googlePlaceMap.put("lng", longitude);
            googlePlaceMap.put("reference", reference);

        }
        catch (JSONException e) {
            e.printStackTrace();
        }
        return googlePlaceMap;

    }

//    public String[] parseDirections(String jsonData){
//
//        JSONArray jsonArray = new JSONArray();
//        JSONObject jsonObject;
//
//        try {
//            jsonObject = new JSONObject(jsonData);
//            jsonArray = jsonObject.getJSONArray("routes").getJSONObject(0)
//                    .getJSONArray("legs")
//                    .getJSONObject(0)
//                    .getJSONArray("steps");
//
//        } catch (JSONException e) {
//            e.printStackTrace();
//        }
//
//        return getPaths(jsonArray);
//
//    }

//    private String[] getPaths(JSONArray jsonArray) {
//
//        int count = jsonArray.length();
//        String[] polyLines = new String[count];
//
//        for (int i = 0; i < count; i++) {
//            try {
//                polyLines[i] = getPath(jsonArray.getJSONObject(i));
//            } catch (JSONException e) {
//                e.printStackTrace();
//            }
//        }
//        return polyLines;
//    }

//    private String getPath(JSONObject jsonObject) throws JSONException {
//
//        String polyLine;
//
//        polyLine = jsonObject.getJSONObject("polyline").getString("points");
//        return polyLine;
//    }

}

And finally but most importantly, this is where the called method returns not what I expect it to do

generateRoute.setOnClickListener(new View.OnClickListener() {
                @Override
                public void onClick(View v) {

                    lat = location.getLatitude();
                    lng = location.getLongitude();
                    LatLng currentLoc = new LatLng(lat, lng);

                    GetDirectionsData getDirectionsData = new GetDirectionsData();
                    GetNearbyPlaces getNearbyPlaces = new GetNearbyPlaces();
                    Object dataTransfer[] = new Object[3];

                    Object placeType = listOfPreferences.get("PlaceType");
                    Object minPrice =  listOfPreferences.get("PlaceMinPrice");
                    Object maxPrice =  listOfPreferences.get("PlaceMaxPrice");

                    String url = getUrl(lat, lng, (String) placeType, minPrice, maxPrice);

                    final  String TAG1= "TAG1";
                    Log.i(TAG1, placeType.toString() + " " + minPrice + maxPrice);

                    mMap.clear();
                    dataTransfer[0] = mMap;
                    mMap.addMarker(new MarkerOptions().position(currentLoc).title("Current Location"));
                    mMap.moveCamera(CameraUpdateFactory.newLatLng(currentLoc));
                    mMap.moveCamera(CameraUpdateFactory.newLatLngZoom(currentLoc, 15));

                    dataTransfer[1] = url;

                    Parser parser = new Parser();

                        List<String> test = parser.test();
                        Log.i("test", test.toString());

                        String url1 = parser.parseJSON2(url);
                        String url1Result = getDistanceUrl(url1);
                        Log.i("DISTANCE", url1Result);
                        dataTransfer[2] = url1Result;

                    getNearbyPlaces.execute(dataTransfer);
                    getDirectionsData.execute(dataTransfer);

[Marin Capranov]

Basically that's my entire code more or less. Other bits are not involved in this problem.

[Liutauras Vilda]

I don't see you addressed any problems we discussed in this thread recently.

[Dave Tolls]

String url1 = parser.parseJSON2(url);

Again, you are passing in the url to your parser.
Your parser is expecting the response from the url, not the url itself.

At the moment I see no connection between your code that gets the json data (the doInBackground that populates the googleDirectionsData) and the parser code.